[PATCH v2] drm/mediatek: stop using 0 as NULL pointer

2023-01-10 Thread Miles Chen
Use NULL for NULL pointer to fix the following sparse warning: drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer Fixes: 3df64d7b0a4f ("drm/mediatek: Implement gem prime vmap/vunmap function") Signed-off-by: Miles Chen R

Re: [PATCH] drm/mediatek: stop using 0 as NULL pointer

2023-01-10 Thread Miles Chen
Hi Angelo, >Il 10/01/23 04:12, Miles Chen ha scritto: >> Use NULL for NULL pointer to fix the following sparse warning: >> drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain >> integer as NULL pointer >> >> Signed-off-by: Miles Chen

[PATCH] drm/mediatek: include missing headers

2023-01-10 Thread Miles Chen
static? drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:340:24: sparse: warning: symbol 'mtk_hdmi_ddc_driver' was not declared. Should it be static? drivers/gpu/drm/mediatek/mtk_dsi.c:1223:24: sparse: warning: symbol 'mtk_dsi_driver' was not declared. Should it be static? Signed

[PATCH] drm/mediatek: stop using 0 as NULL pointer

2023-01-09 Thread Miles Chen
Use NULL for NULL pointer to fix the following sparse warning: drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer Signed-off-by: Miles Chen --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2022-01-07 Thread Miles Chen
Hi Matthias, >> I'm still not happy with the commit subject, I think it is misleading. Clang >> only helped to find the bug, but the we are fixing something else, that's >> not >> just a clang warning. But I don't want to nit-pick too much so: >> >> Reviewed-by: Matthias Brugger > thanks. I

[PATCH v4] drm/mediatek: Fix mtk_cec_mask()

2022-01-03 Thread Miles Chen
quot;) Cc: Zhiqiang Lin Cc: CK Hu Cc: Matthias Brugger Signed-off-by: Miles Chen --- Change since v1: add Fixes tag Change since v2: add explanation of mtk_cec_mask() Change since v3: change misleading subject and modify the commit message since this is a bug fix patch --- drivers/gpu/dr

[PATCH v3] drm/mediatek: Fix unused-but-set variable warning

2021-12-30 Thread Miles Chen
mi experts, mtk_cec_mask() should read a register, clean only mask bits, and update (val | mask) bits to the register. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Cc: Zhiqiang Lin Cc: CK Hu Cc: Matthias Brugger Signed-off-by: Miles Chen --- Change since v1: add Fixes tag

[PATCH v2] drm/mediatek: Fix unused-but-set variable warning

2021-12-30 Thread Miles Chen
Fix unused-but-set variable warning: drivers/gpu/drm/mediatek/mtk_cec.c:85:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] Cc: CK Hu Cc: Matthias Brugger Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Signed-off-by: Miles Chen --- Change

[PATCH] drm/mediatek: Fix unused-but-set variable warning

2021-12-30 Thread Miles Chen
Fix unused-but-set variable warning: drivers/gpu/drm/mediatek/mtk_cec.c:85:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] Signed-off-by: Miles Chen --- drivers/gpu/drm/mediatek/mtk_cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d