Hi Linus,
The patch to fix the warning is here
(https://www.spinics.net/lists/amd-gfx/msg61614.html)
I guess it just didn't propagate all the way to the release.
Can it still be pulled into 5.13-rc1 release?
From: Mikita Lipski
[why]
Previous statement would always evaluate to true
m
Thanks for the change!
Reviewed-by: Mikita Lipski
On 2021-04-19 6:55 p.m., Lyude Paul wrote:
While working on moving i2c device registration into drm_dp_aux_init() - I
realized that in order to do so we need to make sure that drivers calling
drm_dp_aux_init() handle any errors it could
erstand how it should have be done initially.
This change makes sense and looks correct to me, therefore:
Reviewed-by: Mikita Lipski
Thanks,
Mikita
Signed-off-by: Lyude Paul
Fixes: cd82d82cbc04 ("drm/dp_mst: Add branch bandwidth validation to MST atomic
check")
he solution in wrong places. But I'm glad you
were able to identify the solution.
I still think the port should have an available_pbn value so it could be
updated when driver parses RESOURCE_STATUS_NOTIFY and
ENUM_PATH_RESOURCES messages.
With that being said it is a great find. Thanks.
Revie
atches for shortly). Note that I don't have
any DSC displays locally yet, so if someone from AMD could sanity check
this I would appreciate it ♥.
The series is tested and verified with MST DSC Realtek board.
Tested-by: Mikita Lipski
Cc: Mikita Lipski
Cc: Alex Deucher
Cc: Sean Paul
Cc:
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cmikita.lipski%40amd.com%7Ca48e7470afee41cb208508d7bb155ad0%7C3dd8961fe4884e608e11a82d994
On 1/24/20 5:01 PM, Lyude Paul wrote:
On Fri, 2020-01-24 at 16:46 -0500, Lyude Paul wrote:
On Fri, 2020-01-24 at 14:20 -0500, Mikita Lipski wrote:
On 1/24/20 2:10 PM, Lyude Paul wrote:
Disabling a display on MST can potentially happen after the entire MST
topology has been removed, which
herwise the patch is good. Thanks again!
Reviewed-by: Mikita Lipski
Mikita
return true;
}
@@ -285,7 +283,6 @@ bool dm_helpers_dp_mst_send_payload_allocation(
struct amdgpu_dm_connector *aconnector;
struct drm_dp_mst_topology_mgr *mst_mgr;
struct drm_dp_
On 1/24/20 9:55 AM, Harry Wentland wrote:
On 2020-01-23 7:06 p.m., Lyude Paul wrote:
Disabling a display on MST can potentially happen after the entire MST
topology has been removed, which means that we can't communicate with
the topology at all in this scenario. Likewise, this also means tha
On 1/17/20 10:09 AM, Sean Paul wrote:
On Fri, Dec 13, 2019 at 3:09 PM wrote:
From: Mikita Lipski
Hi Mikita,
Unfortunately this patch causes a crash on my i915 device when I
unplug my MST hub. The panic is below.
Hi Sean,
I thought this issue was fixed by Wayne Lin in
https
Thanks for the catch! Makes sense to skip disabled managers there, but I
wonder why it didn't cause a crash with amdgpu. Anyways looks good to me.
Acked-by: Mikita Lipski
On 1/16/20 8:58 PM, José Roberto de Souza wrote:
When a main MST port is disconnected drivers should
Thank you,
Reviewed-by: Mikita Lipski
On 1/8/20 10:24 PM, Alex Deucher wrote:
the parameter is the mst manager, not the port.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/drm_dp_mst_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
On 12/20/19 4:41 PM, Lyude Paul wrote:
So I reviewed this already but realized I made a very silly mistake, comments
down below:
On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote:
From: Mikita Lipski
[why]
Since for DSC MST connector's PBN is claculated differently
d
crtc_state to enable CRTC.
/* Scaling or underscan settings */
if (is_scaling_state_different(dm_old_conn_state, dm_new_conn_state))
--
Thanks,
Mikita Lipski
Software Engineer, AMD
mikita.lip...@amd.com
___
dri-devel mailing list
dri-devel@li
On 12/6/19 7:24 PM, Lyude Paul wrote:
Nice! All I've got is a couple of typos I noticed and one question, this looks
great :)
Thanks! I'll clean it up. The response to the question is below.
On Tue, 2019-12-03 at 09:35 -0500, mikita.lip...@amd.com wrote:
From: Mikita Lipski
te the tests in test-drm_dp_mst_helper.c
Reviewed-by: Manasi Navare
Reviewed-by: Lyude Paul
Reviewed-by: Harry Wentland
Signed-off-by: David Francis
Signed-off-by: Mikita Lipski
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
drivers/gpu/drm/drm_dp_mst_topology.c
On 20/11/2019 05:17, Ville Syrjälä wrote:
On Tue, Nov 19, 2019 at 04:11:43PM -0500, Mikita Lipski wrote:
On 19/11/2019 16:09, Mikita Lipski wrote:
On 19/11/2019 12:11, Ville Syrjälä wrote:
On Tue, Nov 19, 2019 at 04:59:40PM +, Cornij, Nikola wrote:
If you're going to make a
On 19/11/2019 16:09, Mikita Lipski wrote:
On 19/11/2019 12:11, Ville Syrjälä wrote:
On Tue, Nov 19, 2019 at 04:59:40PM +, Cornij, Nikola wrote:
If you're going to make all of them the same, then u64, please.
This is because I'm not sure if calculations require 64-bit at s
mikita.lip...@amd.com wrote:
From: Mikita Lipski
We shouldn't compare int with unsigned long to find the max value and
since we are not expecting negative value returned from
compute_offset we should make this function return unsigned long so
we can compare the values when computing rc pa
On 19/11/2019 09:56, Ville Syrjälä wrote:
On Tue, Nov 19, 2019 at 09:45:26AM -0500, mikita.lip...@amd.com wrote:
From: Mikita Lipski
We shouldn't compare int with unsigned long to find the max value
and since we are not expecting negative value returned from
compute_offset we should
Thanks for catching it!
Reviewed-by: Mikita Lipski
On 11.11.2019 12:25, Gustavo A. R. Silva wrote:
Currenly, the error check below on variable*vcpi_slots* is always
false because it is a uint64_t type variable, hence, the values
this variable can hold are never less than zero:
drivers/gpu
Thanks!
Reviewed-by: Mikita Lipski
On 08.11.2019 9:38, Colin King wrote:
> From: Colin Ian King
>
> Currently pointer aconnector is being dereferenced by the call to
> to_dm_connector_state before it is being null checked, this could
> lead to a null pointer dereference. Fix t
On 31.10.2019 9:16, Kazlauskas, Nicholas wrote:
> On 2019-10-30 3:24 p.m., mikita.lip...@amd.com wrote:
>> From: Mikita Lipski
>>
>> - Adding encoder atomic check to find vcpi slots for a connector
>> - Using DRM helper functions to calculate PBN
>> - Adding
Linux kernel can be a confusing endeavor. I'm more then happy to help out
>> with
>> this wherever I can, all you need to do is ask. Asking a few questions about
>> something you aren't sure you understand can save both of us a lot of time,
>> and avoid having to g
; +#endif
>> +
>> static void get_freesync_config_for_crtc(
>> struct dm_crtc_state *new_crtc_state,
>> struct dm_connector_state *new_con_state)
>> @@ -7388,6 +7456,17 @@ static int amdgpu_dm_atomic_check(struct drm_device
>> *dev,
>> if (ret)
>&
Tested-by: Mikita Lipski
Mikita Lipski
On 2019-08-19 11:50 a.m., David Francis wrote:
> In create_stream_for_sink, check for SST DP connectors
>
> Parse DSC caps to DC format, then, if DSC is supported,
> compute the config
>
> DSC hardware will be programmed by dc_co
26 matches
Mail list logo
