On 20/12/2024 11:08, Steven Price wrote:
On 19/12/2024 16:30, Mihail Atanassov wrote:
On 18/12/2024 18:18, Adrián Martínez Larumbe wrote:
From: Adrián Larumbe
This will display the sizes of kenrel BO's bound to an open file,
which are
otherwise not exposed to UM through a handle.
ec, struct
drm_sched_job *job);
int panthor_group_pool_create(struct panthor_file *pfile);
void panthor_group_pool_destroy(struct panthor_file *pfile);
+void panthor_group_kbo_sizes(struct panthor_file *pfile, struct
drm_memory_stats *status);
int panthor_sched_init(struct panthor_device *ptdev);
void panthor_sched_unplug(struct panthor_device *ptdev);
With the mutex cleanup 'modernised',
Reviewed-by: Mihail Atanassov
--
Mihail Atanassov
On 11/12/2024 17:02, Adrián Larumbe wrote:
Hi Mihail,
On 11.12.2024 16:40, Mihail Atanassov wrote:
Hi Adrián,
On 11/12/2024 16:34, Adrián Larumbe wrote:
A previous commit enabled display of driver-internal kernel BO sizes
through the device file's fdinfo interface.
Expand the descri
-internal` shows the size of kernel BO's associated with
+VM's and groups currently being scheduled for execution by the GPU.
+`drm-shared-memory` is unused at present, but in the future it might stand for
+the size of the Firmware regions, since they do not belong to an open file
context.
--
Mihail Atanassov
c
+++ b/drivers/gpu/drm/panthor/panthor_mmu.c
@@ -1580,7 +1580,9 @@ panthor_vm_pool_get_vm(struct panthor_vm_pool *pool, u32
handle)
{
struct panthor_vm *vm;
+ xa_lock(&pool->xa);
vm = panthor_vm_get(xa_load(&pool->xa, handle));
+ xa_unlock(&pool->va);
return vm;
}
Reviewed-by: Mihail Atanassov
--
Mihail Atanassov
On 06/11/2024 12:14, Mihail Atanassov wrote:
Hi Liviu,
On 06/11/2024 12:07, Liviu Dudau wrote:
Similar to cac075706f29 ("drm/panthor: Fix race when converting
group handle to group object") we need to use the XArray's internal
locking when retrieving a pointer from there
PANTHOR_SYNC_OP_SIGNAL = (int)(1u << 31),
-};
+/**
+ * DRM_PANTHOR_SYNC_OP_SIGNAL
+ *
+ * Signal operation.
+ */
+#define DRM_PANTHOR_SYNC_OP_SIGNAL (1u << 31)
/**
* struct drm_panthor_sync_op - Synchronization operation.
--
Mihail Atanassov
we might as well tackle it
completely...
Also, expanding the enum-type to 64 bits might have some additional
consequences, like needlessly needing more stack-space to pass values
around etc.
Thoughts? Surely there must be some precedence on using the top bit for
flags in the kernel, no?
--
Miha
l in this series or in the
Mesa MR [1], besides decoding it. Can it be removed?
[1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30651
+};
+
/**
* struct drm_panthor_dev_query - Arguments passed to
DRM_PANTHOR_IOCTL_DEV_QUERY
*/
--
Mihail Atanassov
On 05/09/2024 16:41, Steven Price wrote:
Hi Mihail,
On 05/09/2024 14:54, Mihail Atanassov wrote:
Hi Mary,
On 05/09/2024 12:13, Mary Guillemard wrote:
This adds a new value to drm_panthor_group_priority exposing the
realtime priority to userspace.
This is required to implement
he
order of the patches, they'd make more sense IMO.
};
/**
--
Mihail Atanassov
On 28/08/2024 18:27, Boris Brezillon wrote:
On Wed, 28 Aug 2024 18:07:03 +0200
Boris Brezillon wrote:
On Wed, 28 Aug 2024 14:22:51 +0100
Mihail Atanassov wrote:
Hi Boris,
On 28/08/2024 13:09, Boris Brezillon wrote:
Hi Mihail,
On Thu, 8 Aug 2024 12:41:05 +0300
Mihail Atanassov wrote
From: Ketil Johnsen
Similar to how the kernel driver notifies userspace about syncobj
modifications, the reverse notification is also necessary to let panthor
re-evaluate any queues (GPU or XGS) that were blocked on wait
operations.
Signed-off-by: Mihail Atanassov
Signed-off-by: Ketil Johnsen
-by: Ketil Johnsen
Co-developed-by: Akash Goel
Signed-off-by: Akash Goel
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/panthor/Makefile | 3 +-
drivers/gpu/drm/panthor/panthor_device.h | 4 +
drivers/gpu/drm/panthor/panthor_drv.c| 123 -
drivers/gpu/drm/panthor
Expose the SYNC_UPDATE event to userspace so it can respond to changes
in syncobj state.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/panthor/panthor_sched.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panthor/panthor_sched.c
GROUP_KICK ioctl,
to keep it distinct from the existing submit flow.
Signed-off-by: Ketil Johnsen
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/panthor/panthor_drv.c | 12 +++
drivers/gpu/drm/panthor/panthor_sched.c | 27 +
drivers/gpu/drm/panthor/panthor_sched.h
From: Ketil Johnsen
The code is needed both for the existing kernel submission path and for
implementing cross-group sync (XGS) queues which link between
drm_syncobj and the HW syncobj primitives.
Signed-off-by: Ketil Johnsen
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/panthor
From: Ketil Johnsen
Allow userspace to mmap() the ring buffer, and the doorbell and user I/O
pages, so that it can submit work directly to queues.
Signed-off-by: Ketil Johnsen
Co-developed-by: Mihail Atanassov
Signed-off-by: Mihail Atanassov
Co-developed-by: Akash Goel
Signed-off-by: Akash
From: Ketil Johnsen
Dinging the doorbell directly from userspace allows the user driver to
bypass the kernel if the group is already assigned and active.
Signed-off-by: Ketil Johnsen
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/panthor/panthor_device.c | 66
ndling
drm/panthor: Implement XGS queues
drm/panthor: Add SYNC_UPDATE ioctl
Mihail Atanassov (1):
drm/panthor: Add sync_update eventfd handling
drivers/gpu/drm/panthor/Makefile | 4 +-
drivers/gpu/drm/panthor/panthor_device.c | 66 ++-
drivers/gpu/drm/panthor/panthor_device.h | 35
mechanism to synchronise
between groups' queues across a VM
* Add a SYNC_UPDATE ioctl for user to notify kernel that it needs to
re-evaluate groups and XGS queues; use eventfds for kernel-to-user
notifications
Signed-off-by: Ketil Johnsen
Co-developed-by: Mihail Atanassov
Signed-o
Hi Boris,
On 28/08/2024 13:09, Boris Brezillon wrote:
Hi Mihail,
On Thu, 8 Aug 2024 12:41:05 +0300
Mihail Atanassov wrote:
+/** + * struct drm_panthor_timestamp_info - Timestamp information +
* + * Structure grouping all queryable information relating to the
GPU timestamp. + */ +struct
timestamp. It's untestable (in
userspace) without the offset.
The struct can be extended later if really needed, so while I'd like to
have the field stay, I'm not going to argue very hard against removing it.
+};
--
Mihail Atanassov
Hi Mary,
On 28/08/2024 09:24, Mary Guillemard wrote:
Hi Mihail,
On Mon, Aug 19, 2024 at 03:25:48PM +0100, Mihail Atanassov wrote:
diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h
index 926b1deb1116..944f5618aa05 100644
--- a/include/uapi/drm/panthor_drm.h
+++ b
will necessarily be
higher that way.
+};
+
/**
* struct drm_panthor_dev_query - Arguments passed to
DRM_PANTHOR_IOCTL_DEV_QUERY
*/
base-commit: 3e828c670b0ac8a9564c69f5c5ecf637b22a58d6
--
Mihail Atanassov
erstanding, the GPU timer frequency doesn't have a register
so I suppose it would be wired to cntfrq_el0 if CONFIG_ARM_ARCH_TIMER is
set, am I correct?
Barring any HW errata, yes, that's the frequency the GPU timer should
tick at, too.
Thanks for the review,
Mary
--
Mihail Atanassov
Sorry about the accidental re-wrap, I got fat fingers...
On 08/08/2024 10:41, Mihail Atanassov wrote:
Hi Mary,
Thanks for your patch.
On 07/08/2024 16:35, Mary Guillemard wrote:
Expose system timestamp and frequency supported by the GPU with a
new device query.
[... snip ...]
base-commit
the system timer value
* the system timer frequency
* the GPU timer value
* the GPU timer frequency (because it _could_ be different in some
systems)
* the GPU timer offset
+}; + /** * struct drm_panthor_dev_query - Arguments passed to
DRM_PANTHOR_IOCTL_DEV_QUERY */
base-commit: f7f3ddb6e5c8dc7b621fd8c0903ea42190d67452
--
Mihail Atanassov
fig as a whole, though I think this
can be done as an extension in the future, assuming multicontext access
is solved:
* you can't get as reliable a periodic trigger from userspace as you
can with an hrtimer, so it would make sense to leave enough of a hole in
the uAPI to let the kernel manag
No functional change.
v3:
- drop driver_private argument (Laurent)
Acked-by: CK Hu
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sil-sii8620.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c
b/drivers/gpu
It's no longer used, all drivers have been converted to an embedded
drm_bridge struct.
Signed-off-by: Mihail Atanassov
---
include/drm/drm_bridge.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 695d0898df38..ee175a2f95e6 1
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/panel.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
- update commit title prefix (Neil)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii9234.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/tc358767.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu/drm
No functional change: drm_bridge_init() sets bridge->of_node, but that's
not used by msm anywhere, and the bridges aren't published with
drm_bridge_add() for it to matter.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
No functional change.
v3:
- drop driver_private argument (Laurent)
Cc: Inki Dae
Cc: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c
b
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c
b/drivers/gpu
tyle updates to docs (Laurent)
- don't set drm_bridge->dev (field removed)
v2:
- s/WARN_ON(!funcs)/WARN_ON(!funcs || !dev)/ as suggested by Daniel
- expand on some kerneldoc comments as suggested by Daniel
- update commit message as suggested by Daniel
Reviewed-by: Daniel Vetter
Signed-of
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c
b/drivers/gpu/drm
nd as part of drm_bridge_init() series
v2:
- fix checkpatch complaint about unnecessary parentheses in
drm_bridge.c
Cc: Daniel Vetter
Suggested-by: Thomas Zimmermann
Acked-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
dr
It's unused.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 83538125a722..1d6dfae8a200 100644
--- a/drivers/gpu/drm/rcar-du/rcar_l
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi
Use a container_of wrapper instead. Note that no logic depends on
driver_private being NULL or not, so the cleanup in exynos_mic_bind is
safe to apply.
Cc: Inki Dae
Signed-off-by: Mihail Atanassov
---
Reviewer note: the driver_private cleanup used to be part of the
relevant drm_bridge_init
evice pointer to drm_bridge_init (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 5 ++---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 8 ++--
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 8
3 files changed, 8 insertions(+), 13 de
Instead, embed the drm_bridge structure into analogix_dp_core and use
a container_of wrapper to access the latter.
Signed-off-by: Mihail Atanassov
---
.../drm/bridge/analogix/analogix_dp_core.c| 40 +++
.../drm/bridge/analogix/analogix_dp_core.h| 8 +++-
2 files changed
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
b
uash all analogix changes into
one patch
Mihail Atanassov (35):
drm: Remove drm_bridge->dev
drm/bridge: analogix_dp: Stop using drm_bridge->driver_private
drm/bridge/synopsys: Stop using drm_bridge->driver_private
drm/bridge: thc63lvd1024: Don't set drm_bridge->dr
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511
No functional change.
v3:
- drop driver_private argument (Laurent)
Acked-by: Linus Walleij
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mcde/mcde_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c
nd as part of drm_bridge_init() series
v2:
- fix checkpatch complaint about unnecessary parentheses in
drm_bridge.c
Cc: Daniel Vetter
Suggested-by: Thomas Zimmermann
Acked-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
dr
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
b/drivers
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii902x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm
It's unused.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
index 3d74129b2995..784f4e4eea05 100644
--- a/drivers/gpu/drm/b
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/i2c/tda998x_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm
dw_hdmi: The drm_bridge struct is already embedded, so use
a container_of wrapper to access it.
dw-mipi-dsi: The field is unused, remove it.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 15 ---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/tc358764.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358764.c
b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/lvds-codec.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c
b/drivers
Instead, embed the drm_bridge structure in the originally-pointed-to
struct and use a container_of wrapper to access it.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/sti/sti_dvo.c | 20
drivers/gpu/drm/sti/sti_hda.c | 17 -
drivers/gpu/drm/sti
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/parade-ps8622.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c
b/drivers
No functional change.
v3:
- drop driver_private argument (Laurent)
v2:
- Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam,
Benjamin)
Reviewed-by: Benjamin Gaignard
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/sti/sti_dvo.c | 3
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge
evt_sprintf(str, events & KOMEDA_EVENT_IBSY, "IBSY|");
> + evt_sprintf(str, events & KOMEDA_EVENT_EMPTY, "EMPTY|");
> + evt_sprintf(str, events & KOMEDA_EVENT_FULL, "FULL|");
> evt_sprintf(str, events & KOMEDA_ERR_AXIE, "AXIE|");
> evt_sprintf(str, events & KOMEDA_ERR_ACE0, "ACE0|");
> evt_sprintf(str, events & KOMEDA_ERR_ACE1, "ACE1|");
>
Thanks for the patch,
Reviewed-by: Mihail Atanassov
--
Mihail
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
eda_kms.c
> index e30a5b43caa9..9a7dcf92591a 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -307,10 +307,6 @@ struct komeda_kms_dev *komeda_kms_attach(struct
> komeda_dev *mdev)
> if (err)
> goto free_component_binding;
>
> - err = mdev->funcs->enable_irq(mdev);
> - if (err)
> - goto free_component_binding;
> -
> drm->irq_enabled = true;
>
> drm_kms_helper_poll_init(drm);
> @@ -324,7 +320,6 @@ struct komeda_kms_dev *komeda_kms_attach(struct
> komeda_dev *mdev)
> free_interrupts:
> drm_kms_helper_poll_fini(drm);
> drm->irq_enabled = false;
> - mdev->funcs->disable_irq(mdev);
> free_component_binding:
> component_unbind_all(mdev->dev, drm);
> cleanup_mode_config:
> @@ -346,7 +341,6 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
> drm_kms_helper_poll_fini(drm);
> drm_atomic_helper_shutdown(drm);
> drm->irq_enabled = false;
> - mdev->funcs->disable_irq(mdev);
> component_unbind_all(mdev->dev, drm);
> drm_mode_config_cleanup(drm);
> komeda_kms_cleanup_private_objs(kms);
>
Reviewed-by: Mihail Atanassov
--
Mihail
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Tiannan,
Thanks for the patch.
On Wednesday, 11 December 2019 10:30:09 GMT Tiannan Zhu (Arm Technology China)
wrote:
> Make komeda driver can recongise D77, D77 is arm latest display
> product, compare with D71, D77 support some new features:
> 1. Crossbar: adjust every plane's zorder
> 2. AT
+428,9 @@ static int d71_enum_resources(struct komeda_dev *mdev)
> err = d71_probe_block(d71, &blk, blk_base);
> if (err)
> goto err_cleanup;
> - i++;
>
patch
I would've expected the fix to be a part of this series as 2/3 and this
patch as 3/3.
Otherwise, this patch is
Reviewed-by: Mihail Atanassov
>
> Signed-off-by: James Qian Wang (Arm Technology China)
>
> ---
> .../drm/arm/display/include/malidp_product.h | 3 +-
> .
ix checkpatch complaint about unnecessary parentheses in
drm_bridge.c. I've left the other two in since they're in the patch
context rather than in a touched line.
Cc: Daniel Vetter
Suggested-by: Thomas Zimmermann
Acked-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drive
Hi,
On Wednesday, 11 December 2019 07:38:29 GMT Thomas Zimmermann wrote:
> Hi
>
> Am 10.12.19 um 16:11 schrieb Mihail Atanassov:
> > As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1
> > follows the setting and NULLing of the 'encoder&#
Hi Laurent,
On Tuesday, 10 December 2019 22:57:04 GMT Laurent Pinchart wrote:
> To support implementation of DRM connectors on top of DRM bridges
> instead of by bridges, the drm_bridge needs to expose new operations and
> data:
>
> - Output detection, hot-plug notification, mode retrieval and ED
On Tuesday, 10 December 2019 16:26:47 GMT Laurent Pinchart wrote:
> Hi Mihail,
>
> Thank you for the patch.
>
> On Tue, Dec 10, 2019 at 02:48:49PM +, Mihail Atanassov wrote:
> > The function was unexported and was causing link failures for pl111 (and
> > probably
Vetter
Suggested-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 +-
drivers/gpu/drm/bridge/cdns-ds
The function was unexported and was causing link failures for pl111 (and
probably the other user tve200) in a module build.
Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper")
Cc: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Linux Walleij
Signed-off-by: Mihail
On Tuesday, 10 December 2019 10:12:50 GMT Daniel Vetter wrote:
> On Fri, Dec 06, 2019 at 12:59:04PM +0100, Thomas Zimmermann wrote:
> > Hi
> >
> > Am 06.12.19 um 12:25 schrieb Mihail Atanassov:
> > > Hallo Thomas,
> > >
> > > On Thursday, 5 De
On Monday, 9 December 2019 10:39:07 GMT Neil Armstrong wrote:
> Hi Mihail,
Hi Neil,
>
> On 04/12/2019 12:48, Mihail Atanassov wrote:
> > Hi all,
> >
> > I've dropped the fun parts of this series since they need more work, but
> > figured drm_bridge_init()
Hallo Thomas,
On Thursday, 5 December 2019 18:20:06 GMT Thomas Zimmermann wrote:
> Hi
>
> Am 05.12.19 um 17:30 schrieb Mihail Atanassov:
> > The 'dev' name causes some confusion with 'struct device' [1][2], so use
> > 'drm' instead si
k.freedesktop.org/patch/343643/?series=70432&rev=1
Cc: Daniel Vetter
Cc: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix-
Hi Neil,
On Thursday, 5 December 2019 12:10:37 GMT Neil Armstrong wrote:
> Hi,
>
> On 04/12/2019 12:48, Mihail Atanassov wrote:
> > No functional change.
> >
>
> Why this particular one has "gpu: drm: bridge" unlike the other patches of
> the serie ?
&g
Hi Laurent,
On Thursday, 5 December 2019 12:40:22 GMT Laurent Pinchart wrote:
> Hi Mihail,
>
> Thank you for the patch.
Thanks for the quick reviews :).
>
> On Wed, Dec 04, 2019 at 11:48:02AM +, Mihail Atanassov wrote:
> > A simple convenience function to initialize
On Thursday, 5 December 2019 08:53:02 GMT james qian wang (Arm Technology
China) wrote:
> On Tue, Dec 03, 2019 at 09:59:57AM +0000, Mihail Atanassov wrote:
> > On Tuesday, 3 December 2019 06:46:06 GMT james qian wang (Arm Technology
> > China) wrote:
> > > On Mon, De
No functional change.
The setting of bridge->of_node by drm_bridge_init() in
analogix_dp_core.c is safe, since ->of_node isn't used directly and the
bridge isn't published with drm_bridge_add().
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/analogix/analog
use
drm_bridge for its pipe outputs; this isn't a regression in usability
any more since device links bring the same automatic remove/reprobe
feature as components.
Mihail Atanassov (28):
drm: Introduce drm_bridge_init()
drm/bridge: adv7511: Use drm_bridge_init()
drm/bridge/analogix:
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/i2c/tda998x_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c/tda998x_drv.c
index a63790d32d75..f7dfa694aff7 100644
--- a/drivers/gpu
No functional change: it's not used anywhere.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index ac1f29bacfcb..168a718
No functional change: no logic depends on driver_private being NULL, so
it's safe to set it earlier in exynos_mic_probe.
Acked-by: Inki Dae
Tested-by: Inki Dae
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +---
1 file changed, 1 insertion(+), 7 dele
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c
b/drivers/gpu/drm/bridge/megachips-stdp-ge
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 8c6c172bbf2e..ac1f29bacfcb 100644
--- a/drivers
No functional change: drm_bridge_init() sets bridge->of_node, but that's
not used by msm anywhere, and the bridges aren't published with
drm_bridge_add() for it to matter.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++--
drivers/gpu/drm/msm/edp
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii902x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index b70e8c5cf2e1..2a9db621484d 100644
--- a/drivers/gpu/drm
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c
b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index f684947c5243..9761a80674d9 100644
--- a/drivers
No functional change.
Acked-by: Linus Walleij
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mcde/mcde_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 42fff811653e..d9b9253acccf 100644
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index dbe38a54870b..6c71ffc9df5a
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
index 3d74129b2995..abe806db5f4d 100644
--- a
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii9234.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index f81f81b7051f..bfd3832baa1a 100644
--- a/drivers/gpu/drm
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c
b/drivers/gpu/drm/bridge/nxp-ptn3460.c
index 57ff01339559..2656a188b434 100644
--- a
No functional change.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
b/drivers/gpu/drm/bridge/dumb-vga-dac.c
index cc33dc411b9e..896f27272e38 100644
--- a
1 - 100 of 243 matches
Mail list logo
