Re: [PATCH] staging: vboxvideo: Fix reporting invalid suggested-offset-properties

2017-10-13 Thread Michael Thayer
x_hint and y_hint against ~0 below, rather than -1 (see inline below)? Other than that, looks good to me. I will send Gianfranco a patch to test against Ubuntu's version of the driver. Regards Michael > Reported-by: Gianfranco Costamagna > Cc: sta...@vger.kernel.org > Cc: Michael

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-28 Thread Michael Thayer
/drm/vbox_fb.c (revision 116355) +++ src/VBox/Additions/linux/drm/vbox_fb.c (working copy) @@ -364,6 +364,9 @@ if (fbdev->helper.fbdev) { info = fbdev->helper.fbdev; +#ifdef CONFIG_FB_DEFERRED_IO + fb_deferred_io_cleanup(info); +#endif

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-14 Thread Michael Thayer
as the subject is relevant to it. Regards, and sorry for the annoyance Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgerich

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-14 Thread Michael Thayer
d-up code? Of course, I am open to patches or suggestions as to how to simplify the code in our repository as long as they do not affect other platforms (vboxguest builds and runs for five different operating system kernels). Regards Michael > Regards, > > Hans -- Michael Thayer | Virt

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-14 Thread Michael Thayer
nversion to Atomic would probably have to happen at some time or another anyway. I have put that off (out-of-tree) so far because I was tracking the AST driver as closely as possible as the simplest way of picking up fixes, and because Dave, who wrote that, knows much more about drm drivers

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-14 Thread Michael Thayer
small as possible will make sense for me. Regards Michael [...] -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht Münch

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-13 Thread Michael Thayer
13.06.2017 15:59, Greg Kroah-Hartman wrote: > On Tue, Jun 13, 2017 at 03:45:14PM +0200, Michael Thayer wrote: >> 13.06.2017 14:48, Greg Kroah-Hartman wrote: >> [Discussion of vboxvideo coding style.] >>> Once your code is accepted into the main kernel tree, why would you &g

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-13 Thread Michael Thayer
ports to its stable kernels. Regards Michael [...] -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-13 Thread Michael Thayer
style throws a bit of a spanner in that). Please be clear, I am not trying to dictate to anyone. The code is GPL, it is fine to include it with whatever modifications you deem appropriate. Since individual distributions are already doing that, it will still simplify our life somewhat if it is

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-12 Thread Michael Thayer
ould be explained by waiting for a moderator, though I don't get a warning that the message is waiting for approval. For now we have disabled that on vbox-dev too (I assume that was the list you meant). Regards Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG

Re: [PATCH v2] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-12 Thread Michael Thayer
not trying to argue here, just to get an idea for my own planning. Regards Michael Dave. -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstraße 25, D-80992 München

Re: [PATCH] staging: vboxvideo: Add vboxvideo to drivers/staging

2017-06-11 Thread Michael Thayer
kes sense in a virtual machine, where you often explicitly want to be running older software). And on the other hand, someone who doesn't need that might also appreciate knowing that it doesn't apply to them. Regards and thanks Michael Regards, Hans-- Michael Thayer | VirtualBox e

[PATCH] drm: remove immutable flag from suggested X/Y connector properties

2017-01-04 Thread Michael Thayer
lement".) [1] https://mail.gnome.org/archives/gnome-shell-list/2016-December/msg1.html Regards Michael > > cheers, > Gerd > -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | D-71384 Weinstadt ORACLE Deutschland B.V. &a

[PATCH] drm: remove immutable flag from suggested X/Y connector properties

2016-12-22 Thread Michael Thayer
22.12.2016 08:07, Daniel Vetter пишет: > On Wed, Dec 21, 2016 at 03:30:04PM +0100, Michael Thayer wrote: >> 21.12.2016 10:05, Daniel Vetter wrote: >>> On Tue, Dec 20, 2016 at 11:38:52AM +0100, Michael Thayer wrote: >>>> The suggested X and Y connector proper

[PATCH] drm: remove immutable flag from suggested X/Y connector properties

2016-12-21 Thread Michael Thayer
21.12.2016 10:05, Daniel Vetter wrote: > On Tue, Dec 20, 2016 at 11:38:52AM +0100, Michael Thayer wrote: >> The suggested X and Y connector properties are intended as a way for drivers >> for virtual machine GPUs to provide information about the layout of the >> host system

[PATCH] drm: remove immutable flag from suggested X/Y connector properties

2016-12-20 Thread Michael Thayer
. Knowing that layout lets the hypervisor send the right position information through the input device. Signed-off-by: Michael Thayer --- Follow-up to thread "Passing multi-screen layout to KMS driver". In that thread, Gerd suggested an alternative way of solving the use case, namely emu

Passing multi-screen layout to KMS driver

2016-12-16 Thread Michael Thayer
Adding Dave on CC here as the original creator of the suggested X and Y properties. 15.12.2016 15:03, Michael Thayer wrote: > 14.12.2016 11:11, Gerd Hoffmann wrote: [Summary of cut text: VirtualBox and Qemu use emulated graphics tablets to pass the host pointer through to the guest. X.Org

Passing multi-screen layout to KMS driver

2016-12-15 Thread Michael Thayer
ot; and "suggested Y" hints in the driver. That which works well enough in a first approximation - if the user changes the layout inside the virtual machine the mapping breaks, and as soon as they change it outside it mends again. So my idea was to try to have people agree on on int

Passing multi-screen layout to KMS driver

2016-12-13 Thread Michael Thayer
n about an interface to let the compositor pass the information. If not, would people be open to the idea? I would much rather have something generally agreed on than hack something up. Thanks. Regards Michael -- Michael Thayer | VirtualBox engineer ORACLE Deutschland B.V. & Co. KG | Werkstr