[PATCH v2 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel

2020-01-31 Thread michael . srba
From: Michael Srba Signed-off-by: Michael Srba --- Changes since v1: reorder includes; remove empty functions; fix after rebasing --- drivers/gpu/drm/panel/Kconfig | 6 + drivers/gpu/drm/panel/Makefile| 1 + .../panel/panel-samsung-s6e88a0-ams452ef01.c

Re: [PATCH v2 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel

2020-01-31 Thread Michael Srba
s checked > > > > Use: dim checkpatch" if you have dim. > Otherwise use checkpatch -q --emacs --strict --show-types > > Ignore the warning "MACRO_WITH_FLOW_CONTROL" - as this seems legit in this > use-case. > > Sam > > On Thu, Jan 30, 2020 at 06:1

[PATCH v3 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

2020-01-31 Thread michael . srba
From: Michael Srba This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes use of their S6E88A0 controller. Signed-off-by: Michael Srba --- Hi, I recall now that tabs cause a syntax error in yaml, should be easy to check in checkpatch.pl? I hope there are no more

[PATCH v3 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel

2020-01-31 Thread michael . srba
From: Michael Srba Signed-off-by: Michael Srba --- Changes in v2: reorder includes; remove empty functions; fix after rebasing Changes in v3: fix straightforward line-over-80-chars issues --- drivers/gpu/drm/panel/Kconfig | 6 + drivers/gpu/drm/panel/Makefile

[PATCH v2 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

2020-01-31 Thread michael . srba
From: Michael Srba This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes use of their S6E88A0 controller. Signed-off-by: Michael Srba --- Hi, Thanks for the review. I believe I've fixed everything, and I tested that I get image on drm-next with these patches ap

[PATCH 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

2020-01-27 Thread michael . srba
From: Michael Srba This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes use of their S6E88A0 controller. Signed-off-by: Michael Srba --- .../panel/samsung,s6e88a0-ams452ef01.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644

[PATCH 2/2] drm/panel: Add a driver for Samsung s6e88a0-ams452ef01 panel

2020-01-27 Thread michael . srba
From: Michael Srba Add a driver for Samsung AMS452EF01 AMOLED panel, which makes use of their S6E88A0 controller. Basic functionality is supported, with the only notable feature missing being backlight control. Backlight control on these panels is complex and hard to make look nice, mainly