);
> > - spin_unlock_irqrestore(&dev->devres_lock, flags);
> > -
> > release_nodes(dev, &todo);
> > } else {
> > WARN_ON(1);
> > - spin_unlock_irqrestore(&dev->d
Hi Doug
On Wed, Aug 7, 2024 at 11:02 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Aug 7, 2024 at 5:39 AM Michael Nazzareno Trimarchi
> wrote:
> >
> > Hi Doug
> >
> > +cc Doug
> >
> > I have seen that you have done some re-working a
63353_panel *rpanel = mipi_dsi_get_drvdata(dsi);
>
> - r63353_panel_unprepare(&rpanel->base);
> + drm_panel_unprepare(&rpanel->base);
> }
>
> static const struct r63353_desc sharp_ls068b3sx02_data = {
> --
> 2.43.0
e: Document bridge init order with pre_enable_prev_first
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=113cc3ad8566
>
>
>
> Rob
>
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__
pre_enable_prev_first and immediately the next assigned to previous
> > > > > > Bridge 6 and limit assignments to next Bridge 6 and call post_enable
> > > > > > of Bridge 6 even though the next consecutive Bridge 5 is enabled
> > > > > > with
> > > > > > pre_enable_prev_first. This clearly misses the logic to find the
> > > > > > state
> > > > > > of next conducive bridge as everytime the next and limit assigns
> > > > > > previous bridge if given bridge enabled pre_enable_prev_first.
> > > > > >
> > > > > > So, the resulting post_disable bridge order would be,
> > > > > > - Encoder, Bridge 6, Bridge 5, Bridge 4, Bridge 3, Bridge 2, Bridge
> > > > > > 1,
> > > > > > Panel.
> > > > > >
> > > > > > This patch fixes this by assigning next with previou bridge only if
> > > > > > the
> > > > > > bridge doesn't enable pre_enable_prev_first flag and the next
> > > > > > further
> > > > > > assign it to limit. This way we can find the bridge that NOT
> > > > > > requested
> > > > > > prev to disable last.
> > > > > >
> > > > > > So, the resulting pre_enable bridge order with fix would be,
> > > > > > - Encoder, Bridge 4, Bridge 5, Bridge 6, Bridge 2, Bridge 3, Bridge
> > > > > > 1,
> > > > > > Panel.
> > > > > >
> > > > > > Validated the bridge init ordering by incorporating dummy bridges in
> > > > > > the sun6i-mipi-dsi pipeline
> > > > > >
> > > > > > Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to
> > > > > > alter bridge init order")
> > > > > > Signed-off-by: Jagan Teki
> > > >
> > > > Thanks for investigating and sorting this.
> > > >
> > > > Reviewed-by: Dave Stevenson
> > > >
> > > > > > ---
> > > > > > Changes for v2:
> > > > > > - add missing dri-devel in CC
> > > > >
> > > > > Would you please look into this issue?
> > >
> > > These still not been picked it yet, can any one pull these two fixes?
> >
> > Ping!
>
Tested-by: Michael Trimarchi
> Ping!
>
> Thanks,
> Jagan.
>
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com
Hi Frieder
On Thu, Dec 7, 2023 at 5:58 PM Frieder Schrempf
wrote:
>
> On 07.12.23 15:16, Dario Binacchi wrote:
> > The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp
> > platforms (i. e. not exynos).
>
> This also affects i.MX8MM, so better just mention i.MX in general in t
Hi Jagan
On Wed, Dec 6, 2023 at 2:31 PM Jagan Teki wrote:
>
> Hi Dario,
>
> On Wed, Dec 6, 2023 at 6:57 PM Dario Binacchi
> wrote:
> >
> > Hi Dave and Jagan,
> >
> > On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson
> > wrote:
> > >
> > > Hi Dario
> > >
> > > On Tue, 5 Dec 2023 at 10:54, Dario Bina
Hi Jagan
On Sun, Nov 26, 2023 at 5:11 PM Jagan Teki wrote:
>
> On Mon, Nov 13, 2023 at 6:45 PM Jagan Teki wrote:
> >
> > On Tue, Aug 1, 2023 at 11:50 AM Dave Stevenson
> > wrote:
> > >
> > > Hi Jagan
> > >
> > > My apologies for dropping the ball on this one, and thanks to Frieder
> > > for the
Hi
On Tue, Jun 13, 2023 at 4:41 PM Philippe CORNU
wrote:
>
>
>
> On 6/9/23 08:20, Dario Binacchi wrote:
> > Boards that use the STM32F{4,7} series have limited amounts of RAM. The
> > added parameter allows users to size, within certain limits, the memory
> > footprint required by the framebuffer
Hi Daniel
On Tue, Mar 21, 2023 at 1:15 PM Daniel Stone wrote:
>
> Hi,
>
> On Tue, 21 Mar 2023 at 12:08, Jani Nikula wrote:
> > On Tue, 21 Mar 2023, Daniel Stone wrote:
> > > There have been some threads - mostly motivated by MacBooks and the
> > > Asahi team - about creating a KMS property to e
Hi Daniel
On Tue, Mar 21, 2023 at 12:49 PM Daniel Stone wrote:
>
> Hi,
>
> On Tue, 21 Mar 2023 at 11:24, Jani Nikula wrote:
> > On Tue, 21 Mar 2023, Michael Nazzareno Trimarchi
> > wrote:
> > > On Tue, Mar 21, 2023 at 11:43 AM Jani Nikula
> > >
Hi
On Tue, Mar 21, 2023 at 11:43 AM Jani Nikula
wrote:
>
> On Tue, 21 Mar 2023, Michael Nazzareno Trimarchi
> wrote:
> > Hi all
> >
> > I would like to know the best approach in the graphics subsystem how
> > deal with panels where the display area is di
Hi all
I would like to know the best approach in the graphics subsystem how
deal with panels where the display area is different from the visible
area because the display has a band left and right. I have already
done the drm driver for the panel but from userspace point of view
it's a pain to dea
| 18 +
> .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 72 +++
> include/linux/phy/phy.h | 3 +-
> 3 files changed, 92 insertions(+), 1 deletion(-)
>
> --
> 2.34.1
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executiv
8.yaml | 72 +++
> > drivers/gpu/drm/tiny/Kconfig | 13 +
> > drivers/gpu/drm/tiny/Makefile | 1 +
> > drivers/gpu/drm/tiny/ili9488.c | 440 ++
> > 4 files changed, 526 insertions(+)
>
+ return PTR_ERR(dc);
> + }
> +
> + dbidev->backlight = devm_of_find_backlight(dev);
> + if (IS_ERR(dbidev->backlight))
> + return PTR_ERR(dbidev->backlight);
> +
> + device_property_read_u32(dev, "rotation&quo
Hi
On Fri, Dec 10, 2021 at 4:48 PM Dave Stevenson
wrote:
>
> Hi Michael
>
> On Fri, 10 Dec 2021 at 09:05, Michael Nazzareno Trimarchi
> wrote:
> >
> > Hi Dave
> >
> > some questions below
> >
> > On Thu, Dec 9, 2021 at 7:10 PM Michael
Hi Dave
some questions below
On Thu, Dec 9, 2021 at 7:10 PM Michael Nazzareno Trimarchi
wrote:
>
> Hi Dave
>
> On Thu, Dec 9, 2021 at 6:58 PM Dave Stevenson
> wrote:
> >
> > Hi Michael
> >
> > On Thu, 9 Dec 2021 at 16:58, Michael Nazzareno T
Hi
On Thu, Dec 9, 2021 at 9:24 PM Lucas Stach wrote:
>
> Am Donnerstag, dem 09.12.2021 um 18:09 +0100 schrieb Michael Nazzareno
> Trimarchi:
> > Hi Tim
> >
> > On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote:
> > >
> > > On Thu, Dec 9, 2021 at 12:3
Hi Dave
On Thu, Dec 9, 2021 at 6:58 PM Dave Stevenson
wrote:
>
> Hi Michael
>
> On Thu, 9 Dec 2021 at 16:58, Michael Nazzareno Trimarchi
> wrote:
> >
> > Hi all
> >
> > On Sat, Oct 16, 2021 at 4:58 PM Michael Trimarchi
> > wrote:
> > >
Hi Tim
On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote:
>
> On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi
> wrote:
> >
> > Hi Tim
> >
> > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote:
> > >
> > > On Sun, Jul 25, 2021 at 10
> + return 0;
> +
> mipi_dsi_dcs_enter_sleep_mode(ctx->dsi);
> regulator_disable(ctx->power);
> gpiod_set_value(ctx->reset, 1);
>
> + ctx->prepared = false;
> +
> return 0;
> }
>
> --
> 2.25.1
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com
at your repo it looks
> like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim
> branch but you've got a lot of things there that are likely not
> related to this series?
I have a bit of work on those patches and tested on imx8mn. Basically:
- add the dsi timing calc
backlight = <&backlight>;
> > > > >
> > > > > port {
> > > > > bridge_out_dsi: endpoint {
> > > > > remote-endpoint = <&dsi_out_bridge>;
> > > > > };
> > > > > };
> > > > >};
> > > > > };
> > > >
> > > > Yes, I know, and that's because ...
> > >
> > > Okay. I will use find panel and bridge separately instead of
> > > devm_drm_of_get_bridge in version patches.
> >
> > That's not been my point, at all?
> >
> > I mean, that whole discussion has been because you shouldn't do that.
> >
> > > >
> > > > > >
> > > > > > > https://patchwork.kernel.org/project/dri-devel/patch/20211122065223.88059-6-ja...@amarulasolutions.com/
> > > > > > >
> > > > > > > dsi->next_bridge = devm_drm_of_get_bridge(dsi->dev,
> > > > > > > dsi->dev->of_node, 0, 0);
> > > > > > > if (IS_ERR(dsi->next_bridge))
> > > > > > >return PTR_ERR(dsi->next_bridge);
> > > > > > >
> > > > > > > It is only working if we have ports on the pipeline, something
> > > > > > > like this
> > > > > > > https://patchwork.kernel.org/project/dri-devel/patch/20210214194102.126146-8-ja...@amarulasolutions.com/
> > > > > > >
> > > > > > > Please have a look and let me know if I miss anything?
> > > > > >
> > > > > > Yes, you're missing the answer you quoted earlier:
> > > > >
> > > > > Yes, I'm trying to resolve the comment one after another. Will get
> > > > > back.
> > > >
> > > > ... You've ignored that comment.
> > >
> > > Not understand which comment you mean. There are few about bridge
> > > conversion details, I will send my comments.
> >
> > The one that got quoted there and you removed. For reference:
> >
> > > Then drm_of_find_panel_or_bridge needs to be adjusted to handle the DSI
> > > bindings and look for a panel or bridge not only through the OF graph,
> > > but also on the child nodes
> >
> > devm_drm_of_get_bridge uses drm_of_find_panel_or_bridge under the hood,
> > so of course it won't find it if drm_of_find_panel_or_bridge doesn't.
> > You need to modify drm_of_find_panel_or_bridge to also look for child
> > devices and see if there's a panel or bridge registered for that child
> > node. Then devm_drm_of_get_bridge will work as you intend it to.
>
> Got it now, I will make necessary changes.
>
> Thanks,
> Jagan.
>
>
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com
Hi Sam
On Sat, Oct 16, 2021 at 2:27 PM Sam Ravnborg wrote:
>
> Hi Michael,
>
> On Sat, Oct 16, 2021 at 10:22:27AM +, Michael Trimarchi wrote:
> > This patch series add support for W552946ABA panel. This panel is used
> > in px30-evb v11. All the patches can be applied on top of drm-fixes
> >
wn call chains...
*/
if (dsi->panel_bridge->funcs->post_disable)
dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
Is this comment relevant?
Michael
On Sat, Oct 16, 2021 at 3:32 PM Michael Nazzareno Trimarchi
wrote:
>
> Hi Sam
>
&g
pdata);
> > + if (IS_ERR(dmd)) {
> > + ret = PTR_ERR(dmd);
>
> The memory pointed to by dmd is allocated in dw_mipi_dsi_probe(), but
> the pointer is not saved here.
> We rely on the attach operation to save the dmd pointer.
>
>
> In other words - the attach operation must be
dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
> > + dsi->mode_flags = ctx->desc->mode_flags;
> > dsi->format = MIPI_DSI_FMT_RGB888;
> > dsi->lanes = 4;
> >
> > @@ -691,17 +916,28 @@ static const struct ili9881c_desc lhr050h41_desc =
- if (IS_ERR(bridge))
> > - return PTR_ERR(bridge);
> > + dsi->device_found = true;
> > }
> >
> > - dsi->panel_bridge = bridge;
> > -
> > - drm_bridge_add(&dsi->bridge);
> > -
> >
nes < 1 || sn->dsi_lanes > 4)
> + return -EINVAL;
> +
> + sn->host_node = of_graph_get_remote_node(dev->of_node, 0, 0);
> + if (!sn->host_node)
> + return -ENODEV;
> +
> + of_node_put(sn->host_node);
> +
> + return 0;
On Wed, Jan 20, 2021 at 12:29 PM Jagan Teki wrote:
>
> On Wed, Jan 20, 2021 at 4:55 PM Michael Nazzareno Trimarchi
> wrote:
> >
> > Hi Jagan
> >
> > On Wed, Jan 20, 2021 at 12:22 PM Jagan Teki
> > wrote:
> > >
> > > SN65DSI84 is a Sin
}
> + }
> + }
> +
> + sn->dsi_lanes = len / sizeof(u32);
> + if (sn->dsi_lanes < 1 || sn->dsi_lanes > 4)
> + return -EINVAL;
> +
> + sn->host_node = of_graph_get_remote_node(dev->of_node, 0, 0);
> + if (!sn
Hi Maxime
On Wed, Aug 28, 2019 at 3:03 PM Maxime Ripard wrote:
>
> Hi,
>
> On Thu, Aug 15, 2019 at 02:25:57PM +0200, Michael Nazzareno Trimarchi wrote:
> > On Tue, Aug 13, 2019 at 8:05 AM Maxime Ripard
> > wrote:
> > > On Mon, Jul 29, 2019 at 08:59:04AM +
Hi Maxime
On Tue, Aug 13, 2019 at 8:05 AM Maxime Ripard wrote:
>
> On Mon, Jul 29, 2019 at 08:59:04AM +0200, Michael Nazzareno Trimarchi wrote:
> > Hi
> >
> > On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard
> > wrote:
> > >
> > > On Mon, Ju
Hi Maxime
On Mon, Jul 29, 2019 at 8:59 AM Michael Nazzareno Trimarchi
wrote:
>
> Hi
>
> On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard
> wrote:
> >
> > On Mon, Jul 22, 2019 at 03:51:04PM +0530, Jagan Teki wrote:
> > > Hi Maxime,
> > >
> &
7PM +0530, Jagan Teki wrote:
> > > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard
> > > > wrote:
> > > > >
> > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi
> > > > > wrote:
> > > > >
> > > wrote:
> > > >
> > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi
> > > > wrote:
> > > > > > > tcon-pixel clock is the rate that you want to achive on display
> > > > > > > side
Hi
On Sat., 20 Jul. 2019, 8:58 am Maxime Ripard,
wrote:
> On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi
> wrote:
> > > > tcon-pixel clock is the rate that you want to achive on display side
> > > > and if you have 4 lanes 32bit or lanes
Hi
On Sat, Jul 20, 2019 at 11:32 AM Maxime Ripard
wrote:
>
> On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote:
> > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard
> > wrote:
> > >
> > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trim
Hi
On Thu, Jul 11, 2019 at 7:43 PM Michael Nazzareno Trimarchi
wrote:
>
> Hi Maxime
>
> On Thu, Jul 11, 2019 at 2:23 PM Maxime Ripard
> wrote:
> >
> > On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote:
> > > On Wed, Jul 3, 2019 at
Hi Maxime
On Thu, Jul 11, 2019 at 2:23 PM Maxime Ripard wrote:
>
> On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote:
> > On Wed, Jul 3, 2019 at 1:49 PM Maxime Ripard
> > wrote:
> > >
> > > On Tue, Jun 25, 2019 at 09:00:36PM +05
0
> > > > [1.920572] sun4i_dclk_recalc_rate: val = 1, rate = 17820
> > > > [1.920576] sun4i_dclk_recalc_rate: val = 1, rate = 17820
> > > > [1.920597] rate = 17820
> > > > [1.920599] parent_rate = 29700
42 matches
Mail list logo
