Re: (subset) [PATCH 00/35] Reorganize kerneldoc parameter names

2024-11-17 Thread Michael Ellerman
On Mon, 30 Sep 2024 13:20:46 +0200, Julia Lawall wrote: > Reorganize kerneldoc parameter names to match the parameter > order in the function header. > > The misordered cases were identified using the following > Coccinelle semantic patch: > > // > @initialize:ocaml@ > @@ > > [...] Applied to

Re: [PATCH v2] printk: Add a short description string to kmsg_dump()

2024-07-12 Thread Michael Ellerman
ard >declaration of oops_to_nvram() > > Signed-off-by: Jocelyn Falempe > --- > arch/powerpc/kernel/nvram_64.c | 8 > arch/powerpc/platforms/powernv/opal-kmsg.c | 4 ++-- Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH v2] printk: Add a short description string to kmsg_dump()

2024-07-12 Thread Michael Ellerman
Jocelyn Falempe writes: > On 02/07/2024 14:26, Jocelyn Falempe wrote: >> kmsg_dump doesn't forward the panic reason string to the kmsg_dumper >> callback. >> This patch adds a new struct kmsg_dump_detail, that will hold the >> reason and description, and pass it to the dump() callback. >> >> To a

Re: (subset) [PATCH 00/34] address all -Wunused-const warnings

2024-04-22 Thread Michael Ellerman
On Wed, 03 Apr 2024 10:06:18 +0200, Arnd Bergmann wrote: > Compilers traditionally warn for unused 'static' variables, but not > if they are constant. The reason here is a custom for C++ programmers > to define named constants as 'static const' variables in header files > instead of using macros or

Re: [PATCH v3 15/15] powerpc: Add support for suppressing warning backtraces

2024-04-03 Thread Michael Ellerman
fine but a virtual variable). > > Tested-by: Linux Kernel Functional Testing > Acked-by: Dan Carpenter > Cc: Michael Ellerman > Signed-off-by: Guenter Roeck > --- > v2: > - Rebased to v6.9-rc1 > - Added Tested-by:, Acked-by:, and Reviewed-by: tags > - Introduced KUNIT_SUPPRESS

Re: [PATCH 00/14] Add support for suppressing warning backtraces

2024-03-17 Thread Michael Ellerman
Guenter Roeck writes: > On 3/14/24 07:37, Guenter Roeck wrote: >> On 3/14/24 06:36, Geert Uytterhoeven wrote: >>> Hi Günter, >>> >>> On Tue, Mar 12, 2024 at 6:03 PM Guenter Roeck wrote: Some unit tests intentionally trigger warning backtraces by passing bad parameters to kernel API func

Re: [PATCH v3 3/3] arch/powerpc: Remove from backlight code

2024-03-07 Thread Michael Ellerman
cklight.h| 5 ++-- > arch/powerpc/platforms/powermac/backlight.c | 26 - > 2 files changed, 2 insertions(+), 29 deletions(-) Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Michael Ellerman
Jani Nikula writes: > On Mon, 04 Mar 2024, Jani Nikula wrote: >> Removal of the backlight include from fb.h uncovered an implicit >> dependency in powerpc asm/backlight.h. Add the explicit include. >> >> Reported-by: Naresh Kamboju >> Closes: >> https://lore.kernel.org/r/ca+g9fysak5tbqqxfc2w4oh

Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

2024-03-04 Thread Michael Ellerman
Christophe Leroy writes: > Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit : >> Hi >> >> Am 04.03.24 um 10:55 schrieb Jani Nikula: >>> Removal of the backlight include from fb.h uncovered an implicit >>> dependency in powerpc asm/backlight.h. Add the explicit include. >>> >>> Reported-by: Naresh

[PATCH] fbdev/mb862xxfb: Fix defined but not used error

2024-02-29 Thread Michael Ellerman
socrates_gc_mode = { Fix it by moving socrates_gc_mode inside that ifdef, immediately prior to the only function where it's used. Signed-off-by: Michael Ellerman --- drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/

Re: [PATCH v2] drivers/ps3: select VIDEO to provide cmdline functions

2024-02-08 Thread Michael Ellerman
gt;> Fixes: dae7fbf43fd0 ("driver/ps3: Include for mode >> parsing") >> Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= >> parameter") >> Cc: Michael Ellerman >> Cc: Nicholas Piggin >> Cc: Christophe Leroy >

Re: (subset) [PATCH 00/22] -Wmissing-prototype warning fixes

2023-12-07 Thread Michael Ellerman
On Wed, 08 Nov 2023 13:58:21 +0100, Arnd Bergmann wrote: > I slightly dropped the ball on this since last sending the series in > August, but a number of warning fixes have made it into the kernel in > the meantime, both from my earlier submission and from architecture > maintainers. > > I have no

Re: (subset) [PATCH v5 0/5] ppc, fbdev: Clean up fbdev mmap helper

2023-11-12 Thread Michael Ellerman
On Fri, 22 Sep 2023 10:04:54 +0200, Thomas Zimmermann wrote: > Clean up and rename fb_pgprotect() to work without struct file. Then > refactor the implementation for PowerPC. This change has been discussed > at [1] in the context of refactoring fbdev's mmap code. > > The first two patches update f

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-09 Thread Michael Ellerman
Christophe Leroy writes: > Le 09/11/2023 à 11:18, Michael Ellerman a écrit : >> "Arnd Bergmann" writes: >>> On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >>>> Le 08/11/2023 à 13:58, Arnd Bergmann a écrit : >>> >>>> power

Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes

2023-11-09 Thread Michael Ellerman
"Arnd Bergmann" writes: > On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote: >> Le 08/11/2023 à 13:58, Arnd Bergmann a écrit : > >> powerpc has functions doing more or less the same, they are called >> __c_kernel_clock_gettime() and alike with their prototypes siting in >> arch/powerpc/inclu

Re: [PATCH v5 0/5] ppc, fbdev: Clean up fbdev mmap helper

2023-10-18 Thread Michael Ellerman
Thomas Zimmermann writes: > FYI, I intent to merge patches 1 and 2 of this patchset into > drm-misc-next. The updates for PowerPC can be merged through PPC trees > later. Let me know if this does not work for you. Hi Thomas, Sorry for the late reply, I was on leave. Yeah that's fine. cheers

Re: [PATCH 00/11] add missing of_node_put

2023-09-21 Thread Michael Ellerman
On Thu, 07 Sep 2023 11:55:10 +0200, Julia Lawall wrote: > Add of_node_put on a break out of an of_node loop. > Patches 3 and 6 applied to powerpc/next. [03/11] powerpc/powermac: add missing of_node_put https://git.kernel.org/powerpc/c/a59e9eb25216eb1dc99e14fc31b76aa648d79540 [06/11] pow

Re: [PATCH 0/4] ppc, fbdev: Clean up fbdev mmap helper

2023-09-04 Thread Michael Ellerman
Thomas Zimmermann writes: > Refactor fb_pgprotect() in PowerPC to work without struct file. Then > clean up and rename fb_pgprotect(). This change has been discussed at > [1] in the context of refactoring fbdev's mmap code. > > The first three patches adapt PowerPC's internal interfaces to > provi

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-20 Thread Michael Ellerman
Arnd Bergmann writes: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old arch/ppc codeb

Re: build failure from drm/ttm commit now in mainline (was: linux-next: build failure after merge of the drm tree)

2023-04-26 Thread Michael Ellerman
Thorsten Leemhuis writes: > Lo! > > Sometimes the regression tracker runs into regressions himself... :-D > > On 11.04.23 08:47, Stephen Rothwell wrote: >> >> After merging the drm tree, today's linux-next build (powerpc >> allyesconfig) failed like this: >> >> drivers/gpu/drm/ttm/ttm_pool.c:73:

Re: mainline build failure due to 322458c2bb1a ("drm/ttm: Reduce the number of used allocation orders for TTM pages")

2023-04-26 Thread Michael Ellerman
Linus Torvalds writes: > On Wed, Apr 26, 2023 at 10:44 AM Sudip Mukherjee (Codethink) > wrote: >> >> drivers/gpu/drm/ttm/ttm_pool.c:73:29: error: variably modified >> 'global_write_combined' at file scope >>73 | static struct ttm_pool_type global_write_combined[TTM_DIM_ORDER]; >> |

Re: In-flight collision: DRM_AMD_DC_DCN renaming

2023-04-24 Thread Michael Ellerman
Hi Lukas, Lukas Bulwahn writes: > Dear Michael, dear Harry, dear Alex, > > The commit 4652ae7a51b7 ("drm/amd/display: Rename DCN config to FP") > renames config DRM_AMD_DC_DCN to config DRM_AMD_DC_FP. The concurrent > commit 78f0929884d4 ("powerpc/64: Always build with 128-bit long > double") ove

Re: [PATCH v2 15/19] arch/powerpc: Implement with generic helpers

2023-04-11 Thread Michael Ellerman
Thomas Zimmermann writes: > Replace the architecture's fb_is_primary_device() with the generic > one from . No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc: Christophe Leroy > --- > arch/powerpc/in

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-11 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/amd/display/Kconfig > > between commit: > > 78f0929884d4 ("powerpc/64: Always build with 128-bit long double") > > from the powerpc tree and commit: > > 4652ae7a51b7 ("drm/a

Re: [PATCH v2 01/16] slab: Remove __malloc attribute from realloc functions

2022-09-29 Thread Michael Ellerman
Kees Cook writes: > On Wed, Sep 28, 2022 at 09:26:15AM +0200, Geert Uytterhoeven wrote: >> On Fri, Sep 23, 2022 at 10:35 PM Kees Cook wrote: >> > The __malloc attribute should not be applied to "realloc" functions, as >> > the returned pointer may alias the storage of the prior pointer. Instead >

Re: [PATCH 1/7] mm/memory.c: Fix race when faulting a device private page

2022-09-28 Thread Michael Ellerman
Alistair Popple writes: > Michael Ellerman writes: >> Alistair Popple writes: >>> When the CPU tries to access a device private page the migrate_to_ram() >>> callback associated with the pgmap for the page is called. However no >>> reference is taken on the f

Re: [PATCH 1/7] mm/memory.c: Fix race when faulting a device private page

2022-09-28 Thread Michael Ellerman
Alistair Popple writes: > When the CPU tries to access a device private page the migrate_to_ram() > callback associated with the pgmap for the page is called. However no > reference is taken on the faulting page. Therefore a concurrent > migration of the device private page can free the page and p

Re: [PATCH v3 1/4] video: fbdev: offb: Include missing linux/platform_device.h

2022-07-29 Thread Michael Ellerman
On Fri, 8 Jul 2022 09:11:05 +0200, Christophe Leroy wrote: > A lot of drivers were getting platform and of headers > indirectly via headers like asm/pci.h or asm/prom.h > > Most of them were fixed during 5.19 cycle but a newissue was > introduced by commit 52b1b46c39ae ("of: Create platform device

Re: [PATCH v2 00/10] drm: Add driver for PowerPC OF displays

2022-07-28 Thread Michael Ellerman
Thomas Zimmermann writes: > (was: drm: Add driverof PowerPC OF displays) > > PowerPC's Open Firmware offers a simple display buffer for graphics > output. Add ofdrm, a DRM driver for the device. As with the existing > simpledrm driver, the graphics hardware is pre-initialized by the > firmware. Th

Re: [PATCH v2] drm/nouveau/bios: Rename prom_init() and friends functions

2022-06-17 Thread Michael Ellerman
this gets pushed today >> >> On Tue, 2022-06-07 at 23:00 +1000, Michael Ellerman wrote: >> > Lyude Paul writes: >> > > Reviewed-by: Lyude Paul >> > > >> > > Will push to drm-misc-next >> > >> > I don't see this patch in

Re: [PATCH v2] drm/nouveau/bios: Rename prom_init() and friends functions

2022-06-07 Thread Michael Ellerman
Lyude Paul writes: > Reviewed-by: Lyude Paul > > Will push to drm-misc-next I don't see this patch in mainline or drm-misc-next, did it get lost? cheers > On Sat, 2022-03-19 at 11:27 +0100, Christophe Leroy wrote: >> While working at fixing powerpc headers, I ended up with the >> following err

Re: [PATCH] video: fbdev: use memset_io() instead of memset()

2021-10-11 Thread Michael Ellerman
On Wed, 15 Sep 2021 15:34:35 +0200, Christophe Leroy wrote: > While investigating a lockup at startup on Powerbook 3400C, it was > identified that the fbdev driver generates alignment exception at > startup: > > --- interrupt: 600 at memset+0x60/0xc0 > NIP: c0021414 LR: c03fc49c CTR:

Re: [PATCH] video: fbdev: use memset_io() instead of memset()

2021-10-07 Thread Michael Ellerman
Christophe Leroy writes: > While investigating a lockup at startup on Powerbook 3400C, it was > identified that the fbdev driver generates alignment exception at > startup: ... > > Use fb_memset() instead of memset(). fb_memset() is defined as > memset_io() for powerpc. > > Fixes: 8c8709334cec ("[

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-16 Thread Michael Ellerman
Christoph Hellwig writes: > On Wed, Sep 15, 2021 at 07:18:34PM +0200, Christophe Leroy wrote: >> Could you please provide more explicit explanation why inlining such an >> helper is considered as bad practice and messy ? > > Because now we get architectures to all subly differ. Look at the mess >

Re: [PATCH v3 4/8] powerpc/pseries/svm: Add a powerpc version of cc_platform_has()

2021-09-14 Thread Michael Ellerman
ally only support the CC_ATTR_MEM_ENCRYPT >> attribute. >> >> Cc: Michael Ellerman >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Signed-off-by: Tom Lendacky >> --- >> arch/powerpc/platforms/pseries/Kconfig | 1 + >> arch/powerpc

Re: [PATCH v2 57/63] powerpc/signal32: Use struct_group() to zero spe regs

2021-08-22 Thread Michael Ellerman
Kees Cook writes: > On Fri, Aug 20, 2021 at 05:49:35PM +1000, Michael Ellerman wrote: >> Kees Cook writes: >> > In preparation for FORTIFY_SOURCE performing compile-time and run-time >> > field bounds checking for memset(), avoid intentionally writing acr

Re: [PATCH v2 57/63] powerpc/signal32: Use struct_group() to zero spe regs

2021-08-20 Thread Michael Ellerman
Christophe Leroy writes: > Le 20/08/2021 à 09:49, Michael Ellerman a écrit : >> Kees Cook writes: >>> In preparation for FORTIFY_SOURCE performing compile-time and run-time >>> field bounds checking for memset(), avoid intentionally writing across >>&g

Re: [PATCH v2 57/63] powerpc/signal32: Use struct_group() to zero spe regs

2021-08-20 Thread Michael Ellerman
7; declared with attribute warning: detected write >>> beyond size of field (1st parameter); maybe use struct_group()? >>> [-Werror=attribute-warning] > 195 |__write_overflow_field(); > |^~~~ > > Cc: Michael Ellerman

Re: [PATCH v2 04/12] powerpc/pseries/svm: Add a powerpc version of prot_guest_has()

2021-08-17 Thread Michael Ellerman
Tom Lendacky writes: > Introduce a powerpc version of the prot_guest_has() function. This will > be used to replace the powerpc mem_encrypt_active() implementation, so > the implementation will initially only support the PATTR_MEM_ENCRYPT > attribute. > > Cc: Michael Ellerm

Re: [PATCH 58/64] powerpc: Split memset() to avoid multi-field overflow

2021-08-05 Thread Michael Ellerman
memset(&cmd->info.sublen, 0, 4); > + cmd->info.sublen = 0; > + memset(&cmd->info.subaddr, 0, 3); > break; > case SMU_I2C_TRANSFER_COMBINED: > cmd->info.devaddr &= 0xfe; > -- > 2.30.2 Reviewed-by: Michael Ellerman cheers

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-22 Thread Michael Ellerman
Alex Williamson writes: > On Mon, 12 Apr 2021 19:41:41 +1000 > Michael Ellerman wrote: > >> Alex Williamson writes: >> > On Fri, 26 Mar 2021 07:13:10 +0100 >> > Christoph Hellwig wrote: >> > >> >> This driver never had any open userspace

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-12 Thread Michael Ellerman
Alex Williamson writes: > On Fri, 26 Mar 2021 07:13:10 +0100 > Christoph Hellwig wrote: > >> This driver never had any open userspace (which for VFIO would include >> VM kernel drivers) that use it, and thus should never have been added >> by our normal userspace ABI rules. >> >> Signed-off-by:

Re: [PATCH 01/13] powerpc/powernv: remove get_cxl_module

2021-02-04 Thread Michael Ellerman
gt; Reviewed-by: Andrew Donnellan > --- > arch/powerpc/platforms/powernv/pci-cxl.c | 22 -- > 1 file changed, 22 deletions(-) Acked-by: Michael Ellerman cheers ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-12-03 Thread Michael Ellerman
Uwe Kleine-König writes: > Hello Michael, > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: >> On Thu, 26 Nov 2020 17:59:50 +0100, >> Uwe Kleine-König wrote: >> > >> > The driver core ignores the return value of struct device_driver::remove >> > because there is only little that c

Re: [PATCH] video: fbdev: controlfb: Fix build for COMPILE_TEST=y && PPC_PMAC=n

2020-08-28 Thread Michael Ellerman
On Fri, 21 Aug 2020 20:49:10 +1000, Michael Ellerman wrote: > The build is currently broken, if COMPILE_TEST=y and PPC_PMAC=n: > > linux/drivers/video/fbdev/controlfb.c: In function > ‘control_set_hardware’: > linux/drivers/video/fbdev/controlfb.c:276:2: error: implicit

[PATCH] video: fbdev: controlfb: Fix build for COMPILE_TEST=y && PPC_PMAC=n

2020-08-22 Thread Michael Ellerman
->frame_buffer_phys + CTRLFB_OFF, | ^~~~ Fix it by including btext.h whenever CONFIG_BOOTX_TEXT is enabled. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Signed-off-by: Michael Ellerman --- drivers/video/fbdev/controlfb.c | 2 ++ 1 fi

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-09 Thread Michael Ellerman
On Mon, 30 Mar 2020 15:32:15 +0200, Michal Simek wrote: > recently we wanted to update xilinx intc driver and we found that function > which we wanted to remove is still wired by ancient Xilinx PowerPC > platforms. Here is the thread about it. > https://lore.kernel.org/linux-next/48d3232d-0f1d-42ea

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-06-04 Thread Michael Ellerman
Christophe Leroy writes: > Hi, > > Le 03/06/2020 à 10:10, Michal Simek a écrit : >> Hi Michael, >> >> On 26. 05. 20 15:44, Michael Ellerman wrote: >>> Michal Simek writes: >>>> Hi Michael, >>>> >>>> On 01. 04. 20

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-27 Thread Michael Ellerman
Michal Simek writes: > Hi Michael, > > On 01. 04. 20 13:30, Michal Simek wrote: >> On 01. 04. 20 12:38, Takashi Iwai wrote: >>> On Wed, 01 Apr 2020 12:35:16 +0200, >>> Michael Ellerman wrote: >>>> >>>> Michal Simek writes: >>>

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Michael Ellerman
Christophe Leroy writes: > Le 21/05/2020 à 09:02, Michael Ellerman a écrit : >> Arnd Bergmann writes: >>> +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman >>> wrote: >>>> Benjamin Herrenschmidt writes: >>>>> On Fri, 2020-04-03 a

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-05-21 Thread Michael Ellerman
Arnd Bergmann writes: > +On Wed, Apr 8, 2020 at 2:04 PM Michael Ellerman wrote: >> Benjamin Herrenschmidt writes: >> > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> >> Benjamin Herrenschmidt writes: >> > IBM still put 40x cores inside POW

Re: [PATCH 1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN()

2020-05-21 Thread Michael Ellerman
On Mon, 20 Apr 2020 18:36:34 + (UTC), Christophe Leroy wrote: > _ALIGN_UP() is specific to powerpc > ALIGN() is generic and does the same > > Replace _ALIGN_UP() by ALIGN() Applied to powerpc/next. [1/5] drivers/powerpc: Replace _ALIGN_UP() by ALIGN() https://git.kernel.org/powerpc/c/7

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Michael Ellerman
ch, enable nouveau (Bartlomiej) > > Cc: Antonino Daplas > Cc: Bartlomiej Zolnierkiewicz > Cc: linux-fb...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linuxppc-...@lists.ozlabs.

Re: [PATCH 06/11] powerpc/xmon: constify sysrq_key_op

2020-05-14 Thread Michael Ellerman
Emil Velikov writes: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-ker...@vger.kernel.org > Cc: Michael Ellerman > Cc: Benjamin H

Re: [PATCH V1 00/10] Remove duplicated kmap code

2020-05-01 Thread Michael Ellerman
ira.we...@intel.com writes: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() imp

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-09 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > On Fri, 2020-04-03 at 15:59 +1100, Michael Ellerman wrote: >> Benjamin Herrenschmidt writes: >> > On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: >> > > I have no attachment to 40x, and I'd certainly be happy to have

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-02 Thread Michael Ellerman
Benjamin Herrenschmidt writes: > On Tue, 2020-03-31 at 16:30 +1100, Michael Ellerman wrote: >> I have no attachment to 40x, and I'd certainly be happy to have less >> code in the tree, we struggle to keep even the modern platforms well >> maintained. >> >> A

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-02 Thread Michael Ellerman
Michal Simek writes: > On 01. 04. 20 4:07, Michael Ellerman wrote: >> Michal Simek writes: >>> Hi, >>> >>> recently we wanted to update xilinx intc driver and we found that function >>> which we wanted to remove is still wired by ancient Xilinx Power

Re: [PATCH v2 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-04-01 Thread Michael Ellerman
Michal Simek writes: > Hi, > > recently we wanted to update xilinx intc driver and we found that function > which we wanted to remove is still wired by ancient Xilinx PowerPC > platforms. Here is the thread about it. > https://lore.kernel.org/linux-next/48d3232d-0f1d-42ea-3109-f44bbabfa...@xilinx.

Re: [PATCH 0/2] powerpc: Remove support for ppc405/440 Xilinx platforms

2020-03-31 Thread Michael Ellerman
Christophe Leroy writes: > Le 27/03/2020 à 15:14, Andy Shevchenko a écrit : >> On Fri, Mar 27, 2020 at 02:22:55PM +0100, Arnd Bergmann wrote: >>> On Fri, Mar 27, 2020 at 2:15 PM Andy Shevchenko >>> wrote: On Fri, Mar 27, 2020 at 03:10:26PM +0200, Andy Shevchenko wrote: > On Fri, Mar 27,

Re: [RESEND PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation)

2020-03-13 Thread Michael Ellerman
oid *dst, unsigned long count) > { > readsb(addr, dst, count); > } > -void ioread16_rep(void __iomem *addr, void *dst, unsigned long count) > +void ioread16_rep(const void __iomem *addr, void *dst, unsigned long count) > { > readsw(addr, dst, count); > } &g

Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()

2019-08-08 Thread Michael Ellerman
Hi John, john.hubb...@gmail.com writes: > diff --git a/arch/powerpc/mm/book3s64/iommu_api.c > b/arch/powerpc/mm/book3s64/iommu_api.c > index b056cae3388b..e126193ba295 100644 > --- a/arch/powerpc/mm/book3s64/iommu_api.c > +++ b/arch/powerpc/mm/book3s64/iommu_api.c > @@ -203,6 +202,7 @@ static voi

Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'

2019-02-11 Thread Michael Ellerman
Bartlomiej Zolnierkiewicz writes: > On 10/17/2018 01:52 AM, Michael Ellerman wrote: >> YueHaibing writes: >> >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/video/fbdev/chipsfb.c: In function 'chipsfb_pci_init': &g

Re: [RFC PATCH] drm/ttm: force cached mappings for system RAM on ARM

2019-01-16 Thread Michael Ellerman
Hi Will, Will Deacon writes: > [+ BenH and MPE] > > On Mon, Jan 14, 2019 at 07:21:08PM +, Koenig, Christian wrote: >> Am 14.01.19 um 20:13 schrieb Will Deacon: ... > >> > The Arm architecture (and others including Power afaiu) doesn't >> > guarantee coherency when memory is accessed using mis

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-28 Thread Michael Ellerman
; arch/ia64/mm/discontig.c | 6 +++--- > arch/ia64/sn/kernel/io_common.c | 3 ++- > arch/powerpc/include/asm/pci-bridge.h | 3 ++- > arch/powerpc/kernel/paca.c| 3 ++- > arch/powerpc/kernel/pci-common.c | 3 ++

Crash on FSL Book3E due to pte_pgprot()? (was Re: [PATCH v3 12/24] powerpc/mm: use pte helpers in generic code)

2018-10-16 Thread Michael Ellerman
Christophe Leroy writes: > Get rid of platform specific _PAGE_ in powerpc common code and > use helpers instead. > > mm/dump_linuxpagetables.c will be handled separately > > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: Christophe Leroy > --- > arch/powerpc/include/asm/book3s/32/pgtable.h

Re: [PATCH -next] drivers/video/fbdev: remove set but not used variable 'size'

2018-10-16 Thread Michael Ellerman
riable] > > It not used any more after commit > 8c8709334cec ("[PATCH] ppc32: Remove CONFIG_PMAC_PBOOK") > > Signed-off-by: YueHaibing > --- > drivers/video/fbdev/chipsfb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Looks good, thanks. Should I merge this? O

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-16 Thread Michael Ellerman
LEROY Christophe writes: > Michael Ellerman a écrit : >> Michael Ellerman writes: >>> Christophe Leroy writes: >>> >>>> Set PAGE_KERNEL directly in the caller and do not rely on a >>>> hack adding PAGE_KERNEL flags when _PAGE_PRESENT i

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-15 Thread Michael Ellerman
Christophe Leroy writes: > Set PAGE_KERNEL directly in the caller and do not rely on a > hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. > > As already done for PPC64, use pgprot_cache() helpers instead of > _PAGE_XXX flags in PPC32 ioremap() derived functions. > > Signed-off-by: Chr

Re: [v3,01/24] powerpc/32: Add ioremap_wt() and ioremap_coherent()

2018-10-15 Thread Michael Ellerman
On Tue, 2018-10-09 at 13:51:33 UTC, Christophe Leroy wrote: > Other arches have ioremap_wt() to map IO areas write-through. > Implement it on PPC as well in order to avoid drivers using > __ioremap(_PAGE_WRITETHRU) > > Also implement ioremap_coherent() to avoid drivers using > __ioremap(_PAGE_COHE

Re: [PATCH v3 06/24] powerpc/mm: properly set PAGE_KERNEL flags in ioremap()

2018-10-15 Thread Michael Ellerman
Michael Ellerman writes: > Christophe Leroy writes: > >> Set PAGE_KERNEL directly in the caller and do not rely on a >> hack adding PAGE_KERNEL flags when _PAGE_PRESENT is not set. >> >> As already done for PPC64, use pgprot_cache() helpers instead of >&

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Michael Ellerman
Daniel Vetter writes: > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: >> Le 17/02/2018 à 22:19, Pavel Machek a écrit : >> > >> > Fix double ;;'s in code. >> > >> > Signed-off-by: Pavel Machek >> >> A summary of the files modified on top of the patch would help understand >>

Re: [v3, 3/6] dt: booting-without-of: DT fix s/#interrupt-cell/#interrupt-cells/

2018-01-22 Thread Michael Ellerman
On Fri, 2017-06-02 at 12:38:46 UTC, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/4be4119d1fbd93c44d5c639735c312 cheers ___ dri-devel mailing li

Re: [v3, 4/6] powerpc: dts: acadia: DT fix s/#interrupts-parent/#interrupt-parent/

2017-10-25 Thread Michael Ellerman
On Fri, 2017-06-02 at 12:38:47 UTC, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > Acked-by: Rob Herring Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/3d2d4339cc326c427638daa67e264d cheers ___ dri-devel mailing li

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-21 Thread Michael Ellerman
Geert Uytterhoeven writes: > On Thu, Jul 20, 2017 at 1:43 PM, Michael Ellerman wrote: >> Matt Brown writes: >>> The cacheflush prototypes currently use start and stop values and each >>> call requires typecasting the address to an unsigned long. >>> This pat

Re: [PATCH] powerpc/asm/cacheflush: Cleanup cacheflush function params

2017-07-21 Thread Michael Ellerman
Hi Matt, Thanks for tackling this mess. Matt Brown writes: > The cacheflush prototypes currently use start and stop values and each > call requires typecasting the address to an unsigned long. > This patch changes the cacheflush prototypes to follow the x86 style of > using a base and size value

Re: [PATCH 21/44] powerpc: implement ->mapping_error

2017-06-14 Thread Michael Ellerman
arch/powerpc/platforms/ps3/system-bus.c:static const struct dma_map_ops ps3_ioc0_dma_ops = { All of which look like they definitely can fail, but return 0 on error and don't implement ->mapping_error. So I guess I'm acking this and adding a TODO to fix up the NPU code at least, the p

[PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags

2016-10-19 Thread Michael Ellerman
break; I realise you probably deliberately didn't do that to make the diff clearer. Either way: Acked-by: Michael Ellerman (powerpc) cheers

[PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-27 Thread Michael Ellerman
Emilio López writes: > El 22/09/16 a las 06:43, Michael Ellerman escribió: >> Emilio López writes: >> >> Please don't include the *kernel* headers, they're really not meant to >> be used in userspace programs :) >> >>> +CFLAGS += -I../../.

[PATCH 1/7] selftest: sync: basic tests for sw_sync framework

2016-09-22 Thread Michael Ellerman
Emilio López writes: > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation commands. Hi Emilio, Just a few comments on the Makefile. > diff --git a/tools/testing/selftests/s

[PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-29 Thread Michael Ellerman
On Wed, 2014-10-29 at 09:54 +0200, Jani Nikula wrote: > On Wed, 29 Oct 2014, Michael Ellerman wrote: > > On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: > >> On 10/27/14 06:13, Tomi Valkeinen wrote: > >> > I also think the 'depends on BACKLIGHT_CLASS_DEVI

[PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

2014-10-29 Thread Michael Ellerman
On Tue, 2014-10-28 at 13:29 -0700, Randy Dunlap wrote: > On 10/27/14 06:13, Tomi Valkeinen wrote: > > I also think the 'depends on BACKLIGHT_CLASS_DEVICE || > > BACKLIGHT_CLASS_DEVICE=n' pattern is quite... interesting (i.e. sounds > > like a hack to me =). > > It does exactly what is needed and i

Re: [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection

2013-04-15 Thread Michael Ellerman
On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote: > On pseries machines the detection for max_bus_speed should be done > through an OpenFirmware property. This patch adds a function to perform this > detection and a hook to perform dynamic adding of the function only for > ps

[PATCHv3 1/2] ppc64: perform proper max_bus_speed detection

2013-04-15 Thread Michael Ellerman
On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote: > On pseries machines the detection for max_bus_speed should be done > through an OpenFirmware property. This patch adds a function to perform this > detection and a hook to perform dynamic adding of the function only for > ps

[PATCHv3 1/2] ppc64: perform proper max_bus_speed detection

2013-04-15 Thread Michael Ellerman
On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote: > On pseries machines the detection for max_bus_speed should be done > through an OpenFirmware property. This patch adds a function to perform this > detection and a hook to perform dynamic adding of the function only for > ps

Re: [PATCHv3 1/2] ppc64: perform proper max_bus_speed detection

2013-04-14 Thread Michael Ellerman
On Thu, Apr 11, 2013 at 10:13:13AM -0300, Lucas Kannebley Tavares wrote: > On pseries machines the detection for max_bus_speed should be done > through an OpenFirmware property. This patch adds a function to perform this > detection and a hook to perform dynamic adding of the function only for > ps