Re: [PATCH] drm/virtio: implement virtio_gpu_shutdown

2025-05-10 Thread Maxime Ripard
Hi, On Wed, May 07, 2025 at 10:28:21AM +0200, Gerd Hoffmann wrote: > Calling drm_dev_unplug() is the drm way to say the device > is gone and can not be accessed any more. > > Cc: Michael S. Tsirkin > Signed-off-by: Gerd Hoffmann > Reviewed-by: Eric Auger > Tested-by: Eric Auger > --- > drive

Re: [PATCH v3 22/22] drm/todo: add entry to remove devm_drm_put_bridge()

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:48 +0200, Luca Ceresoli wrote: > devm_drm_put_bridge() is a temporary workaround waiting for the panel > bridge lifetime rework. Add a TODO entry to not forget it must be removed > after such rework. > > Suggested-by: Maxime Ripard > > [ ... ] Ac

Re: [PATCH v3 21/22] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
->dev). However the panel_bridge allocation is not > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 12/22] drm/omap: dss: sdi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 20/22] drm/bridge: add devm_drm_put_bridge()

2025-05-10 Thread Maxime Ripard
f they bind the devm removal action to a > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 16/22] drm/sti: dvo: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
y replacing the struct drm_bridge pointer with an > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 14/22] drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:40 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 07/22] drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:33 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 17/22] drm: zynqmp_dp: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
drm_bridge and its initialization, however it > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 15/22] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:41 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 13/22] drm/omap: dss: venc: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 11/22] drm/omap: dss: hdmi5: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 10/22] drm/omap: dss: hdmi4: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
mplify the code flow by removing now unnecessary gotos. > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 09/22] drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:35 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 08/22] drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:34 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 06/22] drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:32 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, 9 May 2025 15:53:31 +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 04/22] drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, May 09, 2025 at 03:53:30PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v3 03/22] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
On Fri, May 09, 2025 at 03:53:29PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard signature.asc Description: PGP signature

Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-05-10 Thread Maxime Ripard
R_ERR(C); > ) >... > -C->BR.funcs = FUNCS; > > Reviewed-by: Manikandan Muralidharan # > microchip-lvds.c > Reviewed-by: Douglas Anderson # parade-ps8640 > Tested-by: Douglas Anderson # parade-ps8640 > Signed-off-by: Luca Ceresoli Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-09 Thread Maxime Ripard
On Thu, May 08, 2025 at 05:27:21PM +0300, Jani Nikula wrote: > On Mon, 05 May 2025, Anusha Srivatsa wrote: > > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: > > > >> Hi Jani, > >> > >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote:

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-05-06 Thread Maxime Ripard
On Tue, Apr 29, 2025 at 09:25:00AM -0700, John Stultz wrote: > On Mon, Apr 28, 2025 at 7:52 AM Maxime Ripard wrote: > > On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > > > To your larger point about policy, I do get the tension that you want > > > to

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-04 Thread Maxime Ripard
Hi Jani, On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrote: > On Tue, 29 Apr 2025, Maxime Ripard wrote: > > Hi Jani, > > > > On Mon, Apr 28, 2025 at 07:31:50PM +0300, Jani Nikula wrote: > >> On Mon, 31 Mar 2025, Anusha Srivatsa wrote: > >> >

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-05-04 Thread Maxime Ripard
On Mon, Apr 28, 2025 at 05:25:16PM +0200, Luca Ceresoli wrote: > Hi Maxime, > > On Mon, 28 Apr 2025 13:39:23 +0200 > Maxime Ripard wrote: > > > On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > > > This is the new API for allocating DRM bridges.

Re: (subset) [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-30 Thread Maxime Ripard
On Tue, Apr 29, 2025 at 02:41:42PM +0200, Louis Chauvet wrote: > Le 29/04/2025 à 11:27, Louis Chauvet a écrit : > > > > On Thu, 24 Apr 2025 20:59:07 +0200, Luca Ceresoli wrote: > > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a > > > DRM > > > bridge, and the only one s

Re: (subset) [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-30 Thread Maxime Ripard
On Wed, Apr 30, 2025 at 10:21:48AM +0200, Louis Chauvet wrote: > > > Le 29/04/2025 à 16:42, Dmitry Baryshkov a écrit : > > On Tue, Apr 29, 2025 at 11:27:51AM +0200, Louis Chauvet wrote: > > > > > > On Thu, 24 Apr 2025 20:59:07 +0200, Luca Ceresoli wrote: > > > > devm_drm_bridge_alloc() [0] is th

[PULL] drm-misc-fixes

2025-04-30 Thread Maxime Ripard
ELPER from DRM_DEBUG_DP_MST_TOPOLOGY_REFS Karol Wachowski (1): accel/ivpu: Correct DCT interrupt handling Maxime Ripard (1): drm/tests: shmem: Fix memleak Philipp Stanner (1): drm/nouveau: Fix WARN_ON in nouveau_fence_context_kill() Russell Cloran (1): drm/mipi-dbi: Fix blanking

Re: [PATCH v5 06/11] drm/display: add CEC helpers code

2025-04-29 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 07:01:25PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:58, Maxime Ripard wrote: > > On Mon, Apr 07, 2025 at 06:11:03PM +0300, Dmitry Baryshkov wrote: > > > +static void drm_connector_hdmi_cec_adapter_unregister(struct > > &g

Re: [PATCH v5 04/11] drm/connector: unregister CEC data

2025-04-29 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 12:03:23PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:47, Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 07, 2025 at 06:11:01PM +0300, Dmitry Baryshkov wrote: > > > In order to make sure that CEC adapters or notifiers are unregistered

Re: [PATCH v5 03/11] drm/connector: add CEC-related fields

2025-04-29 Thread Maxime Ripard
On Tue, Apr 15, 2025 at 12:10:06PM +0300, Dmitry Baryshkov wrote: > On 14/04/2025 17:52, Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 07, 2025 at 06:11:00PM +0300, Dmitry Baryshkov wrote: > > > +/** > > > + * struct drm_connector_ce

Re: [PATCH] drm/mipi-dbi: Fix blanking for non-16 bit formats

2025-04-29 Thread Maxime Ripard
On Mon, 14 Apr 2025 22:32:59 -0700, Russell Cloran wrote: > On r6x2b6x2g6x2 displays not enough blank data is sent to blank the > entire screen. When support for these displays was added, the dirty > function was updated to handle the different amount of data, but > blanking was not, and remained h

Re: [PATCH] drm/tests: shmem: Fix memleak

2025-04-29 Thread Maxime Ripard
On Tue, 08 Apr 2025 16:07:58 +0200, Maxime Ripard wrote: > The drm_gem_shmem_test_get_pages_sgt() gets a scatter-gather table using > the drm_gem_shmem_get_sg_table() function and rightfully calls > sg_free_table() on it. However, it's also supposed to kfree() the > returned sg_t

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-04-29 Thread Maxime Ripard
nsuring panel pointer is valid and can be usable till the last > > reference is put. > > > > Reviewed-by: Luca Ceresoli > > Reviewed-by: Maxime Ripard > > Signed-off-by: Anusha Srivatsa > > > > --- > > v4: Add refcounting documentation in this p

Re: [PATCH v2 00/34] drm: convert all bridges to devm_drm_bridge_alloc()

2025-04-28 Thread Maxime Ripard
On Mon, Apr 28, 2025 at 05:24:57PM +0200, Luca Ceresoli wrote: > Hi Maxime, other DRM maintainers, > > On Thu, 24 Apr 2025 20:59:07 +0200 > Luca Ceresoli wrote: > > > devm_drm_bridge_alloc() [0] is the new API to allocate and initialize a DRM > > bridge, and the only one supported from now on. I

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-28 Thread Maxime Ripard
Hi John, On Fri, Apr 25, 2025 at 12:39:40PM -0700, John Stultz wrote: > On Thu, Apr 24, 2025 at 11:58 PM Maxime Ripard wrote: > > On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > > > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > > > I appre

Re: [PATCH v2 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Maxime Ripard
On Thu, Apr 24, 2025 at 10:05:49PM +0200, Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > The devm lifetime management of this driver is peculiar. The underlying > device for the panel_bridge is the panel, and the devm lifetime is tied the > panel device (panel->dev). Ho

Re: [PATCH v3 0/2] dma-buf: heaps: Support carved-out heaps

2025-04-25 Thread Maxime Ripard
Hi, On Mon, Apr 07, 2025 at 06:29:06PM +0200, Maxime Ripard wrote: > Hi, > > This series is the follow-up of the discussion that John and I had some > time ago here: > > https://lore.kernel.org/all/candhncqujn6bh3kxkf65bwitylvqsd9892-xtfdhhqqyrro...@mail.gmail.com/ > >

Re: [PATCH v3 2/2] dma-buf: heaps: Introduce a new heap for reserved memory

2025-04-25 Thread Maxime Ripard
On Mon, Apr 14, 2025 at 12:43:44PM -0500, Andrew Davis wrote: > On 4/11/25 3:26 PM, T.J. Mercier wrote: > > On Mon, Apr 7, 2025 at 9:29 AM Maxime Ripard wrote: > > > > > > Some reserved memory regions might have particular memory setup or > > > attributes that

Re: [PATCH v2 1/4] PM: device: Introduce platform_resources_managed flag

2025-04-25 Thread Maxime Ripard
Hi, On Thu, Apr 24, 2025 at 06:51:00PM +0200, Ulf Hansson wrote: > On Thu, 17 Apr 2025 at 18:19, Michal Wilczynski > wrote: > > On 4/16/25 16:48, Rafael J. Wysocki wrote: > > > On Wed, Apr 16, 2025 at 3:32 PM Michal Wilczynski > > > wrote: > > >> > > >> On 4/15/25 18:42, Rafael J. Wysocki wrote:

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-25 Thread Maxime Ripard
On Thu, Apr 24, 2025 at 05:13:47PM -0700, John Stultz wrote: > On Thu, Apr 24, 2025 at 1:34 AM Maxime Ripard wrote: > > On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > > > @@ -22,6 +22,7 @@ > > > #include > > > #include > > >

Re: [PATCH v2 2/2] dma-buf: heaps: Give default CMA heap a fixed name

2025-04-24 Thread Maxime Ripard
Hi Jared, Thanks for working on this On Tue, Apr 22, 2025 at 12:19:39PM -0700, Jared Kangas wrote: > The CMA heap's name in devtmpfs can vary depending on how the heap is > defined. Its name defaults to "reserved", but if a CMA area is defined > in the devicetree, the heap takes on the devicetree

Re: [PATCH v7 1/2] drm/bridge: documentat bridge allocation and lifecycle

2025-04-15 Thread Maxime Ripard
Hi, On Wed, Apr 09, 2025 at 04:50:34PM +0200, Luca Ceresoli wrote: > Document in detail the DRM bridge allocation and refcounting process based > on the recently introduced devm_drm_bridge_alloc(). > > Signed-off-by: Luca Ceresoli There's a typo in your commit title. > --- > > Changes in v7:

Re: [PATCH v2 4/4] drm/imagination: Skip clocks if platform PM manages resources

2025-04-15 Thread Maxime Ripard
On Mon, Apr 14, 2025 at 08:52:58PM +0200, Michal Wilczynski wrote: > Update the Imagination PVR driver to skip clock management during > initialization if the platform PM has indicated that it manages platform > resources. > > This is necessary for platforms like the T-HEAD TH1520, where the GPU's

Re: [PATCH v5 09/11] drm/display: bridge-connector: hook in CEC notifier support

2025-04-14 Thread Maxime Ripard
[ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v5 04/11] drm/connector: unregister CEC data

2025-04-14 Thread Maxime Ripard
by: Dmitry Baryshkov > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v7 2/2] drm/tests: bridge: add a KUnit test for devm_drm_bridge_alloc()

2025-04-14 Thread Maxime Ripard
Hi, On Wed, Apr 09, 2025 at 04:50:35PM +0200, Luca Ceresoli wrote: > Add a basic KUnit test for the newly introduced drm_bridge_alloc(). > > Signed-off-by: Luca Ceresoli > > --- > > Changed in v7: > - rebase on current drm-misc-next, which now has a drm_bridge_test.c file > - cleanup commit

Re: [PATCH v2 1/3] drm/display: hdmi: provide central data authority for ACR params

2025-04-14 Thread Maxime Ripard
by the HDMI drivers. > > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v5 10/11] drm/display: bridge-connector: handle CEC adapters

2025-04-14 Thread Maxime Ripard
On Mon, 7 Apr 2025 18:11:07 +0300, Dmitry Baryshkov wrote: > Implement necessary glue code to let DRM bridge drivers to implement CEC > adapters support. > > Signed-off-by: Dmitry Baryshkov > Signed-off-by: Dmitry Baryshkov > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v5 06/11] drm/display: add CEC helpers code

2025-04-14 Thread Maxime Ripard
On Mon, Apr 07, 2025 at 06:11:03PM +0300, Dmitry Baryshkov wrote: > +static void drm_connector_hdmi_cec_adapter_unregister(struct drm_connector > *connector) > +{ > + struct drm_connector_hdmi_cec_data *data = connector->cec.data; > + > + cec_delete_adapter(data->adapter); > + > + if (

Re: [PATCH v5 03/11] drm/connector: add CEC-related fields

2025-04-14 Thread Maxime Ripard
Hi, On Mon, Apr 07, 2025 at 06:11:00PM +0300, Dmitry Baryshkov wrote: > +/** > + * struct drm_connector_cec - DRM Connector CEC-related structure > + */ > +struct drm_connector_cec { > + /** > + * @mutex: protects all fields in this structure. > + */ > + struct mutex mutex; > + >

Re: [PATCH v5 04/11] drm/connector: unregister CEC data

2025-04-14 Thread Maxime Ripard
Hi, On Mon, Apr 07, 2025 at 06:11:01PM +0300, Dmitry Baryshkov wrote: > In order to make sure that CEC adapters or notifiers are unregistered > and CEC-related data is properly destroyed make drm_connector_cleanup() > call CEC's unregister() callback. > > Signed-off-by: Dmitry Baryshkov > Signed

Re: [PATCH v5 08/11] drm/vc4: hdmi: switch to generic CEC helpers

2025-04-14 Thread Maxime Ripard
On Mon, Apr 07, 2025 at 06:11:05PM +0300, Dmitry Baryshkov wrote: > +static const struct drm_connector_hdmi_cec_adapter_ops vc4_hdmi_cec_adap_ops > = { > + .base.unregister = drm_connector_hdmi_cec_unregister, > + .init = vc4_hdmi_cec_init, > + .enable = vc4_hdmi_cec_adap_enable, > +

Re: [PATCH v5 05/11] drm/display: move CEC_CORE selection to DRM_DISPLAY_HELPER

2025-04-14 Thread Maxime Ripard
Y_DP_AUX_CEC is selected, then CEC_CORE is > selected to be built-in into the kernel even if DRM_DISPLAY_HELPER is > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v1 3/3] drm/ci: Add jobs to run KUnit tests

2025-04-10 Thread Maxime Ripard
On Tue, Apr 01, 2025 at 07:47:16AM +0530, Vignesh Raman wrote: > On 28/03/25 20:40, Maxime Ripard wrote: > > On Thu, Mar 27, 2025 at 09:31:12PM +0530, Vignesh Raman wrote: > > > Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool. > > > > &g

Re: [PATCH v3 13/15] drm/tests: hdmi: Add limited range tests for YUV420 mode

2025-04-10 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:20:02PM +0200, Cristian Ciocaltea wrote: > Provide tests to verify that drm_atomic_helper_connector_hdmi_check() > helper behaviour when using YUV420 output format is to always set the > limited RGB quantization range to 'limited', no matter what the value of > Broadcast

Re: [PATCH v3 02/15] drm/connector: hdmi: Add support for YUV420 format verification

2025-04-10 Thread Maxime Ripard
On Wed, 26 Mar 2025 12:19:51 +0200, Cristian Ciocaltea wrote: > Provide the necessary constraints verification in > sink_supports_format_bpc() in order to support handling of YUV420 > output format. > > Signed-off-by: Cristian Ciocaltea > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 5/8] rust: drm: add DRM driver registration

2025-04-10 Thread Maxime Ripard
Hi Danilo, On Fri, Mar 28, 2025 at 03:50:13PM +0100, Danilo Krummrich wrote: > On Fri, Mar 28, 2025 at 03:28:04PM +0100, Maxime Ripard wrote: > > On Wed, Mar 26, 2025 at 11:46:54AM +0100, Danilo Krummrich wrote: > > > On Wed, Mar 26, 2025 at 10:24:43AM +0100, Maxime Ripard wro

Re: [PATCH v3 15/15] drm/tests: hdmi: Add test for unsuccessful forced fallback to YUV420

2025-04-10 Thread Maxime Ripard
Hi, On Wed, Mar 26, 2025 at 12:20:04PM +0200, Cristian Ciocaltea wrote: > Provide test to verify a forced fallback to YUV420 output cannot succeed > when driver doesn't advertise YUV420 support. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 4

Re: [PATCH v3 14/15] drm/tests: hdmi: Add max TMDS rate fallback tests for YUV420 mode

2025-04-10 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:20:03PM +0200, Cristian Ciocaltea wrote: > Provide tests to verify drm_atomic_helper_connector_hdmi_check() helper > fallback behavior when using YUV420 output. > > Also rename drm_test_check_max_tmds_rate_{bpc|format}_fallback() to > better differentiate from the newly

Re: [PATCH v3 12/15] drm/tests: hdmi: Setup ycbcr_420_allowed before initializing connector

2025-04-09 Thread Maxime Ripard
In order to allow providing test coverage for YUV420 modes, ensure the > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v3 08/15] drm/tests: hdmi: Add macros to simplify EDID setup

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:19:57PM +0200, Cristian Ciocaltea wrote: > Introduce a few macros to facilitate setting custom (i.e. non-default) > EDID data during connector initialization. > > The actual conversion to use the new helpers is handled separately. > > Signed-off-by: Cristian Ciocaltea

Re: [PATCH v3 11/15] drm/tests: hdmi: Drop unused drm_kunit_helper_connector_hdmi_init_funcs()

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:20:00PM +0200, Cristian Ciocaltea wrote: > After updating the code to make use of the new EDID setup helpers, > drm_kunit_helper_connector_hdmi_init_funcs() became unused, hence drop > it. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/tests/drm_hdmi_sta

Re: [PATCH v3 09/15] drm/tests: hdmi: Fixup CamelCase warning

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:19:58PM +0200, Cristian Ciocaltea wrote: > Rename the reject_100_MHz_connector_hdmi_funcs variable to make > checkpatch.pl happy: > > CHECK: Avoid CamelCase: > > While at it, also rename reject_100MHz_connector_tmds_char_rate_valid() > for consistency. > > Signed-of

Re: [PATCH v3 10/15] drm/tests: hdmi: Replace open coded EDID setup

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:19:59PM +0200, Cristian Ciocaltea wrote: > Make use of the recently introduced macros to reduce boilerplate code > around EDID setup. This also helps dropping the redundant calls to > set_connector_edid(). > > No functional changes intended. > > Signed-off-by: Cristian

Re: [PATCH v3 07/15] drm/connector: hdmi: Use YUV420 output format as an RGB fallback

2025-04-09 Thread Maxime Ripard
On Wed, Mar 26, 2025 at 12:19:56PM +0200, Cristian Ciocaltea wrote: > Try to make use of YUV420 when computing the best output format and > RGB cannot be supported for any of the available color depths. > > Signed-off-by: Cristian Ciocaltea > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c

Re: [PATCH v3 06/15] drm/connector: hdmi: Factor out bpc and format computation logic

2025-04-09 Thread Maxime Ripard
c, enum hdmi_colorspace fmt) > { > struct drm_device *dev = connector->dev; > - > - /* > - * TODO: Add support for YCbCr420 output for HDMI 2.0 capable > - * devices, for modes that only support YCbCr420. > - */ And we should fix that comment for now. Once fixed, Reviewed-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH v2 1/2] drm/ci: Add jobs to validate devicetrees

2025-04-09 Thread Maxime Ripard
On Wed, 9 Apr 2025 11:45:38 +0530, Vignesh Raman wrote: > Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, > exit with a non-zero error code while configuring them as warning in > the GitLab CI pipeline. > > Signed-off-by: Vignesh Raman > > [ ... ]

Re: [PATCH v2 2/2] drm/ci: Add jobs to run KUnit tests

2025-04-09 Thread Maxime Ripard
On Wed, 9 Apr 2025 11:45:39 +0530, Vignesh Raman wrote: > Add jobs to run KUnit tests using tools/testing/kunit/kunit.py tool. > > Signed-off-by: Vignesh Raman Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 34/34] drm/bridge: panel: convert to devm_drm_bridge_alloc() API

2025-04-08 Thread Maxime Ripard
lly by devm, so it is rather done explicitly by calling > drm_panel_bridge_remove(). This is the function that does devm_kfree() the > panel_bridge in current code, so update it as well to put the bridge > reference instead. > > Signed-off-by: Luca Ceresoli > --- > > To: Maarte

Re: [PATCH 1/4] dt-bindings: display: panel: ili9881c: Add dsi-lanes property

2025-04-08 Thread Maxime Ripard
hi, On Tue, Apr 08, 2025 at 05:27:00PM +0200, Kory Maincent wrote: > Add the dsi-lanes property to specify the number of DSI lanes used by the > panel. This allows configuring the panel for either two, three or four > lanes. > > Signed-off-by: Kory Maincent > --- > Documentation/devicetree/bind

Re: [PATCH 0/7] drm/tests: Fix drm_display_mode memory leaks

2025-04-08 Thread Maxime Ripard
On Tue, 08 Apr 2025 09:34:06 +0200, Maxime Ripard wrote: > Here's a series that fixes some memory leaks in our kunit tests that > eventually show up in kmemleak. > > Let me know what you think, > Maxime > > > [...] Applied to misc/kernel.git (drm-misc-fixes). Thanks! Maxime

Re: [PATCH 1/3] drm/panel: auo-a030jtn01: Fix compilation build

2025-04-08 Thread Maxime Ripard
Hi Lucas, On Tue, Apr 08, 2025 at 09:34:22AM -0500, Lucas De Marchi wrote: > On Tue, Apr 08, 2025 at 02:20:06PM +0200, Maxime Ripard wrote: > > Commit 9d7d7c3c9a19 ("panel/auo-a030jtn01: Use refcounted allocation in > > place of devm_kzalloc()") switched from a kmal

[PATCH] drm/tests: shmem: Fix memleak

2025-04-08 Thread Maxime Ripard
Fix it by adding a kunit action to kfree the sgt when the test ends. Reported-by: Philipp Stanner Closes: https://lore.kernel.org/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.ca...@mailbox.org/ Fixes: 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by shmem") S

Re: [PATCH 04/10] panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()

2025-04-08 Thread Maxime Ripard
Deak, Imre ; Neil Armstrong > > ; Jessica Zhang ; > > Maarten Lankhorst ; Maxime Ripard > > ; Thomas Zimmermann ; > > David Airlie ; Simona Vetter ; Linus > > Walleij ; Joel Selvaraj ; > > Douglas > > Anderson ; dri-devel@lists.freedesktop.org; linux- >

Re: [PATCH 04/10] panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()

2025-04-08 Thread Maxime Ripard
On Mon, Apr 07, 2025 at 06:49:23PM +0300, Imre Deak wrote: > Hi, > > On Tue, Apr 01, 2025 at 12:03:47PM -0400, Anusha Srivatsa wrote: > > Move to using the new API devm_drm_panel_alloc() to allocate the > > panel. > > > > Signed-off-by: Anusha Srivatsa > > --- > > drivers/gpu/drm/panel/panel-au

[PATCH 1/3] drm/panel: auo-a030jtn01: Fix compilation build

2025-04-08 Thread Maxime Ripard
reakage. Fixes: 9d7d7c3c9a19 ("panel/auo-a030jtn01: Use refcounted allocation in place of devm_kzalloc()") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-auo-a030jtn01.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel

[PATCH 2/3] drm/panel: boe-th101mb31ig002-28a: Fix compilation build

2025-04-08 Thread Maxime Ripard
lation breakage. Fixes: 77dcbce63779 ("panel/th101mb31ig002-28a: Use refcounted allocation in place of devm_kzalloc()") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH 3/3] drm/panel: boe-tv101wum-ll2: Fix compilation build

2025-04-08 Thread Maxime Ripard
lation breakage. Fixes: 5d2b55e55e61 ("panel/boe-tv101wum-ll2: Use refcounted allocation in place of devm_kzalloc()") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel

[PATCH v3 2/2] dma-buf: heaps: Introduce a new heap for reserved memory

2025-04-08 Thread Maxime Ripard
Some reserved memory regions might have particular memory setup or attributes that make them good candidates for heaps. Let's provide a heap type that will create a new heap for each reserved memory region flagged as such. Signed-off-by: Maxime Ripard --- drivers/dma-buf/heaps/Kc

[PATCH 5/7] drm/tests: modes: Fix drm_display_mode memory leak

2025-04-08 Thread Maxime Ripard
772a73e.ca...@mailbox.org/ Fixes: 4fcd238560ee ("drm/modes: Add a function to generate analog display modes") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_modes_test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_mod

[PATCH 2/7] drm/tests: modeset: Fix drm_display_mode memory leak

2025-04-08 Thread Maxime Ripard
/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.ca...@mailbox.org/ Fixes: 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_clie

[PATCH 4/7] drm/tests: cmdline: Fix drm_display_mode memory leak

2025-04-08 Thread Maxime Ripard
/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.ca...@mailbox.org/ Fixes: e691c9992ae1 ("drm/modes: Introduce the tv_mode property as a command-line option") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_cmdline_parser_test.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 7/7] drm/tests: probe-helper: Fix drm_display_mode memory leak

2025-04-08 Thread Maxime Ripard
/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.ca...@mailbox.org/ Fixes: 1e4a91db109f ("drm/probe-helper: Provide a TV get_modes helper") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 0/7] drm/tests: Fix drm_display_mode memory leaks

2025-04-08 Thread Maxime Ripard
Hi, Here's a series that fixes some memory leaks in our kunit tests that eventually show up in kmemleak. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Maxime Ripard (7): drm/tests: helpers: Create kunit helper to destroy a drm_display_mode drm/tests: mo

[PATCH 6/7] drm/tests: modes: Fix drm_display_mode memory leak

2025-04-08 Thread Maxime Ripard
/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.ca...@mailbox.org/ Fixes: e31538489908 ("drm/tests: Add tests for the new Monochrome value of tv_mode") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_modes_test.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_mod

[PATCH 3/7] drm/tests: modeset: Fix drm_display_mode memory leak

2025-04-08 Thread Maxime Ripard
/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.ca...@mailbox.org/ Fixes: fedcaf726f54 ("drm/modes: Properly generate a drm_display_mode from a named mode") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 1/7] drm/tests: helpers: Create kunit helper to destroy a drm_display_mode

2025-04-08 Thread Maxime Ripard
ust create a helper every test suite can use. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 23 +++ include/drm/drm_kunit_helpers.h | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/d

[PATCH v3 0/2] dma-buf: heaps: Support carved-out heaps

2025-04-07 Thread Maxime Ripard
e-org/dt-schema/pull/138 Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v3: - Reworked global variable patch - Link to v2: https://lore.kernel.org/r/20250401-dma-buf-ecc-heap-v2-0-043fd006a...@kernel.org Changes in v2: - Add vmap/vunmap operations - Drop ECC flag

[PATCH v3 1/2] dma-buf: heaps: system: Remove global variable

2025-04-07 Thread Maxime Ripard
The system heap is storing its struct dma_heap pointer in a global variable but isn't using it anywhere. Let's move the global variable into system_heap_create() to make it local. Signed-off-by: Maxime Ripard --- drivers/dma-buf/heaps/system_heap.c | 3 +-- 1 file changed, 1 inser

Re: [PATCH v2 0/4] drm/vc4: tests: Fix locking failures

2025-04-07 Thread Maxime Ripard
On Thu, 03 Apr 2025 15:33:29 +0200, Maxime Ripard wrote: > This series deals with (lack of) EDEADLK handling in vc4 PV muxing > tests. > > This was leading to failures with CONFIG_DEBUG_WW_MUTEX_SLOWPATH > enabled. > > Maxime > > [...] Applied to misc/kernel.g

Re: [PATCH 00/10] drm/panel: Use refcounted allocation in place of devm_kzalloc()

2025-04-07 Thread Maxime Ripard
On Tue, 01 Apr 2025 12:03:43 -0400, Anusha Srivatsa wrote: > Start converting drivers to use the API - devm_drm_panel_alloc(). > > This series addresses only 10 drivers. There are 98 more to go. Sending this > series to mostly get feedback. if any change is required, it will be > incorporated in t

Re: [PATCH] drm/vc4: fix uninitialized smatch warnings

2025-04-07 Thread Maxime Ripard
On Sat, Apr 05, 2025 at 10:45:03AM +0800, sunlim...@linux.dev wrote: > From: sunliming > > Fix below smatch warnings: > drivers/gpu/drm/vc4/vc4_gem.c:604 vc4_lock_bo_reservations() error: > uninitialized symbol 'ret'. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Closes: h

[PATCH 4/4] drm/vc4: tests: Retry pv-muxing tests when EDEADLK

2025-04-05 Thread Maxime Ripard
4: tests: Add unit test suite for the PV muxing") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c b/drivers/gpu/drm/vc4/tests/vc4_test

Re: [PATCH v1 2/3] drm/ci: Add jobs to validate devicetrees

2025-04-05 Thread Maxime Ripard
On Sun, Mar 30, 2025 at 08:06:45PM +0300, Dmitry Baryshkov wrote: > On Thu, Mar 27, 2025 at 09:31:11PM +0530, Vignesh Raman wrote: > > Add jobs to run dt_binding_check and dtbs_check. If warnings are seen, > > exit with a non-zero error code while configuring them as warning in > > the GitLab CI pi

Re: [PATCH v8 2/5] drm/bridge: add support for refcounting

2025-04-05 Thread Maxime Ripard
DRM bridges to be added to and removed from a DRM card without > tearing the card down. This is possible for connectors already (used by DP > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH RFC 00/12] dma: Enable dmem cgroup tracking

2025-04-05 Thread Maxime Ripard
On Thu, Apr 03, 2025 at 09:39:52AM +0200, Christian König wrote: > > For the UMA GPU case where there is no device memory or eviction > > problem, perhaps a configurable option to just say account memory in > > memcg for all allocations done by this process, and state yes you can > > work around it

Re: [PATCH v4 0/4] drm/panel: Panel Refcounting infrastructure

2025-04-05 Thread Maxime Ripard
On Mon, 31 Mar 2025 11:15:24 -0400, Anusha Srivatsa wrote: > This series adds the infrastructure needed for the refcounting > allocations for panels similar to Luca's efforts with bridges. > Underlying intention and idea is the same - avoid use-after-free > situations in panels. Get reference to pa

[PATCH 1/4] drm/vc4: tests: Use return instead of assert

2025-04-05 Thread Maxime Ripard
let's just properly propagate the errors when they occur. Fixes: f759f5b53f1c ("drm/vc4: tests: Introduce a mocking infrastructure") Fixes: 76ec18dc5afa ("drm/vc4: tests: Add unit test suite for the PV muxing") Signed-off-by: Maxime Ripard --- drivers/gpu/d

Re: [PATCH v6 00/16] drm/bridge: Various quality of life improvements

2025-04-04 Thread Maxime Ripard
On Thu, 13 Mar 2025 12:59:54 +0100, Maxime Ripard wrote: > Here's a series of changes after to the KMS helpers and bridge API > following a bunch of reviews I did. > > It's mostly centered across providing an easier time to deal with bridge > states, and a somewhat

[PATCH v2 1/4] drm/vc4: tests: Use return instead of assert

2025-04-04 Thread Maxime Ripard
let's just properly propagate the errors when they occur. Fixes: f759f5b53f1c ("drm/vc4: tests: Introduce a mocking infrastructure") Fixes: 76ec18dc5afa ("drm/vc4: tests: Add unit test suite for the PV muxing") Reviewed-by: Maíra Canal Signed-off-by: Maxime Rip

  1   2   3   4   5   6   7   8   9   10   >