Re: [PATCH v3 2/5] dt-bindings: display: tegra: nvidia,tegra20-dc: Add parallel RGB output port node

2023-09-05 Thread Maxim Schwalm
Hi Rob, On 21.08.23 18:14, Rob Herring wrote: > On Mon, Aug 07, 2023 at 05:35:12PM +0300, Svyatoslav Ryhel wrote: >> From: Maxim Schwalm >> >> Either this node, which is optional, or the nvidia,panel property can be >> present. >> >> Signed-off-by: Maxi

Re: [PATCH 5/5] drm/bridge: samsung-dsim: calculate porches in Hz

2023-09-04 Thread Maxim Schwalm
Hi, On 28.08.23 17:59, Michael Tretter wrote: > Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500 > Hz, which may be used with a pixel clock of 74.25 MHz with mode > 1920x1080-30. > > Fix the calculation by using HZ instead of kHZ. > > This requires to change the type to u6

Re: [PATCH v3 00/12] drm/bridge: tc358768: Fixes and timings improvements

2023-08-30 Thread Maxim Schwalm
an I add your tested-by? Yes, this series does work fine on the Asus TF700T, so: Tested-by: Maxim Schwalm # Asus TF700T Aside from the TF700T, I have a different kind of tablet, which also has a TC358768/TC358778 bridge, but it's not running a mainline kernel yet. So, unfortunately, I can't tell how this patchset fares on it at this time. Best regards, Maxim

Re: [PATCH v2 03/12] drm/bridge: tc358768: Fix bit updates

2023-08-22 Thread Maxim Schwalm
Hi Tomi, On 16.08.23 13:25, Tomi Valkeinen wrote: > The driver has a few places where it does: > > if (thing_is_enabled_in_config) > update_thing_bit_in_hw() > > This means that if the thing is _not_ enabled, the bit never gets > cleared. This affects the h/vsyncs and continuous DSI clock

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-16 Thread Maxim Schwalm
On 14.08.23 12:04, Tomi Valkeinen wrote: > On 13/08/2023 20:11, Maxim Schwalm wrote: >> On 04.08.23 12:44, Tomi Valkeinen wrote: >>> Signed-off-by: Tomi Valkeinen >>> --- >>> drivers/gpu/drm/bridge/tc358768.c | 64 >>> +++---

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-16 Thread Maxim Schwalm
On 14.08.23 08:34, Tomi Valkeinen wrote: > On 13/08/2023 03:23, Maxim Schwalm wrote: >> Hi, >> >> On 11.08.23 19:02, Tomi Valkeinen wrote: >>> On 11/08/2023 19:23, Péter Ujfalusi wrote: >>>> >>>> >>>> On 04/08/2023 13:44, Tom

Re: [PATCH 02/11] drm/bridge: tc358768: Fix bit updates

2023-08-14 Thread Maxim Schwalm
Hi, On 11.08.23 19:02, Tomi Valkeinen wrote: > On 11/08/2023 19:23, Péter Ujfalusi wrote: >> >> >> On 04/08/2023 13:44, Tomi Valkeinen wrote: >>> The driver has a few places where it does: >>> >>> if (thing_is_enabled_in_config) >>> update_thing_bit_in_hw() >>> >>> This means that if the thing

Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support

2023-08-14 Thread Maxim Schwalm
On 04.08.23 12:44, Tomi Valkeinen wrote: > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/tc358768.c | 64 > +++ > 1 file changed, 45 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c > b/drivers/gpu/drm/bridge/t

Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node

2023-08-02 Thread Maxim Schwalm
Hi, On 27.07.23 18:50, Thierry Reding wrote: > On Thu, Jul 27, 2023 at 07:26:28PM +0300, Svyatoslav Ryhel wrote: >> >> >> 27 липня 2023 р. 18:11:15 GMT+03:00, Thierry Reding >> написав(-ла): >>> On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote: All ASUS Transformers have mic