Re: [PATCH v4 3/4] scripts/kernel-doc.py: don't create *.pyc files

2025-04-30 Thread Mauro Carvalho Chehab
Em Fri, 25 Apr 2025 20:46:41 +0200 Nicolas Schier escreveu: > On Thu, Apr 24, 2025 at 08:16:23AM +0800 Mauro Carvalho Chehab wrote: > > As reported by Andy, kernel-doc.py is creating a __pycache__ > > directory at build time. > > > > Disable creation of __pycache_

Re: [PATCH v4 0/4] Don't create Python bytecode when building the kernel

2025-04-26 Thread Mauro Carvalho Chehab
Hi Akira, Em Sat, 26 Apr 2025 11:39:05 +0900 Akira Yokosawa escreveu: > Bothering with might-become-incompatilbe-in-the-future python environment > variables in kernel Makefiles looks over-engineering to me. > Also, as Mauro says in 3/4, it is incomplete in that it does not cover > the cases whe

Re: [PATCH v3 0/2] Don't create Python bytecode when building the kernel

2025-04-24 Thread Mauro Carvalho Chehab
Em Thu, 24 Apr 2025 15:26:48 +0800 Mauro Carvalho Chehab escreveu: > Em Thu, 24 Apr 2025 11:07:05 +0900 > Akira Yokosawa escreveu: > > > On Wed, 23 Apr 2025 19:31:36 +0300, Andy Shevchenko wrote: > > > On Wed, Apr 23, 2025 at 06:30:48PM +0900, Akira Yokosawa wrote: &g

Re: [PATCH v3 0/2] Don't create Python bytecode when building the kernel

2025-04-24 Thread Mauro Carvalho Chehab
Em Thu, 24 Apr 2025 11:07:05 +0900 Akira Yokosawa escreveu: > On Wed, 23 Apr 2025 19:31:36 +0300, Andy Shevchenko wrote: > > On Wed, Apr 23, 2025 at 06:30:48PM +0900, Akira Yokosawa wrote: > >> On Tue, 22 Apr 2025 10:57:33 +0300, Andy Shevchenko wrote: > >>> On Mon, Apr 21, 2025 at 10:35:29AM

Re: [PATCH v3 0/2] Don't create Python bytecode when building the kernel

2025-04-23 Thread Mauro Carvalho Chehab
Em Mon, 21 Apr 2025 10:35:29 -0600 Jonathan Corbet escreveu: > Dmitry Baryshkov writes: > > > On Wed, Apr 16, 2025 at 03:51:03PM +0800, Mauro Carvalho Chehab wrote: > >> > >> As reported by Andy, the Kernel build system runs kernel-doc script for > >&

[PATCH v4 3/4] scripts/kernel-doc.py: don't create *.pyc files

2025-04-23 Thread Mauro Carvalho Chehab
/linux-doc/z_zyxajctd-c3...@black.fi.intel.com/ Signed-off-by: Mauro Carvalho Chehab Tested-by: Andy Shevchenko --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/i915/Makefile | 2 +- include/drm/Makefile | 2 +- scripts/Makefile.build| 2 +- scripts/find-unused-docs.sh | 2

[PATCH v4 0/4] Don't create Python bytecode when building the kernel

2025-04-23 Thread Mauro Carvalho Chehab
*.pyc at the alphabetical order at the final patch v3: - move KERNELDOC to the main Makefile; - get rid of the badly-named KERNELDOC_CONF var. v2: - added a .gitignore file; - add PYTHONDONTWRITEBYTECODE=1 to the places where kernel-doc is called. Mauro Carvalho Chehab (4): docs: Makefile: ge

Re: [PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-18 Thread Mauro Carvalho Chehab
Hi Andy, Em Wed, 16 Apr 2025 12:41:29 +0300 Andy Shevchenko escreveu: > On Wed, Apr 16, 2025 at 05:38:11PM +0800, Mauro Carvalho Chehab wrote: > > Em Wed, 16 Apr 2025 17:29:01 +0800 > > Mauro Carvalho Chehab escreveu: > > ... > > > Heh, trying to quickly wri

[PATCH v3 0/4] Don't create Python bytecode when building the kernel

2025-04-18 Thread Mauro Carvalho Chehab
ELDOC to the main Makefile; - get rid of the badly-named KERNELDOC_CONF var. v2: - added a .gitignore file; - add PYTHONDONTWRITEBYTECODE=1 to the places where kernel-doc is called. Mauro Carvalho Chehab (4): docs: Makefile: get rid of KERNELDOC_CONF env variable Makefile: move KERNELDOC mac

[PATCH v3 3/4] scripts/kernel-doc.py: don't create *.pyc files

2025-04-18 Thread Mauro Carvalho Chehab
/linux-doc/z_zyxajctd-c3...@black.fi.intel.com/ Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/i915/Makefile | 2 +- include/drm/Makefile | 2 +- scripts/Makefile.build| 2 +- scripts/find-unused-docs.sh | 2 +- 5 files changed, 5

Re: [PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Apr 2025 12:36:06 +0300 Andy Shevchenko escreveu: > On Wed, Apr 16, 2025 at 05:29:01PM +0800, Mauro Carvalho Chehab wrote: > > Em Wed, 16 Apr 2025 17:19:17 +0800 > > Mauro Carvalho Chehab escreveu: > > > Em Wed, 16 Apr 2025 11:34:16 +0300 > > > Ja

Re: [PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Apr 2025 17:29:01 +0800 Mauro Carvalho Chehab escreveu: > Em Wed, 16 Apr 2025 17:19:17 +0800 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 16 Apr 2025 11:34:16 +0300 > > Jani Nikula escreveu: > > > > > On Wed, 16 Apr 2025, Mauro Carvalho Cheha

Re: [PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Apr 2025 17:19:17 +0800 Mauro Carvalho Chehab escreveu: > Em Wed, 16 Apr 2025 11:34:16 +0300 > Jani Nikula escreveu: > > > On Wed, 16 Apr 2025, Mauro Carvalho Chehab > > wrote: > > > As reported by Andy, kernel-doc.py is creating a __pycache__

Re: [PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Apr 2025 11:34:16 +0300 Jani Nikula escreveu: > On Wed, 16 Apr 2025, Mauro Carvalho Chehab wrote: > > As reported by Andy, kernel-doc.py is creating a __pycache__ > > directory at build time. > > > > Disable creation of __pycache__ for the libraries used

Re: [PATCH v2 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Apr 2025 10:22:24 +0300 Andy Shevchenko escreveu: > On Wed, Apr 16, 2025 at 02:57:38PM +0800, Mauro Carvalho Chehab wrote: > > As reported by Andy, kernel-doc.py is creating a __pycache__ > > directory at build time. > > > > Disable creation of __pycache_

[PATCH v3 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
/linux-doc/z_zyxajctd-c3...@black.fi.intel.com/ Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/i915/Makefile | 2 +- include/drm/Makefile | 2 +- scripts/Makefile.build| 2 +- scripts/find-unused-docs.sh | 2 +- 5 files changed, 5

[PATCH v3 0/2] Don't create Python bytecode when building the kernel

2025-04-16 Thread Mauro Carvalho Chehab
yc to .gitignore. --- v3: - changed the order of PYTHONDONTBYTECODE; - patched also scripts/Makefile Mauro Carvalho Chehab (2): scripts/kernel-doc.py: don't create *.pyc files .gitignore: ignore Python compiled bytecode .gitignore| 1 + drivers/gpu/drm/Makefil

Re: [PATCH] scripts/kernel-doc.py: don't create *.pyc files

2025-04-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Apr 2025 14:42:57 +0800 Mauro Carvalho Chehab escreveu: > As reported by Andy, kernel-doc.py is creating a __pycache__ > directory at build time. > > Disable creation of __pycache__ for the libraries used by > kernel-doc.py, when excecuted via the build system or via

[PATCH v2 0/2] Don't create Python bytecode when building the kernel

2025-04-15 Thread Mauro Carvalho Chehab
yc to .gitignore. Mauro Carvalho Chehab (2): scripts/kernel-doc.py: don't create *.pyc files .gitignore: ignore Python compiled bytecode .gitignore| 1 + drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/i915/Makefile | 2 +- include/drm/Makefile | 2 +- sc

[PATCH v2 1/2] scripts/kernel-doc.py: don't create *.pyc files

2025-04-15 Thread Mauro Carvalho Chehab
/linux-doc/z_zyxajctd-c3...@black.fi.intel.com/ Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/i915/Makefile | 2 +- include/drm/Makefile | 2 +- scripts/find-unused-docs.sh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] scripts/kernel-doc.py: don't create *.pyc files

2025-04-15 Thread Mauro Carvalho Chehab
/linux-doc/z_zyxajctd-c3...@black.fi.intel.com/ Signed-off-by: Mauro Carvalho Chehab --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/i915/Makefile | 2 +- include/drm/Makefile | 2 +- scripts/find-unused-docs.sh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-26 Thread Mauro Carvalho Chehab
> > > On Fri, Jan 24, 2025 at 01:52:03PM +0100, Mauro Carvalho Chehab wrote: > > > > > Em Fri, 24 Jan 2025 10:12:50 +0200 Laurent Pinchart escreveu: > > > > > > > > > > > > It's been a few years since I first thought on finding a go

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-26 Thread Mauro Carvalho Chehab
Em Fri, 24 Jan 2025 16:49:30 -0300 Helen Mae Koike Fornazier escreveu: > Hi Mauro, > > > > On Fri, 24 Jan 2025 12:29:16 -0300 Mauro Carvalho Chehab wrote --- > > > Em Fri, 24 Jan 2025 09:26:33 -0500 > > Nicolas Dufresne nicolas.dufre...@collabora.com&

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-24 Thread Mauro Carvalho Chehab
Em Fri, 24 Jan 2025 09:26:33 -0500 Nicolas Dufresne escreveu: > Hi, > > Le vendredi 24 janvier 2025 à 15:00 +0200, Nikolai Kondrashov a écrit : > > On 1/24/25 2:16 PM, Jarkko Sakkinen wrote: > > > On Fri Jan 24, 2025 at 10:12 AM EET, Laurent Pinchart wrote: > > > > Gitlab as an open-source s

Re: [PATCH v2 0/5] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2025-01-24 Thread Mauro Carvalho Chehab
Em Fri, 24 Jan 2025 10:12:50 +0200 Laurent Pinchart escreveu: > > It's been a few years since I first thought on finding a good way of helping > > kernel developers testing their patches, while making use of the free runner > > minutes Gitlab offers. It can greatly simplify the testing for people

Re: [PATCH] docs: document python version used for compilation

2024-05-10 Thread Mauro Carvalho Chehab
Em Fri, 10 May 2024 13:39:17 +0300 Dmitry Baryshkov escreveu: > On Fri, 10 May 2024 at 13:09, Jani Nikula wrote: > > > > On Fri, 10 May 2024, Mauro Carvalho Chehab wrote: > > > Em Fri, 10 May 2024 11:08:38 +0300 > > > Jani Nikula escreveu: > >

Re: [PATCH] docs: document python version used for compilation

2024-05-10 Thread Mauro Carvalho Chehab
Em Fri, 10 May 2024 13:39:17 +0300 Dmitry Baryshkov escreveu: > On Fri, 10 May 2024 at 13:09, Jani Nikula wrote: > > > > On Fri, 10 May 2024, Mauro Carvalho Chehab wrote: > > > Em Fri, 10 May 2024 11:08:38 +0300 > > > Jani Nikula escreveu: > >

Re: [PATCH] docs: document python version used for compilation

2024-05-10 Thread Mauro Carvalho Chehab
Em Fri, 10 May 2024 11:08:38 +0300 Jani Nikula escreveu: > On Thu, 09 May 2024, Dmitry Baryshkov wrote: > > The drm/msm driver had adopted using Python3 script to generate register > > header files instead of shipping pre-generated header files. Document > > the minimal Python version supported

Re: [PATCH v0 04/14] media: au0828: Make I2C terminology more inclusive

2024-05-03 Thread Mauro Carvalho Chehab
Em Fri, 29 Mar 2024 17:00:28 + Easwar Hariharan escreveu: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT bitbangin

Re: [PATCH i-g-t 2/2] lib/kunit: Execute test cases synchronously

2023-11-09 Thread Mauro Carvalho Chehab
On Mon, 6 Nov 2023 10:59:38 +0100 Janusz Krzysztofik wrote: > Up to now we've been loading a KUnit test module in background and parsing > in parallel its KTAP output with results from all the module's test cases. > However, recent KUnit implementation is capable of executing only those > test c

Re: [PATCH 0/2] Add support for inlined documentation for kunit and kselftests

2023-10-07 Thread Mauro Carvalho Chehab
Em Tue, 03 Oct 2023 11:00:20 -0600 Jonathan Corbet escreveu: > Mauro Carvalho Chehab writes: > > > This is a follow-up of the discussions taken here: > > > > > > https://lore.kernel.org/linux-doc/20230704132812.02ba97ba@maurocar-mobl2/T/#t > > > >

Re: [PATCH RFC 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-09-01 Thread Mauro Carvalho Chehab
Hi Rae, Em Thu, 13 Jul 2023 17:31:19 -0400 Rae Moar escreveu: > On Wed, Jul 12, 2023 at 10:29 AM Mauro Carvalho Chehab > wrote: > > > As an example for the new documentation tool, add a documentation > > for drm_buddy_test. > > > > I opted to place this on a c

[PATCH 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-09-01 Thread Mauro Carvalho Chehab
vin Paneer Selvam Signed-off-by: Mauro Carvalho Chehab --- Documentation/index.rst| 2 +- Documentation/tests/index.rst | 6 ++ Documentation/tests/kunit.rst | 5 + drivers/gpu/drm/tests/drm_buddy_test.c | 12 4 files changed, 24 insert

[PATCH 0/2] Add support for inlined documentation for kunit and kselftests

2023-08-31 Thread Mauro Carvalho Chehab
ch is identical to the file with the same name I developed for IGT tree; - patch 2: adds test documentation from a single DRM kunit file (drm_buddy_test.c). Mauro Carvalho Chehab (2): docs: add support for documenting kUnit and kSelftests drm: add documentation for drm_buddy_test kUnit

Re: [PATCH 0/4] Invalidate TLB cache for all GT's

2023-08-01 Thread Mauro Carvalho Chehab
s needed for multi-gt TLB invalidation in MMIO memory. The result is a leaner, more targeted proposal. Series look good to me. Feel free to add my R-B to the patches I didn't sign already. Reviewed-by: Mauro Carvalho Chehab Other patches from the original series might fo

Re: [PATCH RFC 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-07-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Jul 2023 18:03:00 +0300 Jani Nikula escreveu: > On Wed, 12 Jul 2023, Mauro Carvalho Chehab wrote: > > diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c > > b/drivers/gpu/drm/tests/drm_buddy_test.c > > index 09ee6f6af896..dd6c5afd6cd6 100644 > >

[PATCH RFC 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-07-12 Thread Mauro Carvalho Chehab
As an example for the new documentation tool, add a documentation for drm_buddy_test. I opted to place this on a completely different directory, in order to make easier to test the feature with: $ make SPHINXDIRS="tests" htmldocs Signed-off-by: Mauro Carvalho Chehab ---

[PATCH RFC 0/2] Add support for inlined documentation for kunit and kselftests

2023-07-12 Thread Mauro Carvalho Chehab
i915 kunit tests. Mauro Carvalho Chehab (2): docs: add support for documenting kUnit and kSelftests drm: add documentation for drm_buddy_test kUnit test Documentation/conf.py |2 +- Documentation/index.rst|2 +- Documentation/sphinx/test_kdoc.py |

Re: scripts/kernel-doc does not handle duplicate struct & function names (e.g., in amdgpu)

2023-07-11 Thread Mauro Carvalho Chehab
Em Tue, 11 Jul 2023 20:45:18 -0700 Randy Dunlap escreveu: > On 7/11/23 20:32, Akira Yokosawa wrote: > > Hi Randy, > > > >> [just documenting this for posterity or in case someone wants to fix it.] > >> > >> In drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c, one can find both > >> > >> struct amdgpu_vm

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-07-03 Thread Mauro Carvalho Chehab
On Mon, 3 Jul 2023 13:21:43 +0200 Christian König wrote: > > + /* We don't need this BO later, release it */ > > + ttm_bo_put(bo); > > That won't work. A BO must always outlive the TT object allocated for it. > > Otherwise you can get crashes during TT release. Just my two cents: shouldn

Re: [PATCH] media: Fix building pdfdocs

2023-02-26 Thread Mauro Carvalho Chehab
Em Sun, 26 Feb 2023 08:39:32 +0900 Akira Yokosawa escreveu: > [+CC: Jon, linux-doc] > > On Wed, 8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote: > > Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added > > documatation for a few new RGB formats. For some reason these break the > > pd

Re: [PATCH] media: Fix building pdfdocs

2023-02-08 Thread Mauro Carvalho Chehab
we may want to > > apply the fix to the drm tree also. > > Sounds good to me. Mauro, could you ack this patch ? Acked-by: Mauro Carvalho Chehab > > > Documentation/userspace-api/media/v4l/pixfmt-rgb.rst | 3 --- > > 1 file changed, 3 deletions(-) > > > >

Re: [PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2023-01-17 Thread Mauro Carvalho Chehab
y small > > (but still not big). > > Good point. I'm thus leaning more towards merging this through the DRM > tree then. Mauro, can we get your ack on the V4L2 part of this series ? > We'll create a stable branch based on v6.2-rc1 in case it also need to > be mer

[PATCH 0/3] Add KUnit support for i915 mock selftests

2022-12-01 Thread Mauro Carvalho Chehab
i915 mock selftests === [13:23:42] [13:23:42] Testing complete. Ran 18 tests: passed: 18 [13:23:42] Elapsed time: 302.766s total, 0.003s configuring, 280.393s building, 22.341s running Mauro Carvalho Chehab (3): drm/

[PATCH 3/3] drm/i915: allow running mock selftests via Kunit

2022-12-01 Thread Mauro Carvalho Chehab
t.py with: echo "[0.00] TAP version 14" >logs dmesg >>logs ./tools/testing/kunit/kunit.py parse logs Note: kunit.py is currently broken with modules, not producing any results if "TAP version xx" is not found. It also shows the resu

[PATCH 1/3] drm/i915: place selftest preparation on a separate function

2022-12-01 Thread Mauro Carvalho Chehab
The selftest preparation logic should also be used by KUnit. So, place it on a separate function and export it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH 0/3] at: https://lore.kernel.org/all

[PATCH 2/3] drm/i915: export all mock selftest functions

2022-12-01 Thread Mauro Carvalho Chehab
In order to prepare for a new KUnit module that will run selftests, export all mock selftest functions to I915_SELFTEST namespace. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See

Re: [PATCH 2/5] driver core: make struct class.devnode() take a const *

2022-11-25 Thread Mauro Carvalho Chehab
k. Acked-by: Mauro Carvalho Chehab > > Cc: Fenghua Yu > Cc: Reinette Chatre > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x...@kernel.org > Cc: "H. Peter Anvin" > Cc: FUJITA Tomonori > Cc: Jens Axboe

Re: [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-17 Thread Mauro Carvalho Chehab
On Thu, 17 Nov 2022 10:29:01 +0100 Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > Add support for the following composite output modes (all of them are > somewhat more obscure than the previously defined ones): > > - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to >

Re: [PATCH v10 05/19] drm/connector: Add TV standard property

2022-11-17 Thread Mauro Carvalho Chehab
On Thu, 17 Nov 2022 10:28:48 +0100 Maxime Ripard wrote: > The TV mode property has been around for a while now to select and get the > current TV mode output on an analog TV connector. > > Despite that property name being generic, its content isn't and has been > driver-specific which makes it h

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-14 Thread Mauro Carvalho Chehab
On Mon, 7 Nov 2022 15:16:17 -0800 Daniel Latypov wrote: > On Mon, Nov 7, 2022 at 10:38 AM Michał Winiarski > wrote: > > > > On Thu, Nov 03, 2022 at 04:23:02PM +0100, Mauro Carvalho Chehab wrote: > > > Hi, > > > > > > I'm facing a couple

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Mauro Carvalho Chehab
On Fri, 4 Nov 2022 08:49:55 +0100 Mauro Carvalho Chehab wrote: > On Thu, 3 Nov 2022 15:43:26 -0700 > Daniel Latypov wrote: > > > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > > wrote: > > > > > > Hi, > > > > > > I'm fac

Re: KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-04 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 15:43:26 -0700 Daniel Latypov wrote: > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab > wrote: > > > > Hi, > > > > I'm facing a couple of issues when testing KUnit with the i915 driver. > > > > The DRM subsystem and the i9

KUnit issues - Was: [igt-dev] [PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Mauro Carvalho Chehab
urrently, KUnit seems to have just two levels (test suite and tests). Are there a way to add test groups there? Regards, Mauro Forwarded message: Date: Thu, 3 Nov 2022 14:51:38 + From: Mauro Carvalho Chehab To: Cc: Thomas Hellström , linux-kselft...@vger.kernel.org, Michał Winiarski ,

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 10:48:40 +0100 Mauro Carvalho Chehab wrote: > On Sun, 28 Aug 2022 21:09:19 -0300 > Isabella Basso wrote: > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1

[PATCH RFC v2 0/8] Add KUnit support for i915 driver

2022-11-03 Thread Mauro Carvalho Chehab
se, where some tests might fail on newer hardware. --- v2: - changes outside KUnit module moved to separate patches; - added support for running live and perf selftests on bare metal; - made the KUnit test logic identical to i915 selftest. Mauro Carvalho Chehab (8): drm/i915: export all sel

[PATCH RFC v2 2/8] drm/i915: place selftest preparation on a separate function

2022-11-03 Thread Mauro Carvalho Chehab
The selftest preparation logic should also be used by KUnit. So, place it on a separate function and export it. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https

[PATCH RFC v2 7/8] drm/i915: now that all functions are used, remove __maybe_unused

2022-11-03 Thread Mauro Carvalho Chehab
The PCI-specific KUnit tests that run in bare metal got added, so we can remove the __maybe_unused from such functions. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https

[PATCH RFC v2 3/8] drm/i915: allow running mock selftests via Kunit

2022-11-03 Thread Mauro Carvalho Chehab
t.py with: echo "[0.00] TAP version 14" >logs dmesg >>logs ./tools/testing/kunit/kunit.py parse logs Note: kunit.py is currently broken with modules, not producing any results if "TAP version xx" is not found. It also shows the resu

[PATCH RFC v2 1/8] drm/i915: export all selftest functions

2022-11-03 Thread Mauro Carvalho Chehab
In order to prepare for a new KUnit module that will run selftests, export all selftest functions to I915_SELFTEST namespace. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH

[PATCH RFC v2 4/8] drm/i915: add support to run KUnit tests on bare metal

2022-11-03 Thread Mauro Carvalho Chehab
Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org/ drivers/gpu/drm/i915/selftests/i915_kunit.c | 100 1 file changed, 100

[PATCH RFC v2 8/8] drm/i915: check if current->mm is not NULL

2022-11-03 Thread Mauro Carvalho Chehab
/0x1b9 [i915] [ 316.846119] __igt_mmap+0xfe/0x680 [i915] Unfortunately, when KUnit module runs, it doesn't create an user context, causing mmap tests to fail. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover

[PATCH RFC v2 6/8] drm/i915: add perf selftests to KUnit

2022-11-03 Thread Mauro Carvalho Chehab
Now that i915 KUnit has PCI support, add perf tests as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH RFC v2 0/8] at: https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org

[PATCH RFC v2 5/8] drm/i915: add live selftests to KUnit

2022-11-03 Thread Mauro Carvalho Chehab
Now that i915 KUnit has PCI support, add live tests as well. NOTE: currently, some tests are failing when excecuting via KUnit. I'll do a further investigation to check why, and if this patch can be safely merged or not. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Thu, 3 Nov 2022 10:48:40 +0100 Mauro Carvalho Chehab wrote: > On Sun, 28 Aug 2022 21:09:19 -0300 > Isabella Basso wrote: > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-03 Thread Mauro Carvalho Chehab
On Sun, 28 Aug 2022 21:09:19 -0300 Isabella Basso wrote: > This adds functions for both executing the tests as well as parsing (K)TAP > kmsg output, as per the KTAP spec [1]. > > [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html > > Signed-off-by: Isabella Basso Hi Isabella, I'm

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 1 Nov 2022 14:17:26 -0300 Isabella Basso wrote: > Hi, Mauro, > > > Am 01/11/2022 um 9:33 AM schrieb Mauro Carvalho Chehab > > : > > > > Hi Isabella, > > > > On Mon, 19 Sep 2022 17:43:19 -0300 > > Isabella Basso wrote: > > >

[PATCH RFC] drm/i915: allow running mock selftests via Kunit

2022-11-01 Thread Mauro Carvalho Chehab
t.py with: echo "[0.00] TAP version 14" >logs dmesg >>logs ./tools/testing/kunit/kunit.py parse logs Note: kunit.py is currently broken with modules, not producing any results if "TAP version xx" is not found. It also shows the results dup

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 1 Nov 2022 15:16:02 +0200 Petri Latvala wrote: > On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote: > > On Tue, 20 Sep 2022 11:18:25 +0300 > > Petri Latvala wrote: > > > > > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote

Re: [igt-dev] [PATCH i-g-t v2 4/4] tests: DRM selftests: switch to KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Tue, 20 Sep 2022 11:18:25 +0300 Petri Latvala wrote: > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote: > > As the DRM selftests are now using KUnit [1], update IGT tests as well. > > > > [1] - > > https://lore.kernel.org/all/20220708203052.236290-1-maira.ca...@usp.br/ > > >

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Mon, 19 Sep 2022 17:25:38 -0700 Daniel Latypov wrote: > On Mon, Sep 19, 2022 at 1:43 PM Isabella Basso wrote: > > >> +* "(K)TAP version XX" should be the first line on all > > >> (sub)tests as per > > >> +* > > >> https://www.kernel.org/doc/html/latest/dev-tools/ktap.html#ve

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
Hi Isabella, On Mon, 19 Sep 2022 17:43:19 -0300 Isabella Basso wrote: > > Do you want to _require_ KUnit be built as a module, rather than built-in > > here? > > I’ll change the comment and the warning in v3 to clarify this. When do you intend to submit v3? Regards, Mauro

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-11-01 Thread Mauro Carvalho Chehab
On Thu, 1 Sep 2022 14:37:06 +0800 David Gow wrote: > On Mon, Aug 29, 2022 at 8:10 AM Isabella Basso wrote: > > > > This adds functions for both executing the tests as well as parsing (K)TAP > > kmsg output, as per the KTAP spec [1]. > > > > [1] https://www.kernel.org/doc/html/latest/dev-tools/kt

Re: [Intel-gfx] [PATCH v3 27/37] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-09-26 Thread Mauro Carvalho Chehab
Em Fri, 9 Sep 2022 05:06:46 -0400 Rodrigo Vivi escreveu: > On Fri, Sep 09, 2022 at 09:34:34AM +0200, Mauro Carvalho Chehab wrote: > > There are several documented GT kAPI that aren't currently part > > of the docs. Add them, as this allows identifying issues with >

Re: [Intel-gfx] [PATCH v3 01/37] drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files

2022-09-26 Thread Mauro Carvalho Chehab
Em Fri, 16 Sep 2022 17:03:27 +0300 Gwan-gyeong Mun escreveu: > > /** > > - * Called when user space has done writes to this buffer > > + * i915_gem_sw_finish_ioctl - Called when user space has done writes to > > + * this buffer > As per this link[1], the brief description does not hav

Re: [Intel-gfx] [PATCH v3 19/37] drm/i915: stop using kernel-doc markups for something else

2022-09-26 Thread Mauro Carvalho Chehab
Em Mon, 12 Sep 2022 10:19:04 -0700 Matt Roper escreveu: > > Those *appear* to be kernel-doc markups, but they aren't, because > > the structs themselves are not properly marked. See, for instance > > struct intel_context. > > > > scripts/kerneldoc will *only* consider what's there as a proper >

Re: [PATCH v6 0/4] Let userspace know when snd-hda-intel needs i915

2022-09-19 Thread Mauro Carvalho Chehab
Hi Luis, On Mon, 9 May 2022 13:38:28 -0700 Luis Chamberlain wrote: > On Mon, May 09, 2022 at 06:23:35PM +0200, Mauro Carvalho Chehab wrote: > > Currently, kernel/module annotates module dependencies when > > request_symbol is used, but it doesn't cover more complex inter-dri

Re: [PATCH v3 19/37] drm/i915: stop using kernel-doc markups for something else

2022-09-12 Thread Mauro Carvalho Chehab
Hi Matt, Em Mon, 12 Sep 2022 08:09:57 -0700 Matt Roper escreveu: > > --- a/drivers/gpu/drm/i915/gt/intel_context_types.h > > +++ b/drivers/gpu/drm/i915/gt/intel_context_types.h > > Several of the comments in this file do appear to be kerneldoc (in fact > kerneldoc that was specifically reques

[PATCH v3 32/37] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-09-09 Thread Mauro Carvalho Chehab
fi; done >aaa Add them to i915.rst as well. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/37] at: https://lore.kernel.org/all/cover.1662708705.git.mche...

[PATCH v3 10/37] drm/i915: i915_gpu_error.c: document dump_flags

2022-09-09 Thread Mauro Carvalho Chehab
Kernel-doc dump_flags parameter is missing at i915_capture_error_state(). Document it. Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump") Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, on

[PATCH v3 05/37] drm/i915: gem: fix some Kernel-doc issues

2022-09-09 Thread Mauro Carvalho Chehab
gpu/drm/i915/gem/i915_gem_wait.c:130: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Caused by: - lack of function name at the kernel-doc markup; - renamed parameters. Address them. Reviewed-by:

[PATCH v3 36/37] drm/i915: add GuC functions to the documentation

2022-09-09 Thread Mauro Carvalho Chehab
Currently, functions inside GuC aren't presented as part of the GuC documentation. Add them. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/37] at:

[PATCH v3 25/37] drm/i915: i915_deps: use a shorter title markup

2022-09-09 Thread Mauro Carvalho Chehab
The DOC: tag waits for a one-line short title for the doc section. Using multiple lines will produce a weird output. So, add a shorter description for the title, while keeping the current content below it. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing

[PATCH v3 02/37] drm/i915: display: fix kernel-doc markup warnings

2022-09-09 Thread Mauro Carvalho Chehab
'dig_port' description in 'intel_tc_port_disconnect_phy_work' Those are due to wrong parameter of function name. Address them. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on t

[PATCH v3 35/37] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-09-09 Thread Mauro Carvalho Chehab
The intel_gt_pm.h file contains some convenient macros to be used in GT code in order to get/put runtime PM references and for checking them. Add descriptions based on the ones at intel_wakeref.h and intel_runtime_pm.c. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large

[PATCH v3 20/37] drm/i915: dvo_ch7xxx.c: use SPDX header

2022-09-09 Thread Mauro Carvalho Chehab
This file is licensed with MIT license. Change its license text to use SPDX. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/37] at: https://lore.kernel.org/all

[PATCH v3 16/37] drm/i915: i915_gem_region.h: fix i915_gem_apply_to_region_ops doc

2022-09-09 Thread Mauro Carvalho Chehab
ribed, using a list, in order for it to be properly parsed during documentation build time. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/37] at: https://lore.kerne

[PATCH v3 37/37] drm/i915: be consistent with kernel-doc function declaration

2022-09-09 Thread Mauro Carvalho Chehab
Currently, 91% of kernel-doc function declarations don't have parenthesis on it. Let's be consistent inside the driver by removing the parenthesis from the other ones. Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C

[PATCH v3 28/37] docs: gpu: i915.rst: GuC: add more kernel-doc markups

2022-09-09 Thread Mauro Carvalho Chehab
There are several documented GuC kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists wer

[PATCH v3 15/37] drm/i915: intel_pm.c: fix some ascii artwork at kernel-doc

2022-09-09 Thread Mauro Carvalho Chehab
drigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/37] at: https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/ drivers/gpu/drm/i915/intel

[PATCH v3 31/37] docs: gpu: i915.rst: GEM/TTM: add more kernel-doc markups

2022-09-09 Thread Mauro Carvalho Chehab
There are several documented GEM/TTM kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists

[PATCH v3 18/37] drm/i915: fix i915_gem_ttm_move.c DOC: markup

2022-09-09 Thread Mauro Carvalho Chehab
The doc markup should not end with ":", as it would generate a warning on Sphinx while generating the cross-reference tag. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.

[PATCH v3 11/37] drm/i915: document kernel-doc trivial issues

2022-09-09 Thread Mauro Carvalho Chehab
drm/i915/gt/uc/intel_guc_hwconfig.c:113: warning: Function parameter or member 'gt' not described in 'guc_hwconfig_init' drivers/gpu/drm/i915/gt/intel_engine_types.h:276: warning: Function parameter or member 'preempt_hang' not described in 'intel_engine_execlists'

[PATCH v3 09/37] drm/i915: gem: add kernel-doc description for some function parameters

2022-09-09 Thread Mauro Carvalho Chehab
There are some parameters missing at the kernel-doc markups on some gem files. Some of those are trivial enough to be added. Document them. Reviewed-by: Nirmoy Das Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the

[PATCH v3 19/37] drm/i915: stop using kernel-doc markups for something else

2022-09-09 Thread Mauro Carvalho Chehab
There are some occurrences of "/**" that aren't actually part of a kernel-doc markup. Replace them by "/*", in order to make easier to identify what i915 files contain kernel-doc markups. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mail

[PATCH v3 03/37] drm/i915: gt: fix some Kernel-doc issues

2022-09-09 Thread Mauro Carvalho Chehab
rap_offset' not described in 'guc_log_buffer_state' drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:401: warning: Function parameter or member 'flush_to_file' not described in 'guc_log_buffer_state' drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:401: w

[PATCH v3 30/37] docs: gpu: i915.rst: PM: add more kernel-doc markups

2022-09-09 Thread Mauro Carvalho Chehab
Both intel_runtime_pm.h and intel_pm.c contains kAPI for runtime PM. So, add them to the documentation. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. See [PATCH v3 00/37] at

[PATCH v3 34/37] drm/i915: document struct drm_i915_gem_object

2022-09-09 Thread Mauro Carvalho Chehab
This is a large struct used to describe gem objects. It is currently partially documented. Finish its documentation, filling the gaps from git logs. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists were C/C

[PATCH v3 29/37] docs: gpu: i915.rst: GVT: add more kernel-doc markups

2022-09-09 Thread Mauro Carvalho Chehab
There are several documented GVT kAPI that aren't currently part of the docs. Add them, as this allows identifying issues with badly-formatted tags. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho Chehab --- To avoid mailbombing on a large number of people, only mailing lists wer

[PATCH v3 23/37] drm/i915: i915_gem.c fix a kernel-doc issue

2022-09-09 Thread Mauro Carvalho Chehab
Prevent this Sphinx warning: Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447: WARNING: Inline emphasis start-string without end-string. By using @data to identify the data field, as expected by kernel-doc. Reviewed-by: Rodrigo Vivi Signed-off-by: Mauro Carvalho

  1   2   3   4   5   6   7   8   9   >