Em Fri, 10 May 2024 13:39:17 +0300
Dmitry Baryshkov escreveu:
> On Fri, 10 May 2024 at 13:09, Jani Nikula wrote:
> >
> > On Fri, 10 May 2024, Mauro Carvalho Chehab wrote:
> > > Em Fri, 10 May 2024 11:08:38 +0300
> > > Jani Nikula escreveu:
> >
Em Fri, 10 May 2024 13:39:17 +0300
Dmitry Baryshkov escreveu:
> On Fri, 10 May 2024 at 13:09, Jani Nikula wrote:
> >
> > On Fri, 10 May 2024, Mauro Carvalho Chehab wrote:
> > > Em Fri, 10 May 2024 11:08:38 +0300
> > > Jani Nikula escreveu:
> >
Em Fri, 10 May 2024 11:08:38 +0300
Jani Nikula escreveu:
> On Thu, 09 May 2024, Dmitry Baryshkov wrote:
> > The drm/msm driver had adopted using Python3 script to generate register
> > header files instead of shipping pre-generated header files. Document
> > the minimal Python version supported
Em Fri, 29 Mar 2024 17:00:28 +
Easwar Hariharan escreveu:
> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of
> I2C_ALGOBIT bitbangin
On Mon, 6 Nov 2023 10:59:38 +0100
Janusz Krzysztofik wrote:
> Up to now we've been loading a KUnit test module in background and parsing
> in parallel its KTAP output with results from all the module's test cases.
> However, recent KUnit implementation is capable of executing only those
> test c
Em Tue, 03 Oct 2023 11:00:20 -0600
Jonathan Corbet escreveu:
> Mauro Carvalho Chehab writes:
>
> > This is a follow-up of the discussions taken here:
> >
> >
> > https://lore.kernel.org/linux-doc/20230704132812.02ba97ba@maurocar-mobl2/T/#t
> >
> >
Hi Rae,
Em Thu, 13 Jul 2023 17:31:19 -0400
Rae Moar escreveu:
> On Wed, Jul 12, 2023 at 10:29 AM Mauro Carvalho Chehab
> wrote:
>
> > As an example for the new documentation tool, add a documentation
> > for drm_buddy_test.
> >
> > I opted to place this on a c
vin Paneer Selvam
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/index.rst| 2 +-
Documentation/tests/index.rst | 6 ++
Documentation/tests/kunit.rst | 5 +
drivers/gpu/drm/tests/drm_buddy_test.c | 12
4 files changed, 24 insert
ch is identical to the file with the same name I
developed for
IGT tree;
- patch 2:
adds test documentation from a single DRM kunit file (drm_buddy_test.c).
Mauro Carvalho Chehab (2):
docs: add support for documenting kUnit and kSelftests
drm: add documentation for drm_buddy_test kUnit
s needed for multi-gt TLB
invalidation in MMIO memory. The result is a leaner, more
targeted proposal.
Series look good to me. Feel free to add my R-B to the patches I didn't
sign already.
Reviewed-by: Mauro Carvalho Chehab
Other patches from the original series might fo
Em Wed, 12 Jul 2023 18:03:00 +0300
Jani Nikula escreveu:
> On Wed, 12 Jul 2023, Mauro Carvalho Chehab wrote:
> > diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c
> > b/drivers/gpu/drm/tests/drm_buddy_test.c
> > index 09ee6f6af896..dd6c5afd6cd6 100644
> >
As an example for the new documentation tool, add a documentation
for drm_buddy_test.
I opted to place this on a completely different directory, in order
to make easier to test the feature with:
$ make SPHINXDIRS="tests" htmldocs
Signed-off-by: Mauro Carvalho Chehab
---
i915 kunit tests.
Mauro Carvalho Chehab (2):
docs: add support for documenting kUnit and kSelftests
drm: add documentation for drm_buddy_test kUnit test
Documentation/conf.py |2 +-
Documentation/index.rst|2 +-
Documentation/sphinx/test_kdoc.py |
Em Tue, 11 Jul 2023 20:45:18 -0700
Randy Dunlap escreveu:
> On 7/11/23 20:32, Akira Yokosawa wrote:
> > Hi Randy,
> >
> >> [just documenting this for posterity or in case someone wants to fix it.]
> >>
> >> In drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c, one can find both
> >>
> >> struct amdgpu_vm
On Mon, 3 Jul 2023 13:21:43 +0200
Christian König wrote:
> > + /* We don't need this BO later, release it */
> > + ttm_bo_put(bo);
>
> That won't work. A BO must always outlive the TT object allocated for it.
>
> Otherwise you can get crashes during TT release.
Just my two cents: shouldn
Em Sun, 26 Feb 2023 08:39:32 +0900
Akira Yokosawa escreveu:
> [+CC: Jon, linux-doc]
>
> On Wed, 8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote:
> > Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added
> > documatation for a few new RGB formats. For some reason these break the
> > pd
we may want to
> > apply the fix to the drm tree also.
>
> Sounds good to me. Mauro, could you ack this patch ?
Acked-by: Mauro Carvalho Chehab
>
> > Documentation/userspace-api/media/v4l/pixfmt-rgb.rst | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> >
y small
> > (but still not big).
>
> Good point. I'm thus leaning more towards merging this through the DRM
> tree then. Mauro, can we get your ack on the V4L2 part of this series ?
> We'll create a stable branch based on v6.2-rc1 in case it also need to
> be mer
i915 mock selftests ===
[13:23:42]
[13:23:42] Testing complete. Ran 18 tests: passed: 18
[13:23:42] Elapsed time: 302.766s total, 0.003s configuring, 280.393s building,
22.341s running
Mauro Carvalho Chehab (3):
drm/
t.py with:
echo "[0.00] TAP version 14" >logs
dmesg >>logs
./tools/testing/kunit/kunit.py parse logs
Note: kunit.py is currently broken with modules, not producing any
results if "TAP version xx" is not found. It also shows the resu
The selftest preparation logic should also be used by KUnit. So,
place it on a separate function and export it.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH 0/3] at:
https://lore.kernel.org/all
In order to prepare for a new KUnit module that will run
selftests, export all mock selftest functions to I915_SELFTEST
namespace.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See
k.
Acked-by: Mauro Carvalho Chehab
>
> Cc: Fenghua Yu
> Cc: Reinette Chatre
> Cc: Thomas Gleixner
> Cc: Ingo Molnar
> Cc: Borislav Petkov
> Cc: Dave Hansen
> Cc: x...@kernel.org
> Cc: "H. Peter Anvin"
> Cc: FUJITA Tomonori
> Cc: Jens Axboe
On Thu, 17 Nov 2022 10:29:01 +0100
Maxime Ripard wrote:
> From: Mateusz Kwiatkowski
>
> Add support for the following composite output modes (all of them are
> somewhat more obscure than the previously defined ones):
>
> - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to
>
On Thu, 17 Nov 2022 10:28:48 +0100
Maxime Ripard wrote:
> The TV mode property has been around for a while now to select and get the
> current TV mode output on an analog TV connector.
>
> Despite that property name being generic, its content isn't and has been
> driver-specific which makes it h
On Mon, 7 Nov 2022 15:16:17 -0800
Daniel Latypov wrote:
> On Mon, Nov 7, 2022 at 10:38 AM Michał Winiarski
> wrote:
> >
> > On Thu, Nov 03, 2022 at 04:23:02PM +0100, Mauro Carvalho Chehab wrote:
> > > Hi,
> > >
> > > I'm facing a couple
On Fri, 4 Nov 2022 08:49:55 +0100
Mauro Carvalho Chehab wrote:
> On Thu, 3 Nov 2022 15:43:26 -0700
> Daniel Latypov wrote:
>
> > On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab
> > wrote:
> > >
> > > Hi,
> > >
> > > I'm fac
On Thu, 3 Nov 2022 15:43:26 -0700
Daniel Latypov wrote:
> On Thu, Nov 3, 2022 at 8:23 AM Mauro Carvalho Chehab
> wrote:
> >
> > Hi,
> >
> > I'm facing a couple of issues when testing KUnit with the i915 driver.
> >
> > The DRM subsystem and the i9
urrently, KUnit seems to have just two levels (test suite and tests).
Are there a way to add test groups there?
Regards,
Mauro
Forwarded message:
Date: Thu, 3 Nov 2022 14:51:38 +
From: Mauro Carvalho Chehab
To:
Cc: Thomas Hellström ,
linux-kselft...@vger.kernel.org, Michał Winiarski ,
On Thu, 3 Nov 2022 10:48:40 +0100
Mauro Carvalho Chehab wrote:
> On Sun, 28 Aug 2022 21:09:19 -0300
> Isabella Basso wrote:
>
> > This adds functions for both executing the tests as well as parsing (K)TAP
> > kmsg output, as per the KTAP spec [1].
> >
> > [1
se, where some tests might fail
on newer hardware.
---
v2:
- changes outside KUnit module moved to separate patches;
- added support for running live and perf selftests on bare metal;
- made the KUnit test logic identical to i915 selftest.
Mauro Carvalho Chehab (8):
drm/i915: export all sel
The selftest preparation logic should also be used by KUnit. So,
place it on a separate function and export it.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https
The PCI-specific KUnit tests that run in bare metal got added,
so we can remove the __maybe_unused from such functions.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https
t.py with:
echo "[0.00] TAP version 14" >logs
dmesg >>logs
./tools/testing/kunit/kunit.py parse logs
Note: kunit.py is currently broken with modules, not producing any
results if "TAP version xx" is not found. It also shows the resu
In order to prepare for a new KUnit module that will run
selftests, export all selftest functions to I915_SELFTEST
namespace.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH
Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org/
drivers/gpu/drm/i915/selftests/i915_kunit.c | 100
1 file changed, 100
/0x1b9 [i915]
[ 316.846119] __igt_mmap+0xfe/0x680 [i915]
Unfortunately, when KUnit module runs, it doesn't create an
user context, causing mmap tests to fail.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover
Now that i915 KUnit has PCI support, add perf tests as well.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH RFC v2 0/8] at:
https://lore.kernel.org/all/cover.1667486144.git.mche...@kernel.org
Now that i915 KUnit has PCI support, add live tests as well.
NOTE: currently, some tests are failing when excecuting via
KUnit. I'll do a further investigation to check why, and if
this patch can be safely merged or not.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a
On Thu, 3 Nov 2022 10:48:40 +0100
Mauro Carvalho Chehab wrote:
> On Sun, 28 Aug 2022 21:09:19 -0300
> Isabella Basso wrote:
>
> > This adds functions for both executing the tests as well as parsing (K)TAP
> > kmsg output, as per the KTAP spec [1].
> >
> > [1
On Sun, 28 Aug 2022 21:09:19 -0300
Isabella Basso wrote:
> This adds functions for both executing the tests as well as parsing (K)TAP
> kmsg output, as per the KTAP spec [1].
>
> [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html
>
> Signed-off-by: Isabella Basso
Hi Isabella,
I'm
On Tue, 1 Nov 2022 14:17:26 -0300
Isabella Basso wrote:
> Hi, Mauro,
>
> > Am 01/11/2022 um 9:33 AM schrieb Mauro Carvalho Chehab
> > :
> >
> > Hi Isabella,
> >
> > On Mon, 19 Sep 2022 17:43:19 -0300
> > Isabella Basso wrote:
> >
>
t.py with:
echo "[0.00] TAP version 14" >logs
dmesg >>logs
./tools/testing/kunit/kunit.py parse logs
Note: kunit.py is currently broken with modules, not producing any
results if "TAP version xx" is not found. It also shows the results
dup
On Tue, 1 Nov 2022 15:16:02 +0200
Petri Latvala wrote:
> On Tue, Nov 01, 2022 at 01:54:25PM +0100, Mauro Carvalho Chehab wrote:
> > On Tue, 20 Sep 2022 11:18:25 +0300
> > Petri Latvala wrote:
> >
> > > On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote
On Tue, 20 Sep 2022 11:18:25 +0300
Petri Latvala wrote:
> On Sun, Aug 28, 2022 at 09:09:20PM -0300, Isabella Basso wrote:
> > As the DRM selftests are now using KUnit [1], update IGT tests as well.
> >
> > [1] -
> > https://lore.kernel.org/all/20220708203052.236290-1-maira.ca...@usp.br/
> >
>
On Mon, 19 Sep 2022 17:25:38 -0700
Daniel Latypov wrote:
> On Mon, Sep 19, 2022 at 1:43 PM Isabella Basso wrote:
> > >> +* "(K)TAP version XX" should be the first line on all
> > >> (sub)tests as per
> > >> +*
> > >> https://www.kernel.org/doc/html/latest/dev-tools/ktap.html#ve
Hi Isabella,
On Mon, 19 Sep 2022 17:43:19 -0300
Isabella Basso wrote:
> > Do you want to _require_ KUnit be built as a module, rather than built-in
> > here?
>
> I’ll change the comment and the warning in v3 to clarify this.
When do you intend to submit v3?
Regards,
Mauro
On Thu, 1 Sep 2022 14:37:06 +0800
David Gow wrote:
> On Mon, Aug 29, 2022 at 8:10 AM Isabella Basso wrote:
> >
> > This adds functions for both executing the tests as well as parsing (K)TAP
> > kmsg output, as per the KTAP spec [1].
> >
> > [1] https://www.kernel.org/doc/html/latest/dev-tools/kt
Em Fri, 9 Sep 2022 05:06:46 -0400
Rodrigo Vivi escreveu:
> On Fri, Sep 09, 2022 at 09:34:34AM +0200, Mauro Carvalho Chehab wrote:
> > There are several documented GT kAPI that aren't currently part
> > of the docs. Add them, as this allows identifying issues with
>
Em Fri, 16 Sep 2022 17:03:27 +0300
Gwan-gyeong Mun escreveu:
> > /**
> > - * Called when user space has done writes to this buffer
> > + * i915_gem_sw_finish_ioctl - Called when user space has done writes to
> > + * this buffer
> As per this link[1], the brief description does not hav
Em Mon, 12 Sep 2022 10:19:04 -0700
Matt Roper escreveu:
> > Those *appear* to be kernel-doc markups, but they aren't, because
> > the structs themselves are not properly marked. See, for instance
> > struct intel_context.
> >
> > scripts/kerneldoc will *only* consider what's there as a proper
>
Hi Luis,
On Mon, 9 May 2022 13:38:28 -0700
Luis Chamberlain wrote:
> On Mon, May 09, 2022 at 06:23:35PM +0200, Mauro Carvalho Chehab wrote:
> > Currently, kernel/module annotates module dependencies when
> > request_symbol is used, but it doesn't cover more complex inter-dri
Hi Matt,
Em Mon, 12 Sep 2022 08:09:57 -0700
Matt Roper escreveu:
> > --- a/drivers/gpu/drm/i915/gt/intel_context_types.h
> > +++ b/drivers/gpu/drm/i915/gt/intel_context_types.h
>
> Several of the comments in this file do appear to be kerneldoc (in fact
> kerneldoc that was specifically reques
fi; done >aaa
Add them to i915.rst as well.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...
Kernel-doc dump_flags parameter is missing at i915_capture_error_state().
Document it.
Fixes: a6f0f9cf330a ("drm/i915/guc: Plumb GuC-capture into gpu_coredump")
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, on
gpu/drm/i915/gem/i915_gem_wait.c:130: warning: This comment
starts with '/**', but isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst
Caused by:
- lack of function name at the kernel-doc markup;
- renamed parameters.
Address them.
Reviewed-by:
Currently, functions inside GuC aren't presented as part of the
GuC documentation.
Add them.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
The DOC: tag waits for a one-line short title for the doc
section. Using multiple lines will produce a weird output.
So, add a shorter description for the title, while keeping
the current content below it.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing
'dig_port' description in 'intel_tc_port_disconnect_phy_work'
Those are due to wrong parameter of function name. Address them.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on t
The intel_gt_pm.h file contains some convenient macros to be used
in GT code in order to get/put runtime PM references and for
checking them.
Add descriptions based on the ones at intel_wakeref.h and
intel_runtime_pm.c.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large
This file is licensed with MIT license. Change its license text
to use SPDX.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all
ribed, using
a list, in order for it to be properly parsed during documentation
build time.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kerne
Currently, 91% of kernel-doc function declarations don't have
parenthesis on it. Let's be consistent inside the driver by
removing the parenthesis from the other ones.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C
There are several documented GuC kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists wer
drigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/
drivers/gpu/drm/i915/intel
There are several documented GEM/TTM kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists
The doc markup should not end with ":", as it would generate a
warning on Sphinx while generating the cross-reference tag.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
drm/i915/gt/uc/intel_guc_hwconfig.c:113: warning: Function
parameter or member 'gt' not described in 'guc_hwconfig_init'
drivers/gpu/drm/i915/gt/intel_engine_types.h:276: warning: Function
parameter or member 'preempt_hang' not described in 'intel_engine_execlists'
There are some parameters missing at the kernel-doc markups on
some gem files. Some of those are trivial enough to be added.
Document them.
Reviewed-by: Nirmoy Das
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the
There are some occurrences of "/**" that aren't actually part of
a kernel-doc markup. Replace them by "/*", in order to make easier
to identify what i915 files contain kernel-doc markups.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mail
rap_offset' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:401: warning: Function
parameter or member 'flush_to_file' not described in 'guc_log_buffer_state'
drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h:401: w
Both intel_runtime_pm.h and intel_pm.c contains kAPI for
runtime PM. So, add them to the documentation.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at
This is a large struct used to describe gem objects. It is
currently partially documented. Finish its documentation, filling
the gaps from git logs.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
There are several documented GVT kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists wer
Prevent this Sphinx warning:
Documentation/foo/i915:728: ./drivers/gpu/drm/i915/i915_gem.c:447:
WARNING: Inline emphasis start-string without end-string.
By using @data to identify the data field, as expected by kernel-doc.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho
There are several documented GT kAPI that aren't currently part
of the docs. Add them, as this allows identifying issues with
badly-formatted tags.
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PAT
commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
added a rbtree list to allow searching for obj/ctx.
Document it.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on
-string without end-string.
That's because @foo evaluates into **foo**, and placing anything
after it without spaces cause Sphinx to warn and do the wrong
thing.. So, replace them by a different Sphinx-compatible tag.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To
The way it is, it produces this warning:
Documentation/gpu/i915:150:
./drivers/gpu/drm/i915/display/skl_scaler.c:213: WARNING: Block quote ends
without a blank line; unexpected unindent.
Use list markups to suppress the warning.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho
This file is licensed with MIT license. Change its license text
to use SPDX.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all
Two new fields were added to __i915_gem_ttm_object_init() without
their corresponding documentation.
Document them.
Fixes: 9b78b5dade2d ("drm/i915: add i915_gem_object_create_region_at()")
Reviewed-by: Nirmoy Das
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a la
There are several documented kAPI at the display side that
aren't currently part of the docs. Add them, as this allows
identifying issues with badly-formatted tags.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only ma
rnings;
- Added 4 additional patches at the end, documenting some structs
at i915_gem_object_types.h and intel_gt_pm.h, plus adding
intel-guc.c internal functions to the generated documentation.
Mauro Carvalho Chehab (37):
drm/i915: fix kernel-doc trivial warnings on i915/*.[ch] files
drm/
ff-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.org/all/cover.1662708705.git.mche...@kernel.org/
drivers/gpu/drm/i915/display/intel_fb.c | 2 +-
1 file changed, 1 insertion(
/i915/intel_wakeref.h:149: warning: expecting prototype
for intel_wakeref_put_flags(). Prototype was for __intel_wakeref_put() instead
Fix them.
Additionally, improve title for intel_wakeref_get_if_active().
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a
warn and do the wrong
thing.. So, replace them by a different Sphinx-compatible tag.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PATCH v3 00/37] at:
https://lore.kernel.or
The return codes for i915_gem_wait_ioctl() have identation issues,
and will be displayed on a very confusing way. Use lists to improve
its output.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
:
./drivers/gpu/drm/i915/display/intel_dp_link_training.c:186: WARNING:
Definition list ends without a blank line; unexpected unindent.
Use table markups to fix it.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing
otype for
intel_gvt_deactive_vgpu(). Prototype was for intel_gvt_deactivate_vgpu() instead
drivers/gpu/drm/i915/gvt/vgpu.c:358: warning: expecting prototype for
intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu()
instead
Reviewed-by: Rodrigo Vivi
Acked-by: Zhenyu Wang
_utils.h:291: warning: Function parameter or
member 'Wmax' not described in '__wait_for'
drivers/gpu/drm/i915/i915_vma_resource.h:88: warning: Incorrect use of
kernel-doc format: * struct i915_vma_bindinfo - Information needed for
async bind
drive
i915_gem_ttm_pm.c:199: warning: Excess
function parameter 'allow_gpu' description in 'i915_ttm_restore_region'
Reviewed-by: Rodrigo Vivi
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only mailing lists were C/C
on the cover.
See [PA
On Tue, 9 Aug 2022 06:01:53 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:18AM +0100, Mauro Carvalho Chehab wrote:
> > There are several documented GT kAPI that aren't currently part
> > of the docs. Add them, as this allows identifying issues with
>
On Tue, 9 Aug 2022 06:20:57 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:23AM +0100, Mauro Carvalho Chehab wrote:
> > There are other files with kernel-doc markups:
> >
> > $ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/)
> &
On Tue, 9 Aug 2022 05:55:10 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:06AM +0100, Mauro Carvalho Chehab wrote:
> > Preserving ascii artwork on kernel-docs is tricky, as it needs
> > to respect both the Sphinx rules and be properly parsed by
> > kernel-doc
On Fri, 15 Jul 2022 17:40:25 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:04AM +0100, Mauro Carvalho Chehab wrote:
> > We can't use %foo[] as this produces a bad markup.
> > Use instead, the emphasis markup directly.
> >
> > Fix this issue:
&g
On Tue, 9 Aug 2022 05:51:39 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:03AM +0100, Mauro Carvalho Chehab wrote:
> > The return code table is not properly marked, causing warnings
> > and being badly parsed by Sphinx:
> >
> > Documentation/gpu/i915:
On Tue, 9 Aug 2022 06:12:06 -0400
Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:12:26AM +0100, Mauro Carvalho Chehab wrote:
> > The intel_gt_pm.h file contains some convenient macros to be used
> > in GT code in order to get/put runtime PM references and for
> > checki
ic_update(struct device *dev,
> > > unsigned int pipe_index,
> > > rpf->mem.addr[1] = cfg->mem[1];
> > > rpf->mem.addr[2] = cfg->mem[2];
> > >
> > > + rpf->format.flags = (cfg->premult) ? V4L2_PIX_FMT_FLAG_PREMUL_ALPHA :
> > > 0;
> >
> > I'll drop the parentheses when applying.
> >
> > Reviewed-by: Laurent Pinchart
With this change:
Reviewed-by: Mauro Carvalho Chehab
Regards,
Mauro
Address this warning:
Documentation/leds/leds-qcom-lpg.rst: WARNING: o documento não está
incluído em nenhum toctree
Signed-off-by: Mauro Carvalho Chehab
---
See [PATCH 00/13] at:
https://lore.kernel.org/all/cover.1660829433.git.mche...@kernel.org/
Documentation/leds/index.rst
t;Werror" for:
- some ABI issues;
- kernel-doc warnings/errors;
- broken kernel-doc warnings.
Although there will still have Sphinx warnings that can come up from various
sources,
this could help to keep documentation on a better shape, as time goes by.
Regards,
Mauro
Mauro C
1 - 100 of 798 matches
Mail list logo
