Re: [RFC][PATCH] drm: kirin: Fix dsi probe/attach logic

2019-09-12 Thread Matt Redfearn
On 12/09/2019 14:21, Andrzej Hajda wrote: > On 12.09.2019 04:38, John Stultz wrote: >> On Wed, Sep 4, 2019 at 3:26 AM Andrzej Hajda wrote: >>> On 03.09.2019 18:18, John Stultz wrote: On Mon, Sep 2, 2019 at 6:22 AM Andrzej Hajda wrote: > On 30.08.2019 19:00, Rob Clark wrote: >> On T

Re: [PATCH v2] drm/bridge: adv7511: Attach to DSI host at probe time

2019-08-29 Thread Matt Redfearn
On 28/08/2019 08:05, Andrzej Hajda wrote: > On 27.08.2019 22:03, John Stultz wrote: >> On Mon, Aug 19, 2019 at 3:27 PM John Stultz wrote: >>> On Thu, Jun 27, 2019 at 8:18 AM Matt Redfearn >>> wrote: >>>> In contrast to all of the DSI panel drivers in dri

[PATCH v2] drm/bridge: adv7511: Attach to DSI host at probe time

2019-06-27 Thread Matt Redfearn
other mipi_dsi_device drivers call mipi_dsi_attach() in probe(), make the adv7533 mipi_dsi_device do the same. This ensures that the Synopsys MIPI DSI host registers it's bridge such that it is available for the upstream device to connect to. Signed-off-by: Matt Redfearn --- Changes in v2:

Re: [PATCH] drm/bridge: adv7511: Attach to DSI host at probe time

2019-06-27 Thread Matt Redfearn
On 25/06/2019 11:54, Andrzej Hajda wrote: > On 24.04.2019 15:22, Matt Redfearn wrote: >> In contrast to all of the DSI panel drivers in drivers/gpu/drm/panel >> which attach to the DSI host via mipi_dsi_attach() at probe time, the >> ADV7533 bridge device does not. Instead

Re: [PATCH] drm/bridge: adv7511: Attach to DSI host at probe time

2019-06-25 Thread Matt Redfearn
DSI host registers it's bridge such that it is > available for the upstream device to connect to. > > Signed-off-by: Matt Redfearn > > --- > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > >

Re: [PATCH v2] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-06-24 Thread Matt Redfearn
On 24/06/2019 12:44, Andrzej Hajda wrote: > On 24.06.2019 13:02, Matt Redfearn wrote: >> Hi, >> Anything stopping this being applied? > > > Queued to drm-misc-next. Thanks Andrzej! > > -- > Regards > Andrzej > > >> >> Thanks, >>

Re: [PATCH v2] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-06-24 Thread Matt Redfearn
> Thank you, > Philippe :-) > > > On 4/30/19 10:17 AM, Matt Redfearn wrote: >> The Synopsys MIPI DSI IP contains a video test pattern generator which >> is helpful in debugging video timing with connected displays. >> Add a debugfs directory containing files w

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-10 Thread Matt Redfearn
On 10/06/2019 14:03, Anders Roxell wrote: > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil wrote: >> >> On 6/6/19 11:47 AM, Anders Roxell wrote: >>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as >>> loadable modules, we see the following warning: >>> >>> warning: same module name

[PATCH v2] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-04-30 Thread Matt Redfearn
The Synopsys MIPI DSI IP contains a video test pattern generator which is helpful in debugging video timing with connected displays. Add a debugfs directory containing files which allow the VPG to be enabled and disabled, and its orientation to be changed. Signed-off-by: Matt Redfearn

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Matt Redfearn
Hi Andrzej, On 25/04/2019 13:13, Andrzej Hajda wrote: > On 24.04.2019 16:22, Matt Redfearn wrote: >> The DRM documentation states that post_disable is an optional callback. >> As such an implementing device may not populate it. To avoid panicing >> the kernel by calling a

Re: [PATCH] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-04-25 Thread Matt Redfearn
Hi Laurent, Thanks for the review! On 25/04/2019 10:31, Laurent Pinchart wrote: > On Wed, Apr 24, 2019 at 02:22:18PM +0000, Matt Redfearn wrote: >> The Synopsys MIPI DSI IP contains a video test pattern generator which >> is helpful in debugging video timing with connected dis

[PATCH] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-04-24 Thread Matt Redfearn
The Synopsys MIPI DSI IP contains a video test pattern generator which is helpful in debugging video timing with connected displays. Add a debugfs directory containing files which allow the VPG to be enabled and disabled, and it's orientation to be changed. Signed-off-by: Matt Red

[PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-24 Thread Matt Redfearn
The DRM documentation states that post_disable is an optional callback. As such an implementing device may not populate it. To avoid panicing the kernel by calling a NULL function pointer, we should NULL check it before blindy calling it. Signed-off-by: Matt Redfearn --- drivers/gpu/drm

[PATCH] drm/bridge/synopsys: dsi: Wait for all active lanes to reach stop

2019-04-24 Thread Matt Redfearn
set. Signed-off-by: Matt Redfearn --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index bd15c21a177..38e88071363

[PATCH] drm/bridge: adv7511: Attach to DSI host at probe time

2019-04-24 Thread Matt Redfearn
other mipi_dsi_device drivers call mipi_dsi_attach() in probe(), make the adv7533 mipi_dsi_device do the same. This ensures that the Synopsys MIPI DSI host registers it's bridge such that it is available for the upstream device to connect to. Signed-off-by: Matt Redfearn --- drivers/gpu/

[PATCH] drm/bridge: adv7511: Fix low refresh rate selection

2019-04-24 Thread Matt Redfearn
quot;) Signed-off-by: Matt Redfearn --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 85c2d407a52..e7ddd3e3db9 100644 --- a/dr

drm/bridge/synopsys: dsi: support for I2C connected bridges

2018-10-01 Thread Matt Redfearn
Hi, I have looked through patchwork and recent messages to the dri-devel mailing list, but since I am new to this area of the kernel I apologise if I'm re-asking a question or if I have not understood how this is supposed to work correctly. I am looking at a device that has a Synopsis DW MIPI DSI