/r/20250401121830.21696-1-jani.nik...@intel.com
>
> [2]
> https://lore.kernel.org/r/CAHk-=wip0ea7xq2p3ryys6xgwoqtw1e4jha67zbjkafrjqu...@mail.gmail.com
>
>
> Cc: Linus Torvalds
> Cc: Masahiro Yamada
NACK.
This does not solve any real issue, except making Linus happy
- Sure, he is happy as lon
On Wed, Apr 2, 2025 at 4:15 AM Jason Gunthorpe wrote:
>
> On Wed, Apr 02, 2025 at 03:46:34AM +0900, Masahiro Yamada wrote:
> > However, it is annoying to make every header self-contained
> > "just because we are checking this".
>
> From my POV itis not "jus
t revert 62ae45687e43"
If we continue this, maybe leave a caution
in capital letters?
diff --git a/include/Kbuild b/include/Kbuild
index 5e76a599e2dd..4dff23ae51a4 100644
--- a/include/Kbuild
+++ b/include/Kbuild
@@ -1 +1,3 @@
+# The drm subsystem is strict about the self-containedness of header files.
+# OTHER SUBSYSTEMS SHOULD NOT FOLLOW THIS PRACTICE.
obj-$(CONFIG_DRM_HEADER_TEST) += drm/
--
Best Regards
Masahiro Yamada
46EWEFS=bB=j7h9abmvy56vi81...@mail.gmail.com
> Fixes: fcbb8461fd23 ("kbuild: remove header compile test")
> Cc: Masahiro Yamada
> Cc: David Airlie
> Cc: Daniel Vetter
> Signed-off-by: Jani Nikula
>
> ---
Linus did not mention anything bad for usr/in
On Wed, Mar 5, 2025 at 10:59 PM Maxime Ripard wrote:
>
> On Wed, Mar 05, 2025 at 03:05:25AM +0900, Masahiro Yamada wrote:
> > > IMO headers should almost invariably be self-contained, instead of
> > > putting the burden on their users to include other headers to make it
&g
On Mon, Mar 3, 2025 at 10:53 PM Jani Nikula wrote:
>
> On Mon, 03 Mar 2025, Masahiro Yamada wrote:
> > On Mon, Mar 3, 2025 at 7:02 PM Jani Nikula wrote:
> >>
> >> On Mon, 03 Mar 2025, Masahiro Yamada wrote:
> >> And one of the underlying goals is to mak
On Mon, Mar 3, 2025 at 7:02 PM Jani Nikula wrote:
>
> On Mon, 03 Mar 2025, Masahiro Yamada wrote:
> > +CC: Linus
> >
> > On Wed, Jan 22, 2025 at 11:41 PM Jani Nikula wrote:
> >>
> >> Ensure drm headers build, are self-contained, have header guards,
n Lankhorst
> Cc: Maxime Ripard
> Cc: Thomas Zimmermann
> Cc: Masahiro Yamada
> Acked-by: Thomas Zimmermann
> Signed-off-by: Jani Nikula
> ---
> Kbuild | 1 +
> drivers/gpu/drm/Kconfig | 11 +++
> drivers/gpu/drm/Makefile | 18 ++
; > Cc: Maarten Lankhorst
> > Cc: Maxime Ripard
> > Cc: Thomas Zimmermann
> > Cc: Masahiro Yamada
> > Acked-by: Thomas Zimmermann
> > Signed-off-by: Jani Nikula
>
> Masahiro, ack for merging this?
Sorry, I did not notice that I was
drivers/gpu/drm/imagination/ includes local headers with the double-quote
form (#include "...").
Hence, the header search path addition is unneeded.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/imagination/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drive
SM exists in arch/arm64/configs/defconfig
and if you want to build arm64 defconfig, you need to install
all necessary tools for that.
>
> It's needed only for Qualcomm arm64 devices only. But only for these devices
> which are mainlined enough to really use CONFIG_DRM_MSM (many of them aren't
> in
> that state).
>
> postmarketOS is the distribution which supports Qualcomm. It stores kernel
> config for each device and devices often have individual maintainer. E.g. 175x
> "once" :).
If you do not want to be bothered by unnecessary drivers,
you need to disable the relevant CONFIG option.
(e.g, scripts/config -d CONFIG_DRM_MSM)
This is the standard way we have for many years.
--
Best Regards
Masahiro Yamada
a predictable/understandable
> way (ie. I'm in favor of this patchset)
"once" is a keyword here.
"/bin/sh: python3: not found" provides sufficient information
about why the compilation failed, and you know what to do
to fix the problem.
This is good.
If you hide CONFIG_DRM_MSM silently
due to missing python3, you may scratch your head
"why drm/msm was not compiled?".
This is worse.
--
Best Regards
Masahiro Yamada
(+)
>
> > > diff --git a/init/Kconfig b/init/Kconfig
> > > index fbd0cb06a50a..c77e45484e81 100644
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -2047,3 +2047,6 @@ config ARCH_HAS_SYNC_CORE_BEFORE_USERMODE
> > > # .
> > > config ARCH_HAS_SYSCALL_WRAPPER
> > > def_bool n
> > > +
> > > +config HAVE_PYTHON3
> > > + def_bool $(success,$(PYTHON3) -V)
> > > --
> > > 2.45.2
--
Best Regards
Masahiro Yamada
EFORE_USERMODE
> # .
> config ARCH_HAS_SYSCALL_WRAPPER
> def_bool n
> +
> +config HAVE_PYTHON3
> + def_bool $(success,$(PYTHON3) -V)
> --
> 2.45.2
>
--
Best Regards
Masahiro Yamada
On Mon, Sep 9, 2024 at 2:41 AM Daniel Gomez (Samsung)
wrote:
>
> On Sun, Sep 8, 2024 at 1:56 AM Masahiro Yamada wrote:
> >
> > On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay
> > wrote:
> > >
> > > From: Daniel Gomez
> > >
> >
-e s/s390x/s390/ \
> -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
> -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
>
> --
> 2.46.0
>
>
--
Best Regards
Masahiro Yamada
On Sat, Sep 7, 2024 at 6:32 PM Daniel Gomez (Samsung)
wrote:
>
> On Sat, Sep 7, 2024 at 10:33 AM Masahiro Yamada wrote:
> >
> > On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay
> > wrote:
> > >
> > > From: Daniel Gomez
> > >
> >
On Sat, Sep 7, 2024 at 6:28 PM Daniel Gomez (Samsung)
wrote:
>
> On Fri, Sep 6, 2024 at 4:03 PM Masahiro Yamada wrote:
> >
> > On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay
> > wrote:
> > >
> > > From: Daniel Gomez
> > >
> > &
)
>|^~~
> 17 errors generated.
>
> Suggested-by: Nicolas Schier
> Signed-off-by: Daniel Gomez
> ---
> scripts/mod/Makefile | 2 ++
> scripts/mod/file2alias.c | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/scripts/mod/Makefile b/scripts/mod/Makefile
> index c729bc936bae..75c12c045f21 100644
> --- a/scripts/mod/Makefile
> +++ b/scripts/mod/Makefile
> @@ -8,6 +8,8 @@ modpost-objs:= modpost.o file2alias.o sumversion.o
> symsearch.o
>
> devicetable-offsets-file := devicetable-offsets.h
>
> +HOSTCFLAGS_file2alias.o += -D_UUID_T -D__GETHOSTUUID_H
> +
> $(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
> $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)
>
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 99dce93a4188..ab743f6d60ef 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -11,6 +11,9 @@
> */
>
> #include "modpost.h"
> +#ifdef __APPLE__
> +#define uuid_t sys_uuid_t
> +#endif
> #include "devicetable-offsets.h"
Is this what Nicolas suggested?
https://lore.kernel.org/lkml/20240807-sexy-roadrunner-of-acceptance-a84bbf@lindesnes/
I thought he suggested replacing #ifdef __APPLE__
with -D_UUID_T -D__GETHOSTUUID_H.
You added -D_UUID_T -D__GETHOSTUUID_H,
keeping #ifdef __APPLE__.
> /* We use the ELF typedefs for kernel_ulong_t but bite the bullet and
>
> --
> 2.46.0
>
>
--
Best Regards
Masahiro Yamada
orted in macOS
> +~~~~~~
> +
> +At the moment, only arm64 is supported and tested with `allyesconfig`
> Makefile
> +configuration target. Other Kconfig options not included in `allyesconfig`
> +target and architectures may be supported as well as support in macOS is
> based
> +on LLVM effort and maintenance.
> +
> Getting Help
>
>
>
> --
> 2.46.0
>
>
--
Best Regards
Masahiro Yamada
On Fri, Sep 6, 2024 at 11:54 PM Paul Moore wrote:
>
> On Fri, Sep 6, 2024 at 7:01 AM Daniel Gomez via B4 Relay
> wrote:
> >
> > From: Masahiro Yamada
> >
> > This tool is only used in security/selinux/Makefile.
> >
> > There is no reason to
n",
- program_invocation_short_name);
+ progname);
}
static void print_parse_error(const char *err_msg, const char *line,
@@ -136,7 +136,7 @@ int main(int argc, const char *argv[])
if (argc < 3) {
fprintf(stderr, "ERROR: wrong arguments\n");
- print_usage(stderr);
+ print_usage(stderr, argv[0]);
return 1;
}
--
Best Regards
Masahiro Yamada
l $(HOSTPKG_CONFIG) --cflags bee-headers 2>
> /dev/null)
> +HOSTCFLAGS_mk_elfconfig.o = $(shell $(HOSTPKG_CONFIG) --cflags bee-headers
> 2> /dev/null)
>
> $(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
> $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)
Same as 4/8.
NACK.
--
Best Regards
Masahiro Yamada
.o memcpy.o memset.o
> lib-objs := $(addprefix ../../../lib/, $(lib-objs))
>
> --
> 2.46.0
>
>
NACK.
Developers working on Linux distributions have no interest
in your homebrew setup.
For 99% of users, pkg-config does not do anything good.
It is a waste of process forks.
You need to do it outside.
$ HOSTCFLAGS=$(pkg-config --cflags bee-headers) make
or
$ export HOSTCFLAGS=$(pkg-config --cflags bee-headers)
$ make
--
Best Regards
Masahiro Yamada
On Thu, Sep 5, 2024 at 5:56 PM Daniel Gomez wrote:
>
> On Mon, Sep 02, 2024 at 01:15:01AM +0900, Masahiro Yamada wrote:
> > On Sat, Aug 31, 2024 at 4:54 AM Nicolas Schier wrote:
> > >
> > > On Sat, Aug 24, 2024 at 12:54:50AM +0200 Daniel Gomez wrote:
> > &g
> > kit in
> > their environments. I would maintain the script to keep it in sync with the
> > required glibc version for the latest kernel version.
> >
> > [1] https://github.com/Homebrew/homebrew-core/pull/181885
>
> I think it sounds sensible to hold that formula file in the upstream tree.
> But
> I am not sure if scripts/ is the best location.
>
> Masahiro, what do you think?
I do not know much about the homebrew, but why does the upstream
kernel need to merge such masOS stuff?
>
> Kind regards,
> Nicolas
--
Best Regards
Masahiro Yamada
-e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
> -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
>
> --
> Git-146)
>
>
--
Best Regards
Masahiro Yamada
emap_deftbl.o
> clean-files := consolemap_deftbl.c defkeymap.c
>
> hostprogs += conmakehash
> +HOSTCFLAGS_conmakehash.o = -I$(srctree)/usr/include
>
> quiet_cmd_conmk = CONMK $@
>cmd_conmk = $(obj)/conmakehash $< > $@
>
> --
> Git-146)
>
>
--
Best Regards
Masahiro Yamada
st remove the '$(srctree)/' prefix as '$(objtree)/' is always '.'.
Right.
> But I am suspecting that this break cross-building.
Right.
We cannot do this.
--
Best Regards
Masahiro Yamada
@
>cmd_mkmap = TOPDIR=$(srctree) \
> @@ -51,6 +52,7 @@ $(obj)/mapdata.h: $(obj)/makemapdata
> # Generate speakupmap.h from mapdata.h
> hostprogs += genmap
> genmap-objs := genmap.o
> +HOSTCFLAGS_genmap.o += -I$(srctree)/usr/include
> $(obj)/genmap.o: $(obj)/mapdata.h
>
> quiet_cmd_genmap = GENMAP $@
>
> --
> Git-146)
>
>
--
Best Regards
Masahiro Yamada
the problem for me since I
> ran into it too [1].
>
> Tested-by: Douglas Anderson
>
> [1]
> https://lore.kernel.org/r/CAD=FV=XnpS-=cookkxzfm8og9wcsemxfesmftyh811438qg...@mail.gmail.com
>
I do not like Perl.
IMHO, Python should be OK if Perl is OK.
I agree that the required version should be
documented changes.rst, at least.
--
Best Regards
Masahiro Yamada
B=m
> [user@localhost linux]$
>
> I'm not familiar with kbuild. Can anyone troubleshoot it further? You
> can find .config from attachment.
I do not have time to take a look at every build error,
but somebody in the DRM list may help you.
--
Best Regards
Masahiro Yamada
(2) is not reliable,
as the submenu breaks whenever someone forgets to add 'depends on DRM'.
This commit encloses the entire DRM configuration with 'if DRM' and
'endif', except for DRM_PANEL_ORIENTATION_QUIRKS.
Note:
Now, 'depends on DRM' properties insi
reliable
way because the submenu breaks whenever someone forgets to add
'depends on DRM'.
This commit surrounds the entire DRM configuration with 'if DRM' and
'endif', except DRM_PANEL_ORIENTATION_QUIRKS.
Note:
Now, 'depends on DRM' properties inside
nuconfig" syntax.
The "menuconfig" makes sense only when it is
followed by "if".
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 5a0c476361c3..6984b3fea271 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -29,6 +29,8 @@ menuconfig DRM
details. You should also select and configure AGP
(/dev/agpgart) support if it is available for your platform.
+if DRM
+
config DRM_MIPI_DBI
tristate
depends on DRM
@@ -414,3 +416,5 @@ config DRM_LIB_RANDOM
config DRM_PRIVACY_SCREEN
bool
default n
+
+endif
--
Best Regards
Masahiro Yamada
t merged through the kbuild tree, it already touches
> too many places at once.
>
> It may be better for me to just drop the drivers/gpu/ part of
> my patch so you can just just take your patch through the
> drm tree. I actually have a similar patch for the amdgpu driver
> that I can send if you like this option better.
>
> Arnd
>
Applied to linux-kbuild/fixes.
Thanks.
--
Best Regards
Masahiro Yamada
On Mon, Feb 26, 2024 at 8:01 PM Dmitry Baryshkov
wrote:
>
> On Mon, 26 Feb 2024 at 08:33, Masahiro Yamada wrote:
> >
> > On Mon, Feb 26, 2024 at 11:11 AM Dmitry Baryshkov
> > wrote:
> > >
> > > The driver might decide to put the _shipped files to th
o_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -12,7 +12,7 @@
#include
#include
-#include "msm_gpu.h"
+#include "../msm_gpu.h"
#include "adreno_common.xml.h"
#include "adreno_pm4.xml.h"
--
Best Regards
Masahiro Yamada
@@
> # SPDX-License-Identifier: GPL-2.0
> ccflags-y := -I $(srctree)/$(src)
> +ccflags-y := -I $(obj)/registers
This accidentally overwrites ccflags-y defined above.
So, "-I $(srctree)/$(src)" is lost.
It should be
ccflags-y += -I $(obj)/registers
I see several build errors.
--
Best Regards
Masahiro Yamada
e. Use 'cat' instead in order to generate a writable file.
> quiet_cmd_copy = COPY$@
> - cmd_copy = cat $< > $@
> + cmd_copy = mkdir -p $(shell dirname $@) && cat $< > $@
>
> $(obj)/%: $(src)/%_shipped
> $(call cmd,copy)
>
> --
> 2.39.2
>
--
Best Regards
Masahiro Yamada
l.h_shipped}| 37 +-
> .../mdp5.xml.h => registers/mdp5.xml.h_shipped}| 39 +-
> .../gpu/drm/msm/registers/mdp_common.xml.h_shipped | 114 ++
> drivers/gpu/drm/msm/registers/sfpb.xml.h_shipped | 67 +
> drivers/gpu/drm/msm/registers/xml/dsi.xml | 390 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_10nm.xml | 102 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_14nm.xml | 135 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_20nm.xml | 100 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_28nm.xml | 180 +++
> .../drm/msm/registers/xml/dsi_phy_28nm_8960.xml| 134 ++
> drivers/gpu/drm/msm/registers/xml/dsi_phy_7nm.xml | 230
> drivers/gpu/drm/msm/registers/xml/edp.xml | 239
> .../drm/msm/registers/xml/freedreno_copyright.xml | 40 +
> drivers/gpu/drm/msm/registers/xml/hdmi.xml | 1015 +++
> drivers/gpu/drm/msm/registers/xml/mdp4.xml | 480 +++
> drivers/gpu/drm/msm/registers/xml/mdp5.xml | 806
> drivers/gpu/drm/msm/registers/xml/mdp_common.xml | 89 ++
> drivers/gpu/drm/msm/registers/xml/mmss_cc.xml | 48 +
> drivers/gpu/drm/msm/registers/xml/msm.xml | 32 +
> drivers/gpu/drm/msm/registers/xml/rules-ng.xsd | 457 +++
> drivers/gpu/drm/msm/registers/xml/sfpb.xml | 17 +
> scripts/Makefile.lib |2 +-
> 47 files changed, 8034 insertions(+), 587 deletions(-)
> ---
> base-commit: ffa0c87f172bf7a0132aa960db412f8d63b2f533
> change-id: 20240225-fd-xml-shipped-ba9a321cdedf
>
> Best regards,
> --
> Dmitry Baryshkov
>
--
Best Regards
Masahiro Yamada
on/pvr_rogue_heap_config.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_meta.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mips_check.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_rogue_mmu_defs.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_stream_defs.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_sync.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_sync.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm.h
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.c
> create mode 100644 drivers/gpu/drm/imagination/pvr_vm_mips.h
> create mode 100644 include/uapi/drm/pvr_drm.h
>
> --
> 2.41.0
>
--
Best Regards
Masahiro Yamada
nused-const-variable) \
> > + $(call cc-option, -Wstringop-truncation) \
> > + $(call cc-option, -Wpacked-not-aligned)
> > +subdir-ccflags-y += $(cond-flags)
> > subdir-ccflags-y += -Wno-unused-parameter
> > subdir-ccflags-y += -Wno-type-limits
> > subdir-ccflags-y += -Wno-sign-compare
> > --
> > 2.40.1
> >
--
Best Regards
Masahiro Yamada
With the previous fix, these modules are built from a single C file.
Rename the source files so they match the module names.
Signed-off-by: Masahiro Yamada
Reviewed-by: Laurent Pinchart
Reviewed-by: Liu Ying
---
(no changes since v1)
drivers/gpu/drm/bridge/imx/Makefile
odule-builtin objects").
Split imx-ldb-helper.c into a separate module.
Signed-off-by: Masahiro Yamada
Reviewed-by: Laurent Pinchart
Reviewed-by: Liu Ying
---
Changes in v3:
- Remove MODULE_ALIAS()
Changes in v2:
- Add a separate module instead of making the functions static inline
d
On Sun, Jun 4, 2023 at 10:26 PM Laurent Pinchart
wrote:
>
> Hello Yamada-san,
>
> Thank you for the patch.
>
> On Sun, Jun 04, 2023 at 04:57:12PM +0900, Masahiro Yamada wrote:
> > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice
> > versa), imx-ldb-
On Sun, Jun 4, 2023 at 1:52 PM Laurent Pinchart
wrote:
>
> Hi Yamada-san,
>
> Thank you for the patch.
>
> On Sun, Jun 04, 2023 at 02:07:46AM +0900, Masahiro Yamada wrote:
> > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice
> > versa), imx-ldb-help
With the previous fix, these modules are built from a single C file.
Rename the source files so they match the module names.
Signed-off-by: Masahiro Yamada
---
(no changes since v1)
drivers/gpu/drm/bridge/imx/Makefile | 4
drivers/gpu/drm/bridge/imx/{imx8qm-ldb
odule-builtin objects").
Split imx-ldb-helper.c into a separate module.
Signed-off-by: Masahiro Yamada
---
Changes in v2:
- Add a separate module instead of making the functions static inline
drivers/gpu/drm/bridge/imx/Kconfig | 5 +
drivers/gpu/drm/bridge/imx/Makefile
With the previous fix, these modules are built from a single C file.
Rename the source files so they match the module names.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/bridge/imx/Makefile | 4
drivers/gpu/drm/bridge/imx/{imx8qm-ldb-drv.c => imx8qm-ld
odule-builtin objects").
Turn helpers in imx-ldb-helper.c into inline functions.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/bridge/imx/Makefile | 4 +-
drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 221
drivers/gpu/drm/bridge/imx/imx-ldb-help
Kconfig time,
so users do not need to give ARCH= option from the command line.
https://github.com/u-boot/u-boot/blob/v2023.01/arch/Kconfig#L44
You may get a quick idea of what it will look like.
I will take a look at this direction (the compiler choice in Kconfig first),
but it will not happen soonish due to the limited time for upstream work.
--
Best Regards
Masahiro Yamada
h/s390/kernel/vdso64/Makefile| 4 +--
> arch/s390/purgatory/Makefile| 2 +-
> arch/x86/boot/compressed/Makefile | 2 +-
> drivers/gpu/drm/amd/display/dc/dml/Makefile | 3 ++-
> scripts/Kconfig.include | 2 +-
> scripts/Makefile.clang | 2 ++
> scripts/Makefile.compiler | 8 +++---
> scripts/as-version.sh | 2 +-
> 21 files changed, 74 insertions(+), 98 deletions(-)
> ---
> base-commit: 88603b6dc419445847923fcb7fe5080067a30f98
> change-id: 20221228-drop-qunused-arguments-0c5c7dae54fb
>
> Best regards,
> --
> Nathan Chancellor
>
--
Best Regards
Masahiro Yamada
# gcc-11+, clang-14+
ifeq ($(call cc-min-version, 11, 14),y)
dwarf-version-y := 5
else
dwarf-version-y := 4
endif
... can be written in a more simpler way:
dwarf-version-y := 4
dwarf-version-$(call gcc-min-version, 11) := 5
dwarf-version-$(call clang-min-version, 14) := 5
With $(call cc-min-version, 11, 14),
you never know the meaning of 11, 14
until you see the definition of this macro.
So, you feel like adding the comment "gcc-11+, clang-14+".
The latter form, the code is self-documenting.
> # ld-option
> # Usage: KBUILD_LDFLAGS += $(call ld-option, -X, -Y)
> --
> 2.37.2.672.g94769d06f0-goog
>
--
Best Regards
Masahiro Yamada
On Wed, Jun 15, 2022 at 5:35 PM Michel Dänzer
wrote:
>
> On 2022-04-14 18:57, Michel Dänzer wrote:
> > On 2022-04-14 17:04, Masahiro Yamada wrote:
> >> On Thu, Apr 14, 2022 at 10:50 PM Michel Dänzer
> >> wrote:
> >>> On 2022-04-14 15:34, Alex Deucher wro
end it for in-tree drivers.
> >>
> >> Yes, exactly that. I'm like 95% sure that used to work, but I don't know
> >> why exactly either.
> >>
> >>> FWIW, this is pretty common in the kernel according to git grep.
> >>
> >&g
hanging the standard used, this patch explciitly
enales the warnings with `-Wdeclaration-after-statement`, which takes
effect regardless of which version of the C standard is in use."
modpost is already built with -std=gnu89.
If Wdeclaration-after-statement is implied by gnu89,
why did nobody notice this before?
--
Best Regards
Masahiro Yamada
building with -Wextra, ...
> 'make W=1' option, as well as for three drivers in the kernel that always
> enable -Werror, but it was only observed with the i915 driver so far.
Same here.
enable -Werror, but ...
->
enable -Wextra, but ...
Otherwise,
Acked-by: Ma
counterpart. However the feedback received from Masahiro Yamada was that
> it is too ugly, not providing much value. And just wrapping in a boolean
> context is too dumb - we could simply open code it.
>
> As detailed in commit babaab2f4738 ("drm/i915: Encapsulate kconfig
> c
On Fri, Oct 1, 2021 at 12:55 AM Lucas De Marchi
wrote:
>
> On Thu, Sep 30, 2021 at 11:01:36PM +0900, Masahiro Yamada wrote:
> >On Thu, Sep 30, 2021 at 3:34 AM Lucas De Marchi
> > wrote:
> >>
> >> The check for config value doesn't really belong to i915_
, even in the i915 driver.
For a few sources of the warnings,
replacing it with != 0 or > 0 is just fine.
Of course, such an ugly macro is not worth being moved to
--
Best Regards
Masahiro Yamada
On Mon, Sep 6, 2021 at 4:34 PM Daniel Vetter wrote:
>
> On Mon, Sep 6, 2021 at 12:49 AM Stephen Rothwell
> wrote:
> > Hi all,
> >
> > On Thu, 2 Sep 2021 07:50:38 +1000 Stephen Rothwell
> > wrote:
> > >
> > > On Fri, 20 Aug 2021 15:23:34 +090
.d2969f68dd64 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_requests.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_requests.h
> @@ -6,7 +6,7 @@
> #ifndef INTEL_GT_REQUESTS_H
> #define INTEL_GT_REQUESTS_H
>
> -#include
> +#include
>
> struct intel_engine_cs;
> struct intel_gt;
> --
> 2.32.0
>
> --
> Cheers,
> Stephen Rothwell
--
Best Regards
Masahiro Yamada
g.
Signed-off-by: Masahiro Yamada
---
Documentation/process/4.Coding.rst| 2 +-
Documentation/process/submit-checklist.rst| 2 +-
Documentation/translations/it_IT/process/4.Coding.rst | 2 +-
Documentation/translations/it_IT/proc
On Thu, Feb 4, 2021 at 12:23 AM Petr Mladek wrote:
>
> On Tue 2021-02-02 09:44:22, John Ogness wrote:
> > On 2021-02-02, Masahiro Yamada wrote:
> > > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of
> > > CONFIG_CONSOLE_LOGLEVEL_DEFAUL
On Tue, Feb 2, 2021 at 7:09 PM Sergey Senozhatsky
wrote:
>
> On (21/02/02 16:02), Masahiro Yamada wrote:
> >
> > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of
> > CONFIG_CONSOLE_LOGLEVEL_DEFAULT.
> >
> > When you change CONFIG_CONSOLE_LOGLEVEL_
on
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
AR init/built-in.a
LD vmlinux.o
...
For the same reason, do likewise for CONSOLE_LOGLEVEL_QUIET and
MESSAGE_LOGLEVEL_DEFAULT.
Signed-off-by: Masahiro Yamada
---
On Thu, Jan 21, 2021 at 6:39 AM Rob Herring wrote:
>
> On Wed, Jan 20, 2021 at 03:23:51PM +0900, Masahiro Yamada wrote:
> > As commit d0e628cd817f ("kbuild: doc: clarify the difference between
> > extra-y and always-y") explained, extra-y should be used for listing
>
As commit d0e628cd817f ("kbuild: doc: clarify the difference between
extra-y and always-y") explained, extra-y should be used for listing
the prerequsites of vmlinux. always-y is a better fix here.
Signed-off-by: Masahiro Yamada
---
Documentation/devicetree/bindings/Mak
On Wed, Jul 8, 2020 at 3:06 AM Randy Dunlap wrote:
>
> Drop the doubled word "the".
>
> Signed-off-by: Randy Dunlap
> Cc: Jonathan Corbet
> Cc: linux-...@vger.kernel.org
> Cc: Masahiro Yamada
I guess this series will go in via the doc sub-system.
If so, ple
(src)/$(GVT_DIR)/' is added to allow
include/trace/define_trace.h to find the gvt/trace.h
By setting the correct relative path to TRACE_INCLUDE_PATH, this -I
is also unneeded.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gvt/Makefile | 1 -
drivers/gpu/drm/i915/gvt/trace.h | 2 +-
Including subdirectory Makefile from the driver main Makefile does not
buy us much because this is not real isolation.
Having a single Makefile at the top of the module is clearer, and
it is what this driver almost does.
Move all gvt objects to the i915 main Makefile.
Signed-off-by: Masahiro
Hi Rob,
On Mon, Mar 30, 2020 at 4:09 PM Masahiro Yamada wrote:
>
> On Thu, Mar 26, 2020 at 7:06 AM Rob Herring wrote:
> >
> > Setting 'additionalProperties: false' is frequently omitted, but is
> > important in order to check that there aren't extra u
s, so let's fix all
> those occurrences.
>
> Cc: Stephen Boyd
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: Masahiro Yamada
> Cc: Jonathan Cameron
> Cc: Hartmut Knaack
> Cc: Lars-Peter Clausen
> Cc: Peter Meerwald-Stadler
> Cc: Neil Armstrong
> Cc: Maur
e a continual
> review comment and game of wack-a-mole.
>
> Signed-off-by: Rob Herring
> ---
> .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++
You may have already queue this up, but just in case.
Acked-by: Masahiro Yamada
--
Best Regards
Masahiro Yamad
On Fri, Mar 27, 2020 at 5:46 AM Jason A. Donenfeld wrote:
>
> On Thu, Mar 26, 2020 at 2:44 PM Masahiro Yamada wrote:
> > I collected more Reviewed-by and Acked-by,
> > then pushed this series to
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux
et it into -next ASAP, today would be ideal for test
> coverage ...
I collected more Reviewed-by and Acked-by,
then pushed this series to
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git
kbuild-asinstr
It will show up in -next soon.
--
Best Regards
Masahiro Yamada
__
version to 2.21").
I confirmed the code in $(call as-instr,...) can be assembled by the
binutils 2.21 assembler and also by LLVM integrated assembler.
Remove CONFIG_AS_MOVNTDQA, which is always defined.
Signed-off-by: Masahiro Yamada
Reviewed-by: Nick Desaulniers
---
Changes in v2: None
):
x86: probe assembler capabilities via kconfig instead of makefile
crypto: x86 - rework configuration based on Kconfig
crypto: curve25519 - do not pollute dispatcher based on assembler
x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2
Masahiro Yamada (11):
lib/raid6/t
Hi Ingo,
On Wed, Mar 25, 2020 at 1:59 PM Ingo Molnar wrote:
>
>
> * Masahiro Yamada wrote:
>
> > This series of cleanups was prompted by Linus:
> > https://lkml.org/lkml/2020/3/12/726
> >
> > First, this series drop always-on CONFIG_AS_* options.
> > So
On Wed, Mar 25, 2020 at 4:42 AM Alex Deucher wrote:
>
> On Tue, Mar 24, 2020 at 12:48 PM Masahiro Yamada wrote:
> >
> > Hi,
> >
> > I think this series is a good clean-up.
> >
> > Could you take a look at this please?
>
> Can you resend? I d
Hi,
I think this series is a good clean-up.
Could you take a look at this please?
On Fri, Feb 14, 2020 at 12:40 AM Masahiro Yamada wrote:
>
> A header include path without $(srctree)/ is suspicious because it does
> not work with O= builds.
>
> You can build drivers/gpu/drm/
Hi i915 maintainers,
On Mon, Mar 23, 2020 at 11:12 AM Masahiro Yamada wrote:
>
> CONFIG_AS_MOVNTDQA was introduced by commit 0b1de5d58e19 ("drm/i915:
> Use SSE4.1 movntdqa to accelerate reads from WC memory").
>
> We raise the minimal supported binutils version from
version to 2.21").
I confirmed the code in $(call as-instr,...) can be assembled by the
binutils 2.21 assembler and also by LLVM integrated assembler.
Remove CONFIG_AS_MOVNTDQA, which is always defined.
Signed-off-by: Masahiro Yamada
Reviewed-by: Nick Desaulniers
---
drivers/gpu/drm/i9
rypto: curve25519 - do not pollute dispatcher based on assembler
x86: update AS_* macros to binutils >=2.23, supporting ADX and AVX2
Masahiro Yamada (11):
lib/raid6/test: fix build on distros whose /bin/sh is not bash
x86: remove unneeded defined(__ASSEMBLY__) check from asm/dwarf2.h
x86
version to 2.21").
I confirmed the code in $(call as-instr,...) can be assembled by the
binutils 2.21 assembler and also by Clang's integrated assembler.
Remove CONFIG_AS_MOVNTDQA, which is always defined.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/Makefile | 3
/r300.o
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
index 480a8d4a3c82..11c97edde54d 100644
--- a/drivers/gpu/drm/radeon/Makefile
+++ b
This Makefile repeats similar build rules. Use a pattern rule.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 29 +
1 file changed, 1 insertion(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Makefile b/drivers/gpu/drm/radeon/Makefile
if_changed must have FORCE as a prerequisite, and the targets must be
added to 'targets'.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/radeon/Makefile | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/radeon/Makefile
The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
directories have never been compile-tested, but it would be possible
to make them self-contained.
This commit only addresses missing and forward
struct declarations.
Signed-off-by: Masahiro Yamada
---
Rebase on git
The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
directories have never been compile-tested, but it would be possible
to make them self-contained.
This commit only addresses missing and forward
struct declarations.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gem
On Fri, Nov 8, 2019 at 2:15 PM Masahiro Yamada
wrote:
>
> The headers in the gem/selftests/, gt/selftests, gvt/, selftests/
> directories have never been compile-tested, but it would be possible
> to make them self-contained.
>
> This commit only addresses missing an
Since this function is defined in a header file, it should be
'static inline' instead of 'static'.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/dr
anks.
--
Best Regards
Masahiro Yamada
fig options are guarded by
'depends on ATARI' or 'depends on AMIGA'.
The correct tag is:
Fixes: 9012d011660e ("compiler: allow all arches to enable
CONFIG_OPTIMIZE_INLINING")
The commit id is stable.
As an additional work,
depends on (AMIGA || COMPILE_TEST)
would be nice unless this driver contains m68k-specific code.
--
Best Regards
Masahiro Yamada
re...@ellerman.id.au
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
t; ifdef CONFIG_DRM_AMD_DC_DCN2_1
> CFLAGS_$(AMDDALPATH)/dc/dml/dcn21/display_mode_vba_21.o := $(dml_ccflags)
> CFLAGS_$(AMDDALPATH)/dc/dml/dcn21/display_rq_dlg_calc_21.o := $(dml_ccflags)
> --
> 2.6.2
>
--
Best Regards
Masahiro Yamada
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
th it, I plan to send a formal patch with
> Signed-off-by.
>
CONFIG_DRM is tristate.
Your patch requires everything under drivers/gpu/drm/
modular when CONFIG_DRM=m.
At least, drivers/gpu/drm/drm_mipi_dsi.c
is built-in only.
I guess that is the reason why
they use 'obj-y += drm/'.
In other words, if you are able to
make all the drm code modular,
your patch is applicable.
--
Best Regards
Masahiro Yamada
Since commit 04d5e2765802 ("drm/amdgpu: Merge amdkfd into amdgpu"),
drivers/gpu/drm/amd/amdkfd/Makefile does not contain any syntax that
is understood by the build system.
Signed-off-by: Masahiro Yamada
---
drivers/gpu/drm/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/d
This tool is only used by drivers/video/logo/Makefile. No reason to
keep it in scripts/.
Signed-off-by: Masahiro Yamada
---
drivers/video/logo/.gitignore | 1 +
drivers/video/logo/Makefile | 10 +-
{scripts => drivers/video/logo}/pnmtologo.c | 0
scri
1 - 100 of 241 matches
Mail list logo
