Re: [PATCH v1] drm/panthor: Serialize GPU cache flush operations

2025-07-31 Thread Mary Guillemard
Tested and passing VKCTS on G925-Immortalis. Tested-by: Mary Guillemard

Re: [PATCH v7 0/6] Add support for new Mali GPUs

2025-07-31 Thread Mary Guillemard
Series tested and passing VKCTS on G925-Immortalis. Tested-by: Mary Guillemard

[PATCH 2/2] drm/panthor: Expose scheduler groups info in debugfs

2024-09-18 Thread Mary Guillemard
same task. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 1 + drivers/gpu/drm/panthor/panthor_sched.c | 127 drivers/gpu/drm/panthor/panthor_sched.h | 4 + 3 files changed, 132 insertions(+) diff --git a/drivers/gpu/drm/panthor/pantho

[PATCH 1/2] drm/panthor: Add csg_priority to panthor_group

2024-09-18 Thread Mary Guillemard
Keep track of the csg priority in panthor_group when the group is scheduled/active. This is useful to know the actual priority in use in the firmware group slot. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_sched.c | 18 +++--- 1 file changed, 15 insertions

[PATCH 0/2] drm/panthor: Expose scheduler groups info in debugfs

2024-09-18 Thread Mary Guillemard
/ [2]https://lore.kernel.org/all/20240909064820.34982-2-mary.guillem...@collabora.com/ Mary Guillemard (2): drm/panthor: Add csg_priority to panthor_group drm/panthor: Expose scheduler groups info in debugfs drivers/gpu/drm/panthor/panthor_drv.c | 1 + drivers/gpu/drm/panthor/panthor_sch

[PATCH v3 1/2] drm/panthor: Add PANTHOR_GROUP_PRIORITY_REALTIME group priority

2024-09-08 Thread Mary Guillemard
This adds a new value to drm_panthor_group_priority exposing the realtime priority to userspace. This is required to implement NV_context_priority_realtime in Mesa. v2: - Add Steven Price r-b v3: - Add Boris Brezillon r-b Signed-off-by: Mary Guillemard Reviewed-by: Steven Price Reviewed-by

[PATCH v3 2/2] drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query

2024-09-08 Thread Mary Guillemard
minor version. v2: - Remove drm_panthor_group_allow_priority_flags definition - Document that allowed_mask is a bitmask of drm_panthor_group_priority v3: - Use BIT macro in panthor_query_group_priorities_info - Add r-b from Steven Price and Boris Brezillon Signed-off-by: Mary Guillemard

[PATCH v3 0/2] drm/panthor: Expose realtime group priority and allowed priorites to userspace

2024-09-08 Thread Mary Guillemard
panthor_query_group_priorities_info - Add r-b from Steven Price and Boris Brezillon [1]https://lore.kernel.org/all/20240903144955.144278-2-mary.guillem...@collabora.com/ [2]https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30991 Mary Guillemard (2): drm/panthor: Add

[PATCH v2 2/2] drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query

2024-09-05 Thread Mary Guillemard
minor version. v2: - Remove drm_panthor_group_allow_priority_flags definition - Document that allowed_mask is a bitmask of drm_panthor_group_priority Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 61 ++- include/uapi/drm/panthor_drm.h

[PATCH v2 1/2] drm/panthor: Add PANTHOR_GROUP_PRIORITY_REALTIME group priority

2024-09-05 Thread Mary Guillemard
This adds a new value to drm_panthor_group_priority exposing the realtime priority to userspace. This is required to implement NV_context_priority_realtime in Mesa. v2: - Add Steven Price r-b Signed-off-by: Mary Guillemard Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_drv.c

[PATCH v2 0/2] drm/panthor: Expose realtime group priority and allowed priorites to userspace

2024-09-05 Thread Mary Guillemard
://lore.kernel.org/all/20240903144955.144278-2-mary.guillem...@collabora.com/ [2]https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30991 Mary Guillemard (2): drm/panthor: Add PANTHOR_GROUP_PRIORITY_REALTIME group priority drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query drivers/gpu/drm

[PATCH 2/2] drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query

2024-09-05 Thread Mary Guillemard
minor version. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 61 ++- include/uapi/drm/panthor_drm.h| 38 + 2 files changed, 80 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b

[PATCH 1/2] drm/panthor: Add PANTHOR_GROUP_PRIORITY_REALTIME group priority

2024-09-05 Thread Mary Guillemard
This adds a new value to drm_panthor_group_priority exposing the realtime priority to userspace. This is required to implement NV_context_priority_realtime in Mesa. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 2 +- drivers/gpu/drm/panthor/panthor_sched.c | 2

[PATCH 0/2] drm/panthor: Expose realtime group priority and allowed priorites to userspace

2024-09-05 Thread Mary Guillemard
drm-misc-fixes) The Mesa MR using this series is available here [2]. [1]https://lore.kernel.org/all/20240903144955.144278-2-mary.guillem...@collabora.com/ [2]https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30991 Mary Guillemard (2): drm/panthor: Add PANTHOR_GROUP_PRIORITY_REALTIME

[PATCH] drm/panthor: Restrict high priorities on group_create

2024-09-03 Thread Mary Guillemard
/f390835074bdf162a63deb0311d1a6de527f9f89/src/gallium/drivers/panfrost/pan_csf.c#L1038 Signed-off-by: Mary Guillemard Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Cc: sta...@vger.kernel.org --- drivers/gpu/drm/panthor/panthor_drv.c | 23 +++ drivers/gpu/d

[PATCH v4] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-30 Thread Mary Guillemard
long for panthor_gpu_read_timestamp - Apply r-b from Mihail Signed-off-by: Mary Guillemard Reviewed-by: Mihail Atanassov --- drivers/gpu/drm/panthor/panthor_drv.c | 43 +++- drivers/gpu/drm/panthor/panthor_gpu.c | 47 +++ drivers/gpu/drm/panthor

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-29 Thread Mary Guillemard
On Wed, Aug 28, 2024 at 11:09:09AM +0100, Mihail Atanassov wrote: > Do you have a link you can share with the userspace side of things? Assuming > userland has been reviewed and is ready for merging, and the small nitpick > above fixed, > > Reviewed-by: Mihail Atanassov > > -- > Mihail Atanasso

Re: [PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-28 Thread Mary Guillemard
Hi Mihail, On Mon, Aug 19, 2024 at 03:25:48PM +0100, Mihail Atanassov wrote: > > diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h > > index 926b1deb1116..944f5618aa05 100644 > > --- a/include/uapi/drm/panthor_drm.h > > +++ b/include/uapi/drm/panthor_drm.h > > @@ -260,6

[PATCH v3] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-19 Thread Mary Guillemard
arch_timer_get_cntfrq - Rework commit message v3: - Add panthor_gpu_read_64bit_counter - Change panthor_gpu_read_timestamp to use panthor_gpu_read_64bit_counter Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 43 +++- drivers/gpu/drm/panthor/panthor_gpu.c

[PATCH v3 2/2] drm/panfrost: Add cycle counter job requirement

2024-08-19 Thread Mary Guillemard
r-b - Fix a codestyle issue Signed-off-by: Mary Guillemard Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_drv.c | 8 +-- drivers/gpu/drm/panfrost/panfrost_job.c | 28 +++-- include/uapi/drm/panfrost_drm.h | 1 + 3 files changed, 24 insertions

[PATCH v3 1/2] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters

2024-08-19 Thread Mary Guillemard
VK_KHR_calibrated_timestamps. v2: - Rewrote to use GPU timestamp register - Add missing include for arch_timer_get_cntfrq - Rework commit message v3: - Move panfrost_cycle_counter_get and panfrost_cycle_counter_put to panfrost_ioctl_query_timestamp - Handle possible overflow in panfrost_timestamp_read Signed-off-by: Mary

[PATCH v3 0/2] drm/panfrost: Wire cycle counters and timestamp info to userspace

2024-08-19 Thread Mary Guillemard
first patch - Fix a codestyle issue in the second patch and add Steven Price r-b [1]https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30553 Mary Guillemard (2): drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters drm/panfrost: Add cycle counter job

[PATCH v2 2/2] drm/panfrost: Add cycle counter job requirement

2024-08-14 Thread Mary Guillemard
extends the uAPI and because userland needs a way to advertise features like VK_KHR_shader_clock conditionally, we bumps the driver minor version. v2: - Rework commit message - Squash uAPI changes and implementation in this commit - Simplify changes based on Steven Price comments Signed-off-by: Mary

[PATCH v2 1/2] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters

2024-08-14 Thread Mary Guillemard
VK_KHR_calibrated_timestamps. v2: - Rewrote to use GPU timestamp register - Add missing include for arch_timer_get_cntfrq - Rework commit message Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panfrost/panfrost_drv.c | 35 drivers/gpu/drm/panfrost/panfrost_gpu.c | 12 drivers/gpu

[PATCH v2 0/2] drm/panfrost: Wire cycle counters and timestamp info to userspace

2024-08-14 Thread Mary Guillemard
/-/merge_requests/30553 Mary Guillemard (2): drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters drm/panfrost: Add cycle counter job requirement drivers/gpu/drm/panfrost/panfrost_drv.c | 43 ++-- drivers/gpu/drm/panfrost/panfrost_gpu.c | 12

[PATCH v2] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-12 Thread Mary Guillemard
arch_timer_get_cntfrq - Rework commit message Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 43 ++- drivers/gpu/drm/panthor/panthor_gpu.c | 32 drivers/gpu/drm/panthor/panthor_gpu.h | 2 ++ include/uapi/drm/panthor_drm.h

Re: [PATCH 1/3] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters

2024-08-08 Thread Mary Guillemard
Hello Steve, > VK_KHR_calibrated_timestamps says it should query 'quasi simultaneously > from two time domains' - but this is purely providing an interface to > read a single counter at a time. > > It _may_ be useful to report the GPU's view of time and at the same time > (or as near as possible)

Re: [PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-08 Thread Mary Guillemard
> As it stands, this query has nothing to do with the actual GPU so > doesn't really belong here. > > It'd be more valuable, and can maybe give better calibration results > than querying the system timestamp separately in userspace, if you > reported all of: > * the system timer value > * the sy

[PATCH 3/3] drm/panfrost: Handle JD_REQ_CYCLE_COUNT

2024-08-07 Thread Mary Guillemard
the driver minor version. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panfrost/panfrost_drv.c | 8 ++-- drivers/gpu/drm/panfrost/panfrost_job.c | 10 ++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm

[PATCH 2/3] drm/panfrost: Add cycle counter job requirement

2024-08-07 Thread Mary Guillemard
result in an increase of GPU power consumption. As a result, they should be left off unless required by the application. This new uAPI will be used in Mesa to implement timestamp queries and VK_KHR_shader_clock. Signed-off-by: Mary Guillemard --- include/uapi/drm/panfrost_drm.h | 1 + 1 file

[PATCH 1/3] drm/panfrost: Add SYSTEM_TIMESTAMP and SYSTEM_TIMESTAMP_FREQUENCY parameters

2024-08-07 Thread Mary Guillemard
proof in case of errata related to timers for example. This new uAPI will be used in Mesa to implement timestamp queries and VK_KHR_calibrated_timestamps. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panfrost/panfrost_drv.c | 17 + include/uapi/drm/panfrost_drm.h | 2

[PATCH 0/3] drm/panfrost: Wire cycle counters and timestamp info to userspace

2024-08-07 Thread Mary Guillemard
Mali has hardware cycle counters and GPU timestamps available for profiling. This patch series adds support for cycle counters propagation and also new timestamp info parameters. Those new changes to the uAPI will be used in Mesa to implement timestamp queries for OpenGL and Vulkan. Mary

[PATCH] drm/panthor: Add DEV_QUERY_TIMESTAMP_INFO dev query

2024-08-07 Thread Mary Guillemard
conditionally, this also bumps the driver minor version. Signed-off-by: Mary Guillemard --- drivers/gpu/drm/panthor/panthor_drv.c | 23 ++- include/uapi/drm/panthor_drm.h| 16 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm