Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Martin K. Petersen
Joel, > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. Reviewed-by: Martin K. Petersen # SCSI -- Martin K. Peterse

Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

2024-11-04 Thread Martin K. Petersen
Thomas, > The is_bin_visible() callbacks should not modify the struct > bin_attribute passed as argument. Enforce this by marking the argument > as const. > > As there are not many callback implementers perform this change > throughout the tree at once. For scsi: Acked-by:

Re: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value v2

2024-08-28 Thread Martin K. Petersen
which the cleanup > brigade now wants to check for for no good reason. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 23/25] scsi: virtio: drop owner assignment

2024-04-05 Thread Martin K. Petersen
Krzysztof, > virtio core already sets the .owner, so driver does not need to. virtio_scsi looks OK to me. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH 0/9] enabled -Wformat-truncation for clang

2024-04-01 Thread Martin K. Petersen
t; "make W=1". > > Unfortunately, gcc produces a lot more warnings when the option > is enabled, so it's not yet possible to turn it on both both > compilers. > > [...] Applied to 6.9/scsi-fixes, thanks! [7/9] scsi: mylex: fix sysfs buffer lengths https://git.kernel.org/mk

Re: (subset) [PATCH 00/42] Fix coccicheck warnings

2024-02-05 Thread Martin K. Petersen
git.kernel.org/mkp/scsi/c/01105c23de42 [27/42] drivers/scsi/isci: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/5fbf37e53091 [34/42] drivers/scsi/pm8001: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/8179041f801d -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH v2 00/24] use vmalloc_array and vcalloc

2023-07-11 Thread Martin K. Petersen
kp/scsi/c/04d91b783acf -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 00/24] use vmalloc_array and vcalloc

2023-07-05 Thread Martin K. Petersen
lows. Applied #7 and #24 to 6.5/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: (subset) [PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

2023-02-15 Thread Martin K. Petersen
tches are based on linux-next-20230125. > > [...] Applied to 6.3/scsi-queue, thanks! [28/35] Documentation: target: correct spelling https://git.kernel.org/mkp/scsi/c/c57ac5748be5 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/30] fix typos in comments

2022-03-18 Thread Martin K. Petersen
scsi: elx: libefc_sli: fix typos in comments https://git.kernel.org/mkp/scsi/c/8037185d1ad8 [24/30] scsi: qla2xxx: fix typos in comments https://git.kernel.org/mkp/scsi/c/5419e0f15622 [25/30] treewide: fix typos in comments https://git.kernel.org/mkp/scsi/c/9d05790f5187 --

Re: [PATCH 00/30] fix typos in comments

2022-03-14 Thread Martin K. Petersen
es 2, 17, 24, and 25 to 5.18/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 36/64] scsi: ibmvscsi: Avoid multi-field memset() overflow by aiming at srp

2021-07-28 Thread Martin K. Petersen
IU_LEN); > For the moment, I'll leave the patch as-is unless you prefer having > the BUILD_BUG_ON(). :) I'm OK with the BUILD_BUG_ON(). Hopefully Tyrel or Brian will chime in. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 36/64] scsi: ibmvscsi: Avoid multi-field memset() overflow by aiming at srp

2021-07-27 Thread Martin K. Petersen
measure I copied Tyrel and Brian. Acked-by: Martin K. Petersen > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c > b/drivers/scsi/ibmvscsi/ibmvscsi.c > index e6a3eaaa57d9.

Re: [PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings

2021-04-05 Thread Martin K. Petersen
scsi: lpfc: fix gcc -Wstringop-overread warning https://git.kernel.org/mkp/scsi/c/ada48ba70f6b -- Martin K. Petersen Oracle Linux Engineering ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] scsi: csiostor: Assign boolean values to a bool variable

2021-03-18 Thread Martin K. Petersen
[1/1] scsi: csiostor: Assign boolean values to a bool variable https://git.kernel.org/mkp/scsi/c/2ed0fc2b9a79 -- Martin K. Petersen Oracle Linux Engineering ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedeskto

Re: [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI

2021-03-18 Thread Martin K. Petersen
incorrect naming of __lpfc_update_fcf_record() https://git.kernel.org/mkp/scsi/c/3884ce1539b0 [28/30] scsi: mpt3sas: mpt3sas_base: Fix misspelling of _base_put_smid_default_atomic() https://git.kernel.org/mkp/scsi/c/e015e0ded135 [29/30] scsi: lpfc: lpfc_nportdisc: Fix misspelling

Re: [PATCH 00/30] [Set 1] Rid W=1 warnings in SCSI

2021-03-16 Thread Martin K. Petersen
Lee, > This set is part of a larger effort attempting to clean-up W=1 kernel > builds, which are currently overwhelmingly riddled with niggly little > warnings. Applied everything but patch 29 to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux En

Re: (subset) [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-08 Thread Martin K. Petersen
eak/goto/return/fallthrough statements instead of just > letting the code fall through to the next case. > > [...] Applied to 5.11/scsi-queue, thanks! [054/141] target: Fix fall-through warnings for Clang https://git.kernel.org/mkp/scsi/c/492096ecfa39 -- Martin K. Petersen

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-12-01 Thread Martin K. Petersen
Gustavo, > This series aims to fix almost all remaining fall-through warnings in > order to enable -Wimplicit-fallthrough for Clang. Applied 20-22,54,120-124 to 5.11/scsi-staging, thanks. -- Martin K. Petersen Oracle Linux Engineering _

Re: [PATCH 00/29] treewide: Convert comma separated statements

2020-09-09 Thread Martin K. Petersen
b: zstd: Avoid comma separated statements (no commit info) [27/29] ipv6: fib6: Avoid comma separated statements (no commit info) [28/29] sunrpc: Avoid comma separated statements (no commit info) [29/29] tools: Avoid comma separated statements (no commit info) --

Re: [PATCH 00/20] Documentation: eliminate duplicated words

2020-07-08 Thread Martin K. Petersen
On Tue, 7 Jul 2020 11:03:54 -0700, Randy Dunlap wrote: > Drop doubled words in various parts of Documentation/. > > [...] Applied to 5.9/scsi-queue, thanks! [17/20] scsi: advansys: docs: Eliminate duplicated word https://git.kernel.org/mkp/scsi/c/3010dfb0b77c -- Martin K.

Re: [PATCH 00/17] spelling.txt: /decriptors/descriptors/

2020-06-16 Thread Martin K. Petersen
with an addition in > scripts/spelling.txt so it shouldn't re-appear ;-) > > [...] Applied to 5.9/scsi-queue, thanks! [06/17] scsi: Fix trivial spelling https://git.kernel.org/mkp/scsi/c/0a19a725c0ed -- Martin K. Petersen Oracle Linux Engineering ___

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-19 Thread Martin K. Petersen
Joe, > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. SCSI bits look OK. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux

Re: [PATCH 13/15] scsi: make device_type const

2017-08-25 Thread Martin K. Petersen
Bhumika, > Make these const as they are only stored in the type field of a device > structure, which is const. Applied to 4.14/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering ___ dri-devel mailing list dri