Re: [PATCH v2] kernel-doc: rename the kernel-doc directive 'functions' to 'identifiers'

2019-10-28 Thread Markus Heiser
Am 29.10.19 um 01:31 schrieb Changbin Du: But is it, really? I agree with Jon about the distinction between None and '' being confusing. Here python is different from C. Both empty string and None are False in python. Note such condition is common in python. The one is a empty string str(''),

Re: [PATCH 8/8] docs: remove extra conf.py files

2019-07-14 Thread Markus Heiser
Hi Mauro, sorry, I havn't tested your patch, but one question ... Am 14.07.19 um 17:10 schrieb Mauro Carvalho Chehab: Now that the latex_documents are handled automatically, we can remove those extra conf.py files. We need these conf.py also for compiling books' into HTML. For this the tags.

Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

2017-12-12 Thread Markus Heiser
> Am 12.12.2017 um 16:23 schrieb Daniel Vetter : > >>> Thanks for your patch, but similar fix is already merged here [1] >>> >>> Michal >>> >>> [1] >>> https://cgit.freedesktop.org/drm-tip/commit/?id=006c23327f8de8575508c458131b304188d426f7 >> >> >> Thanks for pointing out. I miss the ":doc:

Re: [PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

2017-12-12 Thread Markus Heiser
> Am 12.12.2017 um 13:05 schrieb Michal Wajdeczko : > > On Tue, 12 Dec 2017 12:38:37 +0100, Markus Heiser > wrote: > >> With commit d9e2e0143c the 'GuC-specific firmware loader' doc >> section was removed from intel_guc_loader.c without a >> replacem

[PATCH] docs: fix, intel_guc_loader.c has been moved to intel_guc_fw.c

2017-12-12 Thread Markus Heiser
c_loader.c to intel_guc_fw.c Signed-off-by: Markus Heiser --- Documentation/gpu/i915.rst | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 2e7ee03..e94d3ac 100644 --- a/Documentation/gpu/i915.rst +++ b/Documentatio

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-06 Thread Markus Heiser
Am 06.03.2017 um 11:12 schrieb Daniel Vetter : > Just to avoid confusion: Markus&I chatted a bit in private, and he > volunteered to take over, and fix the few issues that need to be fixed in > his original patch: > - drop the convertsvg python fallback, since we need convert anyway > - relative

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
schrieb Daniel Vetter : > > From: Markus Heiser > > This patch brings scalable figure, image handling and a concept to > embed *render* markups: > > * DOT (http://www.graphviz.org) > * SVG > > For image handling use the 'image' replacement:: > >

Re: [PATCH] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
>> Btw, PDF conversion is also not working: >> >> >> File "/d00/kernel/Documentation/sphinx/kfigure.py", line 241, in svg2pdf >>cmd = [convert_cmd, svg_fname, pdf_fname] >> >> NameError: name 'convert_cmd' is not defined >> >> And including SVG files for HTML output also seems to be

Re: [PATCH] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 20:34 schrieb Mauro Carvalho Chehab > : > > Em Thu, 2 Mar 2017 20:06:39 +0100 > Markus Heiser escreveu: > >> Hi Mauro, >> >>> Tested here with the enclosed patch. >> >> great, big step forward making /media/Makefi

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 20:09 schrieb Mauro Carvalho Chehab > : ... >> >> Yes, its only about "docutils>=0.11" in Sphinx 1.3 dependencies. >> In Sphinx 1.5 the error: >> >> https://github.com/sphinx-doc/sphinx/issues/3212 >> >> is fixed: >> >> >> https://github.com/tk0miya/sphinx/commit/73663f

Re: [PATCH] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Hi Mauro, > Tested here with the enclosed patch. great, big step forward making /media/Makefile smaller ... thanks a lot > It crashed: > Exception occurred: > File "/devel/v4l/patchwork/Documentation/sphinx/kfigure.py", line 222, in > dot2format >sys.stderr.write(err) > TypeError: wri

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 19:20 schrieb Jonathan Corbet : > > On Thu, 2 Mar 2017 19:16:47 +0100 > Markus Heiser wrote: > >> This is very easy, if we use a requiremts.txt file where we >> stick the versions and run the sphinx in this build in a >> virtualenv which is

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 17:29 schrieb Mauro Carvalho Chehab > : > > Em Thu, 2 Mar 2017 17:13:25 +0100 > Markus Heiser escreveu: > >>> Am 02.03.2017 um 16:49 schrieb Mauro Carvalho Chehab >>> : >>> >>>>> You can test it with virtu

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
> Am 02.03.2017 um 16:49 schrieb Mauro Carvalho Chehab > : > >>> You can test it with virtualenv >>> https://virtualenv.pypa.io/en/stable/userguide/ >>> >>> In short: >>> >>> $ cd kernel-src >>> $ virtualenv myenv >>> $ source myenv/bin/activate >>> $ pip install 'Sphinx==1.3.1' >>> $ make .

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Am 02.03.2017 um 16:11 schrieb Daniel Vetter : > On Thu, Mar 02, 2017 at 03:58:36PM +0100, Markus Heiser wrote: >> Hi Daniel, Laurent >> >> Am 02.03.2017 um 15:14 schrieb Laurent Pinchart >> : >> >>> Hi Daniel, >>> >>> On Thursday

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Hi Daniel, Laurent Am 02.03.2017 um 15:14 schrieb Laurent Pinchart : > Hi Daniel, > > On Thursday 02 Mar 2017 14:54:32 Daniel Vetter wrote: >> On Thu, Mar 2, 2017 at 1:26 PM, Laurent Pinchart wrote: >>> Hi Daniel, >>> >>> Thank you for the patch. >>> >>> With this applied, I get >>> >>> make

Re: [PATCH 2/6] docs-rst: automatically convert Graphviz and SVG images

2017-03-02 Thread Markus Heiser
Am 02.03.2017 um 08:12 schrieb Daniel Vetter : > On Wed, Mar 01, 2017 at 12:56:36PM -0300, Gabriel Krisman Bertazi wrote: >> Daniel Vetter writes: >> >> Hi Daniel, >> >>> +if dst_fname: >>> +name = dst_fname[len(out_dir) + 1:] >>> +# the builder needs not to copy one more t

kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation)

2016-10-05 Thread Markus Heiser
Am 05.10.2016 um 16:04 schrieb Jani Nikula : > On Wed, 05 Oct 2016, Daniel Vetter wrote: >> Jani Nikula has a patch with a scrip to make the one kernel-doc parser >> into a lint/checker pass over the entire kernel. I think that'd would >> be more robust instead of trying to approximate the real

[PATCH 06/11] dma-buf: Introduce fence_get_rcu_safe()

2016-09-23 Thread Markus Heiser
Am 23.09.2016 um 14:59 schrieb Daniel Vetter : >> >> /** >> - * fence_put - decreases refcount of the fence >> - * @fence: [in]fence to reduce refcount of >> + * fence_get_rcu_safe - acquire a reference to an RCU tracked fence >> + * @fence: [in]pointer to fence to increase refcount o

[PATCH v2 2/2] Documentation/sphinx: link dma-buf rsts

2016-08-23 Thread Markus Heiser
Am 23.08.2016 um 08:01 schrieb Daniel Vetter : > On Mon, Aug 22, 2016 at 12:49:30PM -0300, Mauro Carvalho Chehab wrote: >> Em Mon, 22 Aug 2016 20:41:45 +0530 >> Sumit Semwal escreveu: >> >>> Include dma-buf sphinx documentation into top level index. >>> >>> Signed-off-by: Sumit Semwal >>> ---

[RFC 3/4] Documentation: move dma-buf documentation to rst

2016-08-11 Thread Markus Heiser
Am 11.08.2016 um 13:58 schrieb Markus Heiser : >> +.. note:: Until this stage, the buffer-exporter has the option to choose >> not to >> + actually allocate the backing storage for this buffer, but wait for the >> + first buffer-user to request use of buffer for alloc

[RFC 3/4] Documentation: move dma-buf documentation to rst

2016-08-11 Thread Markus Heiser
Hi Sumit, I haven't compiled your patch yet, just my 2cent about the reStructuredText (reST) ASCII markup ... Here are some handy links about reST and the Sphinx markup constructs, we have not yet added to the documentation (sorry): * reST primer:http://www.sphinx-doc.org/en/stable/rest.htm

[PATCH 01/20] drm/doc: Fix more kerneldoc/sphinx warnings

2016-08-11 Thread Markus Heiser
Am 11.08.2016 um 10:23 schrieb Jani Nikula : > On Thu, 11 Aug 2016, Jani Nikula wrote: >> On Tue, 09 Aug 2016, Daniel Vetter wrote: >>> diff --git a/drivers/gpu/drm/i915/intel_audio.c >>> b/drivers/gpu/drm/i915/intel_audio.c >>> index d32f586f9c05..85389cdd0bec 100644 >>> --- a/drivers/gpu/drm

[PATCH 2/2] drm/doc: Fix more kerneldoc/sphinx warnings

2016-07-20 Thread Markus Heiser
gt;> True. For some of them we might want to update our style guide on how >>> to reference structures and constants, not sure ... >>> >>> Cc: Markus Heiser >>> Cc: Jonathan Corbet >>> Cc: linux-doc at vger.kernel.org >>> Signed-off-by: Daniel V

[PATCH 1/2] doc/sphinx: Enable keep_warnings

2016-07-20 Thread Markus Heiser
Am 20.07.2016 um 13:27 schrieb Daniel Vetter : > On Wed, Jul 20, 2016 at 12:55 PM, Markus Heiser > wrote: >> Hi Daniel, hi Mauro, >> >> Am 19.07.2016 um 17:32 schrieb Daniel Vetter : >> >>> On Tue, Jul 19, 2016 at 5:25 PM, Daniel Vetter >>

[PATCH 1/2] doc/sphinx: Enable keep_warnings

2016-07-20 Thread Markus Heiser
Hi Daniel, hi Mauro, Am 19.07.2016 um 17:32 schrieb Daniel Vetter : > On Tue, Jul 19, 2016 at 5:25 PM, Daniel Vetter > wrote: >> On Tue, Jul 19, 2016 at 4:59 PM, Markus Heiser >> wrote: >>> >>> Am 19.07.2016 um 13:42 schrieb Daniel Vetter : >>>

[PATCH 1/2] doc/sphinx: Enable keep_warnings

2016-07-19 Thread Markus Heiser
the source, e.g. the drivers/gpu/drm/drm_crtc.c or the rst-file where the drm_crtc.c is referred by a kernel-doc directive .. these dependence sometimes confuse me .. when I missed log messages, I clean the cache e.g. by target cleandocs. -- Markus -- > > Cc: Markus Heiser > Cc: Jon