[PATCH 7/9] drm/rcar-du: dsi: Clean up handling of DRM mode flags

2025-09-22 Thread Marek Vasut
consisten with the current style. Conversion to BIT() and GENMASK() macros is done at the very end of this series in the last two patches. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Magnus Damm Cc:

[PATCH 0/9] drm/rcar-du: dsi: Convert register bits to BIT()/GENMASK() macros

2025-09-22 Thread Marek Vasut
should not have any adverse effect on existing hardware. Marek Vasut (9): drm/rcar-du: dsi: Fix missing parameter in RXSETR_...EN macros drm/rcar-du: dsi: Deduplicate mipi_dsi_pixel_format_to_bpp() usage drm/rcar-du: dsi: Clean up VCLKSET register macros drm/rcar-du: dsi: Clean up CLOCKSET1

[PATCH 1/9] drm/rcar-du: dsi: Fix missing parameter in RXSETR_...EN macros

2025-09-22 Thread Marek Vasut
The RXSETR_CRCEN(n) and RXSETR_ECCEN(n) macros both take parameter (n), add the missing macro parameter. Neither of those macros is used by the driver, so for now the bug is harmless. Fixes: 685e8dae19df ("drm/rcar-du: dsi: Implement DSI command support") Signed-off-by: Marek Vasut ---

[PATCH 2/9] drm/rcar-du: dsi: Deduplicate mipi_dsi_pixel_format_to_bpp() usage

2025-09-22 Thread Marek Vasut
Call mipi_dsi_pixel_format_to_bpp() once in rcar_mipi_dsi_set_display_timing() and store the value into a variable. This slightly simplifies the code. No functional change. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc

[PATCH 9/9] drm/rcar-du: dsi: Convert register bitfields to GENMASK() macro

2025-09-22 Thread Marek Vasut
Convert register bitfields to GENMASK() macro where applicable. Use FIELD_PREP() throughout the driver. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Magnus Damm Cc: Maxime Ripard Cc: Simona Vetter

[PATCH 6/9] drm/rcar-du: dsi: Respect DSI mode flags

2025-09-22 Thread Marek Vasut
is done at the very end of this series in the last two patches. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Magnus Damm Cc: Maxime Ripard Cc: Simona Vetter Cc: Thomas Zimmermann Cc: Tomi Valkeinen

[PATCH 5/9] drm/rcar-du: dsi: Clean up TXVMPSPHSETR DT macros

2025-09-22 Thread Marek Vasut
of this series in the last two patches. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Magnus Damm Cc: Maxime Ripard Cc: Simona Vetter Cc: Thomas Zimmermann Cc: Tomi Valkeinen Cc: dri-devel

[PATCH 4/9] drm/rcar-du: dsi: Clean up CLOCKSET1 CLKINSEL macros

2025-09-22 Thread Marek Vasut
. Conversion to BIT() and GENMASK() macros is done at the very end of this series in the last two patches. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Magnus Damm Cc: Maxime Ripard Cc: Simona Vetter Cc

[PATCH] drm/etnaviv: add HWDB entry for GC8000 Nano Ultra VIP r6205

2025-09-19 Thread Marek Vasut
This is the GPU/NPU combined device found on the ST STM32MP25 SoC. Feature bits taken from the downstream kernel driver 6.4.21. Signed-off-by: Marek Vasut --- Cc: Christian Gmeiner Cc: David Airlie Cc: Lucas Stach Cc: Simona Vetter Cc: dri-devel@lists.freedesktop.org Cc: etna

Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-19 Thread Marek Vasut
tood, thank you. -- Best regards, Marek Vasut

Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-19 Thread Marek Vasut
On 9/19/25 5:21 PM, Tomi Valkeinen wrote: Hello Tomi, On 05/09/2025 00:01, Marek Vasut wrote: This controller can have both bridges and panels connected to it. In order to describe panels properly in DT, pull in dsi-controller.yaml and disallow only unevaluatedProperties, because the panel

Re: [PATCH] dt-bindings: ili9881c: Allow port subnode

2025-09-19 Thread Marek Vasut
On 9/16/25 11:52 AM, Neil Armstrong wrote: On 16/09/2025 10:15, Marek Vasut wrote: On 9/5/25 9:51 AM, Neil Armstrong wrote: On 04/09/2025 22:01, Marek Vasut wrote: The ILI9881C is a DSI panel, which can be tied to a DSI controller using OF graph port/endpoint. Allow the port subnode in the

Re: [PATCH] dt-bindings: ili9881c: Allow port subnode

2025-09-16 Thread Marek Vasut
On 9/16/25 1:54 PM, Neil Armstrong wrote: On 16/09/2025 13:48, Marek Vasut wrote: On 9/16/25 11:52 AM, Neil Armstrong wrote: On 16/09/2025 10:15, Marek Vasut wrote: On 9/5/25 9:51 AM, Neil Armstrong wrote: On 04/09/2025 22:01, Marek Vasut wrote: The ILI9881C is a DSI panel, which can be

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-16 Thread Marek Vasut
ite[2]. I use mainline U-Boot 2025.07 with about 10 extra patches, but nothing significant. I don't think this is U-Boot issue, is it ? I can rebuild SM, which commit in SM (from imx-sm repository) do I need to use ? -- Best regards, Marek Vasut

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-16 Thread Marek Vasut
On 9/16/25 12:06 PM, Rain Yang wrote: Hello everyone, you're right. *0x4d810008=1, this register is a write-once register, so it was moved into SM since imx 6.12.3 release, and latest 6.6.52 release. some document work is still needed in the future. Hi Marek, thanks for your effort to make the

Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-16 Thread Marek Vasut
On 9/8/25 2:54 PM, Marek Vasut wrote: Hello Tomi, On 05/09/2025 00:01, Marek Vasut wrote: This controller can have both bridges and panels connected to it. In order to describe panels properly in DT, pull in dsi-controller.yaml and disallow only unevaluatedProperties, because the panel node

Re: [PATCH] dt-bindings: ili9881c: Allow port subnode

2025-09-16 Thread Marek Vasut
On 9/5/25 9:51 AM, Neil Armstrong wrote: On 04/09/2025 22:01, Marek Vasut wrote: The ILI9881C is a DSI panel, which can be tied to a DSI controller using OF graph port/endpoint. Allow the port subnode in the binding. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc

Re: [PATCH] dt-bindings: bridge: lt9211c: Add bindings

2025-09-10 Thread Marek Vasut
On 9/10/25 9:37 AM, Nilesh Laad wrote: From: Yi Zhang Add bindings for lt9211c. Signed-off-by: Yi Zhang Signed-off-by: Nilesh Laad --- .../bindings/display/bridge/lontium,lt9211c.yaml | 113 + 1 file changed, 113 insertions(+) diff --git a/Documentation/devicetree/

Re: [PATCH v2] drm/rcar-du: dsi: Implement DSI command support

2025-09-08 Thread Marek Vasut
On 9/8/25 8:55 AM, Tomi Valkeinen wrote: Hi, Hello Tomi, On 31/08/2025 22:04, Marek Vasut wrote: Implement support for DSI command transfer. Transmission of both Short Packet and Long Packet is implemented, so is command transmission to request response from peripheral device and

Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-08 Thread Marek Vasut
On 9/8/25 9:43 AM, Tomi Valkeinen wrote: Hi, Hello Tomi, On 05/09/2025 00:01, Marek Vasut wrote: This controller can have both bridges and panels connected to it. In order to describe panels properly in DT, pull in dsi-controller.yaml and disallow only unevaluatedProperties, because the

[PATCH v2 2/2] drm/panel: ilitek-ili9881c: Add configuration for 5" Raspberry Pi 720x1280

2025-09-07 Thread Marek Vasut
Add configuration for the 5" Raspberry Pi 720x1280 DSI panel based on ili9881. This uses 10px longer horizontal sync pulse and 10px shorter HBP to avoid very short hsync pulse. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzy

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-07 Thread Marek Vasut
On 9/4/25 5:20 PM, Boris Brezillon wrote: On Thu, 4 Sep 2025 16:54:38 +0200 Marek Vasut wrote: On 9/4/25 4:04 PM, Boris Brezillon wrote: Hello Boris, I suspect the extra soft reset I did before "un-halted" the GPU and allowed it to proceed. Hm, not quite. I mean, you sti

[PATCH 2/2] drm/panel: ilitek-ili9881c: Add configuration for 5" Raspberry Pi 720x1280

2025-09-07 Thread Marek Vasut
Add configuration for the 5" Raspberry Pi 720x1280 DSI panel based on ili9881. This uses 10px longer horizontal sync pulse and 10px shorter HBP to avoid very short hsync pulse. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzy

[PATCH 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-05 Thread Marek Vasut
This controller can have both bridges and panels connected to it. In order to describe panels properly in DT, pull in dsi-controller.yaml and disallow only unevaluatedProperties, because the panel node is optional. Include example binding with panel. Signed-off-by: Marek Vasut --- Cc: Conor

Re: [PATCH v2 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-05 Thread Marek Vasut
On 9/5/25 5:02 PM, Rob Herring (Arm) wrote: On Thu, 04 Sep 2025 23:01:21 +0200, Marek Vasut wrote: This controller can have both bridges and panels connected to it. In order to describe panels properly in DT, pull in dsi-controller.yaml and disallow only unevaluatedProperties, because the

Re: [PATCH v2 2/2] drm/panel: ilitek-ili9881c: Add configuration for 5" Raspberry Pi 720x1280

2025-09-05 Thread Marek Vasut
On 9/5/25 3:18 PM, Devarsh Thakkar wrote: Hi Marek, Hi, Thanks for the patch. On 05/09/25 02:26, Marek Vasut wrote: Add configuration for the 5" Raspberry Pi 720x1280 DSI panel based on ili9881. This uses 10px longer horizontal sync pulse and 10px shorter HBP to avoid very short

[PATCH] drm/panel: ilitek-ili9881c: Turn ILI9881C_COMMAND_INSTR() parameters lowercase

2025-09-04 Thread Marek Vasut
Make all ILI9881C_COMMAND_INSTR() parameters consistently lowercase. No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob

[PATCH v2 1/4] arm64: dts: renesas: r8a779a0: Rename dsi-encoder@ to dsi@

2025-09-04 Thread Marek Vasut
Rename dsi-encoder@ node to dsi@ node to follow node name pattern in Documentation/devicetree/bindings/display/dsi-controller.yaml . No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Krzysztof Kozlowski Cc

[PATCH 1/2] dt-bindings: ili9881c: Document 5" Raspberry Pi 720x1280

2025-09-04 Thread Marek Vasut
Document the 5" Raspberry Pi 720x1280 DSI panel based on ili9881. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob Herring Cc: Simona V

[PATCH] dt-bindings: ili9881c: Allow port subnode

2025-09-04 Thread Marek Vasut
The ILI9881C is a DSI panel, which can be tied to a DSI controller using OF graph port/endpoint. Allow the port subnode in the binding. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc

Re: [PATCH 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-04 Thread Marek Vasut
On 9/4/25 10:23 PM, Dmitry Baryshkov wrote: [...] @@ -80,14 +83,14 @@ required: - resets - ports -additionalProperties: false +unevaluatedProperties: false examples: - | #include #include -dsi0: dsi-encoder@fed8 { +dsi0: dsi@fed8 { As yo

[PATCH v2 4/4] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Allow panel@ subnode

2025-09-04 Thread Marek Vasut
This controller can have both bridges and panels connected to it. In order to describe panels properly in DT, pull in dsi-controller.yaml and disallow only unevaluatedProperties, because the panel node is optional. Include example binding with panel. Signed-off-by: Marek Vasut --- Cc: Conor

[PATCH v2 2/4] arm64: dts: renesas: r8a779g0: Rename dsi-encoder@ to dsi@

2025-09-04 Thread Marek Vasut
Rename dsi-encoder@ node to dsi@ node to follow node name pattern in Documentation/devicetree/bindings/display/dsi-controller.yaml . No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Krzysztof Kozlowski Cc

[PATCH v2 3/4] arm64: dts: renesas: r8a779h0: Rename dsi-encoder@ to dsi@

2025-09-04 Thread Marek Vasut
Rename dsi-encoder@ node to dsi@ node to follow node name pattern in Documentation/devicetree/bindings/display/dsi-controller.yaml . No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Krzysztof Kozlowski Cc

Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: Add configuration for 5" Raspberry Pi 720x1280

2025-09-04 Thread Marek Vasut
On 9/4/25 10:21 PM, Dmitry Baryshkov wrote: [...] + ILI9881C_COMMAND_INSTR(0xD1, 0x52), + ILI9881C_COMMAND_INSTR(0xD2, 0x63), + ILI9881C_COMMAND_INSTR(0xD3, 0x39), +}; Should the hex be lower-cased? Other than that LGTM. Fixed in V2, thanks. The other panel entries are fix

[PATCH v2 1/2] dt-bindings: ili9881c: Document 5" Raspberry Pi 720x1280

2025-09-04 Thread Marek Vasut
Document the 5" Raspberry Pi 720x1280 DSI panel based on ili9881. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob Herring Cc: Simona V

[PATCH 3/4] arm64: dts: renesas: r8a779h0: Rename dsi-encoder@ to dsi@

2025-09-04 Thread Marek Vasut
Rename dsi-encoder@ node to dsi@ node to follow node name pattern in Documentation/devicetree/bindings/display/dsi-controller.yaml . No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Krzysztof Kozlowski Cc

[PATCH 2/4] arm64: dts: renesas: r8a779g0: Rename dsi-encoder@ to dsi@

2025-09-04 Thread Marek Vasut
Rename dsi-encoder@ node to dsi@ node to follow node name pattern in Documentation/devicetree/bindings/display/dsi-controller.yaml . No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Krzysztof Kozlowski Cc

[PATCH 1/4] arm64: dts: renesas: r8a779a0: Rename dsi-encoder@ to dsi@

2025-09-04 Thread Marek Vasut
Rename dsi-encoder@ node to dsi@ node to follow node name pattern in Documentation/devicetree/bindings/display/dsi-controller.yaml . No functional change. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Krzysztof Kozlowski Cc

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-04 Thread Marek Vasut
On 9/4/25 4:04 PM, Boris Brezillon wrote: Hello Boris, I suspect the extra soft reset I did before "un-halted" the GPU and allowed it to proceed. Hm, not quite. I mean, you still need to explicitly boot the MCU after a reset, which is what the write to MCU_CONTROL [1] does. What the soft-rese

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-04 Thread Marek Vasut
On 9/4/25 4:39 PM, Alexander Stein wrote: Hi, Am Donnerstag, 4. September 2025, 15:52:38 CEST schrieb Marek Vasut: On 9/4/25 8:36 AM, Alexander Stein wrote: Hello Alexander, Maybe the GPU remains halted because setting the GLB_HALT stops command stream processing, and the GPU never samples

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-04 Thread Marek Vasut
On 3/25/25 3:52 PM, Boris Brezillon wrote: Hello Boris, sorry for the late reply. Hm, that might be the cause of the fast reset issue (which is a fast resume more than a fast reset BTW): if you re-assert the reset line on runtime suspend, I guess this causes a full GPU reset, and the MCU ends

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-04 Thread Marek Vasut
On 9/4/25 8:36 AM, Alexander Stein wrote: Hello Alexander, Maybe the GPU remains halted because setting the GLB_HALT stops command stream processing, and the GPU never samples the clearing of GLB_HALT and therefore remains halted forever ? Exactly that, and that's expected. FYI: in a new re

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-09-04 Thread Marek Vasut
On 9/4/25 8:22 AM, Boris Brezillon wrote: Hello Marek, Hello Boris, Can you please test the following patch (also attached) on one of your devices, and tell me what the status is at the end . The diff sets the GLB_HALT bit and then clears it again, which I suspect should first halt the GPU an

Re: [PATCH v2 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-09-04 Thread Marek Vasut
On 9/4/25 11:54 AM, Peng Fan wrote: Hello Peng, @@ -1890,6 +1919,35 @@ netc_emdio: mdio@0,0 { }; }; + gpu_blk_ctrl: reset-controller@4d81 { + compatible = "nxp,imx95-gpu-blk-ctrl"; + reg = <0x0 0x4d8100

Re: [PATCH v2] drm/rcar-du: dsi: Fix 1/2/3 lane support

2025-09-01 Thread Marek Vasut
On 9/1/25 11:22 AM, Tomi Valkeinen wrote: Hello Tomi, Would you like to pick this up via drm-misc , or shall I ? I'll push to drm-misc. Thanks! Thank you -- Best regards, Marek Vasut

[PATCH v2] drm/rcar-du: dsi: Implement DSI command support

2025-08-31 Thread Marek Vasut
is performed purely using controller register interface. Short Packet transfer can transfer up to 2 Bytes of data, Long Packet transfer can transfer up to 16 Bytes of data. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc

Re: [PATCH 4/4] drm/rcar-du: dsi: Implement DSI command support

2025-08-31 Thread Marek Vasut
On 8/18/25 9:20 AM, Tomi Valkeinen wrote: Hello Tomi, If yes, then it might take much longer until the command can be transferred. Do you know the upper limit , is that one or two frame times ? If using DSI video mode and the stream is on, the DSI TX has to interleave the commands either to

Re: [PATCH v2] drm/rcar-du: dsi: Fix 1/2/3 lane support

2025-08-31 Thread Marek Vasut
On 8/14/25 7:54 AM, Tomi Valkeinen wrote: Hello Tomi, On 14/08/2025 00:08, Marek Vasut wrote: Remove fixed PPI lane count setup. The R-Car DSI host is capable of operating in 1..4 DSI lane mode. Remove the hard-coded 4-lane configuration from PPI register settings and instead configure the

Re: [PATCH 4/4] drm/rcar-du: dsi: Implement DSI command support

2025-08-17 Thread Marek Vasut
On 8/12/25 4:36 PM, Tomi Valkeinen wrote: Hello Tomi, On 08/06/2025 17:24, Marek Vasut wrote: Implement support for DSI command transfer mode. Transmission of both Short I constantly kept reading "DSI command mode support". So I was quite confused for a bit =). Maybe avoid the us

Re: [PATCH 2/4] drm/rcar-du: dsi: Remove fixed PPI lane count setup

2025-08-17 Thread Marek Vasut
On 8/14/25 7:39 AM, Tomi Valkeinen wrote: Hello Tomi, The 1/2/3 lane mode was already implemented in the driver, except it was broken. If it never worked, was it broken or not implemented? How much code the original driver must have for the feature to have the feature "implemented, just broke

[PATCH v2] drm/rcar-du: dsi: Fix 1/2/3 lane support

2025-08-13 Thread Marek Vasut
PPISETR register DLEN bitfield. Make sure the LANECNT and DLEN bitfields are configured to match. Fixes: 155358310f01 ("drm: rcar-du: Add R-Car DSI driver") Cc: Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart C

Re: [PATCH 2/4] drm/rcar-du: dsi: Remove fixed PPI lane count setup

2025-08-13 Thread Marek Vasut
On 8/13/25 9:34 AM, Tomi Valkeinen wrote: Hi, diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h b/ drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h index b3e57217ae63..cefa7e92b5b8 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h +++ b/drivers/gpu/drm/renesa

Re: [PATCH 1/4] drm/rcar-du: dsi: Convert register bits to BIT() macro

2025-08-13 Thread Marek Vasut
On 8/13/25 9:42 AM, Tomi Valkeinen wrote: Hi, diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h b/ drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h index a6b276f1d6ee..b3e57217ae63 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h +++ b/drivers/gpu/drm/renesa

Re: [PATCH 1/4] drm/rcar-du: dsi: Convert register bits to BIT() macro

2025-08-13 Thread Marek Vasut
On 8/13/25 8:59 AM, Geert Uytterhoeven wrote: On Tue, 12 Aug 2025 at 22:05, Laurent Pinchart wrote: On Tue, Aug 12, 2025 at 09:32:36PM +0200, Marek Vasut wrote: On 8/12/25 3:26 PM, Tomi Valkeinen wrote: diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h b/drivers/gpu/drm

Re: [PATCH 2/4] drm/rcar-du: dsi: Remove fixed PPI lane count setup

2025-08-12 Thread Marek Vasut
On 8/12/25 3:30 PM, Tomi Valkeinen wrote: Hi, diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h index b3e57217ae63..cefa7e92b5b8 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h +++ b/drivers/gpu/drm/renesa

Re: [PATCH 1/4] drm/rcar-du: dsi: Convert register bits to BIT() macro

2025-08-12 Thread Marek Vasut
On 8/12/25 3:26 PM, Tomi Valkeinen wrote: Hi, diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h index a6b276f1d6ee..b3e57217ae63 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi_regs.h +++ b/drivers/gpu/drm/renesa

Re: [PATCH] drm/panel: ilitek-ili9881c: Use u8 for lane count

2025-06-21 Thread Marek Vasut
On 6/16/25 6:26 PM, Neil Armstrong wrote: On 16/06/2025 18:05, Marek Vasut wrote: On 6/16/25 1:45 PM, Neil Armstrong wrote: On 13/06/2025 12:54, Marek Vasut wrote: On 6/13/25 11:29 AM, Neil Armstrong wrote: On 12/06/2025 01:49, Marek Vasut wrote: Use u8 to hold lane count in struct

Re: [PATCH] drm/panel: ilitek-ili9881c: Use u8 for lane count

2025-06-16 Thread Marek Vasut
On 6/16/25 1:45 PM, Neil Armstrong wrote: On 13/06/2025 12:54, Marek Vasut wrote: On 6/13/25 11:29 AM, Neil Armstrong wrote: On 12/06/2025 01:49, Marek Vasut wrote: Use u8 to hold lane count in struct ili9881c_desc {} to avoid alignment gap between default_address_mode and lanes members. The

Re: [PATCH] drm/panel: ilitek-ili9881c: Use u8 for lane count

2025-06-13 Thread Marek Vasut
On 6/13/25 11:29 AM, Neil Armstrong wrote: On 12/06/2025 01:49, Marek Vasut wrote: Use u8 to hold lane count in struct ili9881c_desc {} to avoid alignment gap between default_address_mode and lanes members. The ili9881c controller can only operate up to 4 DSI lanes, so there is no chance this

[PATCH] drm/panel: ilitek-ili9881c: Use u8 for lane count

2025-06-11 Thread Marek Vasut
Uytterhoeven Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Jessica Zhang Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Simona Vetter Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org Cc: linux-renesas-...@vger.kernel.org --- drivers/gpu/drm/panel

[PATCH 2/3] drm/panel: ilitek-ili9881c: Allow configuration of the number of lanes

2025-06-08 Thread Marek Vasut
Not all panels use all 4 data lanes, so allow configuration based on the compatible string. Signed-off-by: Marek Vasut --- Based on https://github.com/raspberrypi/linux 0d7ac78a3dd9 ("Extending ili9881c driver support for nwe080 panel") by Dave Stevenson and others --- Cc: Conor

[PATCH 1/3] dt-bindings: ili9881c: Document 7" Raspberry Pi 720x1280

2025-06-08 Thread Marek Vasut
Document the 7" Raspberry Pi 720x1280 DSI panel based on ili9881. Signed-off-by: Marek Vasut --- Cc: Conor Dooley Cc: Dave Stevenson Cc: David Airlie Cc: Jessica Zhang Cc: Krzysztof Kozlowski Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Rob Herring Cc: Simona V

[PATCH 1/4] drm/rcar-du: dsi: Convert register bits to BIT() macro

2025-06-08 Thread Marek Vasut
Convert register bits to BIT() macro where applicable. This is done automatically using regex 's@(1 << \([0-9]\+\))@BIT(\1)', except for two BPP_18 macros which are not bits, but bitfields, and which are not modified. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert

[PATCH 2/4] drm/rcar-du: dsi: Remove fixed PPI lane count setup

2025-06-08 Thread Marek Vasut
The R-Car DSI host is capable of operating in 1..4 DSI lane mode. Remove hard-coded 4-lane configuration from PPI register settings and instead configure the PPI lane count according to lane count information already obtained by this driver instance. Signed-off-by: Marek Vasut --- Cc: David

[PATCH 0/4] drm/rcar-du: dsi: Implement DSI command support

2025-06-08 Thread Marek Vasut
Use BIT() macro. Clean up lane count handling for non-4-lane panels. Implement support for DSI command transfer mode using register based access, with maximum payload length of 16 Bytes in Long Packet. Marek Vasut (4): drm/rcar-du: dsi: Convert register bits to BIT() macro drm/rcar-du: dsi

[PATCH 4/4] drm/rcar-du: dsi: Implement DSI command support

2025-06-08 Thread Marek Vasut
transfer is performed purely using controller register interface. Short Packet transfer can transfer up to 2 Bytes of data, Long Packet transfer can transfer up to 16 Bytes of data. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc

[PATCH 3/3] drm/panel: ilitek-ili9881c: Add configuration for 7" Raspberry Pi 720x1280

2025-06-08 Thread Marek Vasut
Add configuration for the 7" Raspberry Pi 720x1280 DSI panel based on ili9881. Signed-off-by: Marek Vasut --- Based on https://github.com/raspberrypi/linux 0d7ac78a3dd9 ("Extending ili9881c driver support for nwe080 panel") by Dave Stevenson and others --- Cc: Conor Dooley Cc:

[PATCH 3/4] drm/rcar-du: dsi: Configure TXSETR register to match PPI lane count

2025-06-08 Thread Marek Vasut
the LANECNT and DLEN bitfields are configured to match. Signed-off-by: Marek Vasut --- Cc: David Airlie Cc: Geert Uytterhoeven Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Magnus Damm Cc: Maxime Ripard Cc: Simona Vetter Cc: Thomas Zimmermann Cc: Tomi Valkeinen Cc

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-04-05 Thread Marek Vasut
On 3/25/25 3:35 PM, Boris Brezillon wrote: On Tue, 25 Mar 2025 14:50:32 +0100 Marek Vasut wrote: On 3/25/25 8:43 AM, Boris Brezillon wrote: On Tue, 25 Mar 2025 00:37:59 +0100 Marek Vasut wrote: On 3/24/25 9:43 AM, Boris Brezillon wrote: [...] @@ -563,6 +585,7 @@ int

Re: [PATCH 6/9] drm/panthor: Reset GPU after L2 cache power off

2025-04-05 Thread Marek Vasut
On 3/3/25 1:42 PM, Boris Brezillon wrote: Hi, This looks like it has been part of a R50 release of the DDK, which is recent enough to consider it up-to-date. The issues you're seeing with fast resume are probably due to some integration issues or other quirks. Boris has the most recent experie

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-03-25 Thread Marek Vasut
On 3/25/25 3:12 PM, Philipp Zabel wrote: On Mo, 2025-03-24 at 20:05 +0100, Marek Vasut wrote: On 3/24/25 9:43 AM, Boris Brezillon wrote: [...] @@ -563,6 +585,7 @@ int panthor_device_suspend(struct device *dev) panthor_devfreq_suspend(ptdev); + reset_control_assert(ptdev->res

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-03-25 Thread Marek Vasut
On 3/25/25 8:43 AM, Boris Brezillon wrote: On Tue, 25 Mar 2025 00:37:59 +0100 Marek Vasut wrote: On 3/24/25 9:43 AM, Boris Brezillon wrote: [...] @@ -563,6 +585,7 @@ int panthor_device_suspend(struct device *dev) panthor_devfreq_suspend(ptdev); + reset_control_assert(ptdev

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-03-25 Thread Marek Vasut
On 3/24/25 9:43 AM, Boris Brezillon wrote: [...] @@ -563,6 +585,7 @@ int panthor_device_suspend(struct device *dev) panthor_devfreq_suspend(ptdev); + reset_control_assert(ptdev->resets); Hm, that might be the cause of the fast reset issue (which is a fast resume more than a fast rese

Re: [PATCH v2 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-03-24 Thread Marek Vasut
On 3/24/25 8:02 AM, Alexander Stein wrote: Hi, @@ -1890,6 +1919,35 @@ netc_emdio: mdio@0,0 { }; }; + gpu_blk_ctrl: reset-controller@4d81 { + compatible = "nxp,imx95-gpu-blk-ctrl"; + reg = <0x0 0x4d81000

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-03-24 Thread Marek Vasut
On 3/24/25 9:43 AM, Boris Brezillon wrote: [...] @@ -563,6 +585,7 @@ int panthor_device_suspend(struct device *dev) panthor_devfreq_suspend(ptdev); + reset_control_assert(ptdev->resets); Hm, that might be the cause of the fast reset issue (which is a fast resume more than a fast rese

[PATCH v2 1/9] dt-bindings: reset: imx95-gpu-blk-ctrl: Document Freescale i.MX95 GPU reset

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in Freescale i.MX95 does require release from reset by writing into a single GPUMIX block controller GPURESET register bit 0. Document support for this reset register. Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor Dooley Cc: David Airlie Cc

[PATCH v2 5/9] drm/panthor: Implement support for multiple power domains

2025-03-21 Thread Marek Vasut
is useful on Freescale i.MX95 which does have two power domains. Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor Dooley Cc: David Airlie Cc: Fabio Estevam Cc: Krzysztof Kozlowski Cc: Liviu Dudau Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Pengutronix Kernel Team Cc: Philipp

[PATCH v2 3/9] dt-bindings: gpu: mali-valhall-csf: Document optional reset

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in Freescale i.MX95 does require release from reset by writing into a single GPUMIX block controller GPURESET register bit 0. Document support for one optional reset. Acked-by: Rob Herring (Arm) Reviewed-by: Frank Li Signed-off-by: Marek Vasut --- Cc: Boris

[PATCH v2 0/9] arm64: dts: imx95: Add support for Mali G310 GPU

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in i.MX95 is the G310. Add support for the GPUMIX reset via simple-reset driver, add reset and multiple power domains support into panthor GPU driver, add iMX95 GPU support into panthor driver and describe the iMX95 GPU in imx95.dtsi DT. Marek Vasut (9): dt

[PATCH v2 4/9] drm/panthor: Implement optional reset

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in Freescale i.MX95 does require release from reset by writing into a single GPUMIX block controller GPURESET register bit 0. Implement support for one optional reset. Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor Dooley Cc: David Airlie Cc

[PATCH v2 2/9] reset: simple: Add support for Freescale i.MX95 GPU reset

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in Freescale i.MX95 does require release from reset by writing into a single GPUMIX block controller GPURESET register bit 0. Implement support for this reset register. Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor Dooley Cc: David Airlie Cc

[PATCH v2 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in i.MX95 is the G310, describe this GPU in the DT. Include description of the GPUMIX block controller, which can be operated as a simple reset. Include dummy GPU voltage regulator and OPP tables. Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor

[PATCH v2 6/9] drm/panthor: Reset GPU after L2 cache power off

2025-03-21 Thread Marek Vasut
This seems necessary on Freescale i.MX95 Mali G310 to reliably resume from runtime PM suspend. Without this, if only the L2 is powered down on RPM entry, the GPU gets stuck and does not indicate the firmware is booted after RPM resume. Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc

[PATCH v2 8/9] drm/panthor: Add i.MX95 support

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in Freescale i.MX95 is the Mali G310, add support for this variant. Reviewed-by: Frank Li Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor Dooley Cc: David Airlie Cc: Fabio Estevam Cc: Krzysztof Kozlowski Cc: Liviu Dudau Cc: Maarten Lankhorst

[PATCH v2 7/9] dt-bindings: gpu: mali-valhall-csf: Document i.MX95 support

2025-03-21 Thread Marek Vasut
The instance of the GPU populated in Freescale i.MX95 is the Mali G310, document support for this variant. Reviewed-by: Alexander Stein Reviewed-by: Frank Li Signed-off-by: Marek Vasut --- Cc: Boris Brezillon Cc: Conor Dooley Cc: David Airlie Cc: Fabio Estevam Cc: Krzysztof Kozlowski Cc

Re: [PATCH 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-03-21 Thread Marek Vasut
On 3/3/25 4:04 PM, Liviu Dudau wrote: [...] + #reset-cells = <1>; + clocks = <&scmi_clk IMX95_CLK_GPUAPB>; + assigned-clocks = <&scmi_clk IMX95_CLK_GPUAPB>; + assigned-clock-parents = <&scmi_clk IMX95_CLK_S

Re: [PATCH 6/9] drm/panthor: Reset GPU after L2 cache power off

2025-03-21 Thread Marek Vasut
On 3/3/25 1:35 PM, Boris Brezillon wrote: Hi, This looks like it has been part of a R50 release of the DDK, which is recent enough to consider it up-to-date. The issues you're seeing with fast resume are probably due to some integration issues or other quirks. Boris has the most recent experie

Re: [PATCH 5/9] drm/panthor: Implement support for multiple power domains

2025-03-03 Thread Marek Vasut
On 2/28/25 11:10 AM, Alexander Stein wrote: Hi, diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c index 51ee9cae94504..4348b7e917b64 100644 --- a/drivers/gpu/drm/panthor/panthor_device.c +++ b/drivers/gpu/drm/panthor/panthor_device.c @@ -75,6 +75,

Re: [PATCH 2/9] reset: simple: Add support for Freescale i.MX95 GPU reset

2025-03-01 Thread Marek Vasut
On 2/28/25 10:58 AM, Alexander Stein wrote: Hi, drivers/reset/reset-simple.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c index 2760678398308..1415a941fd6eb 100644 --- a/drivers/reset/reset-simple.c +++ b/drivers/rese

Re: [PATCH 8/9] drm/panthor: Add i.MX95 support

2025-03-01 Thread Marek Vasut
On 2/28/25 12:23 PM, Florent Tomasin wrote: Hi, diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c index 06fe46e320738..2504a456d45c4 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1591,6 +1591,7 @@ sta

Re: [PATCH 8/9] drm/panthor: Add i.MX95 support

2025-02-28 Thread Marek Vasut
On 2/28/25 11:21 AM, Alexander Stein wrote: Hi, diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c index 0f07ef7d9aea7..2371ab8e50627 100644 --- a/drivers/gpu/drm/panthor/panthor_gpu.c +++ b/drivers/gpu/drm/panthor/panthor_gpu.c @@ -67,6 +67,7 @@ struct

Re: [PATCH 4/9] drm/panthor: Implement optional reset

2025-02-28 Thread Marek Vasut
On 2/28/25 11:06 AM, Alexander Stein wrote: Hi, diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/panthor/panthor_device.c index a9da1d1eeb707..51ee9cae94504 100644 --- a/drivers/gpu/drm/panthor/panthor_device.c +++ b/drivers/gpu/drm/panthor/panthor_device.c @@ -64,6 +64,

Re: [PATCH 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-02-28 Thread Marek Vasut
On 2/28/25 11:36 AM, Alexander Stein wrote: Hi Marek, Hi, diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi index 3af13173de4bd..36bad211e5558 100644 --- a/arch/arm64/boot/dts/freescale/imx95.dtsi +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi @

Re: [PATCH 8/9] drm/panthor: Add i.MX95 support

2025-02-28 Thread Marek Vasut
On 2/28/25 11:33 AM, Marco Felsch wrote: On 25-02-27, Marek Vasut wrote: On 2/27/25 9:17 PM, Marco Felsch wrote: [...] diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c index 06fe46e320738..2504a456d45c4 100644 --- a/drivers/gpu/drm/panthor

Re: [PATCH 6/9] drm/panthor: Reset GPU after L2 cache power off

2025-02-28 Thread Marek Vasut
On 2/28/25 12:06 PM, Liviu Dudau wrote: Hi Marek, Hi, On Thu, Feb 27, 2025 at 05:58:06PM +0100, Marek Vasut wrote: This seems necessary on Freescale i.MX95 Mali G310 to reliably resume from runtime PM suspend. Without this, if only the L2 is powered down on RPM entry, the GPU gets stuck and

Re: [PATCH 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-02-28 Thread Marek Vasut
On 2/28/25 11:39 AM, Alexander Stein wrote: Am Donnerstag, 27. Februar 2025, 23:21:22 CET schrieb Frank Li: On Thu, Feb 27, 2025 at 10:34:20PM +0100, Marek Vasut wrote: On 2/27/25 10:27 PM, Frank Li wrote: [...] + gpu: gpu@4d90 { + compatible = &quo

Re: [PATCH 7/9] dt-bindings: gpu: mali-valhall-csf: Document i.MX95 support

2025-02-28 Thread Marek Vasut
On 2/28/25 1:30 PM, Rob Herring wrote: On Thu, Feb 27, 2025 at 05:58:07PM +0100, Marek Vasut wrote: The instance of the GPU populated in Freescale i.MX95 is the Mali G310, document support for this variant. You should combine patch 4 with this one and make resets required for imx95 since you

Re: [PATCH 1/9] dt-bindings: reset: imx95-gpu-blk-ctrl: Document Freescale i.MX95 GPU reset

2025-02-28 Thread Marek Vasut
On 2/27/25 6:30 PM, Frank Li wrote: [...] +examples: + - | +reset-controller@4d81 { +compatible = "fsl,imx95-gpu-blk-ctrl"; +reg = <0x0 0x4d81 0x0 0xc>; No sure if it pass dt_binding_check, I remember default 32bit address reg = <0x4d81 0xc> +clocks

Re: [PATCH 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-02-27 Thread Marek Vasut
On 2/27/25 10:27 PM, Frank Li wrote: [...] + gpu: gpu@4d90 { + compatible = "fsl,imx95-mali", "arm,mali-valhall-csf"; + reg = <0 0x4d90 0 0x48>; + clocks = <&scmi_clk IMX95_CLK_GPU>; +

  1   2   3   4   5   6   7   8   9   10   >