[PATCH] Revert "drm/virtio: drop prime import/export callbacks"

2019-04-19 Thread Marc-André Lureau
m implementing those stub prime functions, they may return an error at run-time, and it seems to be handled fine by GNOME at least. Please consider a revert. This reverts commit b318e3ff7ca065d6b107e424c85a63d7a6798a69. Cc: Gerd Hoffmann Cc: Dave Airlie Signed-off-by: Marc-André Lureau --- d

virglrenderer regression in commit ad4f0f1941677c

2016-08-01 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: > > Hi, > > > > This commit in virglrenderer causes a regression in Android for me. > > The parameters that get passed in are last_level = 8, width = 1. I'm > > not really sure if this is valid (I'm guessing th

virglrenderer regression in commit ad4f0f1941677c

2016-07-29 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > This commit in virglrenderer causes a regression in Android for me. > The parameters that get passed in are last_level = 8, width = 1. I'm > not really sure if this is valid (I'm guessing there should be some > min width?), or where I should be looking to

[PATCH] virtio-gpu: use src not crtc

2016-06-14 Thread Marc-André Lureau
Hi On Tue, May 31, 2016 at 2:52 PM, Gerd Hoffmann wrote: > Pick up the correct source rectangle from framebuffer. > Without this multihead setups are not working correctly. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau Additionally, I had to modify the page_flip() function

[PATCH 2/2] virtio-gpu: update cursor after scanout

2015-11-13 Thread Marc-André Lureau
It seems appropriate for paravirtual hardware to reset cursor when the resolution changes, that way the cursor is removed if the machine is forcefully rebooted for ex. That's what the QXL/Spice server does. In order for virtio-gpu to work will with the Spice server, set the cursor again after chang

[PATCH 1/2] virtio-gpu: use no-merge for fill-modes

2015-11-13 Thread Marc-André Lureau
Avoid the sticky preferred mode bit by using the no-merge version of the function (this allows gnome-shell to resize to lower resolutions than the default resolution) Signed-off-by: Marc-André Lureau --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 3/4] Add virtio gpu driver.

2015-04-02 Thread Marc-André Lureau
Hi Gerd While doing some testing with your brance, I reached that: On Wed, Apr 1, 2015 at 3:15 PM, Gerd Hoffmann wrote: > +#define MAX_INLINE_CMD_SIZE 96 > [ 750.446449] kernel BUG at drivers/gpu/drm/virtio/virtgpu_vq.c:132! [ 750.447005] Call Trace: [ 750.447005] [] virtio_gpu_alloc_cmd

[PATCH qxl] qxl: don't create too large primary surface

2014-10-27 Thread Marc-André Lureau
ping On Thu, Oct 16, 2014 at 11:39 AM, Marc-André Lureau < marcandre.lureau at gmail.com> wrote: > Limit primary to qemu vgamem size, to avoid reaching > qemu guest bug "requested primary larger than framebuffer" > on resizing screen too large to fit. > > Remove unneeded and misleading variables

[PATCH qxl] qxl: don't create too large primary surface

2014-10-16 Thread Marc-André Lureau
Limit primary to qemu vgamem size, to avoid reaching qemu guest bug "requested primary larger than framebuffer" on resizing screen too large to fit. Remove unneeded and misleading variables. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1127552 Signed-off-by: Marc-Andr? Lureau --- dr

[PATCH] drm: try harder to avoid regression when merging mode bits

2014-03-06 Thread Marc-André Lureau
patch looks ok, and ugly, works for me: Tested-by: Marc-Andr? Lureau Can we get this patch in Fedora asap? thanks On Tue, Jan 14, 2014 at 4:33 AM, Dave Airlie wrote: > From: Dave Airlie > > For QXL hw we really want the bits to be replaced as we change > the preferred mode on the fly, and th

[PATCH 7/7] drm/qxl: fix disabling extra monitors from client

2013-10-18 Thread Marc-André Lureau
To disable a monitor, a Spice client sends a monitor config with the monitor resolution to 0x0. However, before qxl_crtc_disable() is reached after the hotplug event, it can happen that another monitor is reconfigured, and qxl_send_monitors_config() is called with the old config, which will re-ena

[PATCH 6/7] drm/qxl: remove unnecessary check

2013-10-18 Thread Marc-André Lureau
All hard-coded resolutions are passing this check. Signed-off-by: Marc-Andr? Lureau --- drivers/gpu/drm/qxl/qxl_display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 9f33578..4f28060 100644 --- a/drivers/gpu/d

[PATCH 5/7] drm/qxl: prefer the monitor config resolution

2013-10-18 Thread Marc-André Lureau
By default, 1024x768 is the preferred resolution. However, when a monitor config is given, it should be the only preferred resolution. Note that the monitor config resolution is passed to qxl_add_common_modes() to avoid adding a duplicate mode without the preferred resolution. That would discard t

[PATCH 4/7] drm: copy mode type in drm_mode_connector_list_update()

2013-10-18 Thread Marc-André Lureau
In commit 38d5487db7f289be1d56ac7df704ee49ed3213b9, Keith explained: This patch simply merges the two mode type bits together; that seems reasonable to me, but perhaps only a subset of the bits should be used? None of these can be user defined as they all come from looking at just t

[PATCH 3/7] drm/qxl: notify that the monitor config changed

2013-10-18 Thread Marc-André Lureau
drm_helper_hpd_irq_event() only notifies when the connector status changed. However, Spice monitor config can change while the connector is connected, to support arbitrary resolution. Do an hotplug event if it wasn't done by drm_helper_hpd_irq_event(). Signed-off-by: Marc-Andr? Lureau --- driver

[PATCH 2/7] drm: return if changed in drm_helper_hpd_irq_event()

2013-10-18 Thread Marc-André Lureau
The caller may want to know whether the configuration was changed, and if an hotplug event was sent. Signed-off-by: Marc-Andr? Lureau --- drivers/gpu/drm/drm_crtc_helper.c | 6 -- include/drm/drm_crtc_helper.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 1/7] drm: fix a small spelling

2013-10-18 Thread Marc-André Lureau
Fix a little spelling of drm_crtc_convert_umode() comment. Signed-off-by: Marc-Andr? Lureau --- drivers/gpu/drm/drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index fc83bb9..3729fb2 100644 --- a/drivers/gpu/d