[PATCH V3 1/4] drm/vkms/crc: Implement verify_crc_source callback

2018-08-21 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Changes Since V2: - don't return early from set_crc_source to keep behavior same (Haneen) Cc: Haneen Mohammed Signed-off-by: Mahesh

[PATCH V2 4/4] drm/crc: add pre_crc_read function

2018-08-21 Thread Mahesh Kumar
This patch implements a callback function which will be called before crc read. In this function driver can implement any preparation work required for successfully reading CRC data. Changes Since V1: - rebase Cc: dri-devel@lists.freedesktop.org Signed-off-by: Mahesh Kumar --- drivers/gpu/drm

[PATCH V4 3/4] Revert "drm: crc: Wait for a frame before returning from open()"

2018-08-21 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH V5 2/4] drm/crc: Cleanup crtc_crc_open function

2018-08-21 Thread Mahesh Kumar
. Changes since V1: - refactor code to use single spin lock Changes since V2: - rebase Changes since V3: - rebase on top of VKMS driver Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Haneen Mohammed Reviewed-by: Maarten Lankhorst (V2) Acked-by: Leo Li

[PATCH 0/4] Improve crc-core driver interface

2018-08-21 Thread Mahesh Kumar
leanup of crtc_crc_open function first allocate memory before enabling CRC generation - Don't block open() call instead wait in crc read call. Changes: - Rebase on top of VKMS driver - Include pre_crc_read patch Cc: dri-devel@lists.freedesktop.org Mahesh Kumar (4): drm/vkms/crc

[PATCH v5 2/3] drm/crc: Cleanup crtc_crc_open function

2018-08-13 Thread Mahesh Kumar
. Changes since V1: - refactor code to use single spin lock Changes since V2: - rebase Changes since V3: - rebase on top of VKMS driver Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Haneen Mohammed Reviewed-by: Maarten Lankhorst (V2) Acked-by: Leo Li

[PATCH v5 0/3] Improve crc-core driver interface

2018-08-13 Thread Mahesh Kumar
ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and may need inputs Changes: - Rebase on top of VKMS driver Cc: dri-devel@lists.freedesktop.org Mahes

[PATCH v1 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Cc: dri-devel@lists.freedesktop.org Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/vkms/vkms_crc.c | 36 drivers/gpu/drm/vkms/vkms_c

[PATCH v4 3/3] Revert "drm: crc: Wait for a frame before returning from open()"

2018-08-13 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH V6 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

2018-08-08 Thread Mahesh Kumar
Laurent Pinchart Changes Since V3/4/5: (Laurent Pinchart review) - s/rcar_du_crtc_crc_sources_list_init/rcar_du_crtc_crc_init - s/rcar_du_crtc_crc_sources_list_uninit/rcar_du_crtc_crc_cleanup - other cleanup Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart

[PATCH v5 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

2018-07-23 Thread Mahesh Kumar
Laurent Pinchart Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 85 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 ++ 2 files changed, 87 insertions(+), 1 deletion(-) diff --git a

[PATCH v5 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-23 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Changes Since V2: - further optimize the code Changes Since V3: - Adopt to driver style - Address review comments from Laurent Pinchart Signed-off-by: Ma

[PATCH v4 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Changes Since V2: - further optimize the code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten

[PATCH v4 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers

[PATCH v4 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-13 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH v4 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-13 Thread Mahesh Kumar
. Changes since V1: - refactor code to use single spin lock Changes since V2: - rebase Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Acked-by: Leo Li Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH v4 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
e callback description Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/drm_debugfs_crc.c | 8 include/drm/drm_crtc.h| 16 2 files changed, 24

[PATCH v4 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/a

[PATCH v4 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-13 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers

[PATCH 00/10] Improve crc-core driver interface

2018-07-13 Thread Mahesh Kumar
ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and may need inputs Cc: dri-devel@lists.freedesktop.org Mahesh Kumar (10): drm: crc: Introduce verify_crc

[PATCH v4 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/dr

[PATCH v4 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-13 Thread Mahesh Kumar
the number of source in the list. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Changes Since V2: - update commit message - update callback documentation - print one source name per line Signed-off-by: Mahesh Kumar Cc:

[PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-12 Thread Mahesh Kumar
. Changes since V1: - refactor code to use single spin lock Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm

[PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers

[PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-12 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_c

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
the number of source in the list. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Changes Since V2: - update commit message - update callback documentation - print one source name per line Signed-off-by: Mahesh Kumar Cc:

[PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/dr

[PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/a

[PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-12 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-12 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar Cc:

[PATCH 00/10] Improve crc-core driver interface

2018-07-12 Thread Mahesh Kumar
ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and need inputs Cc: dri-devel@lists.freedesktop.org Mahesh Kumar (10): drm: crc: Introduce verify_crc

[PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-11 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-11 Thread Mahesh Kumar
. Changes since V1: - refactor code to use single spin lock Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm

[PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_c

[PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/a

[PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers

[PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-11 Thread Mahesh Kumar
the number of source in the list. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Changes Since V2: - update commit message - update callback documentation - print one source name per line Signed-off-by: Mahesh Kumar Cc:

[PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/dr

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-11 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar Cc:

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node and while opening data node for crc reading. This will help in avoiding setting of wrong string for source. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freed

[PATCH 00/10] Improve crc-core driver interface

2018-07-02 Thread Mahesh Kumar
tant pointer to an array of source list and crc-core does the verification Changes rev3: - reorg patches to push non r-b patches to the last - add r-b tag Cc: dri-devel@lists.freedesktop.org Mahesh Kumar (10): drm: crc: Introduce verify_crc_source callback drm: crc: Introduce get_crc_sources

[PATCH 10/10] drm: crc: Introduce pre_crc_read function

2018-07-02 Thread Mahesh Kumar
This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drive

[PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++ 1 file changed, 40

[PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-02 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-02 Thread Mahesh Kumar
. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +- drivers/gpu/drm/drm_debugfs_crc.c | 52

[PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers

[PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-02 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers

[PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/a

[PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-02 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rockchip/rockchip_drm_

[PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-02 Thread Mahesh Kumar
. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/drm_debugfs_crc.c | 20 +++- include/drm/

[PATCH 09/10] drm/crc: Cleanup crtc_crc_open function

2018-06-27 Thread Mahesh Kumar
. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +- drivers/gpu/drm/drm_debugfs_crc.c | 52 +- drivers/gpu/drm/i915

[PATCH 07/10] drm/i915/crc: implement verify_crc_source callback

2018-06-27 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_pipe_crc.c

[PATCH 05/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-06-27 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 drivers/g

[PATCH 10/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-06-27 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH 04/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-06-27 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 20 1 fi

[PATCH 08/10] drm/i915/crc: implement get_crc_sources callback

2018-06-27 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/intel_display.c

[PATCH 06/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-06-27 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drive

[PATCH 03/10] drm: crc: Introduce get_crc_sources callback

2018-06-27 Thread Mahesh Kumar
. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_debugfs_crc.c | 20 +++- include/drm/drm_crtc.h

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-06-27 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node and while opening data node for crc reading. This will help in avoiding setting of wrong string for source. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freed

[PATCH 00/10] Improve crc-core driver interface

2018-06-27 Thread Mahesh Kumar
tant pointer to an array of source list and crc-core does the verification Cc: dri-devel@lists.freedesktop.org Mahesh Kumar (10): drm: crc: Introduce verify_crc_source callback drm: crc: Introduce pre_crc_read function drm: crc: Introduce get_crc_sources callback drm/rockchip/crc: Implement

[PATCH 02/10] drm: crc: Introduce pre_crc_read function

2018-06-27 Thread Mahesh Kumar
This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drive

[PATCH 06/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-06-25 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drive

[PATCH 10/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-06-25 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[PATCH 09/10] drm/crc: Cleanup crtc_crc_open function

2018-06-25 Thread Mahesh Kumar
. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +- drivers/gpu/drm/drm_debugfs_crc.c | 52 +- drivers/gpu/drm/i915/intel_drv.h

[PATCH 07/10] drm/i915/crc: implement verify_crc_source callback

2018-06-25 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_pipe_crc.c

[PATCH 04/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-06-25 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drive

[PATCH 05/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-06-25 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 drivers/g

[PATCH 02/10] drm: crc: Introduce pre_crc_read function

2018-06-25 Thread Mahesh Kumar
This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drive

[PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-06-25 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node and while opening data node for crc reading. This will help in avoiding setting of wrong string for source. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freed

[PATCH 03/10] drm: crc: Introduce get_crc_sources callback

2018-06-25 Thread Mahesh Kumar
Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_debugfs_crc.c | 3 +++ include/drm/drm_crtc.h| 10 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 2b

Re: drivers/gpu/drm/i915/intel_pm.c:4467: bad comparison ?

2017-07-17 Thread Mahesh Kumar
Hi, On Monday 17 July 2017 04:01 PM, Maarten Lankhorst wrote: Op 17-07-17 om 12:32 schreef Mahesh Kumar: Hi, On Monday 17 July 2017 03:22 PM, Jani Nikula wrote: On Mon, 17 Jul 2017, David Binderman wrote: Hello there, Hello. No need to include LKML for stuff like this. But Cc'

Re: drivers/gpu/drm/i915/intel_pm.c:4467: bad comparison ?

2017-07-17 Thread Mahesh Kumar
Hi, On Monday 17 July 2017 03:22 PM, Jani Nikula wrote: On Mon, 17 Jul 2017, David Binderman wrote: Hello there, Hello. No need to include LKML for stuff like this. But Cc'd the folks from the broken commit. drivers/gpu/drm/i915/intel_pm.c:4467]: (warning) Comparison of a boolean expressi