Re: [PATCH v5 01/10] gna: add PCI driver module

2022-10-24 Thread Maciej Kwapulinski
On 10/21/2022 6:20 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 20, 2022 at 07:53:25PM +0200, Maciej Kwapulinski wrote: >> Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator > Please drop all of the (R) stuff in here, and in the Kconfig file and in > the .c file

Re: [PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator

2022-10-24 Thread Maciej Kwapulinski
On 10/21/2022 6:17 AM, Greg Kroah-Hartman wrote: > On Thu, Oct 20, 2022 at 07:53:24PM +0200, Maciej Kwapulinski wrote: >> Dear kernel maintainers, > > > This really is v6, not v5, right? Why send 2 v5 out? > > greg k-h what do you mean?

Re: [PATCH v5 07/10] gna: add GNA_COMPUTE ioctl

2022-10-22 Thread Maciej Kwapulinski
On 10/21/2022 11:30 AM, Linus Walleij wrote: > Hi Maciej, Hi Walleij > > thanks for your patch! > > On Thu, Oct 20, 2022 at 7:57 PM Maciej Kwapulinski > wrote: > >> From: Tomasz Jankowski >> >> This is the ioctl context part of score request + "do

Re: [PATCH v5 07/10] gna: add GNA_COMPUTE ioctl

2022-10-22 Thread Maciej Kwapulinski
On 10/21/2022 1:52 PM, Maciej Kwapulinski wrote: > On 10/21/2022 11:30 AM, Linus Walleij wrote: >> Hi Maciej, > Hi Walleij oo sorry,  hi Linus I should say

[PATCH v5 06/10] gna: add GNA_GEM_NEW and GNA_GEM_FREE ioctls

2022-10-21 Thread Maciej Kwapulinski
drm_gem_shmem_object is base for memory objects provided by the patch Signed-off-by: Maciej Kwapulinski Tested-by: Mikolaj Grzybowski --- drivers/gpu/drm/gna/Kconfig | 1 + drivers/gpu/drm/gna/gna_device.c | 27 +++- drivers/gpu/drm/gna/gna_device.h | 13 ++ drivers/gpu/drm

[PATCH v5 00/10] Driver of Intel(R) Gaussian & Neural Accelerator

2022-10-21 Thread Maciej Kwapulinski
- GNA memory objects use ~drm_gem_shmem_object~ objects as a base - patches reorganized to meet symbols' usage with their declarations/definitions - 'recovery_timeout' module parameter removed - number of other/minor fixes from v3 review - tests performed on kernel v6.0 v4

[PATCH v5 05/10] gna: add GNA_GET_PARAMETER ioctl

2022-10-21 Thread Maciej Kwapulinski
From: Tomasz Jankowski As this is first ioctl in the series, the patch also adds common bits for remaining ioctls Signed-off-by: Tomasz Jankowski Tested-by: Mikolaj Grzybowski Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by

[PATCH v5 10/10] gna: add open and close operations on GNA device

2022-10-21 Thread Maciej Kwapulinski
From: Tomasz Jankowski Signed-off-by: Tomasz Jankowski Tested-by: Mikolaj Grzybowski Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/gpu/drm/gna/gna_device.c | 46

Re: [PATCH v4 01/10] gna: add PCI driver module

2022-10-21 Thread Maciej Kwapulinski
On 10/20/2022 4:09 PM, Matthew Wilcox wrote: > On Thu, Oct 20, 2022 at 03:35:16PM +0200, Kwapulinski, Maciej wrote: >> +++ b/drivers/gpu/drm/gna/Kconfig >> @@ -0,0 +1,12 @@ >> +# >> +# Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA) >> +# >> + >> +config DRM_GNA >> +tristate "Intel(R) G

[PATCH v5 01/10] gna: add PCI driver module

2022-10-21 Thread Maciej Kwapulinski
Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator with basic support like module loading and unloading. The full function of the driver will be added by further changes. Signed-off-by: Maciej Kwapulinski Tested-by: Mikolaj Grzybowski Co-developed-by: Tomasz Jankowski Signed

[PATCH v5 09/10] gna: add power management

2022-10-21 Thread Maciej Kwapulinski
Implement power management in GNA driver Signed-off-by: Maciej Kwapulinski Tested-by: Mikolaj Grzybowski Co-developed-by: Tomasz Jankowski Signed-off-by: Tomasz Jankowski Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang --- drivers/gpu/drm/gna/gna_device.c | 47

[PATCH v5 08/10] gna: add GNA_WAIT ioctl

2022-10-21 Thread Maciej Kwapulinski
Jankowski Tested-by: Mikolaj Grzybowski Co-developed-by: Anisha Dattatraya Kulkarni Signed-off-by: Anisha Dattatraya Kulkarni Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/gpu/drm/gna/Kbuild

[PATCH v5 04/10] gna: initialize MMU

2022-10-21 Thread Maciej Kwapulinski
From: Tomasz Jankowski Setup MMU in the driver with a new memory component. Signed-off-by: Tomasz Jankowski Tested-by: Mikolaj Grzybowski Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/gpu/drm

[PATCH v5 02/10] gna: add GNA DRM device

2022-10-21 Thread Maciej Kwapulinski
Signed-off-by: Maciej Kwapulinski Tested-by: Mikolaj Grzybowski --- drivers/gpu/drm/gna/Kconfig | 1 + drivers/gpu/drm/gna/gna_device.c | 65 drivers/gpu/drm/gna/gna_device.h | 21 +++ drivers/gpu/drm/gna/gna_hw.h | 17 + drivers/gpu

[PATCH v5 03/10] gna: read hardware info

2022-10-21 Thread Maciej Kwapulinski
From: Tomasz Jankowski Get the hardware information from register MMIO_IBUFFS Signed-off-by: Tomasz Jankowski Tested-by: Mikolaj Grzybowski Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/gpu

Re: [PATCH v4 01/10] gna: add PCI driver module

2022-10-21 Thread Maciej Kwapulinski
On 10/20/2022 4:32 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 20, 2022 at 03:35:16PM +0200, Kwapulinski, Maciej wrote: >> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata >> i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej >> wiadomosci, prosim

Re: [PATCH v4 01/10] gna: add PCI driver module

2022-10-21 Thread Maciej Kwapulinski
On 10/20/2022 8:00 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 20, 2022 at 06:11:49PM +0200, Maciej Kwapulinski wrote: >> On 10/20/2022 4:32 PM, Greg Kroah-Hartman wrote: >>> On Thu, Oct 20, 2022 at 03:35:16PM +0200, Kwapulinski, Maciej wrote: >>>> Ta wiad

[PATCH v5 07/10] gna: add GNA_COMPUTE ioctl

2022-10-21 Thread Maciej Kwapulinski
Signed-off-by: Anisha Dattatraya Kulkarni Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/gpu/drm/gna/Kbuild| 2 +- drivers/gpu/drm/gna/gna_device.c | 33 +++ drivers/gpu/drm/gna/gna_devic

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

2022-06-21 Thread maciej . kwapulinski
On Wed, 16 Jun 2021 09:38:14 +0200, Maciej Kwapulinski wrote: > after consulting, we will try to share api and some kernel code > between the two drivers. We prepared a prototype work based on Daniel Vetter’s invitation to evaluate DRM framework as prospective fit. Early results look

Re: [PATCH v3 00/14] Driver of Intel(R) Gaussian & Neural Accelerator

2022-06-21 Thread Maciej Kwapulinski
Greg KH writes: > On Mon, Jun 20, 2022 at 11:49:07AM +0200, maciej.kwapulin...@linux.intel.com > wrote: >> Please share your thoughts. > > No code here to share thoughts about :( code will be published in comming weeks to dri-devel ML