[PATCH] accel/ivpu: Fix the D0i2 disable test mode

2025-04-16 Thread Maciej Falkowski
From: Andrzej Kacprowski Correct setup of D0i2 disable which was by mistake set up to value 1 and use BIT(1) instead. Fixes: 011529fe8112 ("accel/ivpu: Implement D0i2 disable test mode") Signed-off-by: Andrzej Kacprowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivp

[PATCH] accel/ivpu: Correct DCT interrupt handling

2025-04-16 Thread Maciej Falkowski
. Fixes: a19bffb10c46 ("accel/ivpu: Implement DCT handling") Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_hw_btrs.h | 2 +- drivers/accel/ivpu/ivpu_pm.c | 18 ++ 2 files changed, 11 insertions(+), 9 deletions(-) di

[PATCH] accel/ivpu: Implement heartbeat-based TDR mechanism

2025-04-16 Thread Maciej Falkowski
: Maciej Falkowski --- drivers/accel/ivpu/ivpu_drv.c | 4 drivers/accel/ivpu/ivpu_drv.h | 1 + drivers/accel/ivpu/ivpu_fw.h | 1 + drivers/accel/ivpu/ivpu_pm.c | 20 4 files changed, 26 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu

[PATCH 2/2] accel/ivpu: Show NPU frequency in sysfs

2025-04-04 Thread Maciej Falkowski
From: Andrzej Kacprowski Add sysfs files that show maximum and current frequency of the NPU's data processing unit. New sysfs entries: - npu_max_frequency_mhz - npu_current_frequency_mhz Signed-off-by: Andrzej Kacprowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu

[PATCH] accel/ivpu: Add cmdq_id to job related logs

2025-04-01 Thread Maciej Falkowski
From: Karol Wachowski Add tracking of command queue ID in JOB debug message to improve debugging capabilities. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_job.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a

[PATCH 1/2] accel/ivpu: Fix the NPU's DPU frequency calculation

2025-04-01 Thread Maciej Falkowski
remove CPU frequency calculation code. Show NPU frequency in FREQ_CHANGE interrupt when frequency tracking is enabled. Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code") Cc: # v6.11+ Signed-off-by: Andrzej Kacprowski Signed-off-by: Maciej Falkowski --- drivers/

[PATCH 0/2] accel/ivpu: Expose NPU frequency into userspace

2025-04-01 Thread Maciej Falkowski
This patchset introduces the capability to measure the NPU frequency and makes it accessible to a userspace via sysfs. The initial patch in the series addresses the inconsistency in retrieving the clock frequency from the device across the Meteor Lake and Lunar Lake generations. Subsequently, the

[PATCH] accel/ivpu: Update FW Boot API to version 3.28.3

2025-04-01 Thread Maciej Falkowski
From: Karol Wachowski This commit bumps FW Boot API to 3.28.3. Use new preemption buffer size fields from FW header added to firmware boot API for preemption buffers allocations, if those new fields are zeroed use old values instead. Signed-off-by: Karol Wachowski Signed-off-by: Maciej

[PATCH] accel/ivpu: Flush pending jobs of device's workqueues

2025-04-01 Thread Maciej Falkowski
Use flush_work() instead of cancel_work_sync() for driver workqueues to guarantee that remaining pending work will be handled. Fixes: bc3e5f48b7ee ("accel/ivpu: Use workqueue for IRQ handling") Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_drv.c | 6 +++--- 1 file

[PATCH 0/2] PM fixes in Metric Steamer code

2025-03-25 Thread Maciej Falkowski
This patches contains two fixes for Metric Stream: - Fix deadlock that may occur when executing runtime resume during cold boot where ms_lock will be already held there, - Fix warning to warn for suspend status only if the runtime PM is enabled. Jacek Lawrynowicz (2): accel/ivpu:

[PATCH 1/2] accel/ivpu: Fix deadlock in ivpu_ms_cleanup()

2025-03-25 Thread Maciej Falkowski
ck and causes the deadlock. Fixes: cdfad4db7756 ("accel/ivpu: Add NPU profiling support") Cc: # v6.11+ Signed-off-by: Jacek Lawrynowicz Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_ms.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/accel/ivpu/ivp

[PATCH 2/2] accel/ivpu: Fix PM related deadlocks in MS IOCTLs

2025-03-25 Thread Maciej Falkowski
Cc: # v6.11+ Signed-off-by: Jacek Lawrynowicz Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_debugfs.c | 4 ++-- drivers/accel/ivpu/ivpu_ms.c | 18 ++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_debugfs.c b/drive

[PATCH] accel/ivpu: Fix warning in ivpu_ipc_send_receive_internal()

2025-03-25 Thread Maciej Falkowski
esume") Cc: # v6.13+ Signed-off-by: Jacek Lawrynowicz Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_ipc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c index 0e096fd9b95d..39f83225c181 10

[PATCH 02/14] accel/ivpu: Add API for command queue create/destroy/submit

2025-01-07 Thread Maciej Falkowski
From: Karol Wachowski Implement support for explicit command queue management. To allow more flexible control over command queues add capabilities to create, destroy and submit jobs to specific command queues. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel

[PATCH 11/14] accel/ivpu: Fix locking order in ivpu_job_submit

2025-01-07 Thread Maciej Falkowski
priv_release() lock(&vdev->context_list_lock) lock(&file_priv->lock) #2 This order of locking causes a deadlock. To resolve this issue, change the order of locking in ivpu_job_submit(). Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski ---

[PATCH 05/14] accel/ivpu: Use workqueue for IRQ handling

2025-01-07 Thread Maciej Falkowski
: Maciej Falkowski --- drivers/accel/ivpu/ivpu_drv.c | 39 --- drivers/accel/ivpu/ivpu_drv.h | 5 +++- drivers/accel/ivpu/ivpu_hw.c | 5 drivers/accel/ivpu/ivpu_hw.h | 9 --- drivers/accel/ivpu/ivpu_hw_btrs.c | 3 +-- drivers/accel/ivpu

[PATCH 00/14] accel/ivpu: Changes for 6.14

2025-01-07 Thread Maciej Falkowski
: Add platform detection for presilicon Maciej Falkowski (2): accel/ivpu: Expose NPU memory utilization info in sysfs accel/ivpu: Use workqueue for IRQ handling drivers/accel/ivpu/ivpu_drv.c | 88 ++-- drivers/accel/ivpu/ivpu_drv.h | 10 +- drivers/accel/ivpu

[PATCH 13/14] accel/ivpu: Add platform detection for presilicon

2025-01-07 Thread Maciej Falkowski
From: Karol Wachowski Use highest buttress VPU_STATUS register bits(15:13) that encode platform type as follows: 0 - Silicon 2 - Simics 3 - FPGA 4 - Hybrid SLE Remove old DMI based method. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski

[PATCH 06/14] accel/ivpu: Dump only first MMU fault from single context

2025-01-07 Thread Maciej Falkowski
s. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_mmu.c | 51 --- drivers/accel/ivpu/ivpu_mmu_context.c | 13 --- drivers/accel/ivpu/ivpu_mmu_context.h | 2 -- 3 files changed, 46 insertions(+), 20 deletions(-) di

[PATCH 08/14] accel/ivpu: Fix missing MMU events from reserved SSID

2025-01-07 Thread Maciej Falkowski
default NPU HW setting. Such situation will occur if FW freed context related resources but still performed access to DRAM. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_mmu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a

[PATCH 14/14] accel/ivpu: Enable HWS by default on all platforms

2025-01-07 Thread Maciej Falkowski
From: Jacek Lawrynowicz Enable HWS on selected platforms if FW API version is above 3.19. Signed-off-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_fw.c | 13 - 1 file changed, 12 insertions(+), 1 deletion

[PATCH 04/14] accel/ivpu: Expose NPU memory utilization info in sysfs

2025-01-07 Thread Maciej Falkowski
Expose NPU memory utilization info in sysfs in bytes to show total memory used by NPU (FW + runtime). Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_sysfs.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/accel/ivpu

[PATCH 12/14] accel/ivpu: Add handling of VPU_JSM_STATUS_MVNCI_CONTEXT_VIOLATION_HW

2025-01-07 Thread Maciej Falkowski
. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_job.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_job.c b/drivers/accel/ivpu/ivpu_job.c index c93ea37062d7..3c162ac41a1d 100644 --- a/drivers/accel

[PATCH 01/14] accel/ivpu: Separate DB ID and CMDQ ID allocations from CMDQ allocation

2025-01-07 Thread Maciej Falkowski
From: Karol Wachowski Move doorbell ID and command queue ID XArray allocations from command queue memory allocation function. This will allows IDs allocations to be done without the need for actual memory allocation. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers

[PATCH 10/14] accel/ivpu: Fix locking order in ivpu_cmdq_destroy_ioctl

2025-01-07 Thread Maciej Falkowski
nction which locks submitted_jobs_lock. That way locking order is maintained: 1) global submitted_jobs_lock first 2) per context file_priv->lock second Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_job.c | 9 ++--- 1 file changed, 6 inserti

[PATCH 09/14] accel/ivpu: Set command queue management capability based on HWS

2025-01-07 Thread Maciej Falkowski
not support all required functionalities for correct command queue management with OS scheduling. Return -ENODEV from command queue create/destroy/submit IOCTLs. Remove is_valid field from struct ivpu_job_cmdq Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu

[PATCH 07/14] accel/ivpu: Move parts of MMU event IRQ handling to thread handler

2025-01-07 Thread Maciej Falkowski
rd) bit from context descriptor to ensure no more faults are recorded until that context is destroyed Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_job.c | 7 ++- drivers/accel/ivpu/ivpu_mmu.c | 93 +++ drivers/accel/

[PATCH 03/14] accel/ivpu: Abort all jobs after command queue unregister

2025-01-07 Thread Maciej Falkowski
of a specific context results in context release. Signed-off-by: Karol Wachowski Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_drv.c | 32 ++-- drivers/accel/ivpu/ivpu_drv.h | 2 + drivers/accel/ivpu/ivpu_job.c | 137 drivers/accel

[PATCH 2/2] accel/ivpu: Update power island delays

2024-10-04 Thread Maciej Falkowski
From: "Wachowski, Karol" Apply Hardware Architecture Specification compatible delays for main island power delivery for 50xx and above. Signed-off-by: Wachowski, Karol Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_hw_40xx_reg.h | 2 ++ drivers/accel/ivpu/iv

[PATCH 1/2] accel/ivpu: Add initial Panther Lake support

2024-10-04 Thread Maciej Falkowski
Add support for the 5th generation of Intel NPU that is going to be present in PTL_P (Panther Lake) CPUs. NPU5 code reuses almost all of previous driver code. Signed-off-by: Maciej Falkowski --- drivers/accel/ivpu/ivpu_drv.c | 1 + drivers/accel/ivpu/ivpu_drv.h | 10 +++--- drivers/accel

[PATCH 0/2] accel/ivpu: Intel NPU Panther Lake support

2024-10-04 Thread Maciej Falkowski
This patchset adds initial support for 5th generation Intel NPU that is going to be present in the upcoming Panther Lake CPUs. Maciej Falkowski (1): accel/ivpu: Add initial Panther Lake support Wachowski, Karol (1): accel/ivpu: Update power island delays drivers/accel/ivpu/ivpu_drv.c

Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Scaler to dt-schema

2019-09-26 Thread Maciej Falkowski
On 9/26/19 5:35 PM, Rob Herring wrote: > On Thu, Sep 26, 2019 at 9:47 AM Maciej Falkowski > wrote: >> >> On 9/26/19 4:03 PM, Krzysztof Kozlowski wrote: >>> On Thu, Sep 26, 2019 at 02:56:14PM +0200, Marek Szyprowski wrote: >>>> From: Maciej Falkowski &g

Re: [PATCH v2] dt-bindings: gpu: Convert Samsung Image Scaler to dt-schema

2019-09-26 Thread Maciej Falkowski
On 9/26/19 4:03 PM, Krzysztof Kozlowski wrote: > On Thu, Sep 26, 2019 at 02:56:14PM +0200, Marek Szyprowski wrote: >> From: Maciej Falkowski >> >> Convert Samsung Image Scaler to newer dt-schema format. >> >> Signed-off-by: Maciej Falkowski >> Signed

[PATCH v3] dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

2019-09-17 Thread Maciej Falkowski
Convert Samsung Image Rotator to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- v3: - remove unneded comments and descriptions - remove unneded maxItems field from clock-names property --- .../bindings/gpu/samsung-rotator.txt | 28

[PATCH] dt-bindings: gpu: Convert Samsung Image Scaler to dt-schema

2019-09-13 Thread Maciej Falkowski
Convert Samsung Image Scaler to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- .../bindings/gpu/samsung-scaler.txt | 27 - .../bindings/gpu/samsung-scaler.yaml | 57 +++ 2 files changed, 57 insertions

[PATCH v2] dt-bindings: gpu: Convert Samsung Image Rotator to dt-schema

2019-09-12 Thread Maciej Falkowski
Convert Samsung Image Rotator to newer dt-schema format. Signed-off-by: Maciej Falkowski Signed-off-by: Marek Szyprowski --- v2: - add required properties - add proper commit recipients --- .../bindings/gpu/samsung-rotator.txt | 28 -- .../bindings/gpu/samsung-rotator.yaml