Re: BUG [RESEND][NEW BUG]: kernel NULL pointer dereference, address: 0000000000000008

2024-01-24 Thread Ma, Jun
Hi Mirsad, On 1/25/2024 1:48 AM, Mirsad Todorovac wrote: > Hi, Ma Jun, > > Normally, I would reply under the quoted text, but I will adjust to your > convention. > > I have just discovered that your patch causes Ubuntu 22.04 LTS GNOME XWayland > session > to bloc

Re: BUG [RESEND]: kernel NULL pointer dereference, address: 0000000000000008

2024-01-22 Thread Ma, Jun
Perhaps similar to the problem I encountered earlier, you can try the following patch https://lists.freedesktop.org/archives/amd-gfx/2024-January/103259.html Regards, Ma Jun On 1/21/2024 3:54 AM, Mirsad Todorovac wrote: > Hi, > > The last email did not pass to the most of the recipien

[PATCH] drm/buddy: Fix drm buddy info output format

2023-08-03 Thread Ma Jun
[1] Change pages to blocks to avoid confusion. [2] Fix output format to align the output info. Signed-off-by: Ma Jun --- drivers/gpu/drm/drm_buddy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c index

Re: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-31 Thread Ma, Jun
On 5/31/2023 4:45 PM, Christian König wrote: > Am 31.05.23 um 08:20 schrieb Chen, Guchun: >> [Public] >> >>> -Original Message- >>> From: amd-gfx On Behalf Of Ma >>> Jun >>> Sent: Wednesday, May 31, 2023 1:31 PM >>> To: am

Re: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-31 Thread Ma, Jun
On 5/31/2023 2:20 PM, Chen, Guchun wrote: > [Public] > >> -Original Message- >> From: amd-gfx On Behalf Of Ma >> Jun >> Sent: Wednesday, May 31, 2023 1:31 PM >> To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Koenig, >> Chr

[PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-30 Thread Ma Jun
Remove redundant assignment code for ttm->caching as it's overwritten just a few lines later. v2: - Update the commit message. Signed-off-by: Ma Jun --- drivers/gpu/drm/ttm/ttm_tt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/

Re: [PATCH] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-30 Thread Ma, Jun
On 5/30/2023 4:59 PM, Christian König wrote: > Am 29.05.23 um 11:28 schrieb Ma Jun: >> Remove redundant assignment code for ttm->caching > > The explanation is missing why this is redundant, e.g. something like > "this is overwritten just a few lines later"

[PATCH] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-29 Thread Ma Jun
Remove redundant assignment code for ttm->caching Signed-off-by: Ma Jun --- drivers/gpu/drm/ttm/ttm_tt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 02b812dacc5d..45a44544b656 100644 --- a/drivers/gpu/drm/ttm/ttm_t

Re: [PATCH 1/2] drm/ttm: Check ttm_debugfs_root before creating files under it

2023-01-15 Thread Ma, Jun
On 1/13/2023 5:37 PM, Christian König wrote: > Am 13.01.23 um 06:34 schrieb Ma Jun: >> Check the ttm_debugfs_root before creating files under it. >> If the ttm_debugfs_root is NULL, all the files created for >> ttm/ will be placed in the /sys/kerne/debug/ but not >

Re: [PATCH 2/2] drm/ttm: Use debugfs_remove_recursive to remove ttm directory

2023-01-15 Thread Ma, Jun
On 1/13/2023 5:38 PM, Christian König wrote: > Am 13.01.23 um 06:34 schrieb Ma Jun: >> Use debugfs_remove_recursive to remove the /sys/kernel/debug/ttm >> directory for better compatibility. Becuase debugfs_remove fails >> on older kernel. > > Again NAK for ups

[PATCH 2/2] drm/ttm: Use debugfs_remove_recursive to remove ttm directory

2023-01-12 Thread Ma Jun
Use debugfs_remove_recursive to remove the /sys/kernel/debug/ttm directory for better compatibility. Becuase debugfs_remove fails on older kernel. Signed-off-by: Ma Jun --- drivers/gpu/drm/ttm/ttm_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm

[PATCH 1/2] drm/ttm: Check ttm_debugfs_root before creating files under it

2023-01-12 Thread Ma Jun
Check the ttm_debugfs_root before creating files under it. If the ttm_debugfs_root is NULL, all the files created for ttm/ will be placed in the /sys/kerne/debug/ but not /sys/kernel/debug/ttm/ Signed-off-by: Ma Jun --- drivers/gpu/drm/ttm/ttm_device.c | 3 ++- drivers/gpu/drm/ttm/ttm_pool.c

[PATCH V2] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-15 Thread Ma Jun
Add the missing declaration of struct drm_atomic_state to fix the compile error below: error: 'struct drm_atomic_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Signed-off-by: Ma Jun --- include/drm/drm_plane_helper.h | 1

Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-15 Thread Ma, Jun
On 12/15/2022 4:40 PM, Thomas Zimmermann wrote: > Hi > > Am 15.12.22 um 04:01 schrieb Ma Jun: >> Add the missing declaration of struct drm_atomic_state to fix the >> compile error below: >> >> error: 'struct drm_atomic_state' declared inside param

[RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-14 Thread Ma Jun
Add the missing declaration of struct drm_atomic_state to fix the compile error below: error: 'struct drm_atomic_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] Signed-off-by: Ma Jun --- include/drm/drm_plane_helper.h | 1

[PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state

2022-12-07 Thread Ma Jun
Add the missing declaration of struct drm_atomic_state Signed-off-by: Ma Jun --- include/drm/drm_plane_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h index b00ad36cf5b6..530f88176db4 100644 --- a/include/drm

Re: Coverity: kfd_parse_subtype_cache(): Memory - corruptions

2022-11-06 Thread Ma, Jun
Thanks, I will send the fix patch. Regards, Ma Jun On 11/5/2022 4:40 AM, Felix Kuehling wrote: > On 2022-11-04 15:41, coverity-bot wrote: >> Hello! >> >> This is an experimental semi-automated report about issues detected by >> Coverity from a scan of next-20221104 as