Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-05-23 Thread Måns Rullgård
Måns Rullgård writes: > Frank Oltmanns writes: > >> Hi Måns, >> >> 21.05.2024 15:43:10 Måns Rullgård : >> >>> Frank Oltmanns writes: >>> >>>> The Allwinner SoC's typically have an upper and lower limit for their >&g

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-05-22 Thread Måns Rullgård
Frank Oltmanns writes: > Hi Måns, > > 21.05.2024 15:43:10 Måns Rullgård : > >> Frank Oltmanns writes: >> >>> The Allwinner SoC's typically have an upper and lower limit for their >>> clocks' rates. Up until now, support for that has

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-05-21 Thread Måns Rullgård
--git a/drivers/clk/sunxi-ng/ccu_common.h > b/drivers/clk/sunxi-ng/ccu_common.h > index 942a72c09437..329734f8cf42 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.h > +++ b/drivers/clk/sunxi-ng/ccu_common.h > @@ -31,6 +31,9 @@ struct ccu_common { > u16 lock_reg; > u32 prediv; > > + unsigned long min_rate; > + unsigned long max_rate; > + > unsigned long features; > spinlock_t *lock; > struct clk_hw hw; > > -- > > 2.44.0 > -- Måns Rullgård

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Måns Rullgård
Daniel Thompson writes: > On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote: >> Daniel Thompson writes: >> >> > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: >> >> The condition for the initial power state based on the defaul

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Måns Rullgård
45acf9 ("backlight: add led-backlight driver") >> Signed-off-by: Mans Rullgard >> --- >> Changes in v3: >> - Add comment > > This mismatches the subject line ;-) but I can live with that if Lee > and Jingoo can! Does it not fix it? If you think the subject is misleading, feel free to change it. -- Måns Rullgård

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-04 Thread Måns Rullgård
as (priv->default_brightness > 0) > since the value read by led_bl_get_leds() can be clobbered when we > parse the properties. Am I understanding correctly that the code should be using the default_brightness value as set by led_bl_get_leds() to determine the initial power state, not whatever default value the devicetree provides? -- Måns Rullgård

Re: [PATCH] drm: sun4i: hdmi: Fix inverted HPD result

2020-07-15 Thread Måns Rullgård
ned long reg; > > reg = readl(hdmi->base + SUN4I_HDMI_HPD_REG); > - if (reg & SUN4I_HDMI_HPD_HIGH) { > + if (!(reg & SUN4I_HDMI_HPD_HIGH)) { > cec_phys_addr_invalidate(hdmi->cec_adap); > return connector_status_disconnected; >

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-24 Thread Måns Rullgård
Maxime Ripard writes: > On Tue, Mar 19, 2019 at 12:48:19PM +0000, Måns Rullgård wrote: >> Maxime Ripard writes: >> >> > On Mon, Mar 18, 2019 at 04:23:56PM +, Måns Rullgård wrote: >> >> Maxime Ripard writes: >> >> >> >> >

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-19 Thread Måns Rullgård
Maxime Ripard writes: > On Mon, Mar 18, 2019 at 04:23:56PM +0000, Måns Rullgård wrote: >> Maxime Ripard writes: >> >> > On Thu, Mar 14, 2019 at 04:09:13PM +, Måns Rullgård wrote: >> >> Maxime Ripard writes: >> >> >> >> >

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-19 Thread Måns Rullgård
Maxime Ripard writes: > On Thu, Mar 14, 2019 at 04:09:13PM +0000, Måns Rullgård wrote: >> Maxime Ripard writes: >> >> > On Mon, Mar 11, 2019 at 04:11:06PM +, Måns Rullgård wrote: >> >> Maxime Ripard writes: >> >> >> >> > Hi!

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-15 Thread Måns Rullgård
Maxime Ripard writes: > On Mon, Mar 11, 2019 at 04:11:06PM +0000, Måns Rullgård wrote: >> Maxime Ripard writes: >> >> > Hi! >> > >> > On Mon, Mar 11, 2019 at 01:47:13PM +, Mans Rullgard wrote: >> >> Sometimes it is desirabled to use

Re: [PATCH] drm/sun4i: hdmi: add support for ddc-i2c-bus property

2019-03-12 Thread Måns Rullgård
>> .get_modes = sun4i_hdmi_get_modes, >> }; >> @@ -575,6 +597,12 @@ static int sun4i_hdmi_bind(struct device *dev, struct >> device *master, >> goto err_disable_mod_clk; >> } >> >> +hdmi->ddc_i2c = sun4i_hdmi_get