Re: [PATCH v2 30/34] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API

2025-05-07 Thread Liu Ying
On 05/07/2025, Luca Ceresoli wrote: > Hello Liu, > > On Wed, 7 May 2025 10:10:53 +0800 > Liu Ying wrote: > >> On 05/07/2025, Luca Ceresoli wrote: >>> Hello Liu, >> >> Hi Luca, >> >>> >>> thanks for your further feedb

Re: [PATCH v9 00/19] Add Freescale i.MX8qxp Display Controller support

2025-05-07 Thread Liu Ying
Hi Maxime, drm/misc maintainers, On 04/14/2025, Liu Ying wrote: > Hi, > > This patch series aims to add Freescale i.MX8qxp Display Controller support. > > The controller is comprised of three main components that include a blit > engine for 2D graphics accelerations, disp

Re: [PATCH v2 30/34] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API

2025-05-06 Thread Liu Ying
On 05/07/2025, Luca Ceresoli wrote: > Hello Liu, Hi Luca, > > thanks for your further feedback. > > On Tue, 6 May 2025 10:24:18 +0800 > Liu Ying wrote: > >> On 04/30/2025, Luca Ceresoli wrote: >>> Hello Liu, >> >> Hi Luca, >> >>

Re: [PATCH v2 30/34] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API

2025-05-05 Thread Liu Ying
On 04/30/2025, Luca Ceresoli wrote: > Hello Liu, Hi Luca, > > On Tue, 29 Apr 2025 10:10:55 +0800 > Liu Ying wrote: > >> Hi, >> >> On 04/25/2025, Luca Ceresoli wrote: >>> This is the new API for allocating DRM bridges. >>> >>> Thi

Re: [PATCH v2 31/34] drm/bridge: imx8*-ldb: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Liu Ying
sing devm_drm_bridge_alloc() > * adapt ldb_add_bridge_helper() to not set the funcs pointer >(now done by devm_drm_bridge_alloc()) > * adapt the code wherever using the channels > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Liu Ying > --- > drivers/gpu

Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-04-28 Thread Liu Ying
Adrien Grassein > Cc: Aleksandr Mishin > Cc: Andy Yan > Cc: AngeloGioacchino Del Regno > Cc: Benson Leung > Cc: Biju Das > Cc: Christoph Fritz > Cc: Cristian Ciocaltea > Cc: Detlev Casanova > Cc: Dharma Balasubiramani > Cc: Guenter Roeck > Cc: Heiko Stu

Re: [PATCH v2 30/34] drm/bridge: imx8qxp-pixel-combiner: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Liu Ying
make the new, dynamic bridge allocation possible: > > * change the array of channels into an array of channel pointers > * allocate each channel using devm_drm_bridge_alloc() > * adapt the code wherever using the channels > > Signed-off-by: Luca Ceresoli > > --- > >

[PATCH v9 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2025-04-15 Thread Liu Ying
Baryshkov Signed-off-by: Liu Ying --- v9: * No change. v8: * s/shdld/shdload/ for DE/ED IRQs. (Dmitry) * Use dc_{de,pe}_post_bind(). (Dmitry) * Drop dc_plane_check_no_off_screen(). (Dmitry) * Collect Dmitry's R-b tag. v7: * Drop using typeof in macros and explicitly define variable types. (D

[PATCH v9 10/19] drm/imx: Add i.MX8qxp Display Controller pixel engine

2025-04-15 Thread Liu Ying
pixel engine driver and those unit drivers are components to be aggregated by a master registered in the upcoming DRM driver. Reviewed-by: Maxime Ripard Signed-off-by: Liu Ying Reviewed-by: Dmitry Baryshkov --- v9: * Add Dmitry's R-b tag. v8: * Get CF/ED/FL/FW/LB device instance numbers th

[DO NOT MERGE PATCH v9 14/19] dt-bindings: phy: mixel, mipi-dsi-phy: Allow assigned-clock* properties

2025-04-15 Thread Liu Ying
assigned-clock* properties can be used by default now, so allow them. Signed-off-by: Liu Ying --- v9: * No change. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New patch as needed by MIPI/LVDS subsystems device tree

[DO NOT MERGE PATCH v9 18/19] arm64: dts: imx8qxp-mek: Enable display controller

2025-04-14 Thread Liu Ying
Enable display controller for i.MX8qxp MEK. Signed-off-by: Liu Ying --- v9: * No change. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New patch. (Francesco) arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 1 file

[PATCH v9 08/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller

2025-04-14 Thread Liu Ying
i.MX8qxp Display Controller(DC) is comprised of three main components that include a blit engine for 2D graphics accelerations, display controller for display output processing, as well as a command sequencer. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * No change. v8

[PATCH v9 03/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller display engine consists of all processing units that operate in a display clock domain. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * No change. v8: * Drop instance numbers from compatible strings. This means switching back to the patch in v4

[PATCH v9 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units

2025-04-13 Thread Liu Ying
Freescale i.MX8qxp Display Controller is implemented as construction set of building blocks with unified concept and standardized interfaces. Document all existing processing units. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * No change. v8: * Drop instance numbers from

[PATCH v9 00/19] Add Freescale i.MX8qxp Display Controller support

2025-04-13 Thread Liu Ying
et instance id from display driver. * Find next bridge from TCon's port from display driver. * Drop drm/drm_module.h include from dc-drv.c. * Improve file list in MAINTAINERS. (Frank) * Add entire i.MX8qxp display controller device tree for review. (Krzysztof) * Add MIPI/LVDS subsystems dev

[PATCH v9 13/19] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller

2025-04-13 Thread Liu Ying
Add myself as the maintainer of i.MX8qxp Display Controller. Signed-off-by: Liu Ying Reviewed-by: Maxime Ripard --- v9: * Add Maxime's R-b tag. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * Improve file list. (

[PATCH v9 07/19] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller has a built-in interrupt controller to support Enable/Status/Preset/Clear interrupt bit. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * No change. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3

[PATCH v9 11/19] drm/imx: Add i.MX8qxp Display Controller interrupt controller

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller has a built-in interrupt controller to support Enable/Status/Preset/Clear interrupt bit. Add driver for it. Reviewed-by: Maxime Ripard Reviewed-by: Dmitry Baryshkov Signed-off-by: Liu Ying --- v9: * No change. v8: * Collect Dmitry's R-b tag. v7:

[PATCH v9 04/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller pixel engine consists of all processing units that operate in the AXI bus clock domain. Command sequencer and interrupt controller of the Display Controller work with AXI bus clock, but they are not in pixel engine. Signed-off-by: Liu Ying Reviewed-by: Rob Herring

[DO NOT MERGE PATCH v9 17/19] arm64: dts: imx8qxp: Add MIPI-LVDS combo subsystems

2025-04-13 Thread Liu Ying
The MIPI-LVDS combo subsystems are peripherals of pixel link MSI bus in i.MX8qxp display controller subsystem. Add the MIPI-LVDS combo subsystems. Signed-off-by: Liu Ying --- v9: * No change. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No

[PATCH v9 06/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller command sequencer

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller contains a command sequencer is designed to autonomously process command lists. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * Add Rob's R-b tag. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * Replace &quo

[PATCH v9 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2025-04-13 Thread Liu Ying
aggregated by a master registered in the upcoming DRM driver. Reviewed-by: Maxime Ripard Signed-off-by: Liu Ying Reviewed-by: Dmitry Baryshkov --- v9: * Add Dmitry's R-b tag. v8: * Get DE/FG/TC device instance numbers through register start addresses of the devices, instead of compa

[DO NOT MERGE PATCH v9 19/19] arm64: dts: imx8qxp-mek: Add MX8-DLVDS-LCD1 display module support

2025-04-13 Thread Liu Ying
MX8-DLVDS-LCD1 display module integrates a KOE TX26D202VM0BWA LCD panel and a touch IC. Add an overlay to support the LCD panel on i.MX8qxp MEK. mipi_lvds_0_ldb channel0 and mipi_lvds_1_ldb channel1 send odd and even pixels to the panel respectively. Signed-off-by: Liu Ying --- v9: * Rebase on

[DO NOT MERGE PATCH v9 16/19] arm64: dts: imx8qxp: Add display controller subsystem

2025-04-13 Thread Liu Ying
Add display controller subsystem in i.MX8qxp SoC. Signed-off-by: Liu Ying --- v9: * No change. v8: * Drop instance numbers from display controller internal devices' compatible strings. (Dmitry) v7: * Add instance numbers to display controller internal devices' compatible strin

[DO NOT MERGE PATCH v9 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

2025-04-13 Thread Liu Ying
Document SCU controlled display pixel link child nodes. Signed-off-by: Liu Ying --- v9: * No change. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New patch as needed by display controller subsystem device tree

[PATCH v9 05/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller AXI performance counter

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller contains a AXI performance counter which allows measurement of average bandwidth and latency during operation. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * No change. v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4

[PATCH v9 02/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller blit engine

2025-04-13 Thread Liu Ying
i.MX8qxp Display Controller contains a blit engine for raster graphics. It may read up to 3 source images from memory and computes one destination image from it, which is written back to memory. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v9: * No change. v8: * Drop instance

Re: [PATCH] drm/imx: legacy-bridge: fix inconsistent indenting warning

2025-03-25 Thread Liu Ying
641089/?series=145843&rev=1 -- Regards, Liu Ying

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-23 Thread Liu Ying
drm/bridge/fsl-ldb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to misc/kernel.git (drm-misc-next). Thanks! -- Regards, Liu Ying

Re: [PATCH 1/2] drm/bridge: imx8qxp-ldb: cleanup return value

2025-03-23 Thread Liu Ying
1 insertion(+), 1 deletion(-) Applied to misc/kernel.git (drm-misc-next). Thanks! -- Regards, Liu Ying

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-15 Thread Liu Ying
On 03/06/2025, Maxime Ripard wrote: > On Thu, Mar 06, 2025 at 03:02:41PM +0800, Liu Ying wrote: >> On 03/06/2025, Rob Herring wrote: >>> On Wed, Mar 05, 2025 at 10:35:26AM +0100, Alexander Stein wrote: >>>> Hi, >>>> >>>> Am Dienstag, 4. Mär

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-15 Thread Liu Ying
On 03/07/2025, Luca Ceresoli wrote: > Hello Liu, Hello Luca, > > thanks for your reviews. > > On Fri, 7 Mar 2025 14:33:37 +0800 > Liu Ying wrote: > >> On 03/07/2025, Luca Ceresoli wrote: >>> This warning notifies a clock was set to an inaccurate value. Mo

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-11 Thread Liu Ying
On 03/10/2025, Maxime Ripard wrote: > On Fri, Mar 07, 2025 at 11:25:40AM +0800, Liu Ying wrote: >> On 03/07/2025, Rob Herring wrote: >>> On Thu, Mar 06, 2025 at 12:35:49PM +0100, Maxime Ripard wrote: >>>> On Thu, Mar 06, 2025 at 03:02:41PM +0800, Liu Ying wrote: &g

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-10 Thread Liu Ying
On 03/10/2025, Maxime Ripard wrote: > On Fri, Mar 07, 2025 at 11:10:00AM +0800, Liu Ying wrote: >> On 03/06/2025, Maxime Ripard wrote: >>> On Thu, Mar 06, 2025 at 03:02:41PM +0800, Liu Ying wrote: >>>> On 03/06/2025, Rob Herring wrote: >>>>> On Wed

Re: [PATCH 1/2] drm/bridge: imx8qxp-ldb: cleanup return value

2025-03-10 Thread Liu Ying
On 03/07/2025, Luca Ceresoli wrote: > Hello Liu, > > On Fri, 7 Mar 2025 14:42:12 +0800 > Liu Ying wrote: > >> On 03/07/2025, Luca Ceresoli wrote: >>> 'ret' can only be 0 at this point, being preceded by a 'if (ret) return >>> ret;'. So

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-07 Thread Liu Ying
On 03/06/2025, Rob Herring wrote: > On Wed, Mar 05, 2025 at 10:35:26AM +0100, Alexander Stein wrote: >> Hi, >> >> Am Dienstag, 4. März 2025, 16:23:20 CET schrieb Rob Herring: >>> On Tue, Mar 04, 2025 at 06:15:28PM +0800, Liu Ying wrote: >>>> A DPI

Re: [PATCH 1/2] drm/bridge: imx8qxp-ldb: cleanup return value

2025-03-06 Thread Liu Ying
only place across the kernel tree where this cleanup could be done. So, maybe use some tools to cleanup them all? > } > > static void imx8qxp_ldb_remove(struct platform_device *pdev) > -- Regards, Liu Ying

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-06 Thread Liu Ying
fsl_ldb->clk, configured_link_freq, >> requested_link_freq); > > commit message said show clock name, but %p is for pointer value. Are sure > it show clock name? %pC prints clock name. Please see Documentation/core-api/printk-formats.rst. > > Frank > >> >> clk_prepare_enable(fsl_ldb->clk); >> >> >> -- >> 2.48.1 >> -- Regards, Liu Ying

Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

2025-03-06 Thread Liu Ying
s it make sense to s/%pC/%pCn/ so that the clock name is printed in lower case instead of upper case, since it seems that all i.MX specific clock names are in lower case? > > clk_prepare_enable(fsl_ldb->clk); > > -- Regards, Liu Ying

Re: [PATCH] drm/imx: legacy-bridge: fix inconsistent indenting warning

2025-03-06 Thread Liu Ying
rm/bridge/imx/imx-legacy-bridge.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to misc/kernel.git (drm-misc-next). Thanks! -- Regards, Liu Ying

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-06 Thread Liu Ying
On 03/07/2025, Rob Herring wrote: > On Thu, Mar 06, 2025 at 12:35:49PM +0100, Maxime Ripard wrote: >> On Thu, Mar 06, 2025 at 03:02:41PM +0800, Liu Ying wrote: >>> On 03/06/2025, Rob Herring wrote: >>>> On Wed, Mar 05, 2025 at 10:35:26AM +0100, Alexander Stein w

Re: [PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-05 Thread Liu Ying
On 03/04/2025, Maxime Ripard wrote: > On Tue, Mar 04, 2025 at 06:15:28PM +0800, Liu Ying wrote: >> A DPI color encoder, as a simple display bridge, converts input DPI color >> coding to output DPI color coding, like Adafruit Kippah DPI hat[1] which >> converts input 18-bit

Re: [PATCH 1/5] dt-bindings: display: Document DPI color codings

2025-03-05 Thread Liu Ying
t the only criteria, and not having to manipulate >> strings but instead just doing int comparison is a huge plus. > > Sure, defines work as well. BTW, it has a minor drawback on bindings as > it means you might need to update both binding and the header when > adding new entry, but I understand that it makes implementation life > easier or faster. If no objections, I'd use integer color codings. > > Best regards, > Krzysztof -- Regards, Liu Ying

Re: [PATCH 5/5] drm/bridge: simple-bridge: Add next panel support

2025-03-05 Thread Liu Ying
On 03/04/2025, Maxime Ripard wrote: > On Tue, Mar 04, 2025 at 06:15:30PM +0800, Liu Ying wrote: >> The next bridge connected to a simple bridge could be a panel, e.g., >> a DPI panel connected to a DPI color encoder. Add the next panel support, >> instead of supporting non-p

Re: [PATCH 4/5] drm/bridge: simple-bridge: Add DPI color encoder support

2025-03-05 Thread Liu Ying
On 03/04/2025, Maxime Ripard wrote: > On Tue, Mar 04, 2025 at 06:15:29PM +0800, Liu Ying wrote: >> A DPI color encoder, as a simple display bridge, converts input DPI color >> coding to output DPI color coding, like Adafruit Kippah DPI hat[1] which >> converts input 18-bit

Re: [PATCH] drm/imx: legacy-bridge: fix inconsistent indenting warning

2025-03-05 Thread Liu Ying
rm/bridge/imx/imx-legacy-bridge.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Liu Ying

[PATCH 3/5] dt-bindings: display: simple-bridge: Document DPI color encoder

2025-03-04 Thread Liu Ying
] https://learn.adafruit.com/adafruit-dpi-display-kippah-ttl-tft/downloads Signed-off-by: Liu Ying --- .../display/bridge/simple-bridge.yaml | 89 ++- 1 file changed, 87 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/simple

[PATCH 5/5] drm/bridge: simple-bridge: Add next panel support

2025-03-04 Thread Liu Ying
The next bridge connected to a simple bridge could be a panel, e.g., a DPI panel connected to a DPI color encoder. Add the next panel support, instead of supporting non-panel next bridge only. Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/Kconfig | 1 + drivers/gpu/drm/bridge

[PATCH 0/5] drm/bridge: simple-bridge: Add DPI color encoder support

2025-03-04 Thread Liu Ying
m/design/design-center/development-boards-and-designs/i.MX93EVK [3] https://www.nxp.com/design/design-center/development-boards-and-designs/IMX93QSB Liu Ying (5): dt-bindings: display: Document DPI color codings drm/of: Add drm_of_dpi_get_color_coding() dt-bindings: display: simple-brid

[PATCH 4/5] drm/bridge: simple-bridge: Add DPI color encoder support

2025-03-04 Thread Liu Ying
the simple bridge driver. [1] https://learn.adafruit.com/adafruit-dpi-display-kippah-ttl-tft/downloads Signed-off-by: Liu Ying --- drivers/gpu/drm/bridge/simple-bridge.c | 104 - 1 file changed, 102 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/simple

[PATCH 1/5] dt-bindings: display: Document DPI color codings

2025-03-04 Thread Liu Ying
Document DPI color codings according to MIPI Alliance Standard for Display Pixel Interface(DPI-2) Version 2.00(15 September 2005). Signed-off-by: Liu Ying --- .../bindings/display/dpi-color-coding.yaml| 90 +++ 1 file changed, 90 insertions(+) create mode 100644

[PATCH 2/5] drm/of: Add drm_of_dpi_get_color_coding()

2025-03-04 Thread Liu Ying
Add helper function drm_of_dpi_get_color_coding() to get media bus format value from MIPI DPI color coding string. Signed-off-by: Liu Ying --- drivers/gpu/drm/drm_of.c | 43 include/drm/drm_of.h | 7 +++ 2 files changed, 50 insertions(+) diff

[PATCH v5 0/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2025-03-04 Thread Liu Ying
tag on patch 1/2 and with the patch set rebased upon v6.11-rc1. v1->v2: * Set *num_input_fmts to zero in case imx93_pdfc_bridge_atomic_get_input_bus_fmts() returns NULL in patch 2/2. * Replace .remove callback with .remove_new callback in imx93_pdfc_bridge_driver in patch 2/2. Liu Ying (2):

[PATCH v5 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2025-03-04 Thread Liu Ying
NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Add a DRM bridge driver to support the display format configuration. Signed-off-by: Liu Ying --- v4->v5: * Rebase upon next-20250303.

[PATCH v5 1/2] dt-bindings: soc: imx93-media-blk-ctrl: Add PDFC subnode to schema and example

2025-03-04 Thread Liu Ying
i.MX93 SoC mediamix blk-ctrl contains one DISPLAY_MUX register which configures parallel display format by using the "PARALLEL_DISP_FORMAT" field. Document the Parallel Display Format Configuration(PDFC) subnode and add the subnode to example. Signed-off-by: Liu Ying Reviewed-by: Co

Re: [PATCH 0/2] i.MX91/93 parallel display bridge

2025-02-11 Thread Liu Ying
ch series[1] to add the i.MX93 parallel display format configuration support. I may send a new version to rename .remove_new to .remove in the bridge driver at least. [1] https://patchwork.freedesktop.org/series/113457/ -- Regards, Liu Ying

Re: [PATCH v7 0/7] Add ITE IT6263 LVDS to HDMI converter support

2025-02-06 Thread Liu Ying
On 01/28/2025, Maxime Ripard wrote: > On Wed, Dec 18, 2024 at 02:02:18PM +0800, Liu Ying wrote: >> On 12/17/2024, Maxime Ripard wrote: >>> On Thu, Nov 14, 2024 at 02:57:52PM +0800, Liu Ying wrote: >>>> This patch series aims to add ITE IT6263 LVDS to HDMI

Re: [PATCH v8 13/19] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller

2025-02-04 Thread Liu Ying
Hi Dmitry, Maxime, On 12/30/2024, Liu Ying wrote: > Add myself as the maintainer of i.MX8qxp Display Controller. > > Signed-off-by: Liu Ying > --- > v8: > * No change. > > v7: > * No change. > > v6: > * No change. > > v5: > * No change. > >

Re: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()

2025-01-14 Thread Liu Ying
IT6263 LVDS to HDMI converter") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/bridge/ite-it6263.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to misc/kernel.git (drm-misc-fixes). Thanks! -- Regards, Liu Ying

[PATCH v2 1/2] drm/connector: hdmi: Do atomic check when necessary

2025-01-10 Thread Liu Ying
548c8ff0ab ("drm/rockchip: inno_hdmi: Switch to HDMI connector") Signed-off-by: Liu Ying --- Tested with i.MX8MP imx-lcdif. sun4i and rockchip are not tested due to no HW access. v2: * Trim backtrace in commit message. (Dmitry) * Drop timestamps from backtrace commit message. (Dmitr

[PATCH v2 2/2] drm/tests: hdmi: Add connector disablement test

2025-01-10 Thread Liu Ying
Atomic check should succeed when disabling a connector. Add a test case drm_test_check_disabling_connector() to make sure of this. Suggested-by: Dmitry Baryshkov Signed-off-by: Liu Ying --- v2: * New patch to add the test case. (Dmitry) .../drm/tests/drm_hdmi_state_helper_test.c| 52

[PATCH v2 0/2] drm: display: Fix atomic check for HDMI connector disablement

2025-01-10 Thread Liu Ying
it message. (Dmitry) * Move the necessary checks from drm_bridge_connector_atomic_check() to drm_atomic_helper_connector_hdmi_check(). (Dmitry) * Add the KUnit test case in patch 2. (Dmitry) Liu Ying (2): drm/connector: hdmi: Do atomic check when necessary drm/tests: hdmi: Add connector disabl

Re: [PATCH] drm/display: bridge_connector: Do atomic check when necessary

2025-01-10 Thread Liu Ying
On 01/08/2025, Dmitry Baryshkov wrote: > On Wed, Jan 08, 2025 at 06:13:51PM +0800, Liu Ying wrote: >> It's ok to pass atomic check successfully if an atomic commit tries to >> disable the display pipeline which the connector belongs to. That is, >> when the crtc or th

[PATCH] drm/display: bridge_connector: Do atomic check when necessary

2025-01-08 Thread Liu Ying
Code: d50323bf d65f03c0 52800041 17e6 (b941) [ 46.980350] ---[ end trace ]--- Fixes: 8ec116ff21a9 ("drm/display: bridge_connector: provide atomic_check for HDMI bridges") Signed-off-by: Liu Ying --- drivers/gpu/drm/display/drm_bridge_connector.c | 5 + 1

Re: [PATCH v2 4/4] drm/bridge: imx8qxp-pixel-link: Use dev_err_probe

2025-01-07 Thread Liu Ying
ns(-) Reviewed-by: Liu Ying

Re: [PATCH v2 3/4] drm/bridge: imx-ldb-helper: Use dev_err_probe

2025-01-07 Thread Liu Ying
uot;); Nit: s/find/get/, since "get" was used. > } > > return 0; ldb_init_helper() may return -EPROBE_DEFER too, so it needs to be changed. -- Regards, Liu Ying

Re: [PATCH v2 2/4] drm/bridge: imx8qxp-ldb: Use dev_err_probe

2025-01-07 Thread Liu Ying
ns(-) Reviewed-by: Liu Ying

Re: [PATCH v2 0/4] dev_err_probe usage for imx8qxp DPU pipeline

2025-01-07 Thread Liu Ying
m/bridge/imx/imx8qxp-ldb.c | 37 ++- > .../gpu/drm/bridge/imx/imx8qxp-pixel-link.c | 19 +++--- > drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 26 ----- > 4 files changed, 29 insertions(+), 66 deletions(-) > -- Regards, Liu Ying

Re: [PATCH v2 1/4] drm/bridge: imx8qxp-pxl2dpi: Use dev_err_probe

2025-01-07 Thread Liu Ying
quot;failed to find next bridge: %d\n", > - ret); > - return ret; > - } > + if (IS_ERR(p2d->next_bridge)) > + return dev_err_probe(dev, PTR_ERR(p2d->next_bridge), > + "failed to find next bridge\n"); > > ret = imx8qxp_pxl2dpi_set_pixel_link_sel(p2d); > if (ret) imx8qxp_pxl2dpi_parse_dt_companion() may return -EPROBE_DEFER too, so it needs to be changed. -- Regards, Liu Ying

Re: [PATCH v4 2/4] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2025-01-07 Thread Liu Ying
by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: David Airlie > Cc: Fabio Estevam > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Pengutronix Kernel Team &

Re: [PATCH v3 2/4] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2025-01-03 Thread Liu Ying
by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: David Airlie > Cc: Fabio Estevam > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Pengutronix Kernel Team &

Re: [PATCH v2 3/3] drm/mxsfb: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

2024-12-29 Thread Liu Ying
gt; > Based on 2e87bf389e13 ("drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag > to drm_bridge_attach") > > This makes LT9611 work with i.MX8M Mini. > > Signed-off-by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: David Airlie > Cc: Fabio Estevam > Cc: Jernej Sk

Re: [PATCH v2 2/3] drm/lcdif: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach

2024-12-29 Thread Liu Ying
> + ret = drm_connector_attach_encoder(connector, encoder); > + if (ret < 0) { of_node_put(ep); > + dev_err_probe(drm->dev, ret, > + "Failed to attach encoder.\n"); It looks like no one else calls dev_err_probe() when drm_connector_attach_encoder() fails, plus drm_connector_attach_encoder() doesn't return -EPROBE_DEFER at all. > + drm_connector_cleanup(connector); > + return ret; > + } > } > > return 0; -- Regards, Liu Ying

Re: [PATCH v2 1/3] drm/bridge: imx8mp-hdmi-tx: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR

2024-12-29 Thread Liu Ying
c > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Liu Ying > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Pengutronix Kernel Team > Cc: Robert Foss > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: Simona Vetter > Cc: Stefan Agner &

[DO NOT MERGE PATCH v8 14/19] dt-bindings: phy: mixel, mipi-dsi-phy: Allow assigned-clock* properties

2024-12-29 Thread Liu Ying
assigned-clock* properties can be used by default now, so allow them. Signed-off-by: Liu Ying --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New patch as needed by MIPI/LVDS subsystems device tree. .../devicetree/bindings

[DO NOT MERGE PATCH v8 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

2024-12-29 Thread Liu Ying
Document SCU controlled display pixel link child nodes. Signed-off-by: Liu Ying --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New patch as needed by display controller subsystem device tree. .../devicetree/bindings

[PATCH v8 08/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller(DC) is comprised of three main components that include a blit engine for 2D graphics accelerations, display controller for display output processing, as well as a command sequencer. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v8: * Drop instance

[PATCH v8 10/19] drm/imx: Add i.MX8qxp Display Controller pixel engine

2024-12-29 Thread Liu Ying
pixel engine driver and those unit drivers are components to be aggregated by a master registered in the upcoming DRM driver. Reviewed-by: Maxime Ripard Signed-off-by: Liu Ying --- v8: * Get CF/ED/FL/FW/LB device instance numbers through register start addresses of the devices, instead of

[PATCH v8 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2024-12-29 Thread Liu Ying
Baryshkov Signed-off-by: Liu Ying --- v8: * s/shdld/shdload/ for DE/ED IRQs. (Dmitry) * Use dc_{de,pe}_post_bind(). (Dmitry) * Drop dc_plane_check_no_off_screen(). (Dmitry) * Collect Dmitry's R-b tag. v7: * Drop using typeof in macros and explicitly define variable types. (Dmitry) * Add a co

[PATCH v8 02/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller blit engine

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller contains a blit engine for raster graphics. It may read up to 3 source images from memory and computes one destination image from it, which is written back to memory. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v8: * Drop instance numbers from

[PATCH v8 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units

2024-12-29 Thread Liu Ying
Freescale i.MX8qxp Display Controller is implemented as construction set of building blocks with unified concept and standardized interfaces. Document all existing processing units. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v8: * Drop instance numbers from compatible strings

[PATCH v8 07/19] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller has a built-in interrupt controller to support Enable/Status/Preset/Clear interrupt bit. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * Collect Rob's R-

[DO NOT MERGE PATCH v8 19/19] arm64: dts: imx8qxp-mek: Add MX8-DLVDS-LCD1 display module support

2024-12-29 Thread Liu Ying
MX8-DLVDS-LCD1 display module integrates a KOE TX26D202VM0BWA LCD panel and a touch IC. Add an overlay to support the LCD panel on i.MX8qxp MEK. mipi_lvds_0_ldb channel0 and mipi_lvds_1_ldb channel1 send odd and even pixels to the panel respectively. Signed-off-by: Liu Ying --- v8: * No change

[DO NOT MERGE PATCH v8 18/19] arm64: dts: imx8qxp-mek: Enable display controller

2024-12-29 Thread Liu Ying
Enable display controller for i.MX8qxp MEK. Signed-off-by: Liu Ying --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New patch. (Francesco) arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 4 1 file changed, 4 insertions

[DO NOT MERGE PATCH v8 17/19] arm64: dts: imx8qxp: Add MIPI-LVDS combo subsystems

2024-12-29 Thread Liu Ying
The MIPI-LVDS combo subsystems are peripherals of pixel link MSI bus in i.MX8qxp display controller subsystem. Add the MIPI-LVDS combo subsystems. Signed-off-by: Liu Ying --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * New

[DO NOT MERGE PATCH v8 16/19] arm64: dts: imx8qxp: Add display controller subsystem

2024-12-29 Thread Liu Ying
Add display controller subsystem in i.MX8qxp SoC. Signed-off-by: Liu Ying --- v8: * Drop instance numbers from display controller internal devices' compatible strings. (Dmitry) v7: * Add instance numbers to display controller internal devices' compatible strings. * Drop aliases.

[PATCH v8 13/19] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller

2024-12-29 Thread Liu Ying
Add myself as the maintainer of i.MX8qxp Display Controller. Signed-off-by: Liu Ying --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * No change. v3: * No change. v2: * Improve file list. (Frank) MAINTAINERS | 8 1 file changed, 8 insertions(+) diff

[PATCH v8 11/19] drm/imx: Add i.MX8qxp Display Controller interrupt controller

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller has a built-in interrupt controller to support Enable/Status/Preset/Clear interrupt bit. Add driver for it. Reviewed-by: Maxime Ripard Reviewed-by: Dmitry Baryshkov Signed-off-by: Liu Ying --- v8: * Collect Dmitry's R-b tag. v7: * Fix regmap_config definiti

[PATCH v8 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-12-29 Thread Liu Ying
aggregated by a master registered in the upcoming DRM driver. Reviewed-by: Maxime Ripard Signed-off-by: Liu Ying --- v8: * Get DE/FG/TC device instance numbers through register start addresses of the devices, instead of compatible strings. (Dmitry) * s/shdld/shdload/ for DE IRQs. (Dmitry) * Drop

[PATCH v8 06/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller command sequencer

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller contains a command sequencer is designed to autonomously process command lists. Signed-off-by: Liu Ying --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * Replace "fsl,iram" property with standard "sram" property. (R

[PATCH v8 05/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller AXI performance counter

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller contains a AXI performance counter which allows measurement of average bandwidth and latency during operation. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v8: * No change. v7: * No change. v6: * No change. v5: * No change. v4: * Collect Rob'

[PATCH v8 03/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller display engine consists of all processing units that operate in a display clock domain. Signed-off-by: Liu Ying Reviewed-by: Rob Herring (Arm) --- v8: * Drop instance numbers from compatible strings. This means switching back to the patch in v4. So, add Rob&#

[PATCH v8 04/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine

2024-12-29 Thread Liu Ying
i.MX8qxp Display Controller pixel engine consists of all processing units that operate in the AXI bus clock domain. Command sequencer and interrupt controller of the Display Controller work with AXI bus clock, but they are not in pixel engine. Signed-off-by: Liu Ying Reviewed-by: Rob Herring

[PATCH v8 00/19] Add Freescale i.MX8qxp Display Controller support

2024-12-29 Thread Liu Ying
dc*.yaml. * Use OF alias id to get instance id from display driver. * Find next bridge from TCon's port from display driver. * Drop drm/drm_module.h include from dc-drv.c. * Improve file list in MAINTAINERS. (Frank) * Add entire i.MX8qxp display controller device tree for review. (Krzysztof) * Ad

Re: [PATCH v7 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2024-12-29 Thread Liu Ying
On 12/27/2024, Dmitry Baryshkov wrote: > On Wed, 25 Dec 2024 at 09:18, Liu Ying wrote: >> >> On 12/23/2024, Dmitry Baryshkov wrote: >>> On Mon, Dec 23, 2024 at 02:41:40PM +0800, Liu Ying wrote: >>>> i.MX8qxp Display Controller(DC) is comprised of three main

Re: [PATCH v7 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2024-12-24 Thread Liu Ying
On 12/23/2024, Dmitry Baryshkov wrote: > On Mon, Dec 23, 2024 at 02:41:40PM +0800, Liu Ying wrote: >> i.MX8qxp Display Controller(DC) is comprised of three main components that >> include a blit engine for 2D graphics accelerations, display controller for >> display output pro

Re: [PATCH v7 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-12-24 Thread Liu Ying
On 12/24/2024, Dmitry Baryshkov wrote: > On Tue, 24 Dec 2024 at 08:21, Liu Ying wrote: >> >> On 12/23/2024, Dmitry Baryshkov wrote: >>> On Mon, Dec 23, 2024 at 02:41:37PM +0800, Liu Ying wrote: >>>> i.MX8qxp Display Controller display engine consists of all pro

Re: [PATCH v7 03/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine

2024-12-23 Thread Liu Ying
On 12/24/2024, Dmitry Baryshkov wrote: > On Tue, 24 Dec 2024 at 07:56, Liu Ying wrote: >> >> On 12/23/2024, Dmitry Baryshkov wrote: >>> On Mon, Dec 23, 2024 at 02:41:31PM +0800, Liu Ying wrote: >>>> i.MX8qxp Display Controller display engine consists of all pro

Re: [PATCH v7 10/19] drm/imx: Add i.MX8qxp Display Controller pixel engine

2024-12-23 Thread Liu Ying
On 12/23/2024, Dmitry Baryshkov wrote: > On Mon, Dec 23, 2024 at 02:41:38PM +0800, Liu Ying wrote: >> i.MX8qxp Display Controller pixel engine consists of all processing >> units that operate in the AXI bus clock domain. Add drivers for >> ConstFrame, ExtDst, FetchLayer, Fet

Re: [PATCH v7 09/19] drm/imx: Add i.MX8qxp Display Controller display engine

2024-12-23 Thread Liu Ying
On 12/23/2024, Dmitry Baryshkov wrote: > On Mon, Dec 23, 2024 at 02:41:37PM +0800, Liu Ying wrote: >> i.MX8qxp Display Controller display engine consists of all processing >> units that operate in a display clock domain. Add minimal feature >> support with FrameGen and TCon s

  1   2   3   4   5   6   7   8   9   10   >