; dri-devel@lists.freedesktop.org
; Lazar, Lijo ;
Limonciello, Mario ; kernel-...@igalia.com
; Deucher, Alexander ; Zhu,
James ; Liu, Leo ; Koenig, Christian
Subject: Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling
indirect SRAM mode
On Mon, Jan 16, 2023 at 4:21 PM
On 2019-10-01 5:57 p.m., Gustavo A. R. Silva wrote:
>
> On 10/1/19 16:46, Liu, Leo wrote:
>
>>>>> + ring->sched.ready = true;
>>>> This is redundant. all the sched->ready is initialized as true, please
>>>> refer to drm_sch
On 2019-10-01 5:43 p.m., Gustavo A. R. Silva wrote:
> Hi,
>
> On 10/1/19 16:29, Liu, Leo wrote:
>> On 2019-10-01 1:16 p.m., Gustavo A. R. Silva wrote:
>>> Notice that there is a *continue* statement in the middle of the
>>> for loop and that prevents the c
On 2019-10-01 1:16 p.m., Gustavo A. R. Silva wrote:
> Notice that there is a *continue* statement in the middle of the
> for loop and that prevents the code below from ever being reached:
>
> r = amdgpu_ring_test_ring(ring);
> if (r) {
> ring->sched.ready = false;
>
Just make them properly i.e. put 0 to the Nop reg
Signed-off-by: Leo Liu
---
tests/amdgpu/vcn_tests.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c
index d9f05af8..859ec496 100644
--- a/tests/amdgpu/vcn
