Re: [PATCH 06/11] drm/syncobj: add timeline payload query ioctl v4

2019-02-16 Thread Lionel Landwerlin via dri-devel
On 07/12/2018 09:55, Chunming Zhou wrote: user mode can query timeline payload. v2: check return value of copy_to_user v3: handle querying entry by entry v4: rebase on new chain container, simplify interface Signed-off-by: Chunming Zhou Cc: Daniel Rakos Cc: Jason Ekstrand Cc: Bas Nieuwenhuize

Re: [PATCH 02/11] dma-buf: add new dma_fence_chain container v4

2019-02-15 Thread Lionel Landwerlin via dri-devel
On 15/02/2019 14:32, Koenig, Christian wrote: Am 15.02.19 um 15:23 schrieb Lionel Landwerlin: Hi Christian, David, For timeline semaphore we need points to signaled in order. I'm struggling to understand how this fence-chain implementation preserves ordering of the seqnos. One of the scenario

Re: [PATCH 02/11] dma-buf: add new dma_fence_chain container v4

2019-02-15 Thread Lionel Landwerlin via dri-devel
Hi Christian, David, For timeline semaphore we need points to signaled in order. I'm struggling to understand how this fence-chain implementation preserves ordering of the seqnos. One of the scenario I can see an issue happening is when you have a timeline with points 1 & 2 and userspace subm

Re: [PATCH 09/11] drm/syncobj: add transition iotcls between binary and timeline

2019-02-15 Thread Lionel Landwerlin via dri-devel
Hi David, Thanks a lot for point me to the tests you've added in IGT. While adding a test with that signals fences imported into a timeline syncobj out of order, I ran into a deadlock. Here is the test : https://github.com/djdeath/intel-gpu-tools/commit/1e46cf7e7bff09b78a24367ddc2314f97eb0a1b9

[PATCH] dma-buf/sw_sync: remove points on release prior to signaling

2019-02-14 Thread Lionel Landwerlin via dri-devel
Much like the sync_timeline_signal(), remove the points from the timeline so that if the callee is dropping the last reference on the point's fence we don't end up in a deadlock in timeline_fence_release(). Signed-off-by: Lionel Landwerlin --- drivers/dma-buf/sw_sync.c | 3 +++ 1 file changed, 3