Re: [PATCH v2 11/11] mm/io-mapping: track_pfn() -> "pfnmap tracking"

2025-05-13 Thread Liam R. Howlett
* David Hildenbrand [250512 08:35]: > track_pfn() does not exist, let's simply refer to it as "pfnmap > tracking". > > Reviewed-by: Lorenzo Stoakes > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > ---

Re: [PATCH v2 10/11] drm/i915: track_pfn() -> "pfnmap tracking"

2025-05-13 Thread Liam R. Howlett
* David Hildenbrand [250512 08:35]: > track_pfn() does not exist, let's simply refer to it as "pfnmap > tracking". > > Reviewed-by: Lorenzo Stoakes > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > --- &

Re: [PATCH v2 09/11] x86/mm/pat: inline memtype_match() into memtype_erase()

2025-05-13 Thread Liam R. Howlett
* David Hildenbrand [250512 08:34]: > Let's just have it in a single function. The resulting function is > certainly small enough and readable. > > Signed-off-by: David Hildenbrand Same comment about interval_tree_for_each_span() here, I guess. Reviewed-by: Liam R. Howlett

Re: [PATCH v2 08/11] x86/mm/pat: remove MEMTYPE_*_MATCH

2025-05-13 Thread Liam R. Howlett
but this looks good. Reviewed-by: Liam R. Howlett > --- > arch/x86/mm/pat/memtype_interval.c | 44 -- > 1 file changed, 6 insertions(+), 38 deletions(-) > > diff --git a/arch/x86/mm/pat/memtype_interval.c > b/arch/x86/mm/pat/memtype_interval.c

Re: [PATCH v2 07/11] x86/mm/pat: remove strict_prot parameter from reserve_pfn_range()

2025-05-13 Thread Liam R. Howlett
* David Hildenbrand [250512 08:34]: > Always set to 0, so let's remove it. > > Reviewed-by: Lorenzo Stoakes > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > --- > arch/x86/mm/pat/memtype.c | 12 +++

Re: [PATCH v2 06/11] mm: remove VM_PAT

2025-05-13 Thread Liam R. Howlett
* David Hildenbrand [250512 08:34]: > It's unused, so let's remove it. > > Reviewed-by: Lorenzo Stoakes > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > --- > include/linux/mm.h | 4 +--- >

Re: [PATCH v2 05/11] x86/mm/pat: remove old pfnmap tracking interface

2025-05-13 Thread Liam R. Howlett
* David Hildenbrand [250512 08:34]: > We can now get rid of the old interface along with get_pat_info() and > follow_phys(). > > Reviewed-by: Lorenzo Stoakes > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > -

Re: [PATCH v2 04/11] mm: convert VM_PFNMAP tracking to pfnmap_track() + pfnmap_untrack()

2025-05-13 Thread Liam R. Howlett
d hook into VM splitting > code and split the tracking; however, that adds complexity that might > not be required, so we'll keep it simple for now. > > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > -

Re: [PATCH v2 03/11] mm: introduce pfnmap_track() and pfnmap_untrack() and use them for memremap

2025-05-13 Thread Liam R. Howlett
x86 bits > Signed-off-by: David Hildenbrand Small nit with this one, but either way: Reviewed-by: Liam R. Howlett > --- > arch/x86/mm/pat/memtype.c | 14 ++ > include/linux/pgtable.h | 39 +++ > mm/memremap.c | 8 ++

Re: [PATCH v2 02/11] mm: convert track_pfn_insert() to pfnmap_setup_cachemode*()

2025-05-13 Thread Liam R. Howlett
ion, > and also document why it is valid to not check the whole pfn range. > > We'll reuse pfnmap_setup_cachemode() from core MM next. > > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett > --- > arch/x86/mm/pat/memtyp

Re: [PATCH v2 01/11] x86/mm/pat: factor out setting cachemode into pgprot_set_cachemode()

2025-05-13 Thread Liam R. Howlett
ired, but given that we are > already doing a function call, no need to care about this > micro-optimization. > > Reviewed-by: Lorenzo Stoakes > Acked-by: Ingo Molnar # x86 bits > Signed-off-by: David Hildenbrand Reviewed-by: Liam R. Howlett &

Re: [PATCH v2 00/11] mm: rewrite pfnmap tracking and remove VM_PAT

2025-05-13 Thread Liam R. Howlett
t; Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: David Airlie > Cc: Simona Vetter > Cc: Andrew Morton > Cc: Steven Rostedt > Cc: Masami Hiramatsu > Cc: Mathieu Desnoyers > Cc: "Liam R. Howlett" > Cc: Lorenzo Stoakes > Cc:

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-08 Thread Liam R. Howlett
* Chuck Lever III [241108 08:23]: > > > > On Nov 7, 2024, at 8:19 PM, Yu Kuai wrote: > > > > Hi, > > > > 在 2024/11/07 22:41, Chuck Lever 写道: > >> On Thu, Nov 07, 2024 at 08:57:23AM +0800, Yu Kuai wrote: > >>> Hi, > >>> > >>> 在 2024/11/06 23:19, Chuck Lever III 写道: > > > > On

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-07 Thread Liam R. Howlett
* Yu Kuai [241106 19:57]: > Hi, > > 在 2024/11/06 23:19, Chuck Lever III 写道: > > > > > > > On Nov 6, 2024, at 1:16 AM, Greg KH wrote: > > > > > > On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: > > > > From: Yu Kuai > > > > > > > > Fix patch is patch 27, relied patches are from: > >

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread Liam R. Howlett
* Greg KH [241106 01:16]: > On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: > > From: Yu Kuai > > > > Fix patch is patch 27, relied patches are from: > > > > - patches from set [1] to add helpers to maple_tree, the last patch to > > improve fork() performance is not backported; > > S

Re: [PATCH drm-next v4 14/14] drm/nouveau: debugfs: implement DRM GPU VA debugfs

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:32]: > Provide the driver indirection iterating over all DRM GPU VA spaces to > enable the common 'gpuvas' debugfs file for dumping DRM GPU VA spaces. > > Signed-off-by: Danilo Krummrich > --- > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 39 +++

Re: [PATCH drm-next v4 03/14] drm: manager to keep track of GPUs VA mappings

2023-06-13 Thread Liam R. Howlett
* Danilo Krummrich [230606 18:32]: > Add infrastructure to keep track of GPU virtual address (VA) mappings > with a decicated VA space manager implementation. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace applications to request m

Re: [PATCH drm-next v4 02/14] maple_tree: split up MA_STATE() macro

2023-06-13 Thread Liam R. Howlett
iter_for_each_range(&si, sample, max) { > frob(mgr, sample); > } > > Signed-off-by: Danilo Krummrich Reviewed-by: Liam R. Howlett > --- > include/linux/maple_tree.h | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/linu

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-20 Thread Liam R. Howlett
* Danilo Krummrich [230313 19:46]: > On 3/7/23 23:43, Liam R. Howlett wrote: > > * Danilo Krummrich [230306 10:46]: > > > On 3/2/23 03:38, Liam R. Howlett wrote: > > > > * Danilo Krummrich [230227 08:17]: > > > > > > > > ... > >

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-07 Thread Liam R. Howlett
* Danilo Krummrich [230306 10:46]: > On 3/2/23 03:38, Liam R. Howlett wrote: > > * Danilo Krummrich [230227 08:17]: > > > > ... > > > > > Would this variant be significantly more efficient? > > > > > > > > Well, what you are doing

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-01 Thread Liam R. Howlett
* Danilo Krummrich [230227 08:17]: ... > > > Would this variant be significantly more efficient? > > > > Well, what you are doing is walking the tree to see if there's anything > > there... then re-walking the tree to store it. So, yes, it's much more > > efficient.. However, writing is heavie

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-28 Thread Liam R. Howlett
* Danilo Krummrich [230227 21:17]: > On Tue, Feb 21, 2023 at 01:20:50PM -0500, Liam R. Howlett wrote: > > * Danilo Krummrich [230217 08:45]: > > > Add infrastructure to keep track of GPU virtual address (VA) mappings > > > with a decicated VA space manager implementat

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-23 Thread Liam R. Howlett
* Danilo Krummrich [230222 13:13]: > On 2/21/23 19:20, Liam R. Howlett wrote: > > * Danilo Krummrich [230217 08:45]: > > > Add infrastructure to keep track of GPU virtual address (VA) mappings > > > with a decicated VA space manager implementation. > > >

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-21 Thread Liam R. Howlett
* Danilo Krummrich [230217 08:45]: > Add infrastructure to keep track of GPU virtual address (VA) mappings > with a decicated VA space manager implementation. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace applications to request m

Re: [PATCH drm-next v2 03/16] maple_tree: split up MA_STATE() macro

2023-02-21 Thread Liam R. Howlett
* Danilo Krummrich [230220 09:38]: > On 2/17/23 19:34, Liam R. Howlett wrote: > > * Danilo Krummrich [230217 08:44]: > > > Split up the MA_STATE() macro such that components using the maple tree > > > can easily inherit from struct ma_state and build custom tree walk

Re: [PATCH drm-next v2 03/16] maple_tree: split up MA_STATE() macro

2023-02-17 Thread Liam R. Howlett
* Danilo Krummrich [230217 08:44]: > Split up the MA_STATE() macro such that components using the maple tree > can easily inherit from struct ma_state and build custom tree walk > macros to hide their internals from users. > > Example: > > struct sample_iter { > struct ma_state mas; >

Re: [PATCH drm-next v2 04/16] maple_tree: add flag MT_FLAGS_LOCK_NONE

2023-02-17 Thread Liam R. Howlett
* Danilo Krummrich [230217 08:44]: > Generic components making use of the maple tree (such as the > DRM GPUVA Manager) delegate the responsibility of ensuring mutual > exclusion to their users. > > While such components could inherit the concept of an external lock, > some users might just serial