Re: [PATCH 1/1] drm/i915/hdcp: Simplify code in intel_hdcp_auth_downstream()

2021-05-28 Thread Leizhen (ThunderTown)
On 2021/5/27 18:04, Jani Nikula wrote: > On Thu, 27 May 2021, Zhen Lei wrote: >> If intel_hdcp_validate_v_prime() has been successful within the allowed >> number of tries, we can directly call drm_dbg_kms() and "goto out" without >> jumping out of the loop and repeatedly judging whether the op

Re: [Nouveau] [PATCH v2 1/2] drm/nouveau: Fix ida leak

2021-05-11 Thread Leizhen (ThunderTown)
On 2021/5/12 14:39, Pierre Moreau wrote: > Why remove the const modifier on `nb`? A non-pointer local variable, I don't think it's necessary to add const modifier to make the syntax too complicated. > > On 2021-05-11 — 16:28, Zhen Lei wrote: >> When the 'nb' value allocated from 'bl_ida' is g

Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_dsi_probe()

2021-05-11 Thread Leizhen (ThunderTown)
Hi everybody, Please ignore this patch and other "drm/mediatek". Looks like it would be better to combine them into a single patch. On 2021/5/11 18:00, Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resou

Re: [PATCH 1/1] drm/mediatek: Remove redundant error printing in mtk_cec_probe()

2021-05-11 Thread Leizhen (ThunderTown)
On 2021/5/11 21:13, Baruch Siach wrote: > Hi Zhen Lei, > > On Tue, May 11 2021, Zhen Lei wrote: >> When devm_ioremap_resource() fails, a clear enough error message will be >> printed by its subfunction __devm_ioremap_resource(). The error >> information contains the device name, failure cause,

Re: [PATCH v2 0/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-09 Thread Leizhen (ThunderTown)
On 2021/5/10 14:01, Anton Ivanov wrote: > On 10/05/2021 04:16, Zhen Lei wrote: >> v1 --> v2: >> According to Anton Ivanov's review comments, detele the unnecessary local >> variable initialization "ret = 0". >> >> >> Zhen Lei (1): >>    drm/msm/dpu: Fix error return code in dpu_mdss_init() >> >>

Re: [PATCH 1/1] drm/nouveau: fix error return code in nouveau_backlight_init()

2021-05-08 Thread Leizhen (ThunderTown)
On 2021/5/8 15:34, Pierre Moreau wrote: > Hello Zhen, > > There was a similar patch sent in last month, though which does not seem to > have been merged yet; see > https://lists.freedesktop.org/archives/nouveau/2021-April/038451.html. > > Whether `ret` should be `-ENOSPC` or `-ENOMEM` is hard

Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-08 Thread Leizhen (ThunderTown)
On 2021/5/8 15:58, Stephen Boyd wrote: > Quoting Leizhen (ThunderTown) (2021-05-08 00:55:04) >> >> >> On 2021/5/8 14:09, Stephen Boyd wrote: >>> Quoting Zhen Lei (2021-05-07 19:42:54) >>>> Fix to return a negative error code from the error handling ca

Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

2021-05-08 Thread Leizhen (ThunderTown)
On 2021/5/8 14:09, Stephen Boyd wrote: > Quoting Zhen Lei (2021-05-07 19:42:54) >> Fix to return a negative error code from the error handling case instead >> of 0, as done elsewhere in this function. >> >> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") >> Reported-by: Hulk R

Re: [PATCH 1/1] dt-bindings: eliminate yamllint warnings

2020-12-07 Thread Leizhen (ThunderTown)
On 2020/12/5 1:41, Mark Brown wrote: > On Fri, Dec 04, 2020 at 10:42:26AM +0800, Zhen Lei wrote: >> All warnings are related only to "wrong indentation", except one: >> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml:4:1: \ >> [error] missing document start "---" (document-start) > >

Re: [PATCH 0/1] dt-bindings: eliminate yamllint warnings

2020-12-04 Thread Leizhen (ThunderTown)
Sorry, Forgot to say: This patch is based on the latest linux-next code. On 2020/12/4 10:42, Zhen Lei wrote: > There're too many people, I just send to the maintainer, reviewer, supporter. > > Eliminate below warnings: > ./Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml:32:13: [warning

Re: [PATCH v4 00/23] device-dax: Support sub-dividing soft-reserved ranges

2020-08-22 Thread Leizhen (ThunderTown)
On 8/22/2020 7:21 AM, Andrew Morton wrote: > On Wed, 19 Aug 2020 18:53:57 -0700 Dan Williams > wrote: > >>> I think I am missing some important pieces. Bear with me. >> >> No worries, also bear with me, I'm going to be offline intermittently >> until at least mid-September. Hopefully Joao and