Re: [PATCH 3/6] drm/amdgpu: Flush VM updates for split bindings eagerly.

On 10/31/ , Christian König wrote: > Am 31.10.23 um 14:59 schrieb Bas Nieuwenhuizen: > > > > > > On Tue, Oct 31, 2023 at 2:57 PM Christian König > > wrote: > > > > Am 31.10.23 um 14:40 schrieb Tatsuyuki Ishi: > > > The current amdgpu_gem_va_update_vm only tries to perform > > update

Re: [PATCH] drm/amdgpu: Add description for AMD_IP_BLOCK_TYPE_VPE

type' > > Signed-off-by: Juntong Deng Thanks! Reviewed-by: Lang Yu > --- > drivers/gpu/drm/amd/include/amd_shared.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/include/amd_shared.h > b/drivers/gpu/drm/amd/include/amd_shared.h >

Re: [PATCH v2] drm/ttm: fix one use-after-free

On 07/05/ , Matthew Auld wrote: > On Wed, 5 Jul 2023 at 11:08, Lang Yu wrote: > > > > bo->kref is increased once(kref_init()) in ttm_bo_release, > > but decreased twice(ttm_bo_put()) respectively in > > ttm_bo_delayed_delete and ttm_bo_cleanup_refs, > > which

[PATCH v2] drm/ttm: fix one use-after-free

[ 67.403579] ? tomoyo_file_ioctl+0x19/0x20 [ 67.403590] __x64_sys_ioctl+0x95/0xd0 [ 67.403601] do_syscall_64+0x3b/0x90 [ 67.403609] entry_SYSCALL_64_after_hwframe+0x72/0xdc Signed-off-by: Lang Yu --- drivers/gpu/drm/ttm/ttm_bo.c | 89 1 file changed, 10 inse

Re: [PATCH] drm/ttm: fix one use-after-free

Please ignore this patch, it will cause another issue. Will send a new one. Regards, Lang On 07/05/ , Lang Yu wrote: > [ 67.399887] refcount_t: underflow; use-after-free. > [ 67.399901] WARNING: CPU: 0 PID: 3172 at lib/refcount.c:28 > refcount_warn_saturate+0xc2/0x110 > [ 67

[PATCH] drm/ttm: fix one use-after-free

+0x19/0x20 [ 67.403590] __x64_sys_ioctl+0x95/0xd0 [ 67.403601] do_syscall_64+0x3b/0x90 [ 67.403609] entry_SYSCALL_64_after_hwframe+0x72/0xdc Fixes: 9bff18d13473 ("drm/ttm: use per BO cleanup workers") Signed-off-by: Lang Yu --- drivers/gpu/drm/ttm/ttm_bo.c | 3 +++ 1 file

Re: Questions about KMS flip

On Tue, Nov 16, 2021 at 08:14:08AM +0100, Christian KKKnig wrote: > Am 16.11.21 um 04:27 schrieb Lang Yu: > > On Mon, Nov 15, 2021 at 01:04:15PM +0100, Michel DDDnzer wrote: > > > [SNIP] > > > > Though a single call to dce_v*_0_crtc_do_set_base() will > > >

[PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation

If a BO's backing store is temporary GTT memory, we should move it in BO validation. v2: move the check outside of for loop Signed-off-by: Lang Yu --- drivers/gpu/drm/ttm/ttm_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm

[PATCH v2 3/3] drm/amdgpu: allow temporary GTT allocation under memory pressure

it is not a temporary allocation bail out. v2: still account temporary GTT allocations Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 27 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 2 +- 3 files

[PATCH 2/3] drm/ttm: check with temporary GTT memory in BO validation

If a BO's backing store is temporary GTT memory, we should move it in BO validation. Signed-off-by: Lang Yu --- drivers/gpu/drm/ttm/ttm_bo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index c32a37d0a460..80c8cb2c3f31 1

[PATCH v2 1/3] drm/ttm: cleanup and add TTM_PL_FLAG_TEMPORARY flag

ments Suggested-by: Christian König Signed-off-by: Lang Yu --- include/drm/ttm/ttm_placement.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm/ttm_placement.h index aa6ba4d0cf78..9f5cfc7c2d5a 100644 --- a/include/dr

[PATCH 2/2] drm/amdgpu: stop bookkeeping of temporary GTT allocation

To improve buffer migration performace, stop bookkeeping of temporary GTT allocation, including allocation for BO evicted from VRAM and bounce buffer. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4

[PATCH 1/2] drm/ttm: cleanup and add TTM_PL_FLAG_TEMPORARY

Make TTM_PL_FLAG_* start from zero and add TTM_PL_FLAG_TEMPORARY flag for temporary GTT allocation use. Signed-off-by: Lang Yu --- include/drm/ttm/ttm_placement.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/ttm/ttm_placement.h b/include/drm/ttm