Re: [PATCH] omapfb: reduce stack usage

2019-10-18 Thread Ladislav Michl
On Fri, Oct 18, 2019 at 05:30:04PM +0100, Sudip Mukherjee wrote: > The build of xtensa allmodconfig is giving a warning of: > In function 'dsi_dump_dsidev_irqs': > warning: the frame size of 1120 bytes is larger than 1024 bytes > > Allocate the memory for 'struct dsi_irq_stats' dynamically instead

Re: [PATCH 08/21] udl-kms: avoid prefetch

2018-06-06 Thread Ladislav Michl
On Tue, Jun 05, 2018 at 10:08:02AM +, Alexey Brodkin wrote: > Hi Mikulas, > > On Sun, 2018-06-03 at 16:41 +0200, Mikulas Patocka wrote: > > Modern processors can detect linear memory accesses and prefetch data > > automatically, so there's no need to use prefetch. > > Not each and every CPU t

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-29 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 01:13:51PM +0100, SF Markus Elfring wrote: > Additional improvement possibilities can be taken into account > after corresponding software development discussions, can't they? Sure, but that is in contrary to all you replies. I guess you are familiar with Documentation/proc

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 11:50:14AM +0100, SF Markus Elfring wrote: > >> How will this aspect evolve further? > > > > I do not follow. > > Interesting … > > > This is OMAP framebuffer driver, so in this case, there is zero variation. > > How much are you interested to compare differences in buil

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 12:04:04AM -0800, Joe Perches wrote: > On Tue, 2017-11-28 at 08:41 +0100, SF Markus Elfring wrote: > > > > It seems that I got no responses so far for clarification requests > > > > according to the documentation in a direction I hoped for. > > > > > > That's because you ar

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Tue, Nov 28, 2017 at 11:15:37AM +0100, SF Markus Elfring wrote: > >>> Many people do not know that a generic kmalloc does a > >>> dump_stack() on OOM. > >> > >> This is another interesting information, isn't it? > >> > >> It is expected that the function “devm_kzalloc” has got a similar property

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Mon, Nov 27, 2017 at 08:22:51PM +0100, Ladislav Michl wrote: > On Mon, Nov 27, 2017 at 07:12:50PM +0100, SF Markus Elfring wrote: > > >> Can a default allocation failure report provide the information > > >> which you might expect so far? > > > > > &g

Re: [PATCH] omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Mon, Nov 27, 2017 at 03:33:13PM -0600, Andrew F. Davis wrote: > On 11/27/2017 01:07 PM, Joe Perches wrote: > > On Mon, 2017-11-27 at 10:43 -0600, Andrew F. Davis wrote: > >> On 11/26/2017 12:55 PM, SF Markus Elfring wrote: > >>> From: Markus Elfring > >>> Date: Sun, 26 Nov 2017 19:46:09 +0100 >

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Mon, Nov 27, 2017 at 07:12:50PM +0100, SF Markus Elfring wrote: > >> Can a default allocation failure report provide the information > >> which you might expect so far? > > > > You should be able to answer that question yourself. > > I can not answer this detail completely myself because my kn

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

2017-11-28 Thread Ladislav Michl
On Mon, Nov 27, 2017 at 06:27:08PM +0100, SF Markus Elfring wrote: > >> Omit an extra message for a memory allocation failure in these functions. > … > > nak, unlike many others, these message give extra info on which > > allocation failed, that can be useful. > > Can a default allocation failure