Re: [PATCH 4/4] drm/i915: Enable Y210, Y212, Y216 format for primary and sprite planes

On 8/27/2018 12:17 PM, Swati Sharma wrote: From: Vidya Srinivas In this patch, a list for icl specific pixel formats is created in which Y210, Y212 and Y216 pixel formats are added along with legacy pixel formats for primary and sprite plane. Signed-off-by: Swati Sharma Signed-off-by: Vidya

Re: [PATCH 3/4] drm/i915: Preparations for enabling Y210, Y212, Y216 formats

Hi, On 8/27/2018 12:17 PM, Swati Sharma wrote: From: Vidya Srinivas Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/intel_display.c | 15 +++ drivers/gpu/drm/i915/intel_sprite.c | 3 +++ 2 files changed, 18 insertions(+) diff --git a/dri

Re: [PATCH 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

On 8/27/2018 12:47 PM, Kumar, Mahesh wrote: Hi, On 8/27/2018 12:17 PM, Swati Sharma wrote: From: Vidya Srinivas The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies a

Re: [PATCH 2/4] drm/i915: Add Y210, Y212, Y216 plane control definitions

Hi, Please include platform name in subject line: On 8/27/2018 12:17 PM, Swati Sharma wrote: From: Vidya Srinivas Added needed plane control flag definitions for Y210, Y212 and Y216 formats. may be, add more info in commit message -Mahesh Signed-off-by: Swati Sharma Signed-off-by: Vid

Re: [PATCH 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

Hi, On 8/27/2018 12:17 PM, Swati Sharma wrote: From: Vidya Srinivas The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies a DWORD. Y210: Valid data occupies MSB 10 bits.

Re: [PATCH 00/10] Improve crc-core driver interface

Hi, thanks for the review. On 7/12/2018 4:38 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patches. When resubmitting patch series, could you please add a version number to the [PATCH] prefix ? Otherwise it gets difficult to figure out which version is the latest. This can be done

Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

Hi, Thanks for the review. On 7/10/2018 5:19 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in

Re: [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

Hi, thanks foe the review. On 7/10/2018 5:07 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote: This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@l

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

Hi, On 7/10/2018 5:40 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: On 7/10/2018 4:56 PM, Laurent Pinchart wrote: On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source&q

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

Hi, On 7/10/2018 5:39 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function

Re: [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

Hi, thanks for the review. On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

Hi, Thanks for the review, On 7/10/2018 4:56 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node an

Re: [PATCH 02/10] drm: crc: Introduce pre_crc_read function

Hi, On 6/27/2018 8:48 PM, Maarten Lankhorst wrote: Op 27-06-18 om 16:44 schreef Mahesh Kumar: This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. S

Re: [Intel-gfx] [PATCH 04/10] drm/rockchip/crc: Implement verify_crc_source callback

Hi, On 6/27/2018 5:30 PM, Jani Nikula wrote: On Tue, 26 Jun 2018, Mahesh Kumar wrote: This patch implements "verify_crc_source" callback function for rockchip drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 21 +

Re: [PATCH 09/10] drm/crc: Cleanup crtc_crc_open function

Cc: Laurent Pinchart On 6/26/2018 11:52 AM, Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable

Re: [PATCH 00/10] Improve crc-core driver interface

Cc:dri-devel@lists.freedesktop.org On 6/26/2018 11:52 AM, Mahesh Kumar wrote: This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current so

Re: [PATCH 06/10] drm/rcar-du/crc: Implement verify_crc_source callback

Cc: Laurent Pinchart On 6/26/2018 11:52 AM, Mahesh Kumar wrote: This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 +