Re: [PATCH v2 02/10] sysfs: introduce callback attribute_group::bin_size

2024-11-07 Thread Krzysztof Wilczyński
Hello, [...] > > There exist the sysfs_update_groups(), but the BAR resource sysfs objects > > are currently, at least not yet, added to any attribute group. > > then maybe they should be added to one :) Yeah. There is work in progress that will take care of some of this. Krzysztof

Re: [PATCH v2 02/10] sysfs: introduce callback attribute_group::bin_size

2024-11-06 Thread Krzysztof Wilczyński
Hello, > Several drivers need to dynamically calculate the size of an binary > attribute. Currently this is done by assigning attr->size from the > is_bin_visible() callback. > > This has drawbacks: > * It is not documented. > * A single attribute can be instantiated multiple times, overwriting t

Re: [PATCH v2 00/10] sysfs: constify struct bin_attribute (Part 1)

2024-11-03 Thread Krzysztof Wilczyński
n_attribute' itself. > > The techniques employed by this series can later be reused for the > same change for other sysfs attributes. > > This series is intended to be merged through the driver core tree. This is very nice. Thank you! For PCI changes: Acked-by: Krzysztof Wil

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

2024-07-09 Thread Krzysztof Wilczyński
[...] > pci_intx() calls into pcim_intx() in managed mode, i.e., when > pcim_enable_device() had been called. This recursive call causes a bug > by re-registering the device resource in the release callback. > > This is the same phenomenon that made it necessary to implement some > functionality a

Re: [PATCH v9 10/13] PCI: Give pci_intx() its own devres callback

2024-07-09 Thread Krzysztof Wilczyński
Hello Ashish and Philipp, > I have reviewed and tested this patch, looks to be working fine and fixes the > issue. Great news! Ashish, thank you for taking the time to report the problem and then also testing the fix. Much appreciated. Philipp, I will take this patch and squash into the serie

Re: [PATCH 00/24 v2] Documentation: correct lots of spelling errors (series 1)

2023-06-26 Thread Krzysztof Wilczyński
Hello, > Correct many spelling errors in Documentation/ as reported by codespell. > > Maintainers of specific kernel subsystems are only Cc-ed on their > respective patches, not the entire series. > > These patches are based on linux-next-20230209. > [...] > [PATCH 13/24] Documentation: PCI: c

Re: [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency

2021-11-20 Thread Krzysztof Wilczyński
Hi Jakub, [...] > drivers/pci/controller/dwc/pci-exynos.c | 1 + > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + Happy to give Acked-by: Krzysztof Wilczyński for the the PCI drivers. Thank you! Krzysztof