Re: [RFT][PATCH v2 9/9] vfio: Replace phys_pfn with pages for vfio_pin_pages()

2022-07-06 Thread Kirti Wankhede
Reviewed-by: Kirti Wankhede On 7/6/2022 11:57 AM, Nicolin Chen wrote: Most of the callers of vfio_pin_pages() want "struct page *" and the low-level mm code to pin pages returns a list of "struct page *" too. So there's no gain in converting "struct page *&qu

Re: [RFT][PATCH v2 4/9] vfio: Pass in starting IOVA to vfio_pin/unpin_pages API

2022-07-06 Thread Kirti Wankhede
Reviewed by: Kirti Wankhede On 7/6/2022 11:57 AM, Nicolin Chen wrote: The vfio_pin/unpin_pages() so far accepted arrays of PFNs of user IOVA. Among all three callers, there was only one caller possibly passing in a non-contiguous PFN list, which is now ensured to have contiguous PFN inputs

Re: [RFT][PATCH v2 1/9] vfio: Make vfio_unpin_pages() return void

2022-07-06 Thread Kirti Wankhede
Reviewed-by: Kirti Wankhede On 7/6/2022 11:57 AM, Nicolin Chen wrote: There's only one caller that checks its return value with a WARN_ON_ONCE, while all other callers do not check return value at all. So simplify the API to return void by embedding similar WARN_ON_ONCEs. Suggest

Re: [PATCH 34/34] vfio/mdev: Remove mdev drvdata

2022-04-12 Thread Kirti Wankhede
--- include/linux/mdev.h | 9 - 1 file changed, 9 deletions(-) Reviewed-by: Kirti Wankhede

Re: [PATCH 33/34] vfio/mdev: Use the driver core to create the 'remove' file

2022-04-12 Thread Kirti Wankhede
stoph Hellwig --- drivers/vfio/mdev/mdev_core.c| 1 + drivers/vfio/mdev/mdev_private.h | 2 ++ drivers/vfio/mdev/mdev_sysfs.c | 19 ++- 3 files changed, 13 insertions(+), 9 deletions(-) Reviewed-by: Kirti Wankhede

Re: [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops

2022-04-12 Thread Kirti Wankhede
++- samples/vfio-mdev/mdpy.c | 9 ++- samples/vfio-mdev/mtty.c | 9 ++- 11 files changed, 28 insertions(+), 92 deletions(-) Reviewed-by: Kirti Wankhede

Re: [PATCH 31/34] vfio/mdev: Remove mdev_parent_ops dev_attr_groups

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe This is only used by one sample to print a fixed string that is pointless. In general, having a device driver attach sysfs attributes to the parent is horrific. This should never happen, and always leads to some kind of li

Re: [PATCH 30/34] vfio/mdev: Remove vfio_mdev.c

2022-04-12 Thread Kirti Wankhede
t are connected to it. Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig Reviewed-by: Kirti Wankhede

Re: [PATCH 00/13] Provide core infrastructure for managing open/release

2021-07-15 Thread Kirti Wankhede
On 7/15/2021 5:50 AM, Jason Gunthorpe wrote: Prologue: This is the first series of three to send the "mlx5_vfio_pci" driver that has been discussed on the list for a while now. - Reorganize reflck to support splitting vfio_pci - Split vfio_pci into vfio_pci/vfio_pci_core and provide infra

Re: [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev()

2021-06-16 Thread Kirti Wankhede
x27;, probably 'vfio-mdev-mtty' or 'vfio-mtty' Rest looks fine to me. Reviewed-by: Kirti Wankhede

Re: [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind

2021-06-16 Thread Kirti Wankhede
/vfio/mdev/mdev_core.c | 30 ++ drivers/vfio/mdev/mdev_driver.c | 10 ++ include/linux/mdev.h| 2 ++ 3 files changed, 34 insertions(+), 8 deletions(-) Reviewed-by: Kirti Wankhede

Re: [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-06-16 Thread Kirti Wankhede
driver entirely. Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig Reviewed-by: Cornelia Huck Reviewed-by: Kirti Wankhede

Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe

2021-06-16 Thread Kirti Wankhede
ply the special casing only to that. Signed-off-by: Christoph Hellwig Reviewed-by: Kirti Wankhede

Re: [PATCH 02/10] driver core: Better distinguish probe errors in really_probe

2021-06-14 Thread Kirti Wankhede
On 6/14/2021 8:38 PM, Christoph Hellwig wrote: really_probe tries to special case errors from ->probe, but due to all other initialization added to the function over time now a lot of internal errors hit that code path as well. Untangle that by adding a new probe_err local variable and apply

Re: [PATCH 00/10] Allow mdev drivers to directly create the vfio_device

2021-06-14 Thread Kirti Wankhede
Jason, I couldn't find patch 1,2,4 and 5 of these series. Can you please keep k...@vger.kernel.org cc for all patches? Also it will be helpful if you can add version prefix, eg. 'v3' for this series, in subject line. Thanks, Kirti On 6/8/2021 6:25 AM, Jason Gunthorpe wrote: This is a "v3"

Re: [PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-10 Thread Kirti Wankhede
On 12/9/2019 7:31 PM, Jani Nikula wrote: On Tue, 03 Dec 2019, Jani Nikula wrote: Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Kirti Wankhede Cc: k...@vger.kernel.org Reviewed-by: Daniel Vetter

Re: [PATCH V11 2/6] modpost: add support for mdev class id

2019-11-08 Thread Kirti Wankhede
On 11/7/2019 8:41 PM, Jason Wang wrote: Add support to parse mdev class id table. Reviewed-by: Parav Pandit Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang Reviewed-by: Kirti Wankhede Thanks, Kirti --- drivers/vfio/mdev/vfio_mdev.c | 2 ++ scripts/mod/devicetable

Re: [PATCH V11 3/6] mdev: introduce device specific ops

2019-11-08 Thread Kirti Wankhede
structure. This allows different set of callback to be used by vfio-mdev and virtio-mdev. Reviewed-by: Parav Pandit Signed-off-by: Jason Wang Reviewed-by: Kirti Wankhede Thanks, Kirti --- .../driver-api/vfio-mediated-device.rst | 35 + MAINTAINERS

Re: [PATCH V11 1/6] mdev: class id support

2019-11-08 Thread Kirti Wankhede
od to pair the mdev device and mdev driver correctly. So this patch adds id_table to mdev_driver and class_id for mdev device with the match method for mdev bus. Reviewed-by: Parav Pandit Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang Reviewed-by: Kirti Wankhede Thanks,

Re: [PATCH V11 4/6] mdev: introduce virtio device and its device ops

2019-11-08 Thread Kirti Wankhede
On 11/7/2019 8:41 PM, Jason Wang wrote: This patch implements basic support for mdev driver that supports virtio transport for kernel virtio driver. Reviewed-by: Cornelia Huck Signed-off-by: Jason Wang I'm not expert on virtio part, my ack is from mdev perspective. Reviewed-by:

Re: [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-09 Thread Kirti Wankhede
On 8/8/2017 11:37 PM, Alex Williamson wrote: > On Tue, 8 Aug 2017 14:18:07 +0530 > Kirti Wankhede wrote: > >> On 8/7/2017 11:13 PM, Alex Williamson wrote: >>> On Mon, 7 Aug 2017 08:11:43 + >>> "Zhang, Tina" wrote: >>> >>>

Re: [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-08 Thread Kirti Wankhede
On 8/7/2017 11:13 PM, Alex Williamson wrote: > On Mon, 7 Aug 2017 08:11:43 + > "Zhang, Tina" wrote: > >> After going through the previous discussions, here are some summaries may be >> related to the current discussion: >> 1. How does user mode figure the device capabilities between region

Re: [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-02 Thread Kirti Wankhede
On 8/2/2017 2:48 AM, Alex Williamson wrote: > On Tue, 25 Jul 2017 17:28:18 +0800 > Tina Zhang wrote: > >> Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and >> get the plan and its related information. >> >> The dma-buf's life cycle is handled by user mode and tracked by k