Sure Pierre
Go ahead and get them merged. I am also planning to use that information
in debugfs implementation of some parameters of our driver so I do need
those. I will drop my debugfs patch.
Regards
Sunil Khatri
On 5/28/2025 6:32 PM, Christian König wrote:
On 5/28/25 14:33, Pierre-Eric P
-
From: Pierre-Eric Pelloux-Prayer
Sent: Wednesday, May 28, 2025 6:03 PM
To: Koenig, Christian ; Khatri, Sunil
; dri-devel@lists.freedesktop.org; Tvrtko Ursulin
; dmitry.osipe...@collabora.com; Pelloux-Prayer,
Pierre-Eric
Subject: Re: [PATCH] drm/debugfs: add client-id to the debugfs entry
Hi
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: Koenig, Christian
Sent: Wednesday, May 28, 2025 4:44 PM
To: Khatri, Sunil ; dri-devel@lists.freedesktop.org;
Tvrtko Ursulin ; dmitry.osipe...@collabora.com;
Pelloux-Prayer, Pierre-Eric
Subject: Re
[AMD Official Use Only - AMD Internal Distribution Only]
Ping ?
Not picked yet while patches raised before this are merged.
Regards
Sunil Khatri
-Original Message-
From: Koenig, Christian
Sent: Tuesday, April 29, 2025 12:49 PM
To: Khatri, Sunil ; dri-devel@lists.freedesktop.org
ed to drm-misc-next.
Christian "
-Original Message-
From: Jani Nikula
Sent: Monday, April 28, 2025 5:20 PM
To: Khatri, Sunil ; Koenig, Christian
; Khatri, Sunil ;
dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; David Airlie
; Simona Vetter ; Maxime Ripard
; Maarten
, Pierre-Eric ; Khatri, Sunil
Subject: [PATCH v2] drm/sched: fix the warning in drm_sched_job_done
Fix the below warning.
scheduler/sched_main.c:397: warning: Function parameter or struct member
'result' not described in 'drm_sched_job_done'
Reviewed-by: Tvrtko Ursulin
On 4/22/2025 2:33 PM, Christian König wrote:
Am 17.04.25 um 18:10 schrieb Sunil Khatri:
Add a drm helper function which appends the process information for
the drm_file over drm_err formatted output.
v5: change to macro from function (Christian Koenig)
add helper functions for lock/unloc
[AMD Official Use Only - AMD Internal Distribution Only]
Thanks a lot.
Regards
Sunil Khatri
-Original Message-
From: Maarten Lankhorst
Sent: Tuesday, April 22, 2025 10:24 PM
To: Khatri, Sunil ; Khatri, Sunil ;
dri-devel@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
On 4/22/2025 2:07 PM, Christian König wrote:
Am 17.04.25 um 18:10 schrieb Sunil Khatri:
drm_file will be used in usermode queues code to
enable better process information in logging and hence
add drm_file part of the userq_mgr struct.
update the drm_file pointer in userq_mgr for each
amdgpu_d
@Lankhorst
Does the comment sounds correct or could you please share what should be
the right comment to add
Regards
Sunil Khatri
On 4/21/2025 4:49 PM, Sunil Khatri wrote:
fix the below warning messages:
ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not
described
On 4/17/2025 3:51 PM, Tvrtko Ursulin wrote:
On 17/04/2025 11:01, Sunil Khatri wrote:
Fix the below warning.
scheduler/sched_main.c:397: warning: Function parameter or struct
member 'result' not described in 'drm_sched_job_done'
Reviewed-by: Tvrtko Ursulin
Signed-off-by: Sunil Khatri
---
For rest of the patches which are part of the amdgpu tree will push
incorporating changes as shared by @Tvrtko Ursulin
once drm change is merged.
Thanks a lot all for the reviews.
Regards
Sunil Khatri
On 4/17/2025 6:01 PM, Sunil Khatri wrote:
Add a drm helper function which append the proc
On 4/17/2025 5:01 PM, Tvrtko Ursulin wrote:
On 17/04/2025 10:34, Sunil Khatri wrote:
fix the below warning messages:
ttm/ttm_bo.c:1098: warning: Function parameter or struct member
'hit_low' not described in 'ttm_bo_swapout_walk'
ttm/ttm_bo.c:1098: warning: Function parameter or struct membe
On 4/17/2025 7:04 PM, Tvrtko Ursulin wrote:
On 17/04/2025 13:31, Sunil Khatri wrote:
Add a drm helper function which append the process information for
appends
Noted
the drm_file over drm_err formated output.
formatted
'Noted
v5: change to macro from function (Christian Koenig)
On 4/17/2025 7:11 PM, Tvrtko Ursulin wrote:
On 17/04/2025 13:31, Sunil Khatri wrote:
use drm_file_err instead of DRM_ERROR which adds
process and pid information in the userqueue error
logging.
Sample log:
[ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]]
*ERROR* Timed out wait
[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: Jani Nikula
Sent: Thursday, April 17, 2025 5:00 PM
To: Koenig, Christian ; Khatri, Sunil
; dri-devel@lists.freedesktop.org;
amd-...@lists.freedesktop.org
Cc: Deucher, Alexander ; Tvrtko Ursulin
; Pelloux
On 4/17/2025 3:01 PM, Tvrtko Ursulin wrote:
[Added Philipp and Danilo to cc.]
On 17/04/2025 10:25, Sunil Khatri wrote:
Fix the below warning.
scheduler/sched_main.c:397: warning: Function parameter or struct
member 'result' not described in 'drm_sched_job_done'
Signed-off-by: Sunil Khatri
On 4/16/2025 7:55 PM, Jani Nikula wrote:
On Wed, 16 Apr 2025, Sunil Khatri wrote:
Add a drm helper macro which append the process information for
the drm_file over drm_err.
Signed-off-by: Sunil Khatri
---
include/drm/drm_file.h | 41 +
1 file changed,
On 4/16/2025 7:55 PM, Jani Nikula wrote:
On Wed, 16 Apr 2025, Sunil Khatri wrote:
Add a drm helper macro which append the process information for
the drm_file over drm_err.
Signed-off-by: Sunil Khatri
---
include/drm/drm_file.h | 41 +
1 file changed,
On 4/16/2025 5:37 PM, Pierre-Eric Pelloux-Prayer wrote:
Hi,
Le 16/04/2025 à 12:01, Khatri, Sunil a écrit :
On 4/16/2025 12:56 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
add process and pid information in the userqueue error
logging to make it more useful in
On 4/16/2025 12:56 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
add process and pid information in the userqueue error
logging to make it more useful in resolving the error
by logs.
Sample log:
[ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]]
*ERROR* Time
On 4/16/2025 12:59 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
drm_file will be used in usermode queues code to
enable better process information in logging and hence
add drm_file part of the userq_mgr struct.
update the drm_file pointer in userq_mgr for each
amdgpu_dr
On 4/16/2025 12:37 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
Add a drm helper function which get the process information for
the drm_file and append the process information using the existing
drm_err.
Signed-off-by: Sunil Khatri
---
include/drm/drm_file.h | 40 +++
On 4/16/2025 12:48 PM, Tvrtko Ursulin wrote:
On 15/04/2025 19:43, Sunil Khatri wrote:
change the DRM_ERROR to drm_file_err which gives the drm device
information too which is useful in case of multiple GPU's and also
add process information.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm
On 4/15/2025 5:10 PM, Tvrtko Ursulin wrote:
On 15/04/2025 12:25, Sunil Khatri wrote:
Add helper function which get the process information for
the drm_file and updates the user provided character buffer
with the information of process name and pid as a string.
Signed-off-by: Sunil Khatri
--
On 4/15/2025 2:14 PM, Tvrtko Ursulin wrote:
On 14/04/2025 18:58, Christian König wrote:
Adding Pierre-eric and Tvrtko as well.
Thanks!
Am 11.04.25 um 15:04 schrieb Sunil Khatri:
Add helper function which get the process information for
the drm_file and updates the user provided character
Ping?
On 4/11/2025 6:34 PM, Sunil Khatri wrote:
Add helper function which get the process information for
the drm_file and updates the user provided character buffer
with the information of process name and pid as a string.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/drm_file.c | 30
On 4/11/2025 7:54 PM, Alex Deucher wrote:
On Fri, Apr 11, 2025 at 9:05 AM Sunil Khatri wrote:
add process and pid information in the userqueue error
logging to make it more useful in resolving the error
by logs.
Sample log:
[ 42.444297] [drm:amdgpu_userqueue_wait_for_signal [amdgpu]] *ERRO
[AMD Official Use Only - AMD Internal Distribution Only]
Sure, I will send the patch for the user too.
Regards
Sunil Khatri
-Original Message-
From: Koenig, Christian
Sent: Friday, April 11, 2025 5:40 PM
To: Khatri, Sunil ; dri-devel@lists.freedesktop.org;
amd
On 3/28/2024 8:38 AM, Alex Deucher wrote:
On Tue, Mar 26, 2024 at 1:31 PM Sunil Khatri wrote:
Add FW information of all the IP's in the devcoredump.
Signed-off-by: Sunil Khatri
Might want to include the vbios version info as well, e.g.,
atom_context->name
atom_context->vbios_pn
atom_contex
On 3/26/2024 10:23 PM, Alex Deucher wrote:
On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote:
dump the bios binary in the devcoredump.
Signed-off-by: Sunil Khatri
---
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++
1 file changed, 20 insertions(+)
diff --git a/
...@vger.kernel.org; Zhang, Hawking ; Kuehling,
Felix ; Lazar, Lijo ; Khatri, Sunil
Subject: [PATCH v2] drm/amdgpu: refactor code to reuse system information
Refactor the code so debugfs and devcoredump can reuse the common information
and avoid unnecessary copy of it.
created a new file which
Sent a new patch based on discussion with Alex.
On 3/19/2024 8:34 PM, Christian König wrote:
Am 19.03.24 um 15:59 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 10:56 AM Christian König
wrote:
Am 19.03.24 um 15:26 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri
wrote:
Ref
On 3/19/2024 8:07 PM, Christian König wrote:
Am 19.03.24 um 15:25 schrieb Sunil Khatri:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used betwee
On 3/19/2024 7:43 PM, Lazar, Lijo wrote:
On 3/19/2024 7:27 PM, Khatri, Sunil wrote:
On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a
On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between sy
Validated the code by using the function in same way as ioctl would use
in devcoredump and getting the valid values.
Also this would be the container of the information that we need to
share between ioctl, debugfs and devcoredump and keep updating this
based on information needed.
On 3/19/2
On 3/15/2024 6:45 PM, Alex Deucher wrote:
On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote:
Add all the IP's version information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
This looks great.
Reviewed-by: Alex Deucher
Thanks Alex
---
drivers/gpu/drm/amd/amdgpu/amdgp
;
linux-ker...@vger.kernel.org; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: add the hw_ip version of all IP's
Add all the IP's version information on a SOC to the devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++
1 fi
On 3/14/2024 8:12 PM, Alex Deucher wrote:
On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote:
On 3/14/2024 1:58 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote:
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil K
On 3/14/2024 11:40 AM, Sharma, Shashank wrote:
On 14/03/2024 06:58, Khatri, Sunil wrote:
On 3/14/2024 2:06 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri
wrote:
Add firmware version information of each
IP and each instance where applicable.
Is there a way we can
On 3/14/2024 2:06 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote:
Add firmware version information of each
IP and each instance where applicable.
Is there a way we can share some common code with devcoredump,
debugfs, and the info IOCTL? All three places need to
On 3/14/2024 1:58 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote:
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 19 +++
1 file changed, 19 insertions(+)
di
c: amd-...@lists.freedesktop.org ;
dri-devel@lists.freedesktop.org ;
linux-ker...@vger.kernel.org ; Khatri, Sunil
Subject: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's
Add firmware version information of each
IP and each instance where applicable.
Signed-off-by: Sunil Khatri
---
drivers/
c: amd-...@lists.freedesktop.org ;
dri-devel@lists.freedesktop.org ;
linux-ker...@vger.kernel.org ; Khatri, Sunil
Subject: [PATCH 1/2] drm/amdgpu: add the IP information of the soc
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm
c: amd-...@lists.freedesktop.org ;
dri-devel@lists.freedesktop.org ;
linux-ker...@vger.kernel.org ; Khatri, Sunil
Subject: [PATCH 1/2] drm/amdgpu: add the IP information of the soc
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm
On 3/11/2024 7:29 PM, Christian König wrote:
Am 11.03.24 um 13:22 schrieb Sunil Khatri:
Add relevant ringbuffer information such as
rptr, wptr, ring name, ring size and also
the ring contents for each ring on a gpu reset.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_
-ker...@vger.kernel.org; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: add all ringbuffer information in devcoredump
Add ringbuffer information such as:
rptr, wptr, ring name, ring size and also the ring contents for each ring on a
gpu reset.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd
On 3/8/2024 2:39 PM, Christian König wrote:
Am 07.03.24 um 21:50 schrieb Sunil Khatri:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name: soft_reco
On 3/8/2024 12:44 AM, Alex Deucher wrote:
On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name: s
On 3/7/2024 6:10 PM, Christian König wrote:
Am 07.03.24 um 09:37 schrieb Khatri, Sunil:
On 3/7/2024 1:47 PM, Christian König wrote:
Am 06.03.24 um 19:19 schrieb Sunil Khatri:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
On 3/7/2024 1:47 PM, Christian König wrote:
Am 06.03.24 um 19:19 schrieb Sunil Khatri:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name: soft_reco
...@vger.kernel.org; Joshi, Mukul ; Paneer
Selvam, Arunpravin ; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: add vm fault information to devcoredump
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module
...@vger.kernel.org; Joshi, Mukul ; Paneer
Selvam, Arunpravin ; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: cache in more vm fault information
When an page fault interrupt is raised there is a lot more information that is
useful for developers to analyse the pagefault.
Add all such information
, we just need to provide faulting address, Fault status
register with gpu family to decode the fault along with process information.
Regards
Sunil Khatri
On 3/6/2024 9:56 PM, Khatri, Sunil wrote:
On 3/6/2024 9:49 PM, Christian König wrote:
Am 06.03.24 um 17:06 schrieb Khatri, Sunil:
On 3/6
On 3/6/2024 9:59 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote:
On 3/6/2024 9:45 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote:
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6
On 3/6/2024 9:49 PM, Christian König wrote:
Am 06.03.24 um 17:06 schrieb Khatri, Sunil:
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8
On 3/6/2024 9:45 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote:
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote:
On 3/6/2024 6:12 PM, Christian König wrote:
Am 06.03.24 um
On 3/6/2024 9:19 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote:
On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote:
On 3/6/2024 6:12 PM, Christian König wrote:
Am 06.03.24 um 11:40 schrieb Khatri, Sunil:
On 3/6/2024 3:37 PM, Christian König wrote:
Am 06.03.24 um
On 3/6/2024 6:12 PM, Christian König wrote:
Am 06.03.24 um 11:40 schrieb Khatri, Sunil:
On 3/6/2024 3:37 PM, Christian König wrote:
Am 06.03.24 um 10:04 schrieb Sunil Khatri:
When an page fault interrupt is raised there
is a lot more information that is useful for
developers to analyse
On 3/6/2024 3:37 PM, Christian König wrote:
Am 06.03.24 um 10:04 schrieb Sunil Khatri:
When an page fault interrupt is raised there
is a lot more information that is useful for
developers to analyse the pagefault.
Well actually those information are not that interesting because they
are h
On 3/5/2024 6:40 PM, Christian König wrote:
Am 05.03.24 um 12:58 schrieb Sunil Khatri:
Add ring timeout related information in the amdgpu
devcoredump file for debugging purposes.
During the gpu recovery process the registered call
is triggered and add the debug information in data
file create
64 matches
Mail list logo
