[PATCH] drm/display: Increase DP_RECEIVER_CAP_SIZE from 15 to 16 bytes

2025-07-02 Thread Khaled Almahallawy
c 5.1.4 Source Device Behavior upon HPD Pulse Detection Cc: Uma Shankar Cc: Sean Paul Cc: Jonathan Cavitt Cc: Jani Nikula Signed-off-by: Khaled Almahallawy --- include/drm/display/drm_dp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/display/drm_dp.h b/include/

[PATCH] drm/display/dp: Update the name of bit#4 of DPCD TEST_REQUEST

2023-12-14 Thread Khaled Almahallawy
DP_TEST_LINK_FAUX_PATTERN is deprecated since DP1.3 Spec. Update to the latest definition in DP2.1 spec to reflect its true usage in the code. Cc: Jani Nikula Cc: Rob Clark Cc: Abhinav Kumar Cc: Sean Paul Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/msm/dp/dp_link.c | 2 +- include

[PATCH v2] drm/display/dp: Add the remaining Square PHY patterns DPCD register definitions

2023-11-30 Thread Khaled Almahallawy
Transmitter Equalization Cc: Jani Nikula Cc: Imre Deak Cc: Lee Shawn C Signed-off-by: Khaled Almahallawy --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index 83d2039c018b..3731828825bd 100644

[PATCH] drm/display/dp: Add the remaining Square PHY patterns DPCD register definitions

2023-09-01 Thread Khaled Almahallawy
DP Scope may send requests for all Square PHY pattern configuration during automation. Add them instead of failing these tests. Cc: Jani Nikula Cc: Lee Shawn C Signed-off-by: Khaled Almahallawy --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm

[PATCH] drm/display: Don't rewrite link config when setting phy test pattern

2022-09-15 Thread Khaled Almahallawy
Cc: Jani Nikula Cc: Or Cochvi Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/display/drm_dp_helper.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c index 92990a3d577a..9f055d9710ea 100644

[PATCH] drm/dp: Don't rewrite link config when setting phy CTS test pattern with LTTPR

2022-04-07 Thread Khaled Almahallawy
just change PHY test patterns and swing/pre-emph levels. [1]: LTTPR Re-timer PHY test procedure proposal https://groups.vesa.org/wg/Link/document/16521 Cc: Imre Deak Cc: Jani Nikula Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/dp/drm_dp.c | 9 - 1 file changed, 9 deleti

[RFC PATCH 4/4] drm/msm/dp: Use DPCD 248h DP 2.0 new names/definitions

2021-10-20 Thread Khaled Almahallawy
(CP2520; Normative)) That is why the change from DP_PHY_TEST_PATTERN_SEL_MASK to DP_LINK_QUAL_PATTERN_CP2520_PAT_3 No functional changes Cc: Chandan Uddaraju Cc: Kuogee Hsieh Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/msm/dp/dp_catalog.c | 12 ++-- drivers/gpu/drm/msm/dp

[RFC PATCH 2/4] drm/i915/dp: Use DP 2.0 LINK_QUAL_PATTERN_* Phy test pattern definitions

2021-10-20 Thread Khaled Almahallawy
Update selected phy test pattern names to use the new names/definitions of DPCD 248h in DP2.0/drm_dp_helpers.h No functional changes Cc: Manasi Navare CC: Jani Nikula Cc: Imre Deak Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 12 ++-- 1 file

[RFC PATCH 3/4] drm/amd/dc: Use DPCD 248h DP 2.0 new name

2021-10-20 Thread Khaled Almahallawy
Use the new definition of DPCD 248h (DP_LINK_QUAL_PATTERN_SELECT) No functional changes. Cc: Harry Wentland Cc: Alex Deucher Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[RFC PATCH 0/4] drm/dp: Use DP2.0 DPCD 248h updated register/field names for DP PHY CTS

2021-10-20 Thread Khaled Almahallawy
://groups.vesa.org/wg/AllMem/documentComment/2738 Khaled Almahallawy (4): drm/dp: Rename DPCD 248h according to DP 2.0 specs drm/i915/dp: Use DP 2.0 LINK_QUAL_PATTERN_* Phy test pattern definitions drm/amd/dc: Use DPCD 248h DP 2.0 new name drm/msm/dp: Use DPCD 248h DP 2.0 new names/definitions

[RFC PATCH 1/4] drm/dp: Rename DPCD 248h according to DP 2.0 specs

2021-10-20 Thread Khaled Almahallawy
” https://groups.vesa.org/wg/AllMem/documentComment/2738 Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/drm_dp_helper.c | 6 +++--- include/drm/drm_dp_helper.h | 13 +++-- 2 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers

[RFC PATCH 2/2] drm/i915/dp: Retry AUX requests 7 times.

2021-02-10 Thread Khaled Almahallawy
Given that intel_dp_aux_xfer retries 5 times, so configure drm_dpcd_access to retry only 7 times, which means the max number of retries for i915 = 7 * 5 = 35 times. Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 ++ 1 file changed, 2 insertions(+) diff

[RFC PATCH 1/2] drm/dp: Make number of AUX retries configurable by display drivers.

2021-02-10 Thread Khaled Almahallawy
variable to allow for fine tuning and optimization of aux timing. Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/drm_dp_helper.c | 10 +++--- include/drm/drm_dp_helper.h | 1 + 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b

[PATCH v2 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3

2020-07-22 Thread Khaled Almahallawy
Add the missing CP2520 pattern 2 and 3 phy compliance patterns v2: cosemtic changes Reviewed-by: Manasi Navare (v1) Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/drm_dp_helper.c | 2 +- include/drm/drm_dp_helper.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

2020-07-22 Thread Khaled Almahallawy
Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. v2: uniform bit names TP4a/b/c (Manasi) Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 14 -- drivers/gpu/drm/i915/i915_reg.h | 4 2 files changed, 16 insertions

[PATCH 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3

2020-07-20 Thread Khaled Almahallawy
Add the missing CP2520 pattern 2 and 3 phy compliance patterns Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/drm_dp_helper.c | 2 +- include/drm/drm_dp_helper.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm

[PATCH 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

2020-07-20 Thread Khaled Almahallawy
Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 14 -- drivers/gpu/drm/i915/i915_reg.h | 4 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu