[PATCH v4 7/7] drm/panthor: Add support for Mali-Gx20 and Mali-Gx25 GPUs

patch enables FLUSH_CACHES for both families of GPUs via the PANTHOR_HW_FEATURE_GPU_CTRL_CACHE_FLUSH bit until FLUSH_PA_RANGE support is added. It also adds the aforementioned register definitions and firmware binary support for arch 12.8 and 13.8. Signed-off-by: Karunika Choo --- drivers/gp

[PATCH v3 7/7] drm/panthor: Add support for Mali-G720 and Mali-G725 GPUs

patch enables FLUSH_CACHES for both families of GPUs via the PANTHOR_HW_FEATURE_GPU_CTRL_CACHE_FLUSH bit until FLUSH_PA_RANGE support is added. It also adds the aforementioned register definitions and firmware binary support for arch 12.8 and 13.8. Signed-off-by: Karunika Choo --- drivers/gp

[PATCH v4 2/7] drm/panthor: Move GPU info initialization into panthor_hw.c

necessary register reads behind GPU architecture version guards if the change is minor. For more complex changes, the function can be forked and we can leverage the panthor_hw_ops structure to provide architecture specific initialization routines. Signed-off-by: Karunika Choo --- drivers/gpu/drm

[PATCH v4 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

also enables cache maintenance via GPU_CONTROL for Mali-Gx10 and Mali-Gx15 GPUs for consistency. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 6 + drivers/gpu/drm/panthor/panthor_hw.h | 6 + drivers/gpu/drm/panthor/panthor_mmu.c | 35

[PATCH v4 5/7] drm/panthor: Add support for Mali-Gx15 family of GPUs

Us. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h | 3 +++ 4 files c

[PATCH v3 4/7] drm/panthor: Add support for Mali-G710, Mali-G510 and Mali-G310

This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v4 0/7] Add GPU specific initialization framework to support new Mali GPUs

current implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Thanks, Karunika Choo Karunika Choo (7): drm/panthor: Add GPU specific initialization

[PATCH v4 3/7] drm/panthor: Simplify getting the GPU model name

ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 2 + 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/pantho

[PATCH v3 0/7] Add GPU specific initialization framework to support new Mali GPUs

G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Thanks, Karunika Choo Karunika Choo (7): drm/panthor: Add GPU specific initialization framework drm/panthor: Move GPU info initialization into panthor_hw.c drm/panthor: Make

[PATCH v3 3/7] drm/panthor: Make getting GPU model name simple and extensible

ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 2 + 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/pantho

[PATCH v3 5/7] drm/panthor: Add support for Mali-Gx15 family of GPUs

Us. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h | 3 +++ 4 files c

[PATCH v3 6/7] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

also enables cache maintenance via GPU_CONTROL for Mali-Gx10 and Mali-Gx15 GPUs for consistency. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 6 + drivers/gpu/drm/panthor/panthor_hw.h | 6 + drivers/gpu/drm/panthor/panthor_mmu.c | 35

[PATCH v3 2/7] drm/panthor: Move GPU info initialization into panthor_hw.c

necessary register reads behind GPU architecture version guards if the change is minor. For more complex changes, the function can be forked and we can leverage the panthor_hw_ops structure to provide architecture specific initialization routines. Signed-off-by: Karunika Choo --- drivers/gpu/drm

[PATCH v3 1/7] drm/panthor: Add GPU specific initialization framework

This patch provides an initialization framework for multiple Mali GPUs by introducing a GPU support look-up table. Each entry contains, at minimum, the architecture major version of the GPU, and may optionally provide feature flags and register offset overrides. Signed-off-by: Karunika Choo

[PATCH v3 3/7] drm/panthor: Simplify getting the GPU model name

ed GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 2 + 2 files changed, 19 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/pantho

[PATCH v3 5/7] drm/panthor: Add support for Mali-G715 family of GPUs

and Mali-G615 GPUs. - arch 11.8 FW binary support Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 18 ++ drivers/gpu/drm/panthor/panthor_regs.h | 11 +++ include/uapi/drm/panthor_drm.h |

[PATCH v4 0/2] drm/panthor: Add 64-bit register accessors

-devel/20250410163546.919749-1-karunika.c...@arm.com/ Kind regards, Karunika Choo Karunika Choo (2): drm/panthor: Add 64-bit and poll register accessors drm/panthor: Clean up 64-bit register definitions drivers/gpu/drm/panthor/panthor_device.h | 71 ++ drivers/gpu/drm/panthor

[PATCH v4 2/2] drm/panthor: Clean up 64-bit register definitions

: Boris Brezillon Suggested-by: Boris Brezillon Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_drv.c | 4 +- drivers/gpu/drm/panthor/panthor_gpu.c | 8 +-- drivers/gpu/drm/panthor/panthor_gpu.h | 10 +-- drivers/gpu/drm/panthor/panthor_mmu.c | 16 ++--- drivers/gpu/drm

[PATCH v4 1/2] drm/panthor: Add 64-bit and poll register accessors

: Boris Brezillon Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_device.h | 71 ++ drivers/gpu/drm/panthor/panthor_drv.c| 4 +- drivers/gpu/drm/panthor/panthor_fw.c | 9 +- drivers/gpu/drm/panthor/panthor_gpu.c| 159 +-- drivers/gpu/drm

[PATCH v2 1/2] drm/panthor: Add 64-bit and poll register accessors

This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. This patch also updates Panthor to use the new 64-bit accessors and poll functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor

[PATCH v3 1/2] drm/panthor: Add 64-bit and poll register accessors

This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. This patch also updates Panthor to use the new 64-bit accessors and poll functions. Reviewed-by: Boris Brezillon Signed-off-by: Karunika Choo

[PATCH v3 0/2] drm/panthor: Add 64-bit register accessors

register definitions and renamed *_LO registers - Link to v1: https://lore.kernel.org/dri-devel/20250410163546.919749-1-karunika.c...@arm.com/ Kind regards, Karunika Choo Karunika Choo (2): drm/panthor: Add 64-bit and poll register accessors drm/panthor: Clean up 64-bit register definitions

[PATCH v3 2/2] drm/panthor: Clean up 64-bit register definitions

-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_gpu.c | 12 ++-- drivers/gpu/drm/panthor/panthor_gpu.h | 10 +-- drivers/gpu/drm/panthor/panthor_mmu.c | 16 ++--- drivers/gpu/drm/panthor/panthor_regs.h | 94 +- 4 files changed, 52 insertions(+), 80 deletions

Re: [PATCH] drm/panthor: Add 64-bit and poll register accessors

On 10/04/2025 17:46, Boris Brezillon wrote: > On Thu, 10 Apr 2025 17:35:46 +0100 > Karunika Choo wrote: > >> This patch adds 64-bit register accessors to simplify register access in >> Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. >> >>

[PATCH v2 2/2] drm/panthor: Clean up 64-bit register definitions

With the introduction of 64-bit register accessors, the separate *_HI definitions are no longer necessary. This change removes them and renames the corresponding *_LO entries for cleaner and more consistent register definitions. Suggested-by: Boris Brezillon Signed-off-by: Karunika Choo

[PATCH v2 0/2] drm/panthor: Add 64-bit register accessors

...@arm.com/ Kind regards, Karunika Choo Karunika Choo (2): drm/panthor: Add 64-bit and poll register accessors drm/panthor: Clean up 64-bit register definitions drivers/gpu/drm/panthor/panthor_device.h | 71 drivers/gpu/drm/panthor/panthor_fw.c | 9 +- drivers/gpu/drm/panthor

[PATCH] drm/panthor: Add 64-bit and poll register accessors

This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. This patch also updates Panthor to use the new 64-bit accessors and poll functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor

Re: [PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

On 10/04/2025 14:28, Boris Brezillon wrote: > On Wed, 9 Apr 2025 14:00:54 +0100 > Karunika Choo wrote: > >> On 21/03/2025 07:48, Boris Brezillon wrote: >>> On Thu, 20 Mar 2025 11:17:33 + >>> Karunika Choo wrote: >>> >>>> This pat

Re: [PATCH v2 5/9] drm/panthor: Make getting GPU model name simple and extensible

On 21/03/2025 08:02, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:37 + > Karunika Choo wrote: > >> This patch replaces the previous panthor_model structure with a simple >> switch case based on the product_id, which is in the format of: >> ((arch_m

Re: [PATCH v2 2/9] drm/panthor: Use 64-bit and poll register accessors

On 21/03/2025 07:53, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:34 + > Karunika Choo wrote: > >> This patch updates Panthor to use the new 64-bit accessors and poll >> functions. > > nit: I don't think it makes sense to dissociate the introduction of

Re: [PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

On 21/03/2025 07:48, Boris Brezillon wrote: > On Thu, 20 Mar 2025 11:17:33 + > Karunika Choo wrote: > >> This patch adds 64-bit register accessors to simplify register access in >> Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. >> >

[PATCH v2 5/9] drm/panthor: Make getting GPU model name simple and extensible

rences based on GPU features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.c | 63 +++--- drivers/gpu/drm/panthor/panthor_regs.h | 1 + 2 files changed, 18 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/g

[PATCH v2 6/9] drm/panthor: Add support for Mali-G715 family of GPUs

family of GPUs. - arch 11.8 FW binary support - reading and handling of GPU_FEATURES register Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 1 + drivers/gpu/drm/panthor/panthor_hw.c | 26 ++ drivers/gpu/drm/panthor/panthor_r

[PATCH v2 4/9] drm/panthor: Move GPU info initialization into panthor_hw.c

will enable Panthor to support GPUs with changes to register offsets, size and fields. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_gpu.c | 95 --- drivers/gpu/drm/panthor/panthor_hw.c | 105 ++ drivers/gpu/drm/panthor/panthor_hw.h

[PATCH v2 1/9] drm/panthor: Add 64-bit and poll register accessors

This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 32-bit and 64-bit variants for read_poll_timeout. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_regs.h | 55 ++ 1 file changed, 55 insertions(+) diff --git

[PATCH v2 3/9] drm/panthor: Add GPU specific initialization framework

U, base addresses describing changes in register offsets, and supported features. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor/panthor_device.c | 5 ++ drivers/gpu/drm/panthor/panthor_device.h | 3 + drivers/gpu/drm/panthor/pant

[PATCH v2 2/9] drm/panthor: Use 64-bit and poll register accessors

This patch updates Panthor to use the new 64-bit accessors and poll functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 9 +- drivers/gpu/drm/panthor/panthor_gpu.c | 142 +++--- drivers/gpu/drm/panthor/panthor_mmu.c | 34 ++ 3 files

[PATCH v2 8/9] drm/panthor: Add support for Mali-G720 and Mali-G725 GPUs

patch enables FLUSH_CACHES for both families of GPUs via the PANTHOR_HW_FEATURE_GPU_CTRL_CACHE_FLUSH bit until FLUSH_PA_RANGE support is added. It also adds the aforementioned register definitions and firmware binary support for arch 12.8 and 13.8. Signed-off-by: Karunika Choo --- drivers/gp

[PATCH v2 9/9] drm/panthor: Add support for Mali-G710, Mali-G510, and Mali-G310

This patch adds GPU model name and FW binary support for Mali-G710, Mali-G510, and Mali-G310. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 2 ++ drivers/gpu/drm/panthor/panthor_hw.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panthor

[PATCH v2 0/9] drm/panthor: Add GPU specific initialization framework to support new Mali GPUs

. - Removed unnecessary pre-parsing of register fields from v1. Retaining current implementation as much as possible. - Added support for G710, G715, G720, and G725 series of Mali GPUs. - Link to v1: https://lore.kernel.org/all/20241219170521.64879-1-karunika.c...@arm.com/ Thanks, Karunika Choo

[PATCH v2 7/9] drm/panthor: Support GPU_CONTROL cache flush based on feature bit

-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_hw.h | 6 + drivers/gpu/drm/panthor/panthor_mmu.c | 35 +++ 2 files changed, 41 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_hw.h b/drivers/gpu/drm/panthor/panthor_hw.h index dfe0f86c5d76

[RFC PATCH 1/4] drm/panthor: Add 64-bit register accessors

This patch adds 64-bit register accessors to simplify register access in Panthor. It also adds 64-bit variants for read_poll_timeout and replaces all 64-bit and poll register accesses with these new functions. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_fw.c | 11

[RFC PATCH 0/4] drm/panthor: Add GPU specific initialization and feature detection

. Patch 3/4 implements the GPU specific initialization framework. Patch 4/4 provides an example of feature detection by performing cache flushes via the GPU_COMMAND register in place of the AS_COMMAND register when a feature bit ise set. Karunika Choo (4): drm/panthor: Add 64-bit register

[RFC PATCH 2/4] drm/panthor: Add parsed gpu properties

This patch adds parsing of GPU register fields on initialization instead of parsing the fields each time it is needed. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor/panthor_device.c | 1 + drivers/gpu/drm/panthor/panthor_device.h

[RFC PATCH 4/4] drm/panthor: Use GPU_COMMAND.FLUSH_CACHES for cache maintenance

-by: Karunika Choo --- drivers/gpu/drm/panthor/panthor_gpu.c | 2 +- drivers/gpu/drm/panthor/panthor_hw.c | 3 ++ drivers/gpu/drm/panthor/panthor_hw.h | 4 +++ drivers/gpu/drm/panthor/panthor_mmu.c | 46 +-- 4 files changed, 52 insertions(+), 3 deletions(-) diff --git a

[RFC PATCH 3/4] drm/panthor: Add gpu specific initialization framework

. Signed-off-by: Karunika Choo --- drivers/gpu/drm/panthor/Makefile | 1 + drivers/gpu/drm/panthor/panthor_device.c | 22 -- drivers/gpu/drm/panthor/panthor_device.h | 28 +-- drivers/gpu/drm/panthor/panthor_fw.c | 27 --- drivers/gpu/drm/panthor/panthor_gpu.c| 44

Re: [PATCH] drm/panthor: Fix compilation failure on panthor_fw.c

eset path") > Signed-off-by: Liviu Dudau Reviewed-by: Karunika Choo Looks good to me. Build-tested locally. Thanks for catching the mistake in my previous patch. > --- > drivers/gpu/drm/panthor/panthor_fw.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers

[PATCH v2] drm/panthor: Simplify FW fast reset path

fast reset, because the slow reset will re-initialize all FW sections, including the global interface. Signed-off-by: Karunika Choo --- v2: - clarify comments and commit message with regards to when to clear the GLB_HALT flag. drivers/gpu/drm/panthor/panthor_fw.c | 15 --- 1 file chang

[PATCH] drm/panthor: Simplify FW fast reset path

Stop checking the FW halt_status as MCU_STATUS should be sufficient. This should make the check for successful FW halt and subsequently setting fast_reset to true more robust. We should also clear GLB_REQ.GLB_HALT bit only on post-reset prior to starting the FW. Signed-off-by: Karunika Choo