Re: [PATCH v14 00/12] Improve test coverage of TTM

Hi Christian and Amaranath, On 12.06.2024 14:02, Karolina Stolarek wrote: Introduce tests for ttm_bo_validate()/ttm_bo_init_validate() that exercise simple BO placement as well as eviction (including the case where the evict domain also requires eviction to fit the incoming buffer). Prepare

[PATCH v14 12/12] drm/ttm/tests: Use u32 and u64 over uint*_t types

Update the tests and helpers to use unsigned kernel types. Signed-off-by: Karolina Stolarek Suggested-by: Thomas Hellström Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 12 ++-- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 6 ++ drivers/gpu

[PATCH v14 11/12] drm/ttm/tests: Correct modules' licenses

The test files are GPL and MIT, so update the definitions accordingly. Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c

[PATCH v14 09/12] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- drivers/gpu

[PATCH v14 10/12] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/TODO | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers

[PATCH v14 08/12] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 433 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 106 - driv

[PATCH v14 05/12] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v14 07/12] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .

[PATCH v14 06/12] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Tested-by: Somalapuram, Amaranath Reviewed

[PATCH v14 03/12] drm/ttm/tests: Set DMA mask in KUnit device

appings to unblock testing. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 5b

[PATCH v14 04/12] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld Reviewed-by: Somalapuram, Amaranath --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14

[PATCH v14 02/12] drm/ttm/tests: Delete unnecessary config option

DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/dr

[PATCH v14 01/12] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

: 995279d280d1 ("drm/ttm/tests: Add tests for ttm_bo functions") Suggested-by: Christian König Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 40 +++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 7 +++- drive

[PATCH v14 00/12] Improve test coverage of TTM

accept a dma_resv object and update calls to that helper (Christian) - Update drm_buddy_free_list() calls with an extra argument Karolina Stolarek (12): drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk drm/ttm/tests: Delete unnecessary config option drm/ttm/tests: Set DMA mask

[PATCH v13 12/12] drm/ttm/tests: Use u32 and u64 over uint*_t types

Update the tests and helpers to use unsigned kernel types. Signed-off-by: Karolina Stolarek Suggested-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 12 ++-- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 6 ++ drivers/gpu/drm/ttm/tests

[PATCH v13 11/12] drm/ttm/tests: Correct modules' licenses

The test files are GPL and MIT, so update the definitions accordingly. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 2 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 2 +- drivers/gpu/drm/ttm/tests

[PATCH v13 10/12] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/TODO | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers

[PATCH v13 09/12] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- drivers/gpu

[PATCH v13 08/12] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 433 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 106 - driv

[PATCH v13 07/12] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .

[PATCH v13 06/12] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Tested-by: Somalapuram, Amaranath

[PATCH v13 05/12] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v13 04/12] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld Reviewed-by: Somalapuram, Amaranath --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14

[PATCH v13 03/12] drm/ttm/tests: Set DMA mask in KUnit device

appings to unblock testing. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 5b

[PATCH v13 02/12] drm/ttm/tests: Delete unnecessary config option

DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/dr

[PATCH v13 01/12] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

: 995279d280d1 ("drm/ttm/tests: Add tests for ttm_bo functions") Suggested-by: Christian König Signed-off-by: Karolina Stolarek Reviewed-by: Thomas Hellström --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 40 +++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 7 +++- drive

[PATCH v13 00/12] Improve test coverage of TTM

to create TT domain, so they can perform multihop - Update TODO file, as it got outdated already Karolina Stolarek (12): drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk drm/ttm/tests: Delete unnecessary config option drm/ttm/tests: Set DMA mask in KUnit device drm/ttm/tests: Use an i

Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

On 3.06.2024 11:30, Thomas Hellström wrote: On Mon, 2024-06-03 at 10:28 +0200, Karolina Stolarek wrote: diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 2f590bae53f8..2a2585b37118 100644 --- a/drivers/gpu/drm/ttm/tests

Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 2f590bae53f8..2a2585b37118 100644 --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c @@ -27,8 +27,42 @@ static int mock_move(struct

Re: [PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

Hi Thomas, On 29.05.2024 14:58, Thomas Hellström wrote: On Wed, 2024-05-15 at 13:24 +0200, Karolina Stolarek wrote: Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function

[PATCH v12 08/10] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 433 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 106 - driv

[PATCH v12 06/10] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Tested-by: Somalapuram, Amaranath

[PATCH v12 10/10] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 25 + 1 file changed, 25 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO b/drivers

[PATCH v12 09/10] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- drivers/gpu

[PATCH v12 07/10] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .

[PATCH v12 05/10] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v12 04/10] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld Reviewed-by: Somalapuram, Amaranath --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14

[PATCH v12 03/10] drm/ttm/tests: Set DMA mask in KUnit device

appings to unblock testing. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 5b

[PATCH v12 01/10] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

: 995279d280d1 ("drm/ttm/tests: Add tests for ttm_bo functions") Suggested-by: Christian König Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 40 +++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 7 +++- drivers/gpu/drm/ttm/tests/ttm_kunit

[PATCH v12 02/10] drm/ttm/tests: Delete unnecessary config option

DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by: Karolina Stolarek Reviewed-by: Nirmoy Das --- drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/dr

[PATCH v12 00/10] Improve test coverage of TTM

re updated and should be checked again Karolina Stolarek (10): drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk drm/ttm/tests: Delete unnecessary config option drm/ttm/tests: Set DMA mask in KUnit device drm/ttm/tests: Use an init function from the helpers lib drm/ttm/tests: Test simple

Re: [PATCH v11 01/10] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

On 18.04.2024 10:15, Christian König wrote: Am 17.04.24 um 15:03 schrieb Karolina Stolarek: BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Share bo2's resv object with bo1 to fix the issue. Fixes: 995279d280d1 (&qu

[PATCH v11 07/10] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .

[PATCH v11 10/10] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 25 + 1 file changed, 25 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO b/drivers

[PATCH v11 09/10] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- drivers/gpu

[PATCH v11 06/10] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Tested-by: Somalapuram, Amaranath

[PATCH v11 08/10] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek Reviewed-by: Somalapuram, Amaranath Tested-by: Somalapuram, Amaranath --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 433 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 106 - driv

[PATCH v11 05/10] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v11 02/10] drm/ttm/tests: Delete unnecessary config option

DRM KUnit helpers are selected automatically when TTM tests are enabled, so there's no need to do it directly in the .kunitconfig file. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/.kunitconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/

[PATCH v11 04/10] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld Reviewed-by: Somalapuram, Amaranath --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14

[PATCH v11 00/10] Improve test coverage of TTM

the initialization of spinlock in ttm_bo_validate_move_fence_signaled(), it not used at all (Andi) - Just return the error code threaded_fence_signal(), don't save it to a local variable (Andi) - Use ttm_bo_unreserve() in tests checking different move fence states (Andi) Karolina Stolarek (

[PATCH v11 03/10] drm/ttm/tests: Set DMA mask in KUnit device

appings to unblock testing. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 7b7c1fa805fc..cb1cd676f8ae 10

[PATCH v11 01/10] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Share bo2's resv object with bo1 to fix the issue. Fixes: 995279d280d1 ("drm/ttm/tests: Add tests for ttm_bo functions") Signed-off-by: Karolina Stolarek ---

Re: [PATCH v10 4/9] drm/ttm/tests: Add tests with mock resource managers

Hi Amaranath, Many thanks for your review and comments. On 15.04.2024 14:10, Somalapuram, Amaranath wrote: +static void ttm_bo_validate_basic(struct kunit *test) +{ +    const struct ttm_bo_validate_test_case *params = test->param_value; +    uint32_t fst_mem = TTM_PL_SYSTEM, snd_mem = TTM_PL_V

Re: [PATCH v10 4/9] drm/ttm/tests: Add tests with mock resource managers

On 10.04.2024 16:24, Matthew Auld wrote: On 22/03/2024 14:29, Karolina Stolarek wrote: +static const struct ttm_bo_validate_test_case ttm_mem_type_cases[] = { +    { +    .description = "System manager", +    .mem_type = TTM_PL_SYSTEM, +    }, +    { +    .descripti

Re: [PATCH v10 3/9] drm/ttm/tests: Test simple BO creation and validation

On 10.04.2024 16:01, Matthew Auld wrote: On 22/03/2024 14:29, Karolina Stolarek wrote: +static void ttm_bo_validate_pinned(struct kunit *test) +{ +    enum ttm_bo_type bo_type = ttm_bo_type_device; +    uint32_t size = ALIGN(BO_SIZE, PAGE_SIZE); +    struct ttm_operation_ctx ctx

Re: [PATCH v10 0/9] Improve test coverage of TTM

Hi Amaranath, Thanks for checking this. On 2.04.2024 15:35, Somalapuram, Amaranath wrote: /usr/bin/ld: drivers/gpu/drm/tests/drm_kunit_helpers.o:(.rodata+0xa0): undefined reference to `drm_atomic_helper_crtc_reset' /usr/bin/ld: drivers/gpu/drm/tests/drm_kunit_helpers.o:(.rodata+0xf0): undef

[PATCH v10 8/9] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO b/drivers/gpu

[PATCH v10 9/9] drm/ttm/tests: Fix a warning in ttm_bo_unreserve_bulk

BOs in a bulk move have to share the same reservation object. That is not the case in the ttm_bo_unreserve_bulk subtest. Share bo2's resv object with bo1 to fix the issue. Fixes: 995279d280d1 ("drm/ttm/tests: Add tests for ttm_bo functions") Signed-off-by: Karolina Stolarek ---

[PATCH v10 7/9] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 119 drivers/gpu

[PATCH v10 4/9] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig

[PATCH v10 6/9] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 425 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 107 - drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 7 + drivers/gp

[PATCH v10 2/9] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 + drivers/gpu/drm

[PATCH v10 5/9] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 305

[PATCH v10 3/9] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm

[PATCH v10 1/9] drm/ttm/tests: Set DMA mask in KUnit device

appings to unblock testing. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c index 7b7c1fa805fc..cb1cd676f8ae 10

[PATCH v10 0/9] Improve test coverage of TTM

because we try clean up an incomplete, orphaned resource. That's not good, and this could bite us back in the future. Karolina Stolarek (9): drm/ttm/tests: Set DMA mask in KUnit device drm/ttm/tests: Use an init function from the helpers lib drm/ttm/tests: Test simple BO creatio

[PATCH] drm/tests: Build KMS helpers when DRM_KUNIT_TEST_HELPERS is enabled

me Ripard Cc: Maíra Canal Signed-off-by: Karolina Stolarek --- Run into this when trying to run TTM KUnit tests. As for now, TTM KUnit test suite are the only outside user of these helpers, but I think it makes sense to explicitly select DRM_KMS_HELPER together with DRM_KUNIT_TEST_HELPERS, in

Re: [PATCH RESEND v9 1/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

into the CI. Thanks, Christian. Am 11.01.24 um 11:28 schrieb Karolina Stolarek: Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Dominik Karol Piątkowski Ack

[PATCH RESEND v9 8/8] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO b/drivers/gpu

[PATCH RESEND v9 7/8] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 119 drivers/gpu

[PATCH RESEND v9 6/8] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 426 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 113 - drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 7 + drivers/gp

[PATCH RESEND v9 4/8] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by

[PATCH RESEND v9 5/8] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- .../gpu/drm/ttm/tests/ttm_bo_validate_tes

[PATCH RESEND v9 3/8] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Christian

[PATCH RESEND v9 2/8] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 + drivers/gpu/drm

[PATCH RESEND v9 1/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Dominik Karol Piątkowski Acked-by: Christian König --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file

[PATCH RESEND v9 0/8] Improve test coverage of TTM

ests as a module, even if it uses functions that are not exported - Fix ttm_pool_pre_populated(); a wrong flag was passed to ttm_tt_kunit_init() function Karolina Stolarek (8): drm/ttm/tests: Fix argument in ttm_tt_kunit_init() drm/ttm/tests: Use an init function from the helpers lib

[PATCH v9 6/8] drm/ttm/tests: Add eviction testing

common path of ttm_device init into a function. Signed-off-by: Karolina Stolarek --- .../gpu/drm/ttm/tests/ttm_bo_validate_test.c | 426 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 113 - drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 7 + drivers/gp

[PATCH v9 4/8] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by

[PATCH v9 7/8] drm/ttm/tests: Add tests for ttm_tt_populate

Add tests for functions that add and release pages to TTs. Test the swapin operation. Export ttm_tt_unpopulate, ttm_tt_swapin and ttm_tt_swapout symbols for testing purposes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 119 drivers/gpu

[PATCH v9 8/8] drm/ttm/tests: Add TODO file

List improvements for the test suite with some notes. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/TODO | 24 1 file changed, 24 insertions(+) create mode 100644 drivers/gpu/drm/ttm/tests/TODO diff --git a/drivers/gpu/drm/ttm/tests/TODO b/drivers/gpu

[PATCH v9 5/8] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- .../gpu/drm/ttm/tests/ttm_bo_validate_tes

[PATCH v9 3/8] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Christian

[PATCH v9 2/8] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 + drivers/gpu/drm

[PATCH v9 1/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Dominik Karol Piątkowski Acked-by: Christian König --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file

[PATCH v9 0/8] Improve test coverage of TTM

ests as a module, even if it uses functions that are not exported - Fix ttm_pool_pre_populated(); a wrong flag was passed to ttm_tt_kunit_init() function Karolina Stolarek (8): drm/ttm/tests: Fix argument in ttm_tt_kunit_init() drm/ttm/tests: Use an init function from the helpers lib

Re: [PATCH v8 0/8] Improve test coverage of TTM

On 14.12.2023 11:22, Christian König wrote: Am 14.12.23 um 09:20 schrieb Karolina Stolarek: Hi Christian, On 29.11.2023 13:02, Karolina Stolarek wrote: Karolina Stolarek (8):    drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man    drm/ttm/tests: Add tests for ttm_tt    drm/ttm

Re: [PATCH v8 0/8] Improve test coverage of TTM

Hi Christian, On 29.11.2023 13:02, Karolina Stolarek wrote: Karolina Stolarek (8): drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man drm/ttm/tests: Add tests for ttm_tt drm/ttm/tests: Add tests for ttm_bo functions >drm/ttm/tests: Fix argument in ttm_tt_kunit_i

Re: [PATCH v8 8/8] drm/ttm/tests: Add test cases dependent on fence signaling

Hi Andi, For next time, I find it difficult to follow all these variables, it's easier to read man = ttm_manager_type(priv->ttm_dev, TTM_PL_SYSTEM); than mem_type = TTM_PL_SYSTEM; ... ... ... man = ttm_manager_type(priv->ttm_dev, mem_type);

Re: [PATCH v8 0/8] Improve test coverage of TTM

Hi Andi, On 5.12.2023 16:39, Andi Shyti wrote: Hi Karolina and Christian, Karolina Stolarek (8): drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man drm/ttm/tests: Add tests for ttm_tt drm/ttm/tests: Add tests for ttm_bo functions drm/ttm/tests: Fix argument in ttm_tt_kunit_init

[PATCH v8 3/8] drm/ttm/tests: Add tests for ttm_bo functions

Test reservation and release of TTM buffer objects. Add tests to check pin and unpin operations. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Andi Shyti --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_bo_test.c

[PATCH v8 7/8] drm/ttm/tests: Add tests with mock resource managers

Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by

[PATCH v8 5/8] drm/ttm/tests: Use an init function from the helpers lib

Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 14 ++ drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 1 + drivers/gpu/drm

[PATCH v8 8/8] drm/ttm/tests: Add test cases dependent on fence signaling

Add test cases that check how the state of dma fences in BO's reservation object influence the ttm_bo_validation() flow. Do similar tests for resource manager's move fence. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram --- .../gpu/drm/ttm/tests/ttm_bo_validate_tes

[PATCH v8 4/8] drm/ttm/tests: Fix argument in ttm_tt_kunit_init()

Remove a leftover definition of page order and pass an empty flag value in ttm_pool_pre_populated(). Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Dominik Karol Piątkowski Acked-by: Christian König --- drivers/gpu/drm/ttm/tests/ttm_pool_test.c | 3 +-- 1 file

[PATCH v8 6/8] drm/ttm/tests: Test simple BO creation and validation

Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by: Karolina Stolarek Reviewed-by: Christian

[PATCH v8 2/8] drm/ttm/tests: Add tests for ttm_tt

Test initialization, creation and destruction of ttm_tt instances. Export ttm_tt_destroy and ttm_tt_create symbols for testing purposes. Signed-off-by: Karolina Stolarek Reviewed-by: Christian König Tested-by: Amaranath Somalapuram --- drivers/gpu/drm/ttm/tests/Makefile| 1

[PATCH v8 1/8] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

test purposes only. Signed-off-by: Karolina Stolarek Tested-by: Amaranath Somalapuram Reviewed-by: Christian König --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 22 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h | 3 + drivers/gp

[PATCH v8 0/8] Improve test coverage of TTM

ng flag was passed to ttm_tt_kunit_init() function Karolina Stolarek (8): drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man drm/ttm/tests: Add tests for ttm_tt drm/ttm/tests: Add tests for ttm_bo functions drm/ttm/tests: Fix argument in ttm_tt_kunit_init() drm/ttm/tests: Use an in

  1   2   3   >