Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-24 Thread Kajtár Zsolt
Hello Thomas! Wanted to answer earlier but things took time, and a lot more than expected. > First of all, commit 779121e9f175 ("fbdev: Support for byte-reversed > framebuffer formats") isn't super complicated AFAICT. I can be > implemented in the sys_ helpers as well. It seems like you initially

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-09 Thread Kajtár Zsolt
Hello Thomas! > No it's not. Major code abstractions behind preprocessor tokens are > terrible to maintain. Hmm, don't get me wrong but I'm not sure if the changes were really checked in detail. At first sight it might look like I'm adding tons of new macro ridden code in those header files repl

Re: [RFC PATCH 00/12] Deduplicate cfb/sys drawing fbops

2025-02-04 Thread Kajtár Zsolt
> Some notes regarding your patches: > - please add dri-devel@lists.freedesktop.org mailing list Will do next time. > - it seems you sent your patches manually. Yes, I thought it will work after a bit of practice without mistakes. Sorry. > - patch #2 is missing, and patches 1-5 have the same s

Re: [RFC PATCH v2 0/3] expose mapping wrprotect, fix fb_defio use

2025-02-01 Thread Kajtár Zsolt
> +cc Kajtar, who has kindly smoke tested this series on real hardware and > confirmed things are working ostensibly the same as before. > > On this basis I will be un-RFC'ing this and, if Kajtar can reply to > confirm, will add a Tested-by tag to patch 3/3. No problem, I'm glad I could help. Usi