On 5/9/2025 9:31 PM, Dmitry Baryshkov wrote:
On 09/05/2025 09:18, Jyothi Kumar Seerapu wrote:
Hi Dimitry, Thanks for providing the review comments.
On 5/6/2025 5:16 PM, Dmitry Baryshkov wrote:
On Tue, May 06, 2025 at 04:48:44PM +0530, Jyothi Kumar Seerapu wrote:
The I2C driver gets an
On 5/6/2025 5:02 PM, Dmitry Baryshkov wrote:
On Tue, May 06, 2025 at 04:48:43PM +0530, Jyothi Kumar Seerapu wrote:
GSI hardware generates an interrupt for each transfer completion.
For multiple messages within a single transfer, this results in
N interrupts for N messages, leading to
Hi Dimitry, Thanks for providing the review comments.
On 5/6/2025 5:16 PM, Dmitry Baryshkov wrote:
On Tue, May 06, 2025 at 04:48:44PM +0530, Jyothi Kumar Seerapu wrote:
The I2C driver gets an interrupt upon transfer completion.
When handling multiple messages in a single transfer, this
results
On 5/7/2025 7:51 AM, ALOK TIWARI wrote:
On 06-05-2025 16:48, Jyothi Kumar Seerapu wrote:
+/**
+ * struct geni_i2c_dev - I2C Geni device specific structure
+ *
+ * @se: geni serial engine
+ * @tx_wm: Tx watermark level
+ * @irq: i2c serial engine interrupt
+ * @err: specifies error codes in
I2C write transfers only,
as there is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v5 -> v6:
- Instead of using bei_flag, moved the logic to use with DMA
supported flags like DMA_PREP_INTERRUPT.
- Additio
message triggers
an interrupt, indicating the completion of 8 messages.
This BEI mechanism enhances overall transfer efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v5 ->v6:
- For updating the block event interrupt bit, instead of relying on
bei_flag, decision check is moved w
iver to support the BEI
functionality with the existing TRE size of 64.
- Made changes in QCOM I2C geni driver as per the review comments.
- Fixed Kernel test robot reported compiltion issues.
Jyothi Kumar Seerapu (2):
dmaengine: qcom: gpi: Add GPI Block event interrupt support
i2c: i2c-qcom
Hi Vinod, Thanks for the review comments.
On 3/11/2025 2:30 AM, Vinod Koul wrote:
On 12-02-25, 17:35, Jyothi Kumar Seerapu wrote:
GSI hardware generates an interrupt for each transfer completion.
For multiple messages within a single transfer, this results in
N interrupts for N messages
message triggers
an interrupt, indicating the completion of 8 messages.
This BEI mechanism enhances overall transfer efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v4 -> v5:
- BEI flag naming changed from flags to bei_flag.
- QCOM_GPI_BLOCK_EVENT_IRQ macro is removed from qcom-
size
from device tree.
- Made the changes in QCOM I2C geni driver to support the BEI
functionality with the existing TRE size of 64.
- Made changes in QCOM I2C geni driver as per the review comments.
- Fixed Kernel test robot reported compiltion issues.
Jyothi Kumar Seerapu (2):
dmae
I2C write transfers only,
as there is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v4 -> v5:
- Block event interrupt flag naming changed from flags to bei_flag.
- Documentation added for "struct geni_i2c_d
On 1/13/2025 3:56 PM, Mukesh Kumar Savaliya wrote:
On 1/7/2025 4:09 PM, Jyothi Kumar Seerapu wrote:
On 1/7/2025 11:33 AM, Mukesh Kumar Savaliya wrote:
On 12/17/2024 10:34 PM, Jyothi Kumar Seerapu wrote:
The I2C driver gets an interrupt upon transfer completion.
When handling multiple
I2C write transfers only,
as there is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v4 -> v5:
- Block event interrupt flag naming changed from flags to bei_flag.
- Documentation added for "struct geni_i2c_d
size
from device tree.
- Made the changes in QCOM I2C geni driver to support the BEI
functionality with the existing TRE size of 64.
- Made changes in QCOM I2C geni driver as per the review comments.
- Fixed Kernel test robot reported compiltion issues.
Jyothi Kumar Seerapu (2):
dmae
message triggers
an interrupt, indicating the completion of 8 messages.
This BEI mechanism enhances overall transfer efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v4 -> v5:
- BEI flag naming changed from flags to bei_flag.
- QCOM_GPI_BLOCK_EVENT_IRQ macro is removed from qcom-
On 1/7/2025 11:33 AM, Mukesh Kumar Savaliya wrote:
On 12/17/2024 10:34 PM, Jyothi Kumar Seerapu wrote:
The I2C driver gets an interrupt upon transfer completion.
When handling multiple messages in a single transfer, this
results in N interrupts for N messages, leading to significant
On 1/7/2025 11:11 AM, Mukesh Kumar Savaliya wrote:
On 12/17/2024 10:34 PM, Jyothi Kumar Seerapu wrote:
GSI hardware generates an interrupt for each transfer completion.
For multiple messages within a single transfer, this results in
N interrupts for N messages, leading to significant
I2C write transfers only,
as there is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v3 -> v4:
- API's added for Block event interrupt with multi descriptor support for
I2C is moved from qcom-gpi-dma.h file to
triggers an interrupt,indicating
the completion of 8 messages.
This BEI mechanism enhances overall transfer efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v3 -> v4:
- API's added for Block event interrupt with multi descriptor support for
I2C is moved from qcom-gpi-dma.h file to
d the changes to parse the channel TRE size
from device tree.
- Made the changes in QCOM I2C geni driver to support the BEI
functionality with the existing TRE size of 64.
- Made changes in QCOM I2C geni driver as per the review comments.
- Fixed Kernel test robot reported compiltion
On 12/2/2024 12:51 PM, Vinod Koul wrote:
On 21-11-24, 18:31, Jyothi Kumar Seerapu wrote:
GSI hardware generates an interrupt for each transfer completion.
For multiple messages within a single transfer, this results in
N interrupts for N messages, leading to significant software
interrupt
On 11/21/2024 6:28 PM, Jyothi Kumar Seerapu wrote:
On 11/12/2024 10:03 AM, Bjorn Andersson wrote:
On Mon, Nov 11, 2024 at 07:32:44PM +0530, Jyothi Kumar Seerapu wrote:
The I2C driver gets an interrupt upon transfer completion.
For multiple messages in a single transfer, N interrupts will
On 11/22/2024 3:40 AM, Dmitry Baryshkov wrote:
On Thu, Nov 21, 2024 at 06:31:34PM +0530, Jyothi Kumar Seerapu wrote:
I2C functionality has dependencies on the GPI driver.
Ensure that the GPI driver is enabled when using the I2C
driver functionality.
Therefore, update the I2C GENI driver to
I2C write transfers only,
as there is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v2 -> v3:
- In i2c_gpi_cb_result function, moved the logic of
"!is_tx_multi_xfer" to else.
- MIN_NUM_OF_MSGS_MULTI
I2C functionality has dependencies on the GPI driver.
Ensure that the GPI driver is enabled when using the I2C
driver functionality.
Therefore, update the I2C GENI driver to depend on the GPI driver.
Signed-off-by: Jyothi Kumar Seerapu
---
v2 -> v3:
- Moved this change to patch3.
- Upda
triggers an interrupt,indicating
the completion of 8 messages.
This BEI mechanism enhances overall transfer efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v2-> v3:
- Renamed gpi_multi_desc_process to gpi_multi_xfer_timeout_handler
- MIN_NUM_OF_MSGS_MULTI_DESC changed from 4 to 2
- Ad
I2C geni driver to support the BEI
functionality with the existing TRE size of 64.
- Made changes in QCOM I2C geni driver as per the review comments.
- Fixed Kernel test robot reported compiltion issues.
Jyothi Kumar Seerapu (3):
dmaengine: qcom: gpi: Add GPI Block event interrupt support
On 11/12/2024 10:03 AM, Bjorn Andersson wrote:
On Mon, Nov 11, 2024 at 07:32:44PM +0530, Jyothi Kumar Seerapu wrote:
The I2C driver gets an interrupt upon transfer completion.
For multiple messages in a single transfer, N interrupts will be
received for N messages, leading to significant
On 11/12/2024 10:26 AM, Bjorn Andersson wrote:
On Mon, Nov 11, 2024 at 07:32:42PM +0530, Jyothi Kumar Seerapu wrote:
GSI hardware generates an interrupt for each transfer completion.
For multiple messages within a single transfer, this results
in receiving N interrupts for N messages, which
On 11/12/2024 9:39 AM, Bjorn Andersson wrote:
On Mon, Nov 11, 2024 at 07:32:43PM +0530, Jyothi Kumar Seerapu wrote:
I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and
so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA.
Given that this is a separate patch, your wording can
On 11/12/2024 4:06 AM, Andi Shyti wrote:
Ping, Vinod :-)
Sure, thanks.
Andi
On Mon, Nov 11, 2024 at 07:32:42PM +0530, Jyothi Kumar Seerapu wrote:
GSI hardware generates an interrupt for each transfer completion.
For multiple messages within a single transfer, this results
in receiving N
when an interrupt is necessary.
When using BEI, consider splitting a single multi-message transfer into
chunks of 8. This approach can enhance overall transfer time and
efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v1 -> v2:
- Changed dma_addr type from array of pointers to array.
-
is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v1 -> v2:
- Moved gi2c_gpi_xfer->msg_idx_cnt to separate local variable.
- Updated goto labels for error scenarios in geni_i2c_gpi function
- memset tx_multi_x
I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and
so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA.
Signed-off-by: Jyothi Kumar Seerapu
---
v1 -> v2:
This patch is added in v2 to address the kernel test robot
reported compilation error.
ERROR: modp
ted compiltion issues.
Jyothi Kumar Seerapu (3):
dmaengine: qcom: gpi: Add GPI Block event interrupt support
i2c: qcom_geni: Update compile dependenices for qcom geni
i2c: i2c-qcom-geni: Add Block event interrupt support
drivers/dma/qcom/gpi.c | 49 +++
drivers/i2c/bus
On 10/25/2024 11:47 PM, Konrad Dybcio wrote:
On 15.10.2024 2:07 PM, Jyothi Kumar Seerapu wrote:
The current GPI driver hardcodes the channel TRE (Transfer Ring Element)
size to 64. For scenarios requiring high performance with multiple
messages in a transfer, use Block Event Interrupt (BEI
On 10/19/2024 3:41 AM, kernel test robot wrote:
Hi Jyothi,
kernel test robot noticed the following build errors:
[auto build test ERROR on 55bcd2e0d04c1171d382badef1def1fd04ef66c5]
url:
https://github.com/intel-lab-lkp/linux/commits/Jyothi-Kumar-Seerapu/dt-bindings-dmaengine-qcom-gpi
On 10/19/2024 8:42 AM, kernel test robot wrote:
Hi Jyothi,
kernel test robot noticed the following build errors:
[auto build test ERROR on 55bcd2e0d04c1171d382badef1def1fd04ef66c5]
url:
https://github.com/intel-lab-lkp/linux/commits/Jyothi-Kumar-Seerapu/dt-bindings-dmaengine-qcom-gpi
On 10/16/2024 8:36 PM, Andi Shyti wrote:
Hi Jyothi,
...
@@ -523,26 +576,49 @@ static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, struct
i2c_msg *msg,
enum dma_transfer_direction dma_dirn;
struct dma_async_tx_descriptor *desc;
int ret;
+ struct gpi_multi_xfer *
On 10/15/2024 7:31 PM, Rob Herring wrote:
On Tue, Oct 15, 2024 at 05:37:46PM +0530, Jyothi Kumar Seerapu wrote:
When high performance with multiple i2c messages in a single transfer
is required, employ Block Event Interrupt (BEI) to trigger interrupts
after specific messages transfer and the
On 10/15/2024 6:56 PM, Rob Herring (Arm) wrote:
On Tue, 15 Oct 2024 17:37:46 +0530, Jyothi Kumar Seerapu wrote:
When high performance with multiple i2c messages in a single transfer
is required, employ Block Event Interrupt (BEI) to trigger interrupts
after specific messages transfer and
On 10/16/2024 10:24 AM, Vinod Koul wrote:
On 15-10-24, 17:37, Jyothi Kumar Seerapu wrote:
When high performance with multiple i2c messages in a single transfer
is required, employ Block Event Interrupt (BEI) to trigger interrupts
after specific messages transfer and the last message transfer
On 10/17/2024 12:40 PM, Krzysztof Kozlowski wrote:
On 16/10/2024 16:35, Bjorn Andersson wrote:
@@ -1064,7 +1064,7 @@
};
gpi_dma0: dma-controller@90 {
- #dma-cells = <3>;
+ #dma-cells = <4>;
compati
On 10/17/2024 12:40 PM, Krzysztof Kozlowski wrote:
On 16/10/2024 16:35, Bjorn Andersson wrote:
@@ -1064,7 +1064,7 @@
};
gpi_dma0: dma-controller@90 {
- #dma-cells = <3>;
+ #dma-cells = <4>;
compatibl
On 10/16/2024 8:36 PM, Andi Shyti wrote:
Hi Jyothi,
...
@@ -523,26 +576,49 @@ static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, struct
i2c_msg *msg,
enum dma_transfer_direction dma_dirn;
struct dma_async_tx_descriptor *desc;
int ret;
+ struct gpi_multi_xfer *gi
On 10/16/2024 10:24 AM, Vinod Koul wrote:
On 15-10-24, 17:37, Jyothi Kumar Seerapu wrote:
When high performance with multiple i2c messages in a single transfer
is required, employ Block Event Interrupt (BEI) to trigger interrupts
after specific messages transfer and the last message transfer
On 10/15/2024 7:31 PM, Rob Herring wrote:
On Tue, Oct 15, 2024 at 05:37:46PM +0530, Jyothi Kumar Seerapu wrote:
When high performance with multiple i2c messages in a single transfer
is required, employ Block Event Interrupt (BEI) to trigger interrupts
after specific messages transfer and the
On 10/15/2024 7:01 PM, Krzysztof Kozlowski wrote:
On 15/10/2024 14:07, Jyothi Kumar Seerapu wrote:
When high performance with multiple i2c messages in a single transfer
is required, employ Block Event Interrupt (BEI) to trigger interrupts
after specific messages transfer and the last message
when an interrupt is necessary.
When using BEI, consider splitting a single multi-message transfer into
chunks of 8. This approach can enhance overall transfer time and
efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
v1 -> v2:
- Changed dma_addr type from array of pointers to array.
-
is no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
v1 -> v2:
- Moved gi2c_gpi_xfer->msg_idx_cnt to separate local variable.
- Updated goto labels for error scenarios in geni_i2c_gpi function
- memset tx_multi_x
I2C_QCOM_GENI is having compile dependencies on QCOM_GPI_DMA and
so update I2C_QCOM_GENI to depends on QCOM_GPI_DMA.
Signed-off-by: Jyothi Kumar Seerapu
---
v1 -> v2:
This patch is added in v2 to address the kernel test robot
reported compilation error.
ERROR: modp
ted compiltion issues
Jyothi Kumar Seerapu (3):
dmaengine: qcom: gpi: Add GPI Block event interrupt support
i2c: qcom_geni: Update compile dependenices for qcom geni
i2c: i2c-qcom-geni: Add Block event interrupt support
drivers/dma/qcom/gpi.c | 49 +++
drivers/i2c/bus
.
Signed-off-by: Jyothi Kumar Seerapu
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 132 +--
1 file changed, 66 insertions(+), 66 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 3d8410683402..c7c0e15ff9d3 100644
--- a
modify this value based on
their specific requirements.
Signed-off-by: Jyothi Kumar Seerapu
---
Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
b/Documentation
no use case for multiple I2C read messages in a single transfer
at this time.
Jyothi Kumar Seerapu (5):
dt-bindings: dmaengine: qcom: gpi: Add additional arg to dma-cell
property
arm64: dts: qcom: Add support for configuring channel TRE size
dmaengine: qcom: gpi: Add provision to support
TRE size is set to 64, but this value can update
in the device tree which will then be parsed by the GPI driver.
Signed-off-by: Jyothi Kumar Seerapu
---
drivers/dma/qcom/gpi.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/drivers/dma/qcom/gpi.c b
when an interrupt is necessary.
When using BEI, consider splitting a single multi-message transfer into
chunks of 64. This approach can enhance overall transfer time and
efficiency.
Signed-off-by: Jyothi Kumar Seerapu
---
drivers/dma/qcom/gpi.c | 49
no use case for multiple I2C read messages in a single transfer
at this time.
Signed-off-by: Jyothi Kumar Seerapu
---
drivers/i2c/busses/i2c-qcom-geni.c | 205 +
1 file changed, 181 insertions(+), 24 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c
b
58 matches
Mail list logo