Re: [PATCH 0/1] Backlight driver for the Apple Studio Display

2023-11-17 Thread Julius Zint
On Fri, 17 Nov 2023, Sean Aguinaga wrote: Hi, > Did you get a chance to implement V2? Yes, v2 is here [1] and v3 is here [2]. Currently I do have the a few changes on top of v3 that are appended here as a patch. I use it with DMKS and it works (mostly). I do see the userspace confusion when t

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-09-19 Thread Julius Zint
On Wed, 6 Sep 2023, Hans de Goede wrote: > Hi Julius, > > On 9/4/23 21:02, Julius Zint wrote: > > > > > > On Mon, 4 Sep 2023, Thomas Weißschuh wrote: > > > >> +Cc Hans who ins involved with the backlight subsystem > >> > >> Hi

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-09-04 Thread Julius Zint
On Mon, 4 Sep 2023, Thomas Weißschuh wrote: +Cc Hans who ins involved with the backlight subsystem Hi Julius, today I stumbled upon a mail from Hans [0], which explains that the backlight subsystem is not actually a good fit (yet?) for external displays. It seems a new API is in the works t

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-08-24 Thread Julius Zint
On 20.08.23 12:06, Christophe JAILLET wrote: [...] +static void hid_bl_remove(struct hid_device *hdev) +{ +    struct backlight_device *bl; +    struct hid_bl_data *data; + +    hid_dbg(hdev, "remove\n"); +    bl = hid_get_drvdata(hdev); +    data = bl_get_data(bl); + +    devm_backlight_device

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-08-24 Thread Julius Zint
On 21.08.23 18:36, Daniel Thompson wrote: @@ -472,6 +472,14 @@ config BACKLIGHT_LED If you have a LCD backlight adjustable by LED class driver, say Y to enable this driver. +config BACKLIGHT_HID + tristate "VESA VCP HID Backlight Driver" + depends on HID + h

[PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-08-20 Thread Julius Zint
htness), Logical Minimum (400), Logical Maximum (6), Unit (Centimeter^-2 * Candela), Unit Exponent (14), Report Size (32), Report Count (1), Feature (Variable, Null State), The full HID descriptor dump is available as a comment in the source code. Signed-off-by: Julius Zint --- d

[PATCH v3 0/1] HID backlight driver

2023-08-20 Thread Julius Zint
exit in probe when HID parsing fails - Add return code to error logs - Adding HID Maintainers for review [1] https://lore.kernel.org/dri-devel/20230701120806.11812-1-jul...@zint.sh/ [2] https://lore.kernel.org/dri-devel/20230806091403.10002-1-jul...@zint.sh/ Julius Zint (1): backlight: hid_bl

[PATCH v2 1/1] backlight: hid_bl: Add VESA virtual control panel HID backlight driver

2023-08-06 Thread Julius Zint
htness), Logical Minimum (400), Logical Maximum (6), Unit (Centimeter^-2 * Candela), Unit Exponent (14), Report Size (32), Report Count (1), Feature (Variable, Null State), The full HID descriptor dump is available as a comment in the source code. Signed-off-by: Julius Zint --- d

[PATCH v2 0/1] HID backlight driver

2023-08-06 Thread Julius Zint
- Brightness HID usage value. [1] https://lore.kernel.org/dri-devel/20230701120806.11812-1-jul...@zint.sh/ Julius Zint (1): backlight: hid_bl: Add VESA virtual control panel HID backlight driver drivers/video/backlight/Kconfig | 8 + drivers/video/backlight/Makefile | 1 + drivers/video

Re: [PATCH 0/1] Backlight driver for the Apple Studio Display

2023-07-04 Thread Julius Zint
I appreciate all of the feedback, this should be plenty for a v2. Thanks, Julius

[PATCH 1/1] backlight: apple_bl_usb: Add Apple Studio Display support

2023-07-01 Thread Julius Zint
CE_TABLE(usb, id_table); + +static struct usb_driver usb_asdbl_driver = { + .name = "apple_bl_usb", + .probe = apple_bl_usb_probe, + .disconnect = apple_bl_usb_disconnect, + .id_table = id_table, + .suspend = apple_bl_usb_suspend, + .resume = apple_bl_usb_resume, + .reset_resume = apple_bl_usb_resume +}; +module_usb_driver(usb_asdbl_driver); + +MODULE_AUTHOR("Julius Zint "); +MODULE_LICENSE("Dual MIT/GPL"); +MODULE_DESCRIPTION("Backlight control for USB-C Thunderbolt Apple displays"); -- 2.41.0

[PATCH 0/1] Backlight driver for the Apple Studio Display

2023-07-01 Thread Julius Zint
its fingers from it. Julius Zint (1): backlight: apple_bl_usb: Add Apple Studio Display support drivers/video/backlight/Kconfig| 8 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/apple_bl_usb.c | 264 + 3 files changed, 273 insertions