Re: [PATCH v2 4/5] drm/xe: Convert xe_fb_pin to use a callback for insertion into GGTT

2025-06-23 Thread Juha-Pekka Heikkilä
Look ok to me. Imo that xe_fb_pin part bit unnecessarily maintain complexity but I'll eventually come back to try to take out unnecessary parts and try to get it fixed.. Reviewed-by: Juha-Pekka Heikkila On Tue, Jun 10, 2025 at 10:02 AM Maarten Lankhorst wrote: > > From: Maarten Lankhorst > > T

Re: [PATCH 1/4] drm/fourcc: Introduce format modifiers for DG2 render and media compression

2022-04-07 Thread Juha-Pekka Heikkilä
Seems my first mail didn't come through so here's second time for this patch: Reviewed-by: Juha-Pekka Heikkila On Mon, Apr 4, 2022 at 4:39 PM Imre Deak wrote: > > From: Matt Roper > > The render/media engines on DG2 unify render compression and media > compression into a single format for the

Re: [Intel-gfx] [PATCH 15/19] drm/i915: Simplify skl_max_scale()

2019-09-16 Thread Juha-Pekka Heikkilä
Patches 13, 14 and this 15 look ok to me. Those num/den combos in 13 I cannot bet my head on but the plumbing look all ok. Also if on 1..8 some patch wasn't pushed yet, those are all Reviewed-by: Juha-Pekka Heikkila Ville Syrjala kirjoitti 8.7.2019 klo 15.53: From: Ville Syrjälä Now that t

Re: [PATCH 4/6] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-02-14 Thread Juha-Pekka Heikkilä via dri-devel
Swati Sharma kirjoitti 13.2.2019 klo 15.25: The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210: For each component, valid data occupies MSB 10 bits.

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Enable Y210, Y212, Y216 format for primary and sprite planes

2018-11-27 Thread Juha-Pekka Heikkilä
Swati Sharma kirjoitti 22.10.2018 klo 8.31: From: Vidya Srinivas In this patch, a list for icl specific pixel formats is created in which Y210, Y212 and Y216 pixel formats are added along with legacy pixel formats for primary and sprite plane. v3: since support for planar formats on ICL was

Re: [PATCH v3 2/4] drm/i915/icl: Add Y210, Y212, Y216 plane control definitions

2018-11-27 Thread Juha-Pekka Heikkilä
I did earlier give R-b for this patch. The patch anyway hasn't changed as those defines have not changed. /Juha-Pekka Swati Sharma kirjoitti 22.10.2018 klo 8.31: From: Vidya Srinivas Added needed plane control flag definitions for Y210, Y212 and Y216 formats. v3: no change Signed-off-by: S

Re: [PATCH 1/4] drm: Add P010, P012, P016 format definitions and fourcc

2018-10-03 Thread Juha-Pekka Heikkilä
Alexandru-Cosmin Gheorghe kirjoitti 3.10.2018 klo 20.18: On Wed, Oct 03, 2018 at 02:31:08PM +0300, Juha-Pekka Heikkila wrote: Hi Alex, For my patches there seems limited interest to get them merged before IGT support these modes..I'm not holding my breath for this. I'm interested if that co

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

2018-09-14 Thread Juha-Pekka Heikkilä
Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30: On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote: On Fri, Sep 14, 2018 at 01:36:32PM +, Lisovskiy, Stanislav wrote: On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote: Introduced new XYUV scan-in format for framebuffer a

Re: [PATCH v2 3/4] drm/i915/icl: Preparations for enabling Y210, Y212, Y216 formats

2018-09-12 Thread Juha-Pekka Heikkilä
Swati Sharma kirjoitti 12.9.2018 klo 13.32: From: Vidya Srinivas Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/intel_display.c | 15 +++ drivers/gpu/drm/i915/intel_sprite.c | 3 +++ 2 files changed, 18 insertions(+) diff --git a/driver

Re: [PATCH v2 1/5] drm/fourcc: Add new fourcc for malidp uncompressed formats

2018-08-22 Thread Juha-Pekka Heikkilä
On 22.08.2018 13:50, Alexandru-Cosmin Gheorghe wrote: Hi, On Wed, Aug 22, 2018 at 01:39:16PM +0300, Juha-Pekka Heikkilä wrote: On 22.08.2018 12:40, Daniel Vetter wrote: On Tue, Aug 21, 2018 at 8:30 PM, Alexandru Gheorghe wrote: Malidp implements a number of yuv buffer formats which are

Re: [PATCH v2 1/5] drm/fourcc: Add new fourcc for malidp uncompressed formats

2018-08-22 Thread Juha-Pekka Heikkilä
On 22.08.2018 12:40, Daniel Vetter wrote: On Tue, Aug 21, 2018 at 8:30 PM, Alexandru Gheorghe wrote: Malidp implements a number of yuv buffer formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout. Signed-off-by: Alexandru Gheo