On Mon, Apr 28, 2025 at 12:34:27PM -0700, Linus Torvalds wrote:
> Honestly, the least wrong thing is to just NOT HAVE THE CHECK FOR ZERO AT ALL.
>
> IOW, just generate the divide instruction.
>
> I can almost guarantee that that will actually then generate the best
> code too, because you'll prob
On Tue, Apr 01, 2025 at 10:53:46AM -0700, Guenter Roeck wrote:
> On 4/1/25 10:08, Peter Zijlstra wrote:
> > > + if (!KUNIT_IS_SUPPRESSED_WARNING(__func__)) \
> > > + _BUG_FLAGS(ASM_UD2, __flags, ANNOTATE_REACHABLE(1b)); \
> > > instrumentation_end();
On Mon, Dec 11, 2023 at 11:12:42PM -0800, Christoph Hellwig wrote:
> On Thu, Dec 07, 2023 at 10:49:53PM -0600, Samuel Holland wrote:
> > Actually tracking all possibly-FPU-tainted functions and their call sites is
> > probably possible, but a much larger task.
>
> I think objtool should be able to
On Thu, Jan 21, 2021 at 08:49:50AM +0100, Christoph Hellwig wrote:
> @@ -820,14 +796,25 @@ static int klp_init_object(struct klp_patch *patch,
> struct klp_object *obj)
> const char *name;
>
> obj->patched = false;
> - obj->mod = NULL;
Why was this line removed?
> if (klp
; > > On Fri, 26 Jul 2019, Chris Wilson wrote:
> > > > > Quoting Thomas Gleixner (2019-07-25 22:55:45)
> > > > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote:
> > > > > >
> > > > > > > Objtool reports:
> > > > > > >
;i915: fix missing user_access_end() in page fault
exception case")
Reported-by: Thomas Gleixner
Reported-by: Sedat Dilek
Acked-by: Peter Zijlstra (Intel)
Tested-by: Nick Desaulniers
Tested-by: Sedat Dilek
Link: https://github.com/ClangBuiltLinux/linux/issues/617
Signed-off-by: Josh
to objtool's noreturn list.
>
> Reported-by: kbuild test robot
> Signed-off-by: Brendan Higgins
> Link: https://www.spinics.net/lists/linux-kbuild/msg21708.html
> Cc: Josh Poimboeuf
> Cc: Peter Zijlstra
> ---
> tools/objtool/check.c | 1 +
> 1 file changed, 1 i
- Removed the '-1' oddity from the tracer
>
> - Restricted the tracer nesting to 4
>
> - Restored the lockdep magic to prevent redundant stack traces
>
> - Addressed the small nitpicks here and there
>
> - Picked up Acked/Reviewed tags
Other t
On Thu, Apr 25, 2019 at 11:45:17AM +0200, Thomas Gleixner wrote:
> Simplify the stack retrieval code by using the storage array based
> interface.
>
> Signed-off-by: Thomas Gleixner
> Reviewed-by: Steven Rostedt (VMware)
> ---
> kernel/trace/trace_stack.c | 37
On Thu, Apr 25, 2019 at 11:45:14AM +0200, Thomas Gleixner wrote:
> @@ -2788,29 +2798,32 @@ static void __ftrace_trace_stack(struct
>*/
> preempt_disable_notrace();
>
> - use_stack = __this_cpu_inc_return(ftrace_stack_reserve);
> + stackidx = __this_cpu_inc_return(ftrace_stac
On Fri, Apr 19, 2019 at 11:07:17AM +0200, Peter Zijlstra wrote:
> On Fri, Apr 19, 2019 at 10:32:30AM +0200, Thomas Gleixner wrote:
> > On Fri, 19 Apr 2019, Peter Zijlstra wrote:
> > > On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote:
> > >
> > > > +typedef bool (*stack_trace_consume
On Fri, Apr 19, 2019 at 09:02:11AM +0200, Peter Zijlstra wrote:
> On Thu, Apr 18, 2019 at 05:42:55PM +0200, Thomas Gleixner wrote:
> > On Thu, 18 Apr 2019, Josh Poimboeuf wrote:
>
> > > Another idea I had (but never got a chance to work on) was to extend the
> > &g
On Thu, Apr 18, 2019 at 10:41:47AM +0200, Thomas Gleixner wrote:
> All architectures which support stacktrace carry duplicated code and
> do the stack storage and filtering at the architecture side.
>
> Provide a consolidated interface with a callback function for consuming the
> stack entries pro
On Thu, Apr 18, 2019 at 10:41:20AM +0200, Thomas Gleixner wrote:
> - Remove the extra array member of stack_dump_trace[]. It's not required as
> the stack tracer stores at max array size - 1 entries so there is still
> an empty slot.
What is the empty slot used for?
--
Josh
_
On Fri, Jul 14, 2017 at 06:33:01PM +0200, Mike Galbraith wrote:
> On Fri, 2017-07-14 at 18:10 +0200, Peter Zijlstra wrote:
> > On Fri, Jul 14, 2017 at 05:58:18PM +0200, Mike Galbraith wrote:
> > > On Fri, 2017-07-14 at 17:50 +0200, Peter Zijlstra wrote:
> >
> > > > Urgh, is for some mysterious rea
Commit-ID: 0b0d81e3b7334897da9b2e3ffee860c2046f7bc0
Gitweb: http://git.kernel.org/tip/0b0d81e3b7334897da9b2e3ffee860c2046f7bc0
Author: Josh Poimboeuf
AuthorDate: Thu, 26 May 2016 13:43:43 -0500
Committer: Ingo Molnar
CommitDate: Wed, 8 Jun 2016 15:36:18 +0200
objtool, drm/vmwgfx: Fix
On Wed, May 25, 2016 at 04:51:21PM -0700, Linus Torvalds wrote:
> On Wed, May 25, 2016 at 10:56 AM, Josh Poimboeuf
> wrote:
> >
> > I used to have a STACKTOOL_IGNORE_INSN macro that would tell the tool to
> > skip warnings for specific instructions in inline asm:
> &g
On Wed, May 25, 2016 at 10:14:24AM -0700, Linus Torvalds wrote:
> Josh,
> my current git version (with gcc 5.3.1) makes objtool warn about
> "duplicate frame pointer save" in drivers/gpu/drm/vmwgfx/vmwgfx_msg.c
> for both vmw_send_msg() and vmw_host_get_guestinfo().
>
> The reason is that VMW_POR
Simplify the control flow of si_tiling_mode_table_init() similar to how
it was done in gfx_v7_0.c and gfx_v8_0.c.
Signed-off-by: Josh Poimboeuf
---
drivers/gpu/drm/radeon/si.c | 925 +---
1 file changed, 439 insertions(+), 486 deletions(-)
diff --git a
Simplify the control flow of cik_tiling_mode_table_init() similar to how
it was done in gfx_v7_0.c and gfx_v8_0.c.
Signed-off-by: Josh Poimboeuf
---
drivers/gpu/drm/radeon/cik.c | 1691 +-
1 file changed, 666 insertions(+), 1025 deletions(-)
diff --git a
On Mon, Mar 07, 2016 at 11:45:36PM +, Deucher, Alexander wrote:
> > -Original Message-
> > From: Josh Poimboeuf [mailto:jpoimboe at redhat.com]
> > Sent: Monday, March 07, 2016 6:10 PM
> > To: Deucher, Alexander; Koenig, Christian
> > Cc: dri-devel a
ance with ensuring that the
correct initialization is still being written would be greatly
appreciated! ]
Reported-by: kbuild test robot
Signed-off-by: Josh Poimboeuf
---
Based on linux-next.
drivers/gpu/drm/radeon/cik.c | 1352 ++
1 file changed, 325 ins
22 matches
Mail list logo
