Re: [PATCH] drm/tiny: Add driver for displays with ST7365P controller

2025-05-01 Thread Josef Luštický
On Wed, Apr 30, 2025 at 3:53 PM David Lechner wrote: > > On 4/30/25 8:17 AM, Josef Lusticky wrote: > > The driver supports 3.5" Kingway HW-035P0Z002 display found > > on Braiins Mini Miner BMM 101 product. > > > > Signed-off-by: Josef Lusticky > > --- > > I haven't really looked at the patch yet,

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-14 Thread Josef Luštický
On Mon, Mar 10, 2025 at 7:33 PM Alex Lanzano wrote: > > On Fri, Mar 07, 2025 at 10:25:18AM +0100, Josef Luštický wrote: > > Ok, I'll implement the change and post it for a review. > > About the property naming, I tend to name it something like > > "inverted-rese

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-03-11 Thread Josef Luštický
On Tue, Feb 25, 2025 at 2:46 PM Alex Lanzano wrote: > > On Tue, Feb 25, 2025 at 12:59:59PM +0100, Josef Luštický wrote: > > On Mon, Feb 24, 2025 at 12:13 AM Alex Lanzano > > wrote: > > > > > > On Mon, Feb 17, 2025 at 12:39:01PM +0100, Josef Luštick

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-25 Thread Josef Luštický
On Mon, Feb 24, 2025 at 12:13 AM Alex Lanzano wrote: > > On Mon, Feb 17, 2025 at 12:39:01PM +0100, Josef Luštický wrote: > > On Sat, Feb 15, 2025 at 8:14 PM Alex Lanzano wrote: > > > > > > On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > > >

Re: drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-17 Thread Josef Luštický
On Sat, Feb 15, 2025 at 8:14 PM Alex Lanzano wrote: > > On Fri, Feb 14, 2025 at 08:04:41PM -0500, Alex Lanzano wrote: > > On Fri, Feb 14, 2025 at 10:29:29AM +0100, Josef Luštický wrote: > > > Hello Alex, > > > there is a bug in mipi_dbi_hw_reset() function that

drm: mipi_dbi_hw_reset() keeps display in reset

2025-02-14 Thread Josef Luštický
Hello Alex, there is a bug in mipi_dbi_hw_reset() function that implements the logic of display reset contrary. It keeps the reset line activated which keeps displays in reset state. I reported the bug to https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/63 Unfortunately, fixing the bug wou

Re: [RFC 0/4] drm/mipi-dbi: Support panel drivers

2019-07-30 Thread Josef Luštický
se. I would expected the driver to fallback to SPI input mode in such case. In other words, the ili9341-based panels can be used in both modes, but not all displays available on the market provide breakout pins for the parallel RGB connection. út 30. 7. 2019 v 16:08 odesílatel Noralf Trønnes n

Re: [RFC 4/4] drm/panel/ili9341: Support mi0283qt

2019-07-30 Thread Josef Luštický
Hi Noralf, see comments bellow. po 29. 7. 2019 v 21:55 odesílatel Noralf Trønnes napsal: > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 179 ++- > 1 file changed, 170 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/panel/p

Re: [RFC 2/4] drm/panel/ili9341: Rebase and some more

2019-07-29 Thread Josef Luštický
Hi Noralf, see comment bellow. po 29. 7. 2019 v 21:55 odesílatel Noralf Trønnes napsal: > > Embed mipi_dbi in struct ili9341. > Rebase on moved mipi-dbi, rename variable name. > Add backlight_device to panel struct. > mipi_dbi_hw_reset() already has a NULL check on the reset gpio. > Prepare for m

Re: [RFC 0/4] drm/mipi-dbi: Support panel drivers

2019-07-29 Thread Josef Luštický
Hi Noralf, the patch series looks good, see comments in the patch emails. One question: is there a general mechanism to tell a driver not to use parallel RGB even though the display supports it and "port" is specified in the device-tree? Josef po 29. 7. 2019 v 21:55 odesílatel Noralf Trønnes na

Re: Controllers with several interface options - one or more drivers?

2019-07-29 Thread Josef Luštický
Hello, I am happy to see this discussion. I like Noralf's late work to move mipi_dbi to drm/ and remove tinydrm. This helps to simplify implementation and maintenance of drivers for displays that conform to MIPI_DBI set of commands, no matter if they use MIPI_DBI to transfer the image data or not.

Re: [PATCH v2 1/2] dt-bindings: panel: Add parallel RGB mode for Ilitek ILI9341 panels

2019-07-25 Thread Josef Luštický
Hello Rob, my fault, sorry, backlight should not be required. I'll fix this in the next patch version. I'd like to post the DT bindings in the YAML format. Work-in-progress YAML bindings file is in the attachment, any comments would be highly appreciated. Kind regards Josef st 24. 7. 2019 v 21:5

Re: [PATCH v2 2/2] drm/panel: Add Ilitek ILI9341 parallel RGB panel driver

2019-07-12 Thread Josef Luštický
Hi Sam, thank you for comments. st 10. 7. 2019 v 15:47 odesílatel Sam Ravnborg napsal: > > Hi Josef. > > Thanks for updating the driver. > > On Mon, Jul 08, 2019 at 04:56:18PM +0200, Josef Lusticky wrote: > > Add driver for Ilitek ILI9341 panels in parallel RGB mode > > > > Signed-off-by: Josef L

Re: [PATCH 0/2] Add DRM panel driver for Ilitek ILI9341 based panels in parallel RGB mode

2019-06-26 Thread Josef Luštický
Hello Sam, Rob, thank you both for comments. I've already prepared most of the code for v2 of this patchset. At the moment I am investigating, if it's possible to use mipi_dbi_* functions for the display initialization, as Rob suggested ("Can't you use existing mipi_dbi_* functions instead of rol