On 2024-07-11 08:18:18, Rodrigo Vivi wrote:
> Hi Dave and Sima,
>
> This is a v2 of https://lore.kernel.org/intel-xe/zo2so4t32dxqy...@intel.com/
>
> v2 - Removed Thomas' write-back caching mode patch since Lucas will propagete
> that through drm-xe-fixes towards 6.10. So we remove the amount of p
On 2024-01-19 12:24:24, Stefan Dirsch wrote:
> Hi Jordan
>
> Thanks for digging into this!
>
> On Fri, Jan 19, 2024 at 12:10:37PM -0800, Jordan Justen wrote:
> > On 2024-01-18 04:37:52, Stefan Dirsch wrote:
> > > Hi
> > >
> > > I noticed that with
On 2024-01-18 04:37:52, Stefan Dirsch wrote:
> Hi
>
> I noticed that with version 23.3.x Mesa no longer can be built with python
> 2.6. It still worked with Mesa 23.2.1.
As mentioned in other emails, this was typo where 3.6 was intended.
>
> It fails with
>
> [ 95s] Traceback (most recent ca
mesa/mesa/-/merge_requests/22878
> >
> > Signed-off-by: Fei Yang
> > Cc: Chris Wilson
> > Cc: Matt Roper
> > Cc: Andi Shyti
> > Reviewed-by: Andi Shyti
> > Acked-by: Jordan Justen
> > Tested-by: Jordan Justen
>
> last call for comments and revi
ed at
> https://patchwork.freedesktop.org/series/117695/
>
> Tested with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22878
>
> Signed-off-by: Fei Yang
> Cc: Chris Wilson
> Cc: Matt Roper
> Cc: Andi Shyti
> Reviewed-by: Andi Shyti
> Acked-by: Jordan Justen
ck these patches.
The good news was that I found that OpenGL testing with our iris
driver appeared to have ok results when using this interface.
But, our Vulkan Anvil driver was not stable with the current patches
in the Mesa MR. We will need to debug this further before using the
interface on Vul
can use this UAPI and we can discuss
> that on the MESA patch.
>
>
> hmmm.. so... ack anyone? [insert big hopeful smiley here]
> apologies if I am asking too often.
Assuming that:
2 = PXP feature is supported but should be ready soon (pending
initialization of non-i915 sy
...fixing some Cc email addresses I somehow mangled.
On 2023-05-10 12:40:07, Souza, Jose wrote:
> On Mon, 2023-05-08 at 17:49 +, Teres Alexis, Alan Previn wrote:
> > On Fri, 2023-05-05 at 00:39 -0700, Justen, Jordan L wrote:
> > > On 2023-05-04 22:30:07, Teres Alexis, Alan Previn wrote:
> > >
On 2023-05-04 22:30:07, Teres Alexis, Alan Previn wrote:
> On Thu, 2023-04-27 at 16:48 -0700, Teres Alexis, Alan Previn wrote:
> > Because of the additional firmware, component-driver and
> > initialization depedencies required on MTL platform before a
> > PXP context can be created, UMD calling fo
On 2023-04-26 11:17:16, Teres Alexis, Alan Previn wrote:
> alan: Hi Jordan, Tvrtko, Daniel Vetter and Lionel,...
> how to proceed on this series (which have required Rb/Ack's) in light of
> the recent discussion on the other series here:
> https://patchwork.freedesktop.org/patch/532994/?series=115
On 2023-04-26 04:52:43, Daniel Vetter wrote:
>
> Joonas asked me to put my thoughts here:
>
> - in general the "feature discovery by trying it out" approach is most
> robust and hence preferred, but it's also not something that's required
> when there's good reasons against it
More robust in
On 2023-04-25 06:41:54, Joonas Lahtinen wrote:
> (+ Faith and Daniel as they have been involved in previous discussions)
>
> Quoting Jordan Justen (2023-04-24 20:13:00)
> > On 2023-04-24 02:08:43, Tvrtko Ursulin wrote:
> > >
> > > Being able to "li
On 2023-04-16 23:43:20, Yang, Fei wrote:
> > fei.y...@intel.com kirjoitti 17.4.2023 klo 9.24:
> >> From: Fei Yang
> >>
> >> The series includes patches needed to enable MTL.
> >> Also add new extension for GEM_CREATE uAPI to let user space set cache
> >> policy for buffer objects.
> >
> > if I'm
On 2023-04-24 02:08:43, Tvrtko Ursulin wrote:
>
> Being able to "list" supported extensions sounds like a reasonable
> principle, albeit a departure from the design direction to date.
> Which means there are probably no quick solutions. Also, AFAIU, only
> PXP context create is the problematic one
On 2023-04-20 09:11:18, Yang, Fei wrote:
> > On 20/04/2023 12:39, Andi Shyti wrote:
> >> Hi Fei,
> >>
> >>> To comply with the design that buffer objects shall have immutable
> >>> cache setting through out their life cycle, {set, get}_caching ioctl's
> >>> are no longer supported from MTL onward.
On 2023-04-05 13:26:43, Jordan Justen wrote:
> On 2023-04-05 00:45:24, Lionel Landwerlin wrote:
> > On 04/04/2023 19:04, Yang, Fei wrote:
> > >> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache
> > >> at BO creation
> > >>
>
On 2023-04-05 00:45:24, Lionel Landwerlin wrote:
> On 04/04/2023 19:04, Yang, Fei wrote:
> >> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at
> >> BO creation
> >>
> >> Just like the protected content uAPI, there is no way for userspace to tell
> >> this feature is availa
On 2022-10-14 03:58:12, Matthew Auld wrote:
> On 14/10/2022 08:20, Jordan Justen wrote:
> > Acked-by: Jordan Justen
>
> Thanks. Can I take that as ack for merging the series from Mesa POV? I
> think Lionel was going to test this, but I think keeps getting swamped
> with ot
Acked-by: Jordan Justen
On 2022-10-04 04:49:15, Matthew Auld wrote:
> On some platforms we potentially have different alignment restrictions
> depending on the memory type. We also now have different alignment
> restrictions for the same region across different kernel versions.
>
On 2022-07-14 16:08:51, Dave Airlie wrote:
> On Fri, 15 Apr 2022 at 10:15, Matt Roper wrote:
> >
> > On Tue, Apr 12, 2022 at 03:59:55PM -0700, john.c.harri...@intel.com wrote:
> > > From: John Harrison
> > >
> > > The latest GuC firmware drops the context descriptor pool in favour of
> > > passin
On 2022-06-24 14:38:50, Chery, Nanley G wrote:
> +Jordan (FYI)
>
> I think the commit message has an extra "color" next to "CC".
> With or without that dropped,
>
> Reviewed-by: Nanley Chery
Reviewed-by: Jordan Justen
Include newer integrated platforms when applying the non-recoverable
> > context and error capture restriction. (Thomas)
> >
> > Signed-off-by: Matthew Auld
> > Cc: Thomas Hellström
> > Cc: Lionel Landwerlin
> > Cc: Tvrtko Ursulin
> > Cc: Jon Bloo
On 2022-05-16 00:47:43, Lionel Landwerlin wrote:
> On 14/05/2022 00:06, Jordan Justen wrote:
>>
>> Acked-by: Jordan Justen
>>
>> I think Nanley has accounted for this on iris with:
>>
>>
>> https://gitlab.freedesktop.org/mesa/mesa/-/co
cc: Lionel Landwerlin
> > cc: Kenneth Graunke
> > cc: mesa-...@lists.freedesktop.org
> > cc: Jordan Justen
> > cc: Tony Ye
> > Reviewed-by: Matthew Auld
> > ---
> > include/uapi/drm/i915_drm.h | 16
> > 1 file changed, 16 inser
.
Series:
Reviewed-by: Jordan Justen
Tested-by: Jordan Justen
-Jordan
On 2022-04-27 21:19:22, Matt Roper wrote:
> Now that the necessary GuC-based hardware workarounds have landed, we're
> finally ready to actually enable compute engines for use by userspace.
> All of the "un
ohn Harrison
Reviewed-by: Matthew Brost
Acked-by: Jon Bloomfield
Signed-off-by: Jordan Justen
Reviewed-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/Makefile | 1 +
drivers/gpu/drm/i915/gt/intel_gt.c| 6 +
drivers/gpu/drm/i915/gt/intel_gt_types.h | 4 +
: Kenneth Graunke
Cc: Michal Wajdeczko
Cc: Slawomir Milczarek
Cc: Joonas Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23
Now with 100% less documentation. (See v7 notes.)
This is John/Rodrigo's 2 patches with some changes. There are various
changes suggested by Michal in John's "fetch" patch. The table
terminology was also changed to "blob" as requested by Joonas.
Dropped these 2 patches (which were in v1-v6):
* "
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
v5:
* Fix documenation formatting and verified with `make htmldocs` as
suggested by Daniel
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
Acked-by: Daniel
based on John's updated "drm/i915/guc: Add fetch of hwconfig
table" v2 which stores the hwconfig blob at the GT level.
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
Reviewed-by: Tvrtko Ursulin
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 43 ++-
hal
* Merge in John's v2 patch, but note:
- Using drm_notice as recommended by Michal
- Reverted Michal's suggestion of using devinfo
Cc: Michal Wajdeczko
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jon Bloomfield
Signed-off-by:
o added a few changes requested by Michal on the v5 posting.
* Tvrtko requested an example of UMD using the i915 hwconfig
interface. Mesa support for this interface can be seen in this MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14511
John Harrison (1):
drm/i915/guc: Add fet
John Harrison writes:
> On 2/22/2022 02:36, Jordan Justen wrote:
>> From: John Harrison
>>
>> Implement support for fetching the hardware description table from the
>> GuC. The call is made twice - once without a destination buffer to
>> query the size and
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
v5:
* Fix documenation formatting and verified with `make htmldocs` as
suggested by Daniel
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
Acked-by: Daniel
: Jordan Justen
Acked-by: Jon Bloomfield
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
index ad289603460c
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed
ichal Wajdeczko
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jon Bloomfield
Signed-off-by: Jordan Justen
---
drivers/gpu/drm/i915/Makefile | 1 +
.../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 1 +
.../gpu/drm/i915/gt/uc/abi/g
in this version.
v5:
* Add many changes suggested by Michal in John's "drm/i915/guc: Add
fetch of hwconfig table" patch.
* Fix documenation formatting as suggested by Daniel in
"drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item"
Ramalingam C writes:
> On 2022-02-18 at 18:06:00 +, Robert Beckett wrote:
>>
>> If desired, we can make the wording clearer, maybe something like:
>>
>> "To keep things simple for userland, we mandate that any GTT mappings
>> must be aligned to 2MB. The kernel will internally pad them out t
3: fix typos and less emphasis
> v2: Fixed suggestions on formatting [Daniel]
>
> Signed-off-by: Matthew Auld
> Signed-off-by: Ramalingam C
> Signed-off-by: Robert Beckett
> Acked-by: Jordan Justen
> Reviewed-by: Ramalingam C
> Reviewed-by: Thomas Hellström
> cc: Simon Ser
: Jordan Justen
Acked-by: Jon Bloomfield
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 44 ++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
index ce6088f112d4
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
Acked-by: Jon Bloomfield
---
include/uapi/drm/i915_drm.h | 35 +++
1 file changed, 35 insertions
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
Acked-by: Jon Bloomfield
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
Rewrite verify_hwconfig_blob() to hopefully be clearer without
relying on comments so much, and add various suggestions from
Michal.
* Michal also had some suggestions in John's "drm/i915/guc: Add fetch
of hwconfig table" patch. I held off on making any of these changes
Tvrtko Ursulin writes:
> Will GuC folks be reviewing this work?
I don't know. If you mean the i915 devs interfacing with the GuC, I know
John/Rodrigo seemed a bit resistant writing the patches to give
userspace this trivial format guarantee on the blob.
So, I hoped they would write the patches
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
v3:
* Add various changes suggested by Tvrtko
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
include/uapi/drm/i915_drm.h | 32
1 file changed, 32 insertions(+)
diff --git a/include/uapi/drm
contents,
so this verification step should not add a significant amount of init
time to i915.
v3:
* Add various changes suggested by Tvrtko
Signed-off-by: Jordan Justen
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 56 ++-
1 file changed, 53 insertions(+), 3 deletions
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 24 insertions(+)
diff
om the feedback for
the same patch.
John Harrison (1):
drm/i915/guc: Add fetch of hwconfig table
Jordan Justen (2):
drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item
drm/i915/guc: Verify hwconfig blob matches supported format
Rodrigo Vivi (1):
drm/i915/uapi: Add query for hwcon
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
contents,
so this verification step should not add a significant amount of init
time to i915.
Signed-off-by: Jordan Justen
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 29 +++
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 24 insertions(+)
diff
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
include/uapi/drm/i915_drm.h | 30 ++
1 file changed, 30 insertions(+)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index
h as requested by
Tvrtko.
* Reword text added to i915_drm.h as requested by Tvrtko. (Attempting
to indicate the overall blob ends right at the last blob item.)
John Harrison (1):
drm/i915/guc: Add fetch of hwconfig table
Jordan Justen (2):
drm/i915/uapi: Add struct drm_i915_query_
Signed-off-by: Jordan Justen
---
.../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 26 +++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
index ce6088f112d4..695ef7a8f519 100644
--- a
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct.
Cc: Daniel Vetter
Signed-off-by: Jordan Justen
---
include/uapi/drm/i915_drm.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
index
From: John Harrison
Implement support for fetching the hardware description table from the
GuC. The call is made twice - once without a destination buffer to
query the size and then a second time to fill in the buffer.
Note that the table is only available on ADL-P and later platforms.
Cc: Mich
Lahtinen
Signed-off-by: Rodrigo Vivi
Signed-off-by: John Harrison
Reviewed-by: Matthew Brost
Acked-by: Jordan Justen
Tested-by: Jordan Justen
---
drivers/gpu/drm/i915/i915_query.c | 23 +++
include/uapi/drm/i915_drm.h | 1 +
2 files changed, 24 insertions(+)
diff
what the uAPI
documents.
John Harrison (1):
drm/i915/guc: Add fetch of hwconfig table
Jordan Justen (2):
drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item
drm/i915/guc: Verify hwconfig blob matches supported format
Rodrigo Vivi (1):
drm/i915/uapi: Add query for hwconfig blob
d
Jordan Justen writes:
> John, Rodrigo,
>
> It is now clear to me just how dependent i915 is going to be on the
> closed source guc software, and that's just a fact of life for our
> graphics stack going forward.
>
> In that context, it seems kind of pointless for me t
John, Rodrigo,
It is now clear to me just how dependent i915 is going to be on the
closed source guc software, and that's just a fact of life for our
graphics stack going forward.
In that context, it seems kind of pointless for me to make a big deal
out of this peripheral "query item" commit mess
John Harrison writes:
> On 1/27/2022 16:48, Jordan Justen wrote:
>> john.c.harri...@intel.com writes:
>>
>>> From: Rodrigo Vivi
>>>
>>> GuC contains a consolidated table with a bunch of information about the
>>> current device.
>>>
john.c.harri...@intel.com writes:
> From: Rodrigo Vivi
>
> GuC contains a consolidated table with a bunch of information about the
> current device.
>
> Previously, this information was spread and hardcoded to all the components
> including GuC, i915 and various UMDs. The goal here is to consolid
Fixed suggestions on formatting [Daniel]
>
> Signed-off-by: Matthew Auld
> Signed-off-by: Ramalingam C
> Signed-off-by: Robert Beckett
> cc: Simon Ser
> cc: Pekka Paalanen
> Cc: Jordan Justen
> Cc: Kenneth Graunke
> Cc: mesa-...@lists.freedesktop.org
> Cc: Tony Ye
John Harrison writes:
> On 11/3/2021 14:38, Jordan Justen wrote:
>> So, i915 wants to wash it's hands completely of the format? There is
>> obviously a difference between hardware features and a blob coming from
>> closed source software. (Which i915 just happens to
John Harrison writes:
> On 11/1/2021 08:39, Jordan Justen wrote:
>> writes:
>>
>>> From: Rodrigo Vivi
>>>
>>> GuC contains a consolidated table with a bunch of information about the
>>> current device.
>>>
>>> Previo
writes:
> From: Rodrigo Vivi
>
> GuC contains a consolidated table with a bunch of information about the
> current device.
>
> Previously, this information was spread and hardcoded to all the components
> including GuC, i915 and various UMDs. The goal here is to consolidate
> the data into GuC i
Series Reviewed-by: Jordan Justen
For the 2de4e8fdbae1e1909ce35f8ba15608a124686fb0 version on your drm
gt4 branch.
On 2015-10-23 10:56:33, Ben Widawsky wrote:
> Cc: Kristian Høgsberg
> Cc: Damien Lespiau
> Signed-off-by: Ben Widawsky
> ---
> intel/intel_chipset.h | 12 ++
On Mon, Nov 4, 2013 at 8:11 PM, Keith Packard wrote:
> Jordan Justen writes:
>> After patch 6, this will add SARGB8, right? So, maybe add this to the
>> commit message, or separate out adding SARGB8 into a separate commit?
>
> I added the SARGB8 define in patch 4; is there
e MESA_FORMAT_NONE:
> + return __DRI_IMAGE_FORMAT_NONE;
> + case MESA_FORMAT_SARGB8:
> + return __DRI_IMAGE_FORMAT_SARGB8;
After patch 6, this will add SARGB8, right? So, maybe add this to the
commit message, or separate out adding SARGB8 into a separate commit?
Patches 1-6: R
On Mon, Sep 10, 2012 at 1:27 AM, Michel Dänzer wrote:
> On Son, 2012-09-09 at 15:33 -0700, Jordan Justen wrote:
>> New branch 'debian-experimental' available with the following commits:
>
> I think you pushed this to the wrong repository?
My apologies. I had the hook sc
On Mon, Sep 10, 2012 at 1:27 AM, Michel D?nzer wrote:
> On Son, 2012-09-09 at 15:33 -0700, Jordan Justen wrote:
>> New branch 'debian-experimental' available with the following commits:
>
> I think you pushed this to the wrong repository?
My apologies. I had the hook sc
75 matches
Mail list logo
