Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

Hi, addressing this email to you all since there might be widespread race condition issue in the DRM panel drivers that are using MIPI DSI. See below for my message. Andrzej Hajda: >> +static int s6e8aa0_set_brightness(struct backlight_device *bd) >> +{ >> +struct s6e8aa0 *ctx = bl_get_data(b

Re: [PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

Hi, thanks a lot for the review, Andrzej! Andrzej Hajda: >> +static const struct backlight_ops s6e8aa0_backlight_ops = { >> +.update_status = s6e8aa0_set_brightness, > > > This is racy, update_status can be called in any time between probe and > remove, particularly: > > a) before panel e

[PATCH] drm/panel: samsung: s6e8aa0: Add backlight control support

This makes the backlight brightness controllable from the userspace. Signed-off-by: Joonas Kylmälä --- drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 82 --- 1 file changed, 60 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c b

Preferring cursor plane over overlay plane

Hi DRM subsystem developers, I ran into this patch where overlay plane was switched to cursor plane because there was no proper cursor plane available on the display hardware: . Can we discuss whether to have a policy of using a normal plane for cursor plane in

Re: [linux-sunxi] [PATCH v3 15/16] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

Jernej Škrabec: > I guess that would mean also including connector node (hdmi_con_in) in DTSI, > since it is referenced inside. However, not all boards have HDMI connector, > so > I didn't include it in DTSI. You're absolutely right on this. I wish there was someway to get rid of this duplicati

Re: [linux-sunxi] [PATCH v3 15/16] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

Jernej Skrabec: > +&hdmi_out { > + hdmi_out_con: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > +}; This node is added to all the DTS files you enabled HDMI on. Is it something that could be instead put to the DTSI file? Joonas __