Re: i915 build issue

On 11/07/2023 10:58, Jani Nikula wrote: I didn't notice anything on dri-devel mailing list about this. I presume you're using CONFIG_WERROR=y or W=e. I'm just using whatever vanilla x86_64_defconfig gives. See [1] and [2]. I'm undecided how we should treat this. Ok. Thanks, John

i915 build issue

Hi guys, Did anyone else notice this build issue on v6.5-rc1: drivers/gpu/drm/i915/i915_pci.c:143:15: error: expected expression before ‘,’ token GEN3_FEATURES, ^ drivers/gpu/drm/i915/i915_pci.c:151:15: error: expected expression before ‘,’ token GEN3_FEATURES,

Re: Warnings in DRM code when removing/unbinding a driver

Hi Thomas, drm-tip now contains I have tested today's linux-next, which includes this: commit a88248506a2bcfeaef6837a53cde19fe11970e6c Author: Thomas Zimmermann Date: Tue Dec 3 09:38:15 2019 +0100 drm/hisilicon/hibmc: Switch to generic fbdev emulation which removes this entire c

Re: Warnings in DRM code when removing/unbinding a driver

On 19/12/2019 09:54, Daniel Vetter wrote: On Wed, Dec 18, 2019 at 7:08 PM John Garry wrote: + So the v5.4 kernel does not have this issue. I have bisected the initial occurrence to: commit 37a48adfba6cf6e87df9ba8b75ab85d514ed86d8 Author: Thomas Zimmermann Date: Fri Sep 6 14:20:53 2019

Re: Warnings in DRM code when removing/unbinding a driver

ent a reference counter. So this either exposes or creates the issue. John On Mon, 2019-12-16 at 17:23 +0000, John Garry wrote: Hi all, Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [   27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_hel

Re: Warnings in DRM code when removing/unbinding a driver

Hi Ezequiel, On Mon, 2019-12-16 at 17:23 +, John Garry wrote: Hi all, Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [ 27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 A total

Re: Warnings in DRM code when removing/unbinding a driver

On 16/12/2019 17:23, John Garry wrote: +, - Hi all, xinliang is bouncing. We need to get his new mail address. John Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [   27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm

Warnings in DRM code when removing/unbinding a driver

Hi all, Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system with the HIBMC hw: [ 27.788806] WARNING: CPU: 24 PID: 1 at drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98 [ 27.798969] Modules linked in: [ 27.802018] CPU: 24 PID: 1 Comm: swapper/

Re: [PATCH 0/3] HiBMC driver fixes

On 26/09/2018 10:41, Xinliang Liu wrote: On Wed, 26 Sep 2018 at 16:46, John Garry wrote: On 26/09/2018 04:00, Xinliang Liu wrote: Thanks John, good addressing! The root cause as you said, our hibmc previous frame buffer format depth setting is wrong which does not pass the new format sanity

Re: [PATCH 0/3] HiBMC driver fixes

hisilicon-drm-next. I can't see this branch in the git associated with this driver from its MAINTAINERS entry (git://github.com/xin3liang/linux.git), but please ensure these fixes are included in 4.19 Thanks, John Thanks, Xinliang On Sun, 23 Sep 2018 at 20:32, John Garry wrote:

[PATCH 2/3] drm/hisilicon: hibmc: Don't overwrite fb helper surface depth

e. Fix by not overwriting the surface depth. Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer") Signed-off-by: John Garry --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/

[PATCH 0/3] HiBMC driver fixes

oding it. Tested on Huawei D05 board. I can see tux on BMC VGA console. John Garry (3): drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer pointer drm/hisilicon: hibmc: Don't overwrite fb helper surface depth drm/hisilicon: hibmc: Use HUAWEI PCI vendor ID macro d

[PATCH 1/3] drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer pointer

[9.913418] ret_from_fork+0x10/0x18 [9.917024] Code: a94153f3 a8c27bfd d65f03c0 d503201f (f9400c01) [9.923180] ---[ end trace 2695ffa0af5be375 ]--- Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer") Signed-off-by: John Garry --- drivers/gpu/drm/hisil

[PATCH 3/3] drm/hisilicon: hibmc: Use HUAWEI PCI vendor ID macro

Switch to use Huawei PCI vendor ID macro from pci_ids.h file. In addition, switch to use PCI_VDEVICE() instead of open coding. Signed-off-by: John Garry --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: Bug report: HiBMC crash

On 21/09/2018 15:28, Chris Wilson wrote: Quoting John Garry (2018-09-21 09:11:19) On 21/09/2018 06:49, Liuxinliang (Matthew Liu) wrote: Hi John, Thank you for reporting bug. I am now using 4.18.7. I haven't found this issue yet. I will try linux-next and figure out what's wro

Re: Bug report: HiBMC crash

ct unknown legacy bpp and depth for drm_mode_addfb ioctl Thanks, John On 2018/9/20 19:23, John Garry wrote: On 20/09/2018 11:04, John Garry wrote: Hi, I am seeing this crash below on linux-next (20 Sept). This is on an arm64 D05 board, which includes the HiBMC device. D06 was also crashing for w

Re: Bug report: HiBMC crash

On 20/09/2018 11:04, John Garry wrote: Hi, I am seeing this crash below on linux-next (20 Sept). This is on an arm64 D05 board, which includes the HiBMC device. D06 was also crashing for what looked like same reason. I am using standard defconfig, except DRM and DRM_HISI_HIBMC are built-in

Bug report: HiBMC crash

8/0x28 [9.902337] process_one_work+0x1e0/0x318 [9.906382] worker_thread+0x228/0x450 [9.910164] kthread+0x128/0x130 [9.913418] ret_from_fork+0x10/0x18 [9.917024] Code: a94153f3 a8c27bfd d65f03c0 d503201f (f9400c01) [9.923180] ---[ end trace 2695ffa0af5be375 ]--- On Thu, 20 Sep