Re: [PATCH v2] drm/bridge: adv7511: Switch to atomic operations

2025-01-23 Thread Jesse Van Gavere
Hello, This patch seems to have been archived but I can't seem to find it in the drm-misc git, is there anything else I should be doing to get this patch approved and included? Best regards, Jesse

[PATCH v2] drm/bridge: adv7511: Switch to atomic operations

2025-01-06 Thread Jesse Van Gavere
Use the atomic version of enable/disable. To support bridges where bus format negotiation is needed such as TIDSS we need to implement atomic_get_input_bus_fmts, prepare the driver for this by switching the existing operations to it's atomic variants. Signed-off-by: Jesse Van Gavere --- Ch

Re: [PATCH] drm/bridge: adv7511: Switch to atomic operations

2025-01-06 Thread Jesse Van Gavere
Hello Dmitry, > The patch LGTM, but the commit message needs some work. Why/how does > TIDSS require bridges to use atomic ops? In hindsight that indeed could've been worded better, the approach here was as a stepping stone to implementing the input bus formats, which is what TIDSS needs, so I'll

[PATCH] drm/bridge: adv7511: Switch to atomic operations

2025-01-05 Thread Jesse Van Gavere
Use the atomic version of enable/disable. Doing so enables it to work in a chain where atomic operations are expected such as TIDSS Signed-off-by: Jesse Van Gavere --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

RE: ADV7511/13 implementing atomic ops and bus formats

2025-01-05 Thread Jesse Van Gavere
Hello Dmitry, > How is it so? I don't see any specific requirements on the TIDSS side. Seems right, must've been a mistake on my end > I think that's a separate topic. Bridge drivers don't have to implement > atomic_check. In fact, if you check the latest LT9611 driver, it has dropped > the .a

RE: ADV7511/13 implementing atomic ops and bus formats

2025-01-02 Thread Jesse Van Gavere
Hello Dmitry, ... > The atomic_check() function verifies if the passed set of changes (in the > form of drm_*_state) is valid from the driver's point of view. If you have > nothing to check, it's fine to skip the function. ... Perhaps one last question on the use of atomic_check, this functio

RE: ADV7511/13 implementing atomic ops and bus formats

2025-01-01 Thread Jesse Van Gavere
Hello Dmitry, > The atomic_check() function verifies if the passed set of changes (in the > form of drm_*_state) is valid from the driver's point of view. If you have > nothing to check, it's fine to skip the function. I'll look over the other examples a bit then but I think the reason for imp

ADV7511/13 implementing atomic ops and bus formats

2024-12-29 Thread Jesse Van Gavere
Hey all, For one of our new boards I have to get the ADV7513 chip working with TIDSS, the driver for this expects a bridge chip to have atomic ops and provide bus formats. Doing this for our own needs was quite straightforward but I'd very much like to upstream this as I think it could be helpf

ADV7511/13 implementing atomic ops and bus formats

2024-12-28 Thread Jesse Van Gavere
Hey all, (Hope this is not a duplicate as my first mail didn't seem to have gone through) For one of our new boards I have to get the ADV7513 chip working with TIDSS, the driver for this expects a bridge chip to have atomic ops and provide bus formats. Doing this for our own needs was quite stra