Re: [PATCH] accel/ivpu: Implement heartbeat-based TDR mechanism

2025-04-18 Thread Jeffrey Hugo
On 4/16/2025 4:25 AM, Maciej Falkowski wrote: From: Karol Wachowski Introduce a heartbeat-based Timeout Detection and Recovery (TDR) mechanism. The enhancement aims to improve the reliability of device hang detection by monitoring heartbeat updates. Each progressing inference will update heart

Re: [PATCH v2 5/7] accel/rocket: Add IOCTL for BO creation

2025-03-24 Thread Jeffrey Hugo
On 2/25/2025 12:55 AM, Tomeu Vizoso wrote: +/** + * rocket_gem_create_object - Implementation of driver->gem_create_object. + * @dev: DRM device + * @size: Size in bytes of the memory the object will reference + * + * This lets the GEM helpers allocate object structs for us, and keep + * our BO s

Re: [PATCH v2 7/7] accel/rocket: Add IOCTLs for synchronizing memory accesses

2025-03-21 Thread Jeffrey Hugo
On 2/25/2025 12:55 AM, Tomeu Vizoso wrote: +int rocket_ioctl_fini_bo(struct drm_device *dev, void *data, struct drm_file *file) +{ + struct drm_rocket_fini_bo *args = data; + struct drm_gem_object *gem_obj; + struct rocket_gem_object *rkt_obj; + struct drm_gem_shmem_objec

Re: [PATCH 1/6] accel/ivpu: Add missing locks around mmu queues

2025-02-18 Thread Jeffrey Hugo
On 2/17/2025 8:26 AM, Jacek Lawrynowicz wrote: Hi, On 2/14/2025 5:41 PM, Jeffrey Hugo wrote: On 2/4/2025 1:46 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski Multiple threads were accessing mmu cmd queue simultaneously causing sporadic failures in ivpu_mmu_cmdq_sync() function

Re: [PATCH 2/6] accel/ivpu: Prevent runtime suspend during context abort work

2025-02-18 Thread Jeffrey Hugo
On 2/17/2025 8:33 AM, Jacek Lawrynowicz wrote: Hi, On 2/14/2025 5:49 PM, Jeffrey Hugo wrote: On 2/4/2025 1:46 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski Increment the runtime PM counter when entering ivpu_context_abort_work_fn() to prevent the device from suspending while the

Re: [PATCH] bus: mhi: host: Avoid possible uninitialized fw_load_type

2025-02-14 Thread Jeffrey Hugo
On 2/14/2025 10:34 AM, Manivannan Sadhasivam wrote: On Fri, Feb 14, 2025 at 09:21:09AM -0700, Jeffrey Hugo wrote: If mhi_fw_load_handler() bails out early because the EE is not capable of loading firmware, we may reference fw_load_type in cleanup which is uninitialized at this point. The

Re: [PATCH 6/6] accel/ivpu: Implement D0i2 disable test mode

2025-02-14 Thread Jeffrey Hugo
On 2/4/2025 1:46 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Add power_profile firmware boot param and set it to 0 by default which is default FW power profile. I don't think that patch does this. It looks like boot_params->power_profile is already defined. What am I missing? -Jeff

Re: [PATCH 5/6] accel/ivpu: Add test modes to toggle clock relinquish disable

2025-02-14 Thread Jeffrey Hugo
Reviewed-by: Jeffrey Hugo

Re: [PATCH 4/6] accel/ivpu: Allow to import single buffer into multiple contexts

2025-02-14 Thread Jeffrey Hugo
can be MMU-mapped only to a single context. Each import now creates a new instance of ivpu_bo object that shares the same sg_table but have separate MMU mappings. Reviewed-by: Jacek Lawrynowicz Signed-off-by: Tomasz Rusinowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 3/6] accel/ivpu: Add debugfs interface for setting HWS priority bands

2025-02-14 Thread Jeffrey Hugo
priority band, facilitating validation and fine-tuning. Reviewed-by: Jacek Lawrynowicz Signed-off-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz As a stand alone patch, seems ok to me. Reviewed-by: Jeffrey Hugo

Re: [PATCH 2/6] accel/ivpu: Prevent runtime suspend during context abort work

2025-02-14 Thread Jeffrey Hugo
On 2/4/2025 1:46 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski Increment the runtime PM counter when entering ivpu_context_abort_work_fn() to prevent the device from suspending while the function is executing. Why should suspend be prevented during the abort fn? -Jeff

Re: [PATCH 1/6] accel/ivpu: Add missing locks around mmu queues

2025-02-14 Thread Jeffrey Hugo
On 2/4/2025 1:46 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski Multiple threads were accessing mmu cmd queue simultaneously causing sporadic failures in ivpu_mmu_cmdq_sync() function. Protect critical code with mmu mutex. Describe a scenario in which this can occur? The two functions

[PATCH] bus: mhi: host: Avoid possible uninitialized fw_load_type

2025-02-14 Thread Jeffrey Hugo
r via BHIe in PBL") Signed-off-by: Jeffrey Hugo --- drivers/bus/mhi/host/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c index c8e48f621a8c..efa3b6dddf4d 100644 --- a/drivers/bus/mhi/host/boot.c +++ b/drivers/bu

Re: [PATCH 0/6] accel/ivpu: Changes for 6.15 2025-02-04

2025-02-14 Thread Jeffrey Hugo
On 2/13/2025 7:17 AM, Thomas Zimmermann wrote: Hi Am 12.02.25 um 16:52 schrieb Jeffrey Hugo: On 2/12/2025 6:27 AM, Jacek Lawrynowicz wrote: Hi, Thanks for your detailed feedback and constructive suggestions. I appreciate this as it is not easy to learn all process details otherwise. I

Re: [PATCH] accel/amdxdna: Refactor hardware context destroy routine

2025-02-14 Thread Jeffrey Hugo
On 1/24/2025 10:35 AM, Lizhi Hou wrote: It is required by firmware to wait up to 2 seconds for pending commands before sending the destroy hardware context command. After 2 seconds wait, if there are still pending commands, driver needs to cancel them. So the context destroy steps need to be:

Re: [PATCH 0/6] accel/ivpu: Changes for 6.15 2025-02-04

2025-02-12 Thread Jeffrey Hugo
On 2/12/2025 6:27 AM, Jacek Lawrynowicz wrote: Hi, Thanks for your detailed feedback and constructive suggestions. I appreciate this as it is not easy to learn all process details otherwise. I echo this. At times, accel feels a bit isolated from DRM. On 2/12/2025 11:20 AM, Thomas Zimmerma

Re: [PATCH v2] accel/amdxdna: Add missing include linux/slab.h

2025-02-11 Thread Jeffrey Hugo
); | ^~~ Add the missing include. Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox") Signed-off-by: Su Hui Reviewed-by: Lizhi Hou Reviewed-by: Jeffrey Hugo

Re: [PATCH 6/6] accel/ivpu: Move recovery work to system_unbound_wq

2025-01-31 Thread Jeffrey Hugo
Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/6] accel/ivpu: Add support for hardware fault injection

2025-01-31 Thread Jeffrey Hugo
er to wait for the hardware to reach a specific state. This allows to test failures during NPU boot and shutdown, IPC message handling and more. Fault injection can be enabled using debugfs or a module parameter. Reviewed-by: Maciej Falkowski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 5/6] accel/ivpu: Enable recovery and adjust timeouts for fpga

2025-01-31 Thread Jeffrey Hugo
Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 4/6] accel/ivpu: Turn on HWS by default on all platforms

2025-01-31 Thread Jeffrey Hugo
On 1/29/2025 5:56 AM, Jacek Lawrynowicz wrote: From: Karol Wachowski Hardware scheduling (HWS) is supposed to be supported on all existing platform with recent FW including pre-silicon ones. Turn on HWS by default. Is there released firmware which does not have this enabled/supported? Should

Re: [PATCH 3/6] accel/ivpu: Fix missing MMU events if file_priv is unbound

2025-01-31 Thread Jeffrey Hugo
and new events are not missed. Reviewed-by: Jacek Lawrynowicz Signed-off-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 2/6] accel/ivpu: Update last_busy in IRQ handler

2025-01-31 Thread Jeffrey Hugo
On 1/29/2025 5:56 AM, Jacek Lawrynowicz wrote: Call pm_runtime_mark_last_busy() in top half of IRQ handler to prevent device from being runtime suspended before bottom half is executed on a workqueue. Reviewed-by: Karol Wachowski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 3/3] accel/ivpu: Fix error handling in recovery/reset

2025-01-31 Thread Jeffrey Hugo
. Also, move common reset/recovery code to separate functions for better code readability. Fixes: 27d19268cf39 ("accel/ivpu: Improve recovery and reset support") Cc: # v6.8+ Reviewed-by: Maciej Falkowski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 2/3] accel/ivpu: Clear runtime_error after pm_runtime_resume_and_get() fails

2025-01-31 Thread Jeffrey Hugo
the NPU fails to boot during runtime resume. Fixes: 7d4b4c74432d ("accel/ivpu: Remove suspend_reschedule_counter") Cc: # v6.11+ Reviewed-by: Maciej Falkowski Signed-off-by: Jacek Lawrynowicz --- Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/3] accel/ivpu: Fix error handling in ivpu_boot()

2025-01-31 Thread Jeffrey Hugo
Reviewed-by: Jeffrey Hugo

Re: [PATCH] accel/amdxdna: Refactor hardware context destroy routine

2025-01-31 Thread Jeffrey Hugo
: Jeffrey Hugo

Re: [PATCH v2 0/7] accel/qaic: Initial AIC200 support

2025-01-31 Thread Jeffrey Hugo
On 1/17/2025 10:09 AM, Jeffrey Hugo wrote: Initial support to the driver to boot up AIC200. AIC200 uses BHIe without BHI, which is something that the MHI bus has not supported until now. While the MHI changes are listed first to facilitate cross-tree merging, they are not needed until the last

Re: [PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-21 Thread Jeffrey Hugo
On 1/21/2025 10:06 AM, Manivannan Sadhasivam wrote: On Tue, Jan 21, 2025 at 08:29:32AM -0700, Jeffrey Hugo wrote: On 1/20/2025 10:16 PM, Manivannan Sadhasivam wrote: On Fri, Jan 17, 2025 at 10:09:43AM -0700, Jeffrey Hugo wrote: Add basic support for the new AIC200 product. The PCIe Device ID

Re: [PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-21 Thread Jeffrey Hugo
On 1/20/2025 10:16 PM, Manivannan Sadhasivam wrote: On Fri, Jan 17, 2025 at 10:09:43AM -0700, Jeffrey Hugo wrote: Add basic support for the new AIC200 product. The PCIe Device ID is 0xa110. With this, we can turn on the lights for AIC200 by leveraging much of the existing driver. Co-developed

[PATCH v2 2/7] bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL

2025-01-17 Thread Jeffrey Hugo
, and does not set fbc_download. The intention is to transfer firmware using BHIe in PBL without further BHIe transfers in SBL. Signed-off-by: Matthew Leung Reviewed-by: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo Reviewed-by: Jacek Lawrynowicz --- drivers/bus/mhi/host

[PATCH v2 4/7] accel/qaic: Add support for MSI-X

2025-01-17 Thread Jeffrey Hugo
. Signed-off-by: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo Reviewed-by: Lizhi Hou --- drivers/accel/qaic/qaic_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c index 6e9bed17b3f1

[PATCH v2 7/7] accel/qaic: Add AIC200 support

2025-01-17 Thread Jeffrey Hugo
Add basic support for the new AIC200 product. The PCIe Device ID is 0xa110. With this, we can turn on the lights for AIC200 by leveraging much of the existing driver. Co-developed-by: Youssef Samir Signed-off-by: Youssef Samir Signed-off-by: Jeffrey Hugo Reviewed-by: Lizhi Hou --- drivers

[PATCH v2 5/7] accel/qaic: Mask out SR-IOV PCI resources

2025-01-17 Thread Jeffrey Hugo
-off-by: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo Reviewed-by: Lizhi Hou --- drivers/accel/qaic/qaic_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c index ce0428f6cb82..00fa07aebacd

[PATCH v2 6/7] accel/qaic: Add config structs for supported cards

2025-01-17 Thread Jeffrey Hugo
let the driver configure the qaic_device struct based on the configurations passed to the driver. Co-developed-by: Youssef Samir Signed-off-by: Youssef Samir Signed-off-by: Jeffrey Hugo Reviewed-by: Lizhi Hou --- drivers/accel/qaic/qaic.h | 13 +++-- drivers/accel/qaic/qaic_drv.c

[PATCH v2 3/7] accel/qaic: Allocate an exact number of MSIs

2025-01-17 Thread Jeffrey Hugo
. Allocate only the needed number of MSI vectors per device. Signed-off-by: Youssef Samir Reviewed-by: Troy Hanson Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo Reviewed-by: Lizhi Hou --- drivers/accel/qaic/qaic_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 1/7] bus: mhi: host: Refactor BHI/BHIe based firmware loading

2025-01-17 Thread Jeffrey Hugo
: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/bus/mhi/host/boot.c | 144 +--- 1 file changed, 99 insertions(+), 45 deletions(-) diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c index e8c92972f9df..9fe13d3f09f0

[PATCH v2 0/7] accel/qaic: Initial AIC200 support

2025-01-17 Thread Jeffrey Hugo
mhi_load_image_bhie() -Adjust the order of mhi_cntrl init in qaic_mhi_register_controller() Jeffrey Hugo (2): accel/qaic: Add config structs for supported cards accel/qaic: Add AIC200 support Matthew Leung (2): bus: mhi: host: Refactor BHI/BHIe based firmware loading bus: mhi: host: Add a

Re: [PATCH 2/7] bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL

2025-01-17 Thread Jeffrey Hugo
On 1/7/2025 10:42 PM, Manivannan Sadhasivam wrote: On Fri, Dec 13, 2024 at 02:33:35PM -0700, Jeffrey Hugo wrote: From: Matthew Leung Currently, mhi host only performs firmware transfer via BHI in PBL and s/mhi/MHI here and below. Done BHIe from SBL. To support BHIe transfer directly

Re: [PATCH 1/7] bus: mhi: host: Refactor BHI/BHIe based firmware loading

2025-01-17 Thread Jeffrey Hugo
On 1/7/2025 10:24 PM, Manivannan Sadhasivam wrote: On Fri, Dec 13, 2024 at 02:33:34PM -0700, Jeffrey Hugo wrote: From: Matthew Leung Refactor the firmware loading code to have distinct helper functions for BHI and BHIe operations. This lays the foundation for separating the firmware loading

Re: [PATCH] accel/qaic: Change aic100_image_table definition

2025-01-17 Thread Jeffrey Hugo
On 12/13/2024 11:51 AM, Jeffrey Hugo wrote: From: Youssef Samir aic100_image_table is currently defined as a "const char *" array, this can potentially lead to the accidental modification of the pointers inside. Also, checkpatch.pl gives a warning about it. Change the type to a &

Re: [PATCH] MAINTAINERS: Update intel_vpu maintainer list

2025-01-14 Thread Jeffrey Hugo
: Stanislaw Gruszka Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo

Re: [PATCH 7/7] accel/qaic: Add AIC200 support

2024-12-20 Thread Jeffrey Hugo
On 12/20/2024 10:33 AM, Lizhi Hou wrote: On 12/20/24 09:26, Jeffrey Hugo wrote: On 12/13/2024 5:49 PM, Lizhi Hou wrote: On 12/13/24 13:33, Jeffrey Hugo wrote: +static const struct qaic_device_config aic200_config = { +    .family = FAMILY_AIC200, +    .bar_mask = BIT(0) | BIT(1) | BIT(2

Re: [PATCH 7/7] accel/qaic: Add AIC200 support

2024-12-20 Thread Jeffrey Hugo
On 12/13/2024 5:49 PM, Lizhi Hou wrote: On 12/13/24 13:33, Jeffrey Hugo wrote: @@ -573,6 +898,13 @@ struct mhi_controller *qaic_mhi_register_controller(struct pci_dev *pci_dev, voi   mhi_cntrl->nr_irqs = 1;   mhi_cntrl->irq = devm_kmalloc(&pci_dev->dev, sizeof(*m

Re: [PATCH 6/7] accel/qaic: Add config structs for supported cards

2024-12-20 Thread Jeffrey Hugo
On 12/13/2024 5:35 PM, Lizhi Hou wrote: On 12/13/24 13:33, Jeffrey Hugo wrote: -static struct qaic_device *create_qdev(struct pci_dev *pdev, const struct pci_device_id *id) +static struct qaic_device *create_qdev(struct pci_dev *pdev, +   const struct qaic_device_config

[PATCH 5/7] accel/qaic: Mask out SR-IOV PCI resources

2024-12-13 Thread Jeffrey Hugo
-off-by: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/qaic_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c index ce0428f6cb82..00fa07aebacd 100644 --- a/drivers

[PATCH 1/7] bus: mhi: host: Refactor BHI/BHIe based firmware loading

2024-12-13 Thread Jeffrey Hugo
: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/bus/mhi/host/boot.c | 155 +--- 1 file changed, 110 insertions(+), 45 deletions(-) diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c index e8c92972f9df..e3f3c07166ad

[PATCH 7/7] accel/qaic: Add AIC200 support

2024-12-13 Thread Jeffrey Hugo
Add basic support for the new AIC200 product. The PCIe Device ID is 0xa110. With this, we can turn on the lights for AIC200 by leveraging much of the existing driver. Co-developed-by: Youssef Samir Signed-off-by: Youssef Samir Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic

[PATCH 6/7] accel/qaic: Add config structs for supported cards

2024-12-13 Thread Jeffrey Hugo
let the driver configure the qaic_device struct based on the configurations passed to the driver. Co-developed-by: Youssef Samir Signed-off-by: Youssef Samir Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/qaic.h | 13 +++-- drivers/accel/qaic/qaic_drv.c | 76

[PATCH 4/7] accel/qaic: Add support for MSI-X

2024-12-13 Thread Jeffrey Hugo
. Signed-off-by: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/qaic_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/qaic/qaic_drv.c b/drivers/accel/qaic/qaic_drv.c index 6e9bed17b3f1..ce0428f6cb82 100644 --- a

[PATCH 3/7] accel/qaic: Allocate an exact number of MSIs

2024-12-13 Thread Jeffrey Hugo
. Allocate only the needed number of MSI vectors per device. Signed-off-by: Youssef Samir Reviewed-by: Troy Hanson Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/qaic_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/accel/qaic

[PATCH 0/7] accel/qaic: Initial AIC200 support

2024-12-13 Thread Jeffrey Hugo
different product from AIC100 with MSI-X, different BARs, and different MHI configuration so we finally need some infrastructure in the driver to be able to handle product differences. This is expected to evolve more over time. Jeffrey Hugo (2): accel/qaic: Add config structs for supported cards

[PATCH 2/7] bus: mhi: host: Add a policy to enable image transfer via BHIe in PBL

2024-12-13 Thread Jeffrey Hugo
, and does not set fbc_download. The intention is to transfer firmware using BHIe in PBL without further BHIe transfers in SBL. Signed-off-by: Matthew Leung Reviewed-by: Youssef Samir Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/bus/mhi/host/boot.c | 80

[PATCH] accel/qaic: Change aic100_image_table definition

2024-12-13 Thread Jeffrey Hugo
e pointers immutable, preventing accidental modification of the images' paths. Signed-off-by: Youssef Samir Reviewed-by: Carl Vanderlip Reviewed-by: Jeffrey Hugo Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/sahara.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 10:57 AM, Lizhi Hou wrote: On 12/13/24 09:49, Jeffrey Hugo wrote: On 12/13/2024 10:41 AM, Lizhi Hou wrote: On 12/13/24 09:07, Jeffrey Hugo wrote: On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 10:41 AM, Lizhi Hou wrote: On 12/13/24 09:07, Jeffrey Hugo wrote: On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build warning when CONFIG_PM is disabled: drivers/accel/amdxdna

Re: [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 10:02 AM, Lizhi Hou wrote: On 12/13/24 08:58, Jeffrey Hugo wrote: On 12/6/2024 3:00 PM, Lizhi Hou wrote: The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. I

Re: [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

2024-12-13 Thread Jeffrey Hugo
d-by: Mike Lothian Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohanzxxe7wd2cj9kfj...@mail.gmail.com/ Signed-off-by: Mike Lothian Reviewed-by: Mario Limonciello Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou Applied to drm-misc-next -Jeff

Re: [PATCH 2/2] accel/amdxdna: add missing includes

2024-12-13 Thread Jeffrey Hugo
urce solver") Signed-off-by: Arnd Bergmann amdxdna: includ linux/interrupt.h Signed-off-by: Arnd Bergmann The interrupt part of this is now fixed, see "accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c". The slab portion looks sane. I'll trim the patch when applying unless you'd prefer something else. Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/2] accel/amdxdna: use modern PM helpers

2024-12-13 Thread Jeffrey Hugo
On 12/13/2024 2:02 AM, Arnd Bergmann wrote: From: Arnd Bergmann The old SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS macros cause a build warning when CONFIG_PM is disabled: drivers/accel/amdxdna/amdxdna_pci_drv.c:343:12: error: 'amdxdna_pmops_resume' defined but not used [-Werror=unused-fu

Re: [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

2024-12-13 Thread Jeffrey Hugo
d-by: Mike Lothian Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohanzxxe7wd2cj9kfj...@mail.gmail.com/ Signed-off-by: Mike Lothian Reviewed-by: Mario Limonciello Reviewed-by: Jeffrey Hugo Signed-off-by: Lizhi Hou Pushed to drm-misc-next -Jeff

Re: [PATCH V2 0/8] AMD NPU driver improvements

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Add recent improvements and bug fixes for amdxdna driver (depends on [1]) 1. Support recent hardware and firmware. 2. Replace idr APIs with xarray. 3. Fix the bugs been found. [1]: https://lore.kernel.org/all/20241118172942.2014541-1-lizhi@amd.com/ Cha

Re: [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 3:00 PM, Lizhi Hou wrote: The latest released firmware supports reading firmware interface version from registers directly. The driver's probe routine reads the major and minor version numbers. If the firmware interface does not compatible with the driver, the driver's probe routine

Re: [PATCH V2 6/8] accel/amdxdna: Enhance power management settings

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: +/** + * struct amdxdna_drm_get_power_mode - Get the configured power mode + * @power_mode: The mode type from enum amdxdna_power_mode_type + * @pad: MBZ. I don't see a check for zero in the implementation + */ +struct amdxdna_drm_get_power_mode { +

Re: [PATCH V2 5/8] accel/amdxdna: Add query firmware version

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Enhance GET_INFO ioctl to support retrieving firmware version. Signed-off-by: Lizhi Hou Reviewed-by: Jeffrey Hugo Warning below through. enum amdxdna_drm_get_param { DRM_AMDXDNA_QUERY_AIE_STATUS, DRM_AMDXDNA_QUERY_AIE_METADATA

Re: [PATCH V2 4/8] accel/amdxdna: Replace idr api with xarray

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Switch mailbox message id and hardware context id management over from the idr api to the xarray api. Signed-off-by: Lizhi Hou Implementation looks sane, however you appear to be missing several instances of #include -Jeff

Re: [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Add NPU6 registers and other private configurations. Co-developed-by: Xiaoming Ren Signed-off-by: Xiaoming Ren Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile| 3 +- drivers/accel/amdxdna/npu6_regs.c | 121 +++

Re: [PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput_async to avoid dead lock

2024-12-13 Thread Jeffrey Hugo
dead lock. Fixes: aac243092b70 ("accel/amdxdna: Add command execution") Signed-off-by: Lizhi Hou Reviewed-by: Jeffrey Hugo

Re: [PATCH V2 1/8] accel/amdxdna: Add device status for aie2 devices

2024-12-13 Thread Jeffrey Hugo
On 12/6/2024 2:59 PM, Lizhi Hou wrote: Add device status to track if aie2_hw_start() or aie2_hw_stop() is re-entered. In aie2_hw_stop(), call drmm_kfree to free mbox. Signed-off-by: Lizhi Hou Reviewed-by: Jeffrey Hugo

Re: [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c

2024-12-13 Thread Jeffrey Hugo
is SOB. With either of those: Reviewed-by: Jeffrey Hugo

Re: [PATCH] accel/qaic: Fix typo for struct qaic_manage_trans_passthrough

2024-12-13 Thread Jeffrey Hugo
On 11/29/2024 1:28 PM, Jeffrey Hugo wrote: The documentation header for struct qaic_manage_trans_passthrough has a typo - "t" is missing in "transaction". Signed-off-by: Jeffrey Hugo --- include/uapi/drm/qaic_accel.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH 3/3] accel/ivpu: Fix WARN in ivpu_ipc_send_receive_internal()

2024-12-13 Thread Jeffrey Hugo
On 12/10/2024 6:09 AM, Jacek Lawrynowicz wrote: Move pm_runtime_set_active() to ivpu_pm_inti() so when ivpu_pm_init() With that Reviewed-by: Jeffrey Hugo

Re: [PATCH 2/3] accel/ivpu: Fix memory leak in ivpu_mmu_reserved_context_init()

2024-12-13 Thread Jeffrey Hugo
eviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo

Re: [PATCH 1/3] accel/ivpu: Fix general protection fault in ivpu_bo_list()

2024-12-13 Thread Jeffrey Hugo
pu_addr, bo->base.base.size, bo->flags, kref_read(&bo->base.base.refcount)); if (bo->base.pages) Reviewed-by: Jeffrey Hugo

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Jeffrey Hugo
On 12/6/2024 11:47 AM, Lizhi Hou wrote: On 12/6/24 09:01, Mike Lothian wrote: On Fri, 6 Dec 2024 at 16:41, Mike Lothian wrote: On Fri, 6 Dec 2024 at 16:26, Jeffrey Hugo wrote: On 12/5/2024 8:44 AM, Mike Lothian wrote: Hi I needed to add the following to get things compiling for me diff

Re: [PATCH V7 03/10] accel/amdxdna: Support hardware mailbox

2024-12-06 Thread Jeffrey Hugo
On 12/5/2024 8:44 AM, Mike Lothian wrote: Hi I needed to add the following to get things compiling for me diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c index fe684f463b945..79b9801935e71 100644 --- a/drivers/accel/amdxdna/amdxdna_mailbox.c +++ b

[PATCH] accel/qaic: Fix typo for struct qaic_manage_trans_passthrough

2024-11-29 Thread Jeffrey Hugo
The documentation header for struct qaic_manage_trans_passthrough has a typo - "t" is missing in "transaction". Signed-off-by: Jeffrey Hugo --- include/uapi/drm/qaic_accel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/drm/qaic_accel.

Re: [PATCH AUTOSEL 6.12 033/107] accel/qaic: Add AIC080 support

2024-11-24 Thread Jeffrey Hugo
On 11/24/2024 6:28 AM, Sasha Levin wrote: From: Jeffrey Hugo [ Upstream commit b8128f7815ff135f0333c1b46dcdf1543c41b860 ] Add basic support for the new AIC080 product. The PCIe Device ID is 0xa080. AIC080 is a lower cost, lower performance SKU variant of AIC100. From the qaic perspective, it

Re: [PATCH V11 00/10] AMD XDNA driver

2024-11-22 Thread Jeffrey Hugo
On 11/18/2024 10:29 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. Merged to drm-misc-next -Jeff

Re: [PATCH] accel/qaic: Drop redundant vfree() null check in sahara

2024-11-22 Thread Jeffrey Hugo
On 11/17/2024 1:26 PM, Jeffrey Hugo wrote: The documentation for vfree() says that passing in NULL is ok. Therefore we can drop the null check as redundant. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abf5md4e-...@intel.com/ Signed-off-by: Jeffrey

Re: [PATCH V11 00/10] AMD XDNA driver

2024-11-18 Thread Jeffrey Hugo
On 11/18/2024 10:29 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. Not seeing any additional issues. Build for bisect looks good. My plan is to let this sit on list until Friday to allow for one fin

Re: [PATCH V10 07/10] accel/amdxdna: Add command execution

2024-11-17 Thread Jeffrey Hugo
file.build:478: drivers/accel] Error 2 make[2]: *** [scripts/Makefile.build:478: drivers] Error 2 make[2]: *** Waiting for unfinished jobs AR kernel/module/built-in.a AR kernel/built-in.a With the above two things fixed: Reviewed-by: Jeffrey Hugo

[PATCH] accel/qaic: Drop redundant vfree() null check in sahara

2024-11-17 Thread Jeffrey Hugo
The documentation for vfree() says that passing in NULL is ok. Therefore we can drop the null check as redundant. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202410301732.abf5md4e-...@intel.com/ Signed-off-by: Jeffrey Hugo --- drivers/accel/qaic/sahara.c | 3

Re: [PATCH] accel/ivpu: Fix NOC firewall interrupt handling

2024-10-29 Thread Jeffrey Hugo
debugfs file that tracks firewall interrupts. Fixes: 8a27ad81f7d3 ("accel/ivpu: Split IP and buttress code") Cc: # v6.11+ Signed-off-by: Andrzej Kacprowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-10-29 Thread Jeffrey Hugo
ruct drm_driver, its initialization from drivers, along with the common DRIVER_DATE macros. v2: Also update drivers/accel (kernel test robot) Reviewed-by: Javier Martinez Canillas Acked-by: Alex Deucher Acked-by: Simon Ser Signed-off-by: Jani Nikula For QAIC - Acked-by: Jeffrey Hugo

Re: [PATCH V5 00/10] AMD XDNA driver

2024-10-25 Thread Jeffrey Hugo
On 10/25/2024 3:28 PM, Lizhi Hou wrote: On 10/25/24 10:55, Jeffrey Hugo wrote: On 10/21/2024 10:19 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference

Re: [PATCH V5 00/10] AMD XDNA driver

2024-10-25 Thread Jeffrey Hugo
On 10/21/2024 10:19 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neural Processing Unit) is an AI inference accelerator integrated into AMD client CPUs. NPU enables efficient execution of Machine

Re: [PATCH V5 07/10] accel/amdxdna: Add command execution

2024-10-25 Thread Jeffrey Hugo
On 10/21/2024 10:19 AM, Lizhi Hou wrote: diff --git a/include/uapi/drm/amdxdna_accel.h b/include/uapi/drm/amdxdna_accel.h index 3792750834b2..08f3ec7146ab 100644 --- a/include/uapi/drm/amdxdna_accel.h +++ b/include/uapi/drm/amdxdna_accel.h @@ -13,6 +13,7 @@ extern "C" { #endif +#define AMD

Re: [PATCH V5 09/10] accel/amdxdna: Add error handling

2024-10-25 Thread Jeffrey Hugo
message. The thread stops the clients which are using the column where error occurred. Then the driver resets that column. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou Reviewed-by: Jeffrey Hugo

Re: [PATCH v2] accel/qaic: Add crashdump to Sahara

2024-10-25 Thread Jeffrey Hugo
On 10/21/2024 2:03 PM, Jeffrey Hugo wrote: The Sahara protocol has a crashdump functionality. In the hello exchange, the device can advertise it has a memory dump available for the host to collect. Instead of the device making requests of the host, the host requests data from the device which

[PATCH v2] accel/qaic: Add crashdump to Sahara

2024-10-21 Thread Jeffrey Hugo
the original files from. Reviewed-by: Carl Vanderlip Signed-off-by: Jeffrey Hugo --- v2: -Clarify the dump structure to userspace -Use array notation for copying an array to the dump -Use min() over trinary operator -Remove extra return statement -Remove extra cast -Use all cpu_to_le operations

Re: [PATCH] accel/qaic: Add crashdump to Sahara

2024-10-21 Thread Jeffrey Hugo
On 10/15/2024 1:04 PM, Bjorn Andersson wrote: On Tue, Oct 15, 2024 at 12:34:29PM -0600, Jeffrey Hugo wrote: On 10/14/2024 3:52 PM, Bjorn Andersson wrote: On Wed, Sep 18, 2024 at 09:52:54AM -0600, Jeffrey Hugo wrote: + dev_table_entry = (struct sahara_debug_table_entry64 *)(context->

Re: [PATCH 05/11] accel/ivpu: Unmap partially mapped BOs in case of errors

2024-10-19 Thread Jeffrey Hugo
: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 11/11] accel/ivpu: Move secondary preemption buffer allocation to DMA range

2024-10-18 Thread Jeffrey Hugo
ws to allocate more command queues with corresponding preemption buffers without running out of address range. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 08/11] accel/ivpu: Don't allocate preemption buffers when MIP is disabled

2024-10-18 Thread Jeffrey Hugo
disables MIP - job level preemption will still occur. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 10/11] accel/ivpu: Increase DMA address range

2024-10-18 Thread Jeffrey Hugo
Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 09/11] accel/ivpu: Add debug Kconfig option

2024-10-18 Thread Jeffrey Hugo
On 10/17/2024 8:58 AM, Jacek Lawrynowicz wrote: From: Maciej Falkowski Add CONFIG_DRM_ACCEL_IVPU_DEBUG option that: - Adds -DDEBUG that enables printk regardless of the kernel config - Enables unsafe module params (that are now disabled by default) Signed-off-by: Maciej Falkowski Reviewed

Re: [PATCH 07/11] accel/ivpu: Make command queue ID allocated on XArray

2024-10-18 Thread Jeffrey Hugo
a context. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 06/11] accel/ivpu: Use xa_alloc_cyclic() instead of custom function

2024-10-18 Thread Jeffrey Hugo
are not reused all over. The same can be achieved just by using appropriate Linux API. Signed-off-by: Karol Wachowski Reviewed-by: Jacek Lawrynowicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

Re: [PATCH 04/11] accel/ivpu: Clear CDTAB entry in case of failure

2024-10-18 Thread Jeffrey Hugo
owicz Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo

  1   2   3   4   5   6   7   8   >