Javier Martinez Canillas writes:
> Geert Uytterhoeven writes:
>
> Hello Geert,
>
>> When moving the Sitronix DRM drivers and renaming their Kconfig symbols,
>> the old symbols were kept, aiming to provide a seamless migration path
>> when running "ma
itronix: move tiny Sitronix drivers to their
> own subdir")
> Signed-off-by: Geert Uytterhoeven
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
fix for the current setup, I'd prefer removing the
> old symbols.
>
I agree. When this was discussed, I argued that we should just remove the
old symbols and let kernel packagers to deal with it. As Geert said, it's
not uncommon for Kconfig symbols names to change over time...
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
16-bit values
> for red, green and blue. The driver reduces them to 8 bit to make
> them fit into hardware registers.
>
> Signed-off-by: Thomas Zimmermann
> Acked-by: Javier Martinez Canillas
I think this patch was acked by Jocelyn, not me. You can fix it
just before merging the
+static bool dummycon_switch(struct vc_data *vc)
> +{
> + /* Redraw, so that we get putc(s) for output done while switched away */
Maybe this comment could be a little bit more verbose about why this is needed
for the framebuffer console deferred takeover case? It doesn't hav
for red,
> green and blue. The driver reduces them to 8 bit to make them fit
> into hardware registers.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c
> index fddfe8bea9f7..96fafdc8dd5e 100644
> --- a/drivers/gpu/drm/sysfb/ofdrm.c
> +++ b/drivers/gpu/drm/sysfb/ofdrm.c
> @@ -8,6 +8,7 @@
Looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
alette could
> be used.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/drm_color_mgmt.c | 206 +++
> include/drm/drm_color_mgmt.h | 27
> 2 files changed, 233 insertions(+)
>
Thanks a lot for adding all these helpers. I'm not
Thomas Zimmermann writes:
Hello Marcus,
> Am 12.05.25 um 09:15 schrieb Marcus Folkesson:
>> We start to have support many Sitronix displays in the tiny directory,
>> and we expect more to come.
>>
>> Move them to their own subdirectory.
>>
>> Reviewed-by:
Philipp Stanner writes:
Hello Philipp,
> On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
>> Philipp Stanner writes:
>>
>> Hello Philipp,
>>
>> > cirrus enables its PCI device with pcim_enable_device(). This,
>> > implicitly, swi
Jocelyn Falempe writes:
Hello Jocelyn,
> Add myself and Javier as maintainer for drm_panic, drm_panic_qr_code
> and drm_log.
>
> Signed-off-by: Jocelyn Falempe
> Acked-by: Thomas Zimmermann
> ---
>
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier M
Thomas Zimmermann writes:
> Hi Javier, Marcus
>
> Am 05.05.25 um 11:27 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann writes:
>>
>> Hello Thomas,
>>
>>> Hi,
>>>
>>> there's one major issue here. You must not change th
dmin-guide/abi.html document
explictly states that Kconfig symbols are not an ABI, and userspace
should not rely on these not changing over time.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
> On Mon, Apr 28, 2025 at 09:16:32AM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > We start to have support many Sitronix displays in the tiny dir
Javier Martinez Canillas writes:
> Dan Carpenter writes:
>
> Hello Dan,
>
>> The devm_kzalloc() function returns NULL on failure, not error pointers.
>> Also printing an error message for kmalloc() failures is against kernel
>> style so just return -ENOMEM without
).
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD
> controller")
> Signed-off-by: Dan Carpenter
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Robert Mader writes:
Hello Robert,
> Chris, Javier, Laurent - sorry for the noise, but given you reviewed
> changes in the respective files before, maybe you can help me moving
I'm not familiar with these formats to do a proper review. Sorry about that...
--
Best regards,
Javi
m_client_setup'
>
> Select the appropriate Kconfig symbol.
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD
> controller")
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
mats and invert the
>> pixels for the R1, R2 and XRGB formats.
>>
>> Could that work or are there any side effects that I should be aware of?
>
> That should work fine.
Agree.
> Note that you do not have to support R1 and R2, as they are non-native.
> AFAIK XRGB is the only format all drivers must support.
>
> Gr{oetje,eeting}s,
>
That's correct. The driver should only support D1 and D2 as native formats
and (emulated) XRGB for compatibility with existing user-space. No need
to support R1 and R2 since the controller does not support these formats.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
rnel.org/dri-devel/caniq72ke45eowckmhwhvmwxc03dxr4rnxxkvx+hvwdblopz...@mail.gmail.com/
> [1]
> Signed-off-by: Jocelyn Falempe
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
Hello Marcus,
> We start to have support many Sitronix displays in the tiny directory,
> and we expect more to come.
>
> Move them to their own subdirectory.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
You
Ryosuke Yasuoka writes:
Hello Ryosuke,
> Hi Javier,
>
> On Fri, Apr 25, 2025 at 4:15 PM Javier Martinez Canillas
> wrote:
>>
>> Ryosuke Yasuoka writes:
>>
>> Hello Ryosuke,
>>
>> > Drop simple-KMS in favor of regular atomic helpers to make th
xes: 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by
> shmem")
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
tate, state);
drm_atomic_for_each_plane_damage(&iter, &damage) {
dst_clip = state->dst;
if (!drm_rect_intersect(&dst_clip, &damage))
continue;
hyperv_blit_to_vram_rect(state->fb,
&shadow_p
Marcus Folkesson writes:
> Hello Javier,
>
> On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
>> &
I2C_M_IGNORE_NAK flag.
>
> Signed-off-by: Marcus Folkesson
> ---
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
Hello Marcus,
> Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> The controller has a SPI, I2C and 8bit parallel interface, this
> driver is for the I2C interface only.
>
> Reviewed-by: Thomas Zimmermann
> Reviewed-by: Javier
rallel interface, this
> driver is for the I2C interface only.
>
> Reviewed-by: Thomas Zimmermann
> Reviewed-by: Javier Martinez Canillas
> Signed-off-by: Marcus Folkesson
> ---
> drivers/gpu/drm/tiny/Kconfig | 11 +
> drivers/gpu/drm/tiny/Makefile |1 +
>
d ?
> + if (format == DRM_FORMAT_R1 || format ==
> DRM_FORMAT_XRGB)
> + regmap_bulk_write(st7571->regmap,
> ST7571_DATA_MODE, row + x, 1);
> + }
> + }
> +
> + return 0;
> +}
> +
The driver looks great to me now, thanks a lot for taking my comments into
account!
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
> Sitronix ST7571 is a dot matrix LCD controller supporting
> both 4bit grayscale and monochrome LCDs.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
: Documentation/devicetree/bindings/display/sitronix,st7586.txt
> F: drivers/gpu/drm/tiny/st7586.c
>
> +DRM DRIVER FOR SITRONIX ST7571 PANELS
> +M: Marcus Folkesson
> +S: Maintained
> +F: Documentation/devicetree/bindings/display/sitronix,st7571.yaml
> +F: drivers/gpu/
depth for the
> BPP default")
> Signed-off-by: Fabio Estevam
> Reviewed-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Stanner
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
> Reported-by: Tested-by: "Ivan T. Ivanov"
>> Closes: https://bugzilla.suse.com/show_bug.cgi?id=1240696
>> Tested-by: Tested-by: "Ivan T. Ivanov"
>> Fixes: 78aa89d1dfba ("firmware/sysfb: Update screen_info for relocated EFI
>> framebuffers")
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: # v6.9+
>> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t.
But don't worry about it. Since I've these displays and your driver now
allows for different IC families after adding the mentioned indirection
layer, it should be very trivial for me to add support for these on top.
> I've split up the driver though, which will be right after this series.
>
Nice, thanks again.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; Signed-off-by: Arnd Bergmann
> ---
A similar patch has been proposed by Nathan already and acked by Thomas:
https://lists.freedesktop.org/archives/dri-devel/2025-April/500539.html
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
7;ve a ST7567 based LCD and a WIP driver for it. But I could
just drop that and use your driver, since AFAICT the expected display data
RAM format is exactly the same than when using monochrome for the ST7571.
But due the ST7567 only supporting R1, it would be silly to always have to
define a property in the DT node given that does not support other format.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Make CONFIG_DRM_EFIDRM a tristate to enable module builds.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
> Hello Javier,
>
> Thank you for your review and suggestions.
>
> On Tue, Apr 08, 2025 at 12:44:46PM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > Sitronix ST757
Marcus Folkesson writes:
> Hello Javier,
>
> On Wed, Apr 09, 2025 at 11:43:54AM +0200, Javier Martinez Canillas wrote:
[...]
>>
>> Likely you will need to define more stuff to be specific for each entry,
>> maybe
>> you will need different primary plane upda
ad
to do it the ssd130x driver to support all the Solomon OLED controller families:
https://elixir.bootlin.com/linux/v6.11/source/drivers/gpu/drm/solomon/ssd130x.c#L1439
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ooks
> up the correct DRM format info from a driver-provided list of color
> formats.
>
> These screen_info helpers are only available if CONFIG_SCREEN_INFO
> has been selected, as done by efidrm and vesadrm.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Marti
t;
> MODULE_DESCRIPTION("Helpers for DRM sysfb drivers");
> MODULE_LICENSE("GPL");
> +
I think the convention is to put these MODULE_* macros at the end of the file?
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; sysfb helpers.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Hi,
>
> lots of good points in the review.
>
> Am 08.04.25 um 12:44 schrieb Javier Martinez Canillas:
> [...]
>>> Reviewed-by: Thomas Zimmermann
>>> Signed-off-by: Marcus Folkesson
>>> ---
>>> drivers/gpu/dr
Thomas Zimmermann writes:
> Building efidrm as module requires efi_mem_desc_lookup(). Export
> the symbol.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ore_nak = true;
> +
> + st7571->regmap = devm_regmap_init(&client->dev, &st7571_regmap_bus,
> + client, &st7571_regmap_config);
> + if (IS_ERR(st7571->regmap)) {
> + dev_err(&client->dev, "Failed to initialize regmap\n");
If you use dev_err_probe(), you can give some indication to users about
what failed. It prints messages in the /sys/kernel/debug/devices_deferred
debugfs entry.
> +
> +static void st7571_remove(struct i2c_client *client)
> +{
> + struct st7571_device *st7571 = i2c_get_clientdata(client);
> +
> + drm_dev_unplug(&st7571->dev);
I think you are missing a drm_atomic_helper_shutdown() here.
And also a struct i2c_driver .shutdown callback to call to
drm_atomic_helper_shutdown() as well.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
.kernel.org/dri-devel/20250407131344.139878-1-jfale...@redhat.com/
> Fixes: 177dfbdb7e67 ("drm/sysfb: Merge primary-plane functions")
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ld in struct
> simpledrm_device.
>
> Signed-off-by: Thomas Zimmermann
> Fixes: 11e8f5fd223b ("drm: Add simpledrm driver")
> Cc: # v5.14+
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
es it available in ofdrm.
>
> The supported formats are all native formats plus an optional enulated
> XRGB if that's not already a native format. Provide an initializer
> macro that computes the size of the formats array.
>
> Signed-off-by: Thomas Zimmermann
> --
property in their DT. Exporting
> this information allows compositors to implement correct DPI and
> meaningful color management.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
d by the boot loader
> or read by the kernel during early boot stages.
>
> There's only one VESA display, so EDID data always belongs to this
> output.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
immermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
atch the VESA manuals.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
mas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
nn
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
eded in efidrm,
> but SIMPLEFB_FORMATS can later be converted to struct pixel_format.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Move the calculation of the bits per pixels for screen_info into a
> helper function. This will make it available to other callers besides
> the firmware code.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
Hello Thomas,
> Hi Javier
>
> Am 23.03.25 um 11:57 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann writes:
>>
>>> Merge the connector functions of ofdrm and simpledrm. Replace the
>>> code in each driver with th
single_connector_modes,
> + DRM_SYSFB_CONNECTOR_FUNCS,
> .destroy = drm_connector_cleanup,
Why not include the .destroy callback in DRM_SYSFB_CONNECTOR_FUNCS ?
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> Provide initializer to set struct drm_mode_config_funcs. Convert
> ofdrm and simpledrm.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
y: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
; Signed-off-by: Thomas Zimmermann
> ---
Nice patch, this makes total sense in hindsight.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> The ofdrm and simpledrm drivers are special as they operate on
> externally provided framebuffers. Move them into their own sub-
> directory. Will let them share common code.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez C
truct drm_plane primary_plane;
> struct drm_crtc crtc;
> struct drm_encoder encoder;
> --
> 2.48.1
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> The helper drm_simple_encoder_init() is a trivial helper around
> drm_encoder_init() and therefore deprecated. Open-code the function
> and remove the dependency.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
t struct ofdrm_device_funcs *funcs;
>
> --
> 2.48.1
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
e can already drop
> vgacon from normal x86-64 distro configs, i.e. if there are cases
> that are not already covered by any of efi-earlycon, efifb,
> vga16fb, vesafb/uvesafb or a PCI DRM driver.
>
I believe vgacon is still useful for x86 with legacy BIOS, because
vesafb (and simpledrm)
Maxime Ripard writes:
> The DRM and KMS frameworks and helpers gain more and more kunit
> coverage, so let's document what our expectations are.
>
> Suggested-by: Jani Nikula
> Signed-off-by: Maxime Ripard
>
> ---
>
Seems a reasonable expection to me.
Reviewed
SSD*"
even when they are quite different and can't be supported by same driver.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
gt; 13xx as you have said are display controllers family.
>
Exactly. Both chips are from the same vendor (Solomon Systech [0]) and my
guess is that the SSD prefix means "Solomon Systech Device" or something
like that.
[0]: https://www.solomon-systech.com
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ohn Keeping (2):
> drm/ssd130x: fix ssd132x encoding
> drm/ssd130x: ensure ssd132x pitch is correct
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
John Keeping writes:
> Hi Javier,
>
> Thanks for the review.
>
> On Tue, Jan 14, 2025 at 11:21:25PM +0100, Javier Martinez Canillas wrote:
>> John Keeping writes:
>> Thanks for your patches!
>>
>> > The ssd132x family of chips require the result
Javier Martinez Canillas writes:
> John Keeping writes:
>
>> The bounding rectangle is adjusted to ensure it aligns to
>> SSD132X_SEGMENT_WIDTH, which may adjust the pitch. Calcuate the pitch
>
> Calculate
>
>> after alighting the left and right edge.
>
> SSD132X_SEGMENT_WIDTH),
>ssd130x->width);
>
> + dst_pitch = drm_rect_width(rect);
> +
> ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
> if (ret)
> return ret;
> --
> 2.47.1
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
evice
> *ssd130x,
> u8 n1 = buf[i * width + j];
> u8 n2 = buf[i * width + j + 1];
>
> - data_array[array_idx++] = (n2 << 4) | n1;
> + data_array[array_idx++] = (n2 & 0xf0) | (n1 >&
d msleep()
used for larger msecs.
[0]: https://www.kernel.org/doc/Documentation/timers/timers-howto.rst
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Javier Martinez Canillas writes:
> Dmitry Baryshkov writes:
>
>> On Tue, Dec 31, 2024 at 04:34:34PM +0100, Javier Martinez Canillas wrote:
>>> Dmitry Baryshkov writes:
>>>
>>> Hello Dmitry,
>>>
>>> > On Tue, Dec
Dmitry Baryshkov writes:
> On Tue, Dec 31, 2024 at 04:34:34PM +0100, Javier Martinez Canillas wrote:
>> Dmitry Baryshkov writes:
>>
>> Hello Dmitry,
>>
>> > On Tue, Dec 31, 2024 at 12:44:58PM +0100, Javier Martinez Canillas wrote:
>
> [...]
>
&g
Dmitry Baryshkov writes:
Hello Dmitry,
> On Tue, Dec 31, 2024 at 12:44:58PM +0100, Javier Martinez Canillas wrote:
>> The only reason for the ssd130x-spi driver to have an spi_device_id table
>> is that the SPI core always reports an "spi:" MODALIAS, even when t
id_table even though it's not necessary.
Since the check is done even for built-in drivers, drop the condition to
only define the ID table when the driver is built as a module. Finally,
rename the variable to use the "_spi_id" convention used for ID tables.
Signed-off-by: Javier M
fbdev code scares me, but I at least tried to check a few things and looks
> all good.
>
> Reviewed-by: Simona Vetter
>
Same here, is always scary to review fbdev code but the patch looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ember from struct
> drm_driver, its initialization from drivers, along with the common
> DRIVER_DATE macros.
>
> Signed-off-by: Jani Nikula
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
virtualizat...@lists.linux.dev
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
been merged.
>
Thanks for doing this cleanup. Makes a lot of sense for me to drop it.
For the whole series:
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
loses: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12160
> Signed-off-by: Thomas Zimmermann
> Fixes: b49420d6a1ae ("video/aperture: optionally match the device in
> sysfb_disable()")
> Cc: Javier Martinez Canillas
> Cc: Thomas Zimmermann
> Cc: Helge Dell
Tzung-Bi Shih writes:
Hello Tzung-Bi,
> On Mon, Sep 16, 2024 at 01:00:24PM +0200, Javier Martinez Canillas wrote:
>> The patches have only been compiled tested because I don't have access to
>> a coreboot machine. Please let me know if you plan to merge both patches
&
pes directly (Thomas Zimmermann).
- Fix missing "device" word in a comment (Brian Norris).
- Fix some mispellings in a comment (Brian Norris).
- Change error code returned from -EINVAL to -ENODEV (Brian Norris).
Javier Martinez Canillas (2):
firmware: sysfb: Add a sysfb_handles_screen_inf
.
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
---
Changes in v4:
- New patch to add sysfb_handles_screen_info() helper (Thomas Zimmermann).
drivers/firmware/sysfb.c | 19 +++
include/linux/sysfb.h| 7 +++
2 files changed, 26 insertions(+)
diff --git a
ernel.org/all/ZuCG-DggNThuF4pj@b20ea791c01f/T/#ma7fb65acbc1a56042258adac910992bb225a20d2
Suggested-by: Julius Werner
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
Reviewed-by: Brian Norris
Reviewed-by: Julius Werner
---
Changes in v4:
- Use a sysfb_handles_screen_info() helper ins
Thomas Zimmermann writes:
Hello Thomas,
> Hi Javier
>
> Am 16.09.24 um 10:36 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann writes:
>>
>> Hello Thomas and Tzung-Bi,
>>
>>> Hi
>>>
>>> Am 15.09.24 um 09:44 schrieb kernel test ro
t-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Javier-Martinez-Canillas/firmware-coreboot-Don-t-register-a-pdev-if-screen_info-data-is-present/20240914-053323
>> base:
>> https://git.kernel.org/pu
our Reviewed-by tag collected.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ernel.org/all/ZuCG-DggNThuF4pj@b20ea791c01f/T/#ma7fb65acbc1a56042258adac910992bb225a20d2
Suggested-by: Julius Werner
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
Reviewed-by: Brian Norris
Reviewed-by: Julius Werner
---
Changes in v3:
- Fix coreboot spelling to be all in lowercas
ernel.org/all/ZuCG-DggNThuF4pj@b20ea791c01f/T/#ma7fb65acbc1a56042258adac910992bb225a20d2
Suggested-by: Julius Werner
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Thomas Zimmermann
Reviewed-by: Brian Norris
---
Changes in v2:
- Declare the struct screen_info as constant variable (Thomas Zimmermann)
Brian Norris writes:
Hello Brian,
> Hi Javier,
>
> On Thu, Sep 12, 2024 at 06:33:58PM +0200, Javier Martinez Canillas wrote:
>> That's a very good point. I'm actually not familiar with Coreboot and I
>> used an educated guess (in the case of DT for example, tha
Jocelyn Falempe writes:
> On 13/09/2024 09:22, Javier Martinez Canillas wrote:
>> Jocelyn Falempe writes:
>>
>> Hello Jocelyn,
>>
>>> Add support for ABGR2101010, used by the nouveau driver.
>>>
>>> Signed-off-by: Jocelyn F
y copyright to that driver, but to simplify
> things:
>
> Acked-by: Uwe Kleine-König
>
Similar for me too. My only change to this driver I think was to add DRM
panic support in commit b2cb6011bcaf ("drm/tidss: Add drm_panic support").
But I'm also OK with the change, so:
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t_xrgb_to_argb2101010(color);
> + case DRM_FORMAT_ABGR2101010:
> + return convert_xrgb_to_abgr2101010(color);
> default:
> WARN_ONCE(1, "Can't convert to %p4cc\n", &format);
> return 0;
> --
> 2.46.0
>
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
1 - 100 of 2074 matches
Mail list logo
