r me the change looks good.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
> If this is not what the display map against, the controller has support
> to invert these values.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ng: symbol 'st7571_config' was not declared. Should
it be static?
MODPOST Module.symvers
LD [M] st7571-i2c.ko
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202507180503.nfyd9urv-...@intel.com
Signed-off-by: Javier Martinez Canillas
---
Changes in
ng: symbol 'st7571_config' was not declared. Should
it be static?
MODPOST Module.symvers
LD [M] st7571-i2c.ko
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202507180503.nfyd9urv-...@intel.com
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/sitro
Javier Martinez Canillas writes:
> This patch-series adds support for the Sitronix ST7567 Controller, which is a
> monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel
> interfaces.
>
> The st7571-i2c driver only has support for I2C so displays using oth
Other Sitronix display controllers might need a different parsing DT
logic, so lets add a .parse_dt callback to struct st7571_panel_data.
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
drivers/gpu/drm/sitronix
is used by the ST7571 controller, so only is needed a different callback
that implements the expected initialization sequence for the ST7567 chip.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
Reviewed-by: Thomas Zimmermann
---
Changes in v3:
- Explicitly set
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Rob Herring (Arm)
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
.../bindings/display/sitronix,st7567.yaml | 63 +++
MAINTAINERS
The driver already uses the dev_err_probe() helper (that only prints error
messages for the -EPROBE_DEFER case) when fails to get any other resource.
Also do the same when it fails to obtain the reset GPIO.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
Changes in
It seems the driver took some inspiration from ssd130x and some of the
functions (encoder callbacks) were not renamed to use a st7571_ prefix.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
drivers/gpu/drm/sitronix/st7571-i2c.c | 12
.
Changes in v3:
- Fix reset typo in commit message (Marcus Folkesson).
- Explicitly set ST7571_SET_REVERSE(0) instead of relying on defaults.
Changes in v2:
- Use a different parse DT function (Thomas Zimmermann).
Javier Martinez Canillas (5):
drm/sitronix/st7571-i2c: Fix encoder callbacks
Marcus Folkesson writes:
> On Mon, Jul 14, 2025 at 12:44:01PM +0200, Javier Martinez Canillas wrote:
>> The driver already uses the dev_err_probe() helper (that only prints error
>> messages for the -EPROBE_DEFER case) when fails to get any other resource.
>>
>> Als
Marcus Folkesson writes:
Hello Marcus,
> On Mon, Jul 14, 2025 at 12:44:00PM +0200, Javier Martinez Canillas wrote:
>> It seems the driver took some inspiration from ssd130x and some of the
>> functions (encoder callbacks) were not renamed to use a st7571_ prefix.
>
> Outch,
Marcus Folkesson writes:
> Add support for 2bit grayscale and use it for XRGB when grayscale is
> supported.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
It seems the driver took some inspiration from ssd130x and some of the
functions (encoder callbacks) were not renamed to use a st7571_ prefix.
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm/sitronix/st7571-i2c.c | 12 ++--
1 file changed, 6
> Dark Gray
> 10 => Light Gray
> 11 => White
>
> If this is not what the display map against, make it possible to invert
> the pixels.
>
> Signed-off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
controller also have a "Inverse Display" command, so this
property will also apply.
Or do you prefer for this to land before and then I could post a v3 on top?
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
.
Changes in v2:
- Use a different parse DT function (Thomas Zimmermann).
Javier Martinez Canillas (5):
drm/sitronix/st7571-i2c: Fix encoder callbacks function names
drm/sitronix/st7571-i2c: Log probe deferral cause for GPIO get failure
drm/sitronix/st7571-i2c: Add an indirection level to parse
off-by: Marcus Folkesson
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
The driver already uses the dev_err_probe() helper (that only prints error
messages for the -EPROBE_DEFER case) when fails to get any other resource.
Also do the same when it fails to obtain the rest GPIO.
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm
Other Sitronix display controllers might need a different parsing DT
logic, so lets add a .parse_dt callback to struct st7571_panel_data.
Suggested-by: Thomas Zimmermann
Signed-off-by: Javier Martinez Canillas
---
(no changes since v1)
drivers/gpu/drm/sitronix/st7571-i2c.c | 4 +++-
1 file
is used by the ST7571 controller, so only is needed a different callback
that implements the expected initialization sequence for the ST7567 chip.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Marcus Folkesson
---
Changes in v2:
- Use a different parse DT function (Thomas Zimmermann
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Rob Herring (Arm)
Reviewed-by: Marcus Folkesson
---
(no changes since v1)
.../bindings/display/sitronix,st7567.yaml | 63 +++
MAINTAINERS
Thomas Zimmermann writes:
> Hi
>
> Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas:
>> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin,
>> so lets relax this in the driver and make the reset GPIO to be optional.
>>
>> T
Thomas Zimmermann writes:
Hello Thomas,
> Hi
>
> Am 10.07.25 um 12:24 schrieb Javier Martinez Canillas:
>> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin,
>> so lets relax this in the driver and make the reset GPIO to be optional.
>>
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
>
>
> On Thu, Jul 10, 2025 at 12:24:32PM +0200, Javier Martinez Canillas wrote:
>> This patch-series adds support for the Sitronix ST7567 Controller, which is
>> is a
>> monochrome Dot Matrix LCD Controller
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
>
> On Thu, Jul 10, 2025 at 01:00:41PM +0200, Javier Martinez Canillas wrote:
>> >
>> > devm_gpiod_get_optional() returns -ENOENT when the GPIO is not found,
>> > and that is no error we want to propagag
onversion state.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
onversion state.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ut allows
> common userspace, such as Wayland compositors, to operate on the
> display.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
;
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
> List the conversion from XRGB-to-RGB332 in drm_fb_blit(), so that
> drivers based on sysfb-helpers can use it.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
<< 13) | (g << 10) | (g << 7) | (g << 4) | (g << 1) | (g >> 2);
b = (b << 14) | (b << 12) | (b << 10) | (b << 8) | (b << 6) | (b <<
4) | (b << 2) | b;
/* Call the drivers' specific callback to program the hardware LUT */
set_palette(crtc, i, r, g, b);
It might be evident to you, but I don't think it will be for others looking
at the code later.
The code itself looks good to me, if I understood it correctly :)
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; 1 file changed, 9 insertions(+), 12 deletions(-)
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
to use the pixel format.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
gt;
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
"Luca Weiss" writes:
Hello Luca,
> Hi Javier,
>
> On Fri Jun 27, 2025 at 9:51 AM CEST, Javier Martinez Canillas wrote:
[...]
>>> +static int simpledrm_device_attach_icc(struct simpledrm_device *sdev)
>>> +{
>>> + struct device *dev =
xpect them to be broken.
>
> Signed-off-by: Maxime Ripard
> ---
This seems to be much more robust indeed.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Maxime Ripard writes:
> For some reason, the HDMI VSDBs in our kunit EDIDs had a length longer
> than expected.
>
> While this was harmless, we should get rid of it to make it somewhat
> predictable.
>
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Mart
, 30-70 kHz H, max dotclock 150 MHz
>
> They were actually:
> Display Range Limits:
> Monitor ranges (GTF): 50-70 Hz V, 0-0 kHz H, max dotclock 1960 MHz
>
> Fix that section of the EDIDs to match the expected edid-decode output.
>
> Signed-off-by: Maxime Ripard
&g
Tomi Valkeinen writes:
Hello Tomi,
> Add a call to drm_aperture_remove_framebuffers() to drop the possible
> early fb (simplefb).
>
> Signed-off-by: Tomi Valkeinen
> ---
This patch can be picked and is independant of how the other one.
Reviewed-by: Javier Martinez Canillas
-
Marcus Folkesson writes:
Hello Marcus,
Thanks for your feedback.
> On Thu, Jul 10, 2025 at 12:24:34PM +0200, Javier Martinez Canillas wrote:
>> Some Sitronix LCD controllers (such as the ST7567) don't have a reset pin,
>> so lets relax this in the driver and make the reset
is used by the ST7571 controller, so only is needed a different callback
that implements the expected initialization sequence for the ST7567 chip.
Signed-off-by: Javier Martinez Canillas
---
drivers/gpu/drm/sitronix/st7571-i2c.c | 47 +++
1 file changed, 47 insertions
a DT node.
The DT binding schema for "sitronix,st7571" that require a reset GPIO will
enforce the "reset-gpios" to be present, due being a required DT property.
But in the driver itself the property can be made optional if not defined.
Signed-off-by: Javier Martinez Canillas
"reset-gpios" property in the driver to be optional since
that
isn't needed for the ST7567.
Patch #3 finally extends the st7571-i2c driver to also support the ST7567
device.
Javier Martinez Canillas (3):
dt-bindings: display: Add Sitronix ST7567 LCD Controller
drm/sitronix/st757
Sitronix ST7567 is a monochrome Dot Matrix LCD Controller.
Signed-off-by: Javier Martinez Canillas
---
.../bindings/display/sitronix,st7567.yaml | 63 +++
MAINTAINERS | 1 +
2 files changed, 64 insertions(+)
create mode 100644
"Rob Herring (Arm)" writes:
Hello Rob,
> Use the newly added of_reserved_mem_region_to_resource() function to
> handle "memory-region" properties.
>
> Signed-off-by: Rob Herring (Arm)
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier M
Javier Martinez Canillas writes:
> The commit d391c5827107 ("drivers/firmware: move x86 Generic System
> Framebuffers support") moved the sysfb*.c source files from arch/x86
> to drivers/firmware, because the logic wasn't x86 specific and could
> be used by other
Rob Clark writes:
> On Fri, Jun 27, 2025 at 12:10 PM Javier Martinez Canillas
> wrote:
>>
>> Laurent Pinchart writes:
>>
>> > On Fri, Jun 27, 2025 at 09:39:37AM -0700, Rob Clark wrote:
>> >> On Mon, Feb 26, 2024 at 5:43 AM Jacopo Mondi wrote:
>
say that you could just push it through drm-misc
since there are already a few review-by tags collected.
[0]:
https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html#merge-criteria
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
her be directed towards deleting
> simplefb entirely.
>
That is a good point. You are correct that having some duplication to
make easier to get rid of the fbdev driver is a much better approach.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
7 ("drivers/firmware: move x86 Generic System Framebuffers
support")
Reported-by: Andy Shevchenko
Closes: https://lore.kernel.org/lkml/af53djlieunf_...@smile.fi.intel.com/
Signed-off-by: Javier Martinez Canillas
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/M
ht need a set
of clocks, power domains, regulators, etc left enabled in order to work.
It's true that the "simple" is a misnomer, probably these drivers should
had been named sysfb and sysfbdrm, or something along those lines.
> The driver code also has that support added in this series.
>
> Regards
> Luca
>
>>
>> Best regards,
>> Krzysztof
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
"Luca Weiss" writes:
> On Fri Jun 27, 2025 at 9:56 AM CEST, Javier Martinez Canillas wrote:
[...]
>> These two functions contain the same logic that you are using in the
>> simpledrm driver. I wonder if could be made helpers so that the code
>> isn't dupli
Maxime Ripard writes:
> On Fri, Jun 27, 2025 at 11:04:16AM +0200, Javier Martinez Canillas wrote:
>> Maxime Ripard writes:
>>
[...]
>>
>> Usually I prefer to have static inline functions instead of macros to have
>> type checking. I see that this header has
mann
> Fixes: 814d270b31d2 ("drm/sysfb: vesadrm: Add gamma correction")
> Link:
> https://elixir.bootlin.com/linux/v6.15/source/drivers/video/fbdev/vesafb.c#L375
> # 1
> Cc: Thomas Zimmermann
> Cc: Javier Martinez Canillas
> Cc: dri-devel@lists.freedesktop.org
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
e one if
> relevant.
>
> Reported-by: Francesco Dolcini
> Closes: https://lore.kernel.org/all/20250612081834.GA248237@francesco-nb/
> Fixes: de04bb0089a9 ("drm/panel/panel-simple: Use the new allocation in place
> of devm_kzalloc()")
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
0);
> if (ddc) {
> panel->ddc = of_find_i2c_adapter_by_node(ddc);
> of_node_put(ddc);
>
> if (!panel->ddc)
> - return -EPROBE_DEFER;
> + return ERR_PTR(-EPROBE_DEFER);
Not r
o
> the caller.
>
> This will not fix the breaking commit entirely, but will move us towards
> the right direction.
>
> Fixes: de04bb0089a9 ("drm/panel/panel-simple: Use the new allocation in place
> of devm_kzalloc()")
> Signed-off-by: Maxime Ripard
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
functions instead of macros to have
type checking. I see that this header has a mix of both, so I don't have a
strong opinion on what to use in this case.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Luca Weiss writes:
> Make sure the headers are sorted alphabetically to ensure consistent
> code.
>
> Signed-off-by: Luca Weiss
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
detach_icc, par);
> +
> +err:
> + while (i) {
> + --i;
> + if (!IS_ERR_OR_NULL(par->icc_paths[i]))
> + icc_put(par->icc_paths[i]);
> + }
> + return ret;
> +}
> +#else
These two functions contain the same logic that you are using in the
simpledrm driver. I wonder if could be made helpers so that the code
isn't duplicated in both drivers.
But in any case it could be a follow-up of your series I think.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
goto err;
> + drm_err(&sdev->sysfb.dev, "failed to get interconnect
> path %u: %d\n",
> + i, ret);
You could use dev_err_probe() instead that already handles the -EPROBE_DEFER
case and also will get this message in the /sys/kernel/debug/devices_deferred
debugfs entry, as the reason why the probe deferral happened.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Luca Weiss writes:
> Make sure the headers are sorted alphabetically to ensure consistent
> code.
>
> Signed-off-by: Luca Weiss
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
s
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ed-off-by: Thomas Zimmermann
> Fixes: a979a54165c2 ("drm/format-helper: Normalize BT.601 factors to 256")
> Cc: Thomas Zimmermann
> Cc: Javier Martinez Canillas
> Cc: Maarten Lankhorst
> Cc: Maxime Ripard
> ---
> drivers/gpu/drm/tests/drm_format_helper_tes
his patch.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
John Keeping writes:
Hello John,
> The number of columns relates to the width, not the height. Use the
> correct variable.
>
> Signed-off-by: John Keeping
> ---
Pushed to drm-misc (drm-misc-fixes). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Thomas Zimmermann writes:
Hello Thomas,
> Hi
>
> Am 11.06.25 um 14:47 schrieb Javier Martinez Canillas:
>> John Keeping writes:
>>
>> Hello John,
>>
>>> The number of columns relates to the width, not the height. Use the
>>> co
Thomas Zimmermann writes:
Hello Thomas,
> Only sysfb drivers use drm_fb_build_fourcc_list(). Move the function
> to sysfb helpers and rename it accordingly. Update drivers and tests.
>
> Signed-off-by: Thomas Zimmermann
> ---
Acked-by: Javier Martinez Canillas
--
Best r
;width,
> SSD132X_SEGMENT_WIDTH);
> unsigned int height = ssd130x->height;
>
Ups, indeed. Thanks for fixing it!
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
ster on some hardware.
>
> Signed-off-by: Thomas Zimmermann
> ---
Makes sense.
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
controller as well.
>
> Signed-off-by: Chris Morgan
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Chris Morgan writes:
> From: Chris Morgan
>
> Enable the DSI controller, DSI DCPHY, and Huiling hl055fhav028c
> 1080x1920 panel for the Gameforce Ace.
>
> Signed-off-by: Chris Morgan
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canill
display resolution is 1080x1920 and is 70mm by 127mm
> as stated in the manufacturer's documentation.
>
> Signed-off-by: Chris Morgan
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
evice
> named "vga-framebuffer".
>
> The sysfb code has been taken from vga16fb, where it likely didn't
> work correctly either. With this bugfix applied, vga16fb loads for
> compatible vga-framebuffer devices.
>
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
This change also removes including ,
> which includes several unrelated headers, such as .
>
> Signed-off-by: Thomas Zimmermann
> ---
The patch makes sense to me though.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Javier Martinez Canillas writes:
> Geert Uytterhoeven writes:
>
> Hello Geert,
>
>> When moving the Sitronix DRM drivers and renaming their Kconfig symbols,
>> the old symbols were kept, aiming to provide a seamless migration path
>> when running "ma
itronix: move tiny Sitronix drivers to their
> own subdir")
> Signed-off-by: Geert Uytterhoeven
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
fix for the current setup, I'd prefer removing the
> old symbols.
>
I agree. When this was discussed, I argued that we should just remove the
old symbols and let kernel packagers to deal with it. As Geert said, it's
not uncommon for Kconfig symbols names to change over time...
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
16-bit values
> for red, green and blue. The driver reduces them to 8 bit to make
> them fit into hardware registers.
>
> Signed-off-by: Thomas Zimmermann
> Acked-by: Javier Martinez Canillas
I think this patch was acked by Jocelyn, not me. You can fix it
just before merging the
+static bool dummycon_switch(struct vc_data *vc)
> +{
> + /* Redraw, so that we get putc(s) for output done while switched away */
Maybe this comment could be a little bit more verbose about why this is needed
for the framebuffer console deferred takeover case? It doesn't hav
for red,
> green and blue. The driver reduces them to 8 bit to make them fit
> into hardware registers.
>
> Signed-off-by: Thomas Zimmermann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
t; diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c
> index fddfe8bea9f7..96fafdc8dd5e 100644
> --- a/drivers/gpu/drm/sysfb/ofdrm.c
> +++ b/drivers/gpu/drm/sysfb/ofdrm.c
> @@ -8,6 +8,7 @@
Looks good to me.
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
alette could
> be used.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/drm_color_mgmt.c | 206 +++
> include/drm/drm_color_mgmt.h | 27
> 2 files changed, 233 insertions(+)
>
Thanks a lot for adding all these helpers. I'm not
Thomas Zimmermann writes:
Hello Marcus,
> Am 12.05.25 um 09:15 schrieb Marcus Folkesson:
>> We start to have support many Sitronix displays in the tiny directory,
>> and we expect more to come.
>>
>> Move them to their own subdirectory.
>>
>> Reviewed-by:
Philipp Stanner writes:
Hello Philipp,
> On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
>> Philipp Stanner writes:
>>
>> Hello Philipp,
>>
>> > cirrus enables its PCI device with pcim_enable_device(). This,
>> > implicitly, swi
Jocelyn Falempe writes:
Hello Jocelyn,
> Add myself and Javier as maintainer for drm_panic, drm_panic_qr_code
> and drm_log.
>
> Signed-off-by: Jocelyn Falempe
> Acked-by: Thomas Zimmermann
> ---
>
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier M
Thomas Zimmermann writes:
> Hi Javier, Marcus
>
> Am 05.05.25 um 11:27 schrieb Javier Martinez Canillas:
>> Thomas Zimmermann writes:
>>
>> Hello Thomas,
>>
>>> Hi,
>>>
>>> there's one major issue here. You must not change th
dmin-guide/abi.html document
explictly states that Kconfig symbols are not an ABI, and userspace
should not rely on these not changing over time.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Marcus Folkesson writes:
Hello Marcus,
> Hello Javier,
> On Mon, Apr 28, 2025 at 09:16:32AM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson writes:
>>
>> Hello Marcus,
>>
>> > We start to have support many Sitronix displays in the tiny dir
Javier Martinez Canillas writes:
> Dan Carpenter writes:
>
> Hello Dan,
>
>> The devm_kzalloc() function returns NULL on failure, not error pointers.
>> Also printing an error message for kmalloc() failures is against kernel
>> style so just return -ENOMEM without
).
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD
> controller")
> Signed-off-by: Dan Carpenter
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
Robert Mader writes:
Hello Robert,
> Chris, Javier, Laurent - sorry for the noise, but given you reviewed
> changes in the respective files before, maybe you can help me moving
I'm not familiar with these formats to do a proper review. Sorry about that...
--
Best regards,
Javi
m_client_setup'
>
> Select the appropriate Kconfig symbol.
>
> Fixes: 4b35f0f41ee2 ("drm/st7571-i2c: add support for Sitronix ST7571 LCD
> controller")
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
mats and invert the
>> pixels for the R1, R2 and XRGB formats.
>>
>> Could that work or are there any side effects that I should be aware of?
>
> That should work fine.
Agree.
> Note that you do not have to support R1 and R2, as they are non-native.
> AFAIK XRGB is the only format all drivers must support.
>
> Gr{oetje,eeting}s,
>
That's correct. The driver should only support D1 and D2 as native formats
and (emulated) XRGB for compatibility with existing user-space. No need
to support R1 and R2 since the controller does not support these formats.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
rnel.org/dri-devel/caniq72ke45eowckmhwhvmwxc03dxr4rnxxkvx+hvwdblopz...@mail.gmail.com/
> [1]
> Signed-off-by: Jocelyn Falempe
> ---
Acked-by: Javier Martinez Canillas
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
1 - 100 of 2154 matches
Mail list logo
