.org/dri-devel/cover.1729630039.git.ja...@rocketmail.com/T/#t
v3:
https://lore.kernel.org/dri-devel/cover.1729738189.git.ja...@rocketmail.com/T/#t
Jakob Hauser (5):
dt-bindings: display: panel: Move flip properties to panel-common
dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24
drm/pa
The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By
introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common.
Signed-off-by: Jakob Hauser
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Linus Walleij
---
Patch is based on current
Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
Signed-off-by: Jakob Hauser
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Linus Walleij
---
Patch is based on current branch drm-misc-next.
---
.../panel/samsung,s6e88a0-ams427ap24.yaml | 65 +++
1 file
nstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi
Signed-off-by: Jakob Hauser
---
Changes in v4:
- Removed include , it's not needed.
- Added comments to the mipi_dsi_dcs_write_seq_multi() lines in function
s6e88a0_a
sm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/ss_dsi_panel_S6E88A0_AMS427AP24.c#L666-L678
Signed-off-by: Jakob Hauser
Reviewed-by: Neil Armstrong
---
Changes in v4:
- New defines for payload data length, thereof a fixed and a variable part.
https://github.com/LineageOS/android_kernel_samsung_msm8930-common/blob/lineage-15.1/drivers/video/msm/mipi_samsung_oled_video_qhd_pt-8930.c#L66-L74
Signed-off-by: Jakob Hauser
Reviewed-by: Neil Armstrong
---
Changes in v4:
- Added a comment to the mipi_dsi_dcs_write_seq_multi() line, according t
Hi Linus,
On 25.10.24 21:32, Linus Walleij wrote:
...
On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser wrote:
The way of implementing a flip option follows the existing
panel-samsung-s6e8aa0.c [1][2][3].
That driver is notoriously hard to read because it uses so much
magic numbers so please
Hi Linus,
On 25.10.24 21:27, Linus Walleij wrote:
...
On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser wrote:
+static const int s6e88a0_ams427ap24_br_to_cd[NUM_STEPS_CANDELA] = {
(...)
+ /* brightness till, candela */
Brightness to candela conversion table? Edit comment?
In the
Hi Linus,
On 25.10.24 18:36, Linus Walleij wrote:
...
On Thu, Oct 24, 2024 at 5:18 AM Jakob Hauser wrote:
...
+#include
+#include
+#include
+#include
Why do you need this include? .of_match_table is part of
You're right, I'll remove it.
+static int s6e88a0_ams427ap24
obe function. Changed the parsing from
of_property_read_bool() to device_property_read_bool().
v1:
https://lore.kernel.org/dri-devel/cover.1728582727.git.ja...@rocketmail.com/T/#t
v2:
https://lore.kernel.org/dri-devel/cover.1729630039.git.ja...@rocketmail.com/T/#t
Jakob Hauser (5):
dt-bi
e88a0_ams427ap24_unprepare().
[1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator
[2]
https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi
Signed-off-by: Jakob H
sm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/ss_dsi_panel_S6E88A0_AMS427AP24.c#L666-L678
Signed-off-by: Jakob Hauser
Reviewed-by: Neil Armstrong
---
drivers/gpu/drm/panel/Kconfig | 1 +
.../panel/panel-samsung-s6e88a0-ams42
https://github.com/LineageOS/android_kernel_samsung_msm8930-common/blob/lineage-15.1/drivers/video/msm/mipi_samsung_oled_video_qhd_pt-8930.c#L66-L74
Signed-off-by: Jakob Hauser
Reviewed-by: Neil Armstrong
---
Changes in v3:
- Dissolved function s6e88a0_ams427ap24_parse_dt() and placed
the parsi
The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By
introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common.
Signed-off-by: Jakob Hauser
Reviewed-by: Krzysztof Kozlowski
---
Patch is based on current branch drm-misc-next.
---
.../bindings
Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
Signed-off-by: Jakob Hauser
Reviewed-by: Krzysztof Kozlowski
---
Patch is based on current branch drm-misc-next.
Changes in v3:
- Dropped the second "bindings" in the commit subject.
- Applied 4 spaces indentat
Hi Krzysztof,
On 23.10.24 09:15, Krzysztof Kozlowski wrote:
On Tue, Oct 22, 2024 at 11:33:35PM +0200, Jakob Hauser wrote:
The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By
introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common.
Signed-
https://github.com/LineageOS/android_kernel_samsung_msm8930-common/blob/lineage-15.1/drivers/video/msm/mipi_samsung_oled_video_qhd_pt-8930.c#L66-L74
Signed-off-by: Jakob Hauser
---
.../drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 16
1 file changed, 16 insertions(+)
diff --
sm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/ss_dsi_panel_S6E88A0_AMS427AP24.c#L666-L678
Signed-off-by: Jakob Hauser
---
Changes in v2:
- In the table "s6e88a0_ams427ap24_aid" in comment of the second-last line
changed the format of
quot; in functions s6e88a0_ams427ap24_prepare()
and s6e88a0_ams427ap24_unprepare().
[1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator
[2]
https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/dsi_panel_S6E88A0_AMS427
- Patch 4: In the table "s6e88a0_ams427ap24_aid" in comment of the second-last
line changed the format of "40,00 %" to "40.0%" like all others.
v1:
https://lore.kernel.org/dri-devel/cover.1728582727.git.ja...@rocketmail.com/T/#t
Jakob Hauser (5):
dt-binding
Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
Signed-off-by: Jakob Hauser
---
Patch is based on current branch drm-misc-next.
Changes in v2:
- Adapted property "flip-horizontal" to being moved to "panel-common.yaml".
---
.../panel/samsung,s6e88a0-ams4
The flip properties were used by "samsung,s6e8aa0.yaml" only so far. By
introducing "samsung,s6e88a0-ams427ap24.yaml" they become more common.
Signed-off-by: Jakob Hauser
---
Patch is based on current branch drm-misc-next.
---
.../bindings/display/panel/panel-common
Hi Jessica,
On 11.10.24 19:17, Jessica Zhang wrote:
On 10/10/2024 11:31 AM, Jakob Hauser wrote:
The way of implementing a flip option follows the existing
panel-samsung-s6e8aa0.c [1][2][3].
The value to flip the screen is taken from a downstream kernel file of
a similar but older panel [4
Hi Jessica,
On 11.10.24 18:52, Jessica Zhang wrote:
On 10/10/2024 11:31 AM, Jakob Hauser wrote:
...
+struct s6e88a0_ams427ap24 {
+ struct drm_panel panel;
+ struct mipi_dsi_device *dsi;
+ struct regulator_bulk_data *supplies;
+ struct gpio_desc *reset_gpio;
+ bool prepared
Hi Rob,
On 11.10.24 16:27, Rob Herring wrote:
On Thu, Oct 10, 2024 at 08:31:48PM +0200, Jakob Hauser wrote:
Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
Signed-off-by: Jakob Hauser
---
Patch is based on https://gitlab.freedesktop.org/drm/misc/kernel.git
current branch
r-generator
[2]
https://github.com/msm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/dsi_panel_S6E88A0_AMS427AP24_qhd_octa_video.dtsi
Signed-off-by: Jakob Hauser
---
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/
Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
Signed-off-by: Jakob Hauser
---
Patch is based on https://gitlab.freedesktop.org/drm/misc/kernel.git
current branch drm-misc-next.
---
.../panel/samsung,s6e88a0-ams427ap24.yaml | 68 +++
1 file changed, 68
sm8916-mainline/linux-downstream/blob/GT-I9195I/drivers/video/msm/mdss/samsung/S6E88A0_AMS427AP24/ss_dsi_panel_S6E88A0_AMS427AP24.c#L666-L678
Signed-off-by: Jakob Hauser
---
drivers/gpu/drm/panel/Kconfig | 1 +
.../panel/panel-samsung-s6e88a0-ams427ap24.c | 519 +
The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0
controller. Patches are based on current branch drm-misc-next.
Jakob Hauser (4):
dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings
drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver
drm/panel
https://github.com/LineageOS/android_kernel_samsung_msm8930-common/blob/lineage-15.1/drivers/video/msm/mipi_samsung_oled_video_qhd_pt-8930.c#L66-L74
Signed-off-by: Jakob Hauser
---
.../drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 16
1 file changed, 16 insertions(+)
diff --
Hi all,
On 16.06.23 01:36, Doug Anderson wrote:
...
I guess the tl;dr (summary of my summary) is:
a) Moving panels like this to "pre_enable_prev_first" seems like a
reasonable idea anyway and (presumably) works around the issue.
b) Moving some commands between disable() / post_diable() or
pre_
A typo in my previous e-mail:
On 18.06.23 15:47, Jakob Hauser wrote:
...
Then the panel get's turned off:
... should be "When..." instead of "Then...".
32 matches
Mail list logo
