[PATCH] drm/msm/dp: remove deadcode on dpu_encoder_setup

2021-11-15 Thread Jackie Liu
From: Jackie Liu Nobody care about drm_enc on dpu_encoder_setup, cleanup. [...] *** CID 1493979: Possible Control flow issues (DEADCODE) /drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: 2186 in dpu_encoder_setup() 2180 2181return ret; 2182 2183 fail: 2184DPU_ERROR

[PATCH 2/3] drm/msm/dp: displayPort driver need algorithm rational

2021-11-09 Thread Jackie Liu
From: Jackie Liu Let's select RATIONAL with dp driver. avoid like: [...] x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dp/dp_catalog.o: in function `dp_catalog_ctrl_config_msa': dp_catalog.c:(.text+0x57e): undefined reference to `rational_best_approximation' Fixes: c943b4948b58 (&

[PATCH 1/3] drm/msm/hdmi: fix build without CONFIG_COMMON_CLK

2021-11-09 Thread Jackie Liu
From: Jackie Liu HDMI 8996 PHY/PLL support need common clk. avoid like: [...] x86_64-linux-gnu-ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3e0): undefined reference to `msm_hdmi_phy_8996_cfg' Fixes: e17afdceb4f2 ("drm/msm/hdmi: HDMI 8996 PHY/PLL support") Reported-by: ke

[PATCH 3/3] drm/msm: some features need to be forced to rely on COMMON_CLK

2021-11-09 Thread Jackie Liu
From: Jackie Liu In fact, this will not cause any problems, but when COMPILE_TEST is enabled, COMMON_CLK may not be selected, The CI system will report some compilation errors. even if that is not issue, but we better fix him. [...] x86_64-linux-gnu-ld: drivers/gpu/drm/msm/dsi/phy

Re: [PATCH v3] mdacon: fix redefinition of 'scr_memsetw'

2021-09-21 Thread Jackie Liu
ping, would anyone take this patch? 在 2021/9/15 上午9:13, Jackie Liu 写道: From: Jackie Liu CONFIG_VGA_CONSOLE=n and CONFIG_MDA_CONSOLE=n will cause vt_buffer.h not include . But if we set CONFIG_MDA_CONSOLE=m, mdacon.c include is in front of include . VT_BUF_HAVE_MEMSETW is not defined, so

[PATCH v3] mdacon: fix redefinition of 'scr_memsetw'

2021-09-14 Thread Jackie Liu
From: Jackie Liu CONFIG_VGA_CONSOLE=n and CONFIG_MDA_CONSOLE=n will cause vt_buffer.h not include . But if we set CONFIG_MDA_CONSOLE=m, mdacon.c include is in front of include . VT_BUF_HAVE_MEMSETW is not defined, so vt_buffer.h will define a scr_memsetw, after that, vga.h also define a

Re: [PATCH] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
在 2021/8/16 下午4:56, Jani Nikula 写道: On Mon, 16 Aug 2021, Jani Nikula wrote: On Mon, 16 Aug 2021, Jackie Liu wrote: Hi Jani. Your suggestion is that? diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 7ff89690a976..ba179a539497 100644 --- a/drivers/gpu/drm/Kconfig +++ b

Re: [PATCH v2] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
在 2021/8/16 下午4:58, Jani Nikula 写道: On Mon, 16 Aug 2021, Jackie Liu wrote: From: Jackie Liu When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit. Fixes: f611b1e7624c ("drm: Avoid circular dependencie

[PATCH v2] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
From: Jackie Liu When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit. Fixes: f611b1e7624c ("drm: Avoid circular dependencies for CONFIG_FB") Reported-by: k2ci Signed-off-by: Jackie Liu --- drive

Re: [PATCH] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
depends on DRM + depends on FB if DRM_FBDEV_EMULATION help CRTC helpers for KMS drivers. But it has a syntax error. -- Thanks, BR, Jackie Liu 在 2021/8/16 下午4:33, Jani Nikula 写道: On Mon, 16 Aug 2021, Jackie Liu wrote: Hi Jani. My CI report an randconfigs build failed. there

Re: [PATCH] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
Hi, Jani. Thanks, send V2 version immediately, and cc author. -- Jackie Liu 在 2021/8/16 下午4:35, Jani Nikula 写道: On Mon, 16 Aug 2021, Jackie Liu wrote: After commit f611b1e7624c, we change select FB to depends on FB. And obviously you should cite the commit in the original patch and Cc the

Re: [PATCH] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
DRM_DEBUG_DP_MST_TOPOLOGY_REFS config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - depends on FB + depends on FB && FB != m select DRM_KMS_HELPER select FB_CFB_FILLRECT select FB_CFB_COPYAREA -- Ja

Re: [PATCH] drm/fb: Fix randconfig builds

2021-08-16 Thread Jackie Liu
fb_helper.c:(.text+0x2233): undefined reference to `fb_set_suspend' drm_fb_helper.c:(.text+0x22b0): undefined reference to `fb_set_suspend' drm_fb_helper.c:(.text+0x250f): undefined reference to `fb_deferred_io_init' The main reason is because DRM_FBDEV_EMULATION is built-in, and CO

[PATCH] drm/fb: Fix randconfig builds

2021-08-15 Thread Jackie Liu
From: Jackie Liu When CONFIG_DRM_FBDEV_EMULATION is compiled to y and CONFIG_FB is m, the compilation will fail. we need make that dependency explicit. Reported-by: k2ci Signed-off-by: Jackie Liu --- drivers/gpu/drm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. Thanks for replying to the email so quickly. 在 2021/7/28 下午4:58, Kieran Bingham 写道: Hi Jackie, On 28/07/2021 09:42, Jackie Liu wrote: From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), the cmm module must be included in th

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. 在 2021/7/28 下午8:13, Kieran Bingham 写道: Hi Jackie / Laurent, On 28/07/2021 12:30, Laurent Pinchart wrote: On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: Hi Kieran. How about this. diff --git a/drivers/gpu/drm

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
fact, as long as rcar-du built-in, cmm must also be built-in, otherwise an error will be reported. Do you have a good way? Thanks, Jackie. 在 2021/7/28 下午4:58, Kieran Bingham 写道: Hi Jackie, On 28/07/2021 09:42, Jackie Liu wrote: From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-

[PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
From: Jackie Liu After the patch 78b6bb1d24db ("drm: rcar-du: crtc: Control CMM operations"), the cmm module must be included in the crtc. We cannot remove this configuration option separately. Therefore, simply linking them together is the best solution, otherwise some errors will b

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
Hi Kieran. 在 2021/7/28 下午8:24, Kieran Bingham 写道: > Hi Jackie > > On 28/07/2021 13:21, Jackie Liu wrote: >> Hi Kieran. >> >> 在 2021/7/28 下午8:13, Kieran Bingham 写道: >>> Hi Jackie / Laurent, >>> >>> On 28/07/2021 12:30, L

Re: [PATCH] drm: rcar-du: crtc: force depends on cmm

2021-07-28 Thread Jackie Liu
在 2021/7/28 下午7:30, Laurent Pinchart 写道: On Wed, Jul 28, 2021 at 12:09:34PM +0100, Kieran Bingham wrote: Hi Jackie, On 28/07/2021 10:57, Jackie Liu wrote: Hi Kieran. How about this. diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index b47e74421e34